🇮🇳India @rajeshreeputra

@becw AssetUpdateChecker take care of unpublishing the asset in Drupal.

Let us know if this is not working. Could you please share the version of Acquia DAM you are using.

Requesting review.

rajeshreeputra → created an issue.

Requesting review.

rajeshreeputra → created an issue.

rajeshreeputra → made their first commit to this issue’s fork.

@isholgueras I noticed that a hard dependency on the Key module has been added. Just to confirm my understanding: going forward, will the Acquia SEO Content Insights module solely use the Key module to populate credentials?

rajeshreeputra → changed the visibility of the branch 3538819-remove-acquiacmscommon-module to hidden.

rajeshreeputra → made their first commit to this issue’s fork.

Merged MR!23.

rajeshreeputra → created an issue.

rajeshreeputra → made their first commit to this issue’s fork.

rajeshreeputra → made their first commit to this issue’s fork.

Agree, this should support both old and new formats.

rajeshreeputra → made their first commit to this issue’s fork.

The KeyDeprecationTest still needs to be fixed because the method getKeysByStorageMethod() has been removed from the KeyRepository, but it is still being referenced in the test.

rajeshreeputra → made their first commit to this issue’s fork.

Can we get test fixed.

Pipeline is failing because of the module is not yet Drupal 11 compatible. Lets make it 💬 Drupal 11 compatibility fixes Active .

rajeshreeputra → created an issue.

rajeshreeputra → made their first commit to this issue’s fork.

Module is Drupal 10 compatible.

rajeshreeputra → made their first commit to this issue’s fork.

rajeshreeputra → made their first commit to this issue’s fork.

Started merge train.

We should add test coverage for this hence setting to needs work.

looks good, added to merge train.

Added to merge train.

rajeshreeputra → made their first commit to this issue’s fork.

Can we add test coverage this to make sure this is working.

@joseph.olstad - changes in MR!22 look good. Once the PHPCS warnings are fixed, we can proceed with the merge by this weekend.

@manuel garcia → thank you for confirmation.

For some reason, this issue remains in the review state. However, I am marking it as fixed.

For some reason, this issue remains in the review state. However, I am marking it as fixed.

rajeshreeputra → created an issue.

💬 Add action module as dev dependency. Active is merged so tests should pass now.

rajeshreeputra → made their first commit to this issue’s fork.

@deaom started merge train for 💬 Add action module as dev dependency. Active .

rajeshreeputra → made their first commit to this issue’s fork.

joseph.olstad → credited rajeshreeputra → .

joseph.olstad → credited rajeshreeputra → .

Created MR with following:

• Add key module in dev dependency
• Update configuration form allowing to use the Key module to get api key and shared secret.
• Manually created a simple authentication key using file key provider and used in config form for key based authentication.
• Added new getCredentials() to retrieve API key and shared secret from keyValue or config as per key module used.
• Verified connection is successful with key module as well as with config.

How to use key module with Acquia SEO Content Insights:

1. Require and install key module.
2. Create new key with file key provider or any other, I am using the file key provider to create the Conductor credentials key.
3. Add required details to file, i.e. api_key and shared_secret as json.
4. Visit /admin/config/development/conductor:
   • You will see a new checkbox option(Use Key module for API credentials storage) under the API Credentials.
   • Check the checkbox option.
   • The API Key dropdown field will appear, allowing you to select the key from the list.
   • Choose the Conductor credentials key.
   • Click on Save configurations.

5. You will receive a success or error message based on the data in the file path provided in the key.

Remaining work:

• Update Acquia SEO Content Insights extention to support key module integration.
• Verified the functionality.
• Add test coverage for key module integration.

rajeshreeputra → created an issue.

Created MR with following:

• Add key module in dev dependency
• Update configuration form allowing to use the Key module to get api key.
• Manually created a simple authentication key using file key provider and used in config form for key based authentication.
• Added new getCredentials() to retrieve API key and url from keyValue or config as per key module used.
• Verified the functionality.
• Added test coverage for key module integration.

How to use key module with Acquia Optimize:

1. Require and install key module.
2. Create new key with file key provider or any other, I am using the file key provider to create the Acquia Optimize credentials key.
3. Add required details to file, i.e. api_key and api_url as json.
4. Visit /admin/config/content/acquia-optimize:
   • You will see a new checkbox option(Use Key module for API key storage) under the API Key Configuration.
   • Check the checkbox option.
   • The API Key dropdown field will appear, allowing you to select the key from the list.
   • Choose the Acquia Optimize credentials key.
   • Click on Save configurations.

5. You will receive a success or error message based on the data in the file path provided in the key.

Remaining work:

• Update Acquia Optimize extention to support key module integration.

rajeshreeputra → made their first commit to this issue’s fork.

requesting review.

rajeshreeputra → created an issue.

Regarding the CI, in the Acquia DAM module, we need to run tests with Drupal versions 9.5, 10, and 11. Therefore, we have set the current version to 10, allowing us to test 9.5 under the previous major version and 11 under the next major version, while also testing with the current version, Drupal 10.

The problem: this is currently testing against 11.x, it should be testing against 11.2. Which is the current minor, yet this project's "current" is actually testing against Drupal 10.3. I wonder if this is a problem with https://www.drupal.org/project/gitlab_templates → , or with this project. I haven't touched https://git.drupalcode.org/project/cdn in well over a year, and that is testing against 11.2 🤔

@wim leers, validated this with the latest 1.x-dev version of XB and Drupal 11.2, following the steps outlined, but encountered an error.

1. New Drupal project setup
2. XB UI setup completed
3. XB site installation completed
4. Installed test modules (xb_test_sdc, xb_dev_standard, sdc_test_all_props)
5. Installed Acquia DAM
6. Applied patch from MR!147
7. Edited test article with XB
8. Added XB test SDC with optional image and heading component
9. Clicked on Add media; selected Acquia DAM from the media source options.
10. Selected and inserted media; asset thumbnail appears in the settings tab, but the asset does not render in the body.
11. Error in dblog:

rajeshreeputra → made their first commit to this issue’s fork.

Adding this to README sound good, let's make it.

You can also use a stream wrapper if both asset_id and version_id are available.
\Drupal::service('stream_wrapper.acquia_dam')->getViaUri('acquia-dam://<asset_id>/<version_id>')->getExternalUrl();

Requesting review.

rajeshreeputra → created an issue.

I believe this is no longer necessary due to the changes made in the AssetRepository class.
@jappery what's your opinion on this?

I understand your point, whoever wants to use the collection filter can simply add it to view, since not everyone may need it. Hence we can probably merge this without adding the collection filter in the view.

rajeshreeputra → created an issue.

rajeshreeputra → created an issue.

Requesting review.

requesting review.

@japerry do we need to add the collection filter in the view? and update hook for existing customers/users?

The anchor mapping differs between Drupal and the DAM system. In Drupal, the key is used to map the attribute, while the value is presented in a dropdown(or other) field for better readability (e.g., "Top Left," "Top Right"). Conversely, the DAM expects the equivalent values in a different format (e.g., "nw," "ne," etc.). This is why we have the $anchor_mapping array in the DAM's EmbedCodeUrlBuilder class.

Hope this resolves your concern. Hence closing.

You can also try

    /** @var \Drupal\acquia_dam\Plugin\media\Source\Asset $source */
    $source = $media->getSource();
    $embed_codes = $source->getMetadata($media, 'embeds');
    $url = $embed_codes['original']['url'];

requesting review.

rajeshreeputra → created an issue.

rajeshreeputra → made their first commit to this issue’s fork.

Requesting an early review.
Note: These commands can be further improved.

rajeshreeputra → created an issue.

requesting review.

Requesting review.

rajeshreeputra → created an issue.