🇮🇳India @rajeshreeputra

Requesting review.

Requesting review.

Requesting review.

rajeshreeputra → created an issue.

rajeshreeputra → created an issue.

rajeshreeputra → created an issue.

rajeshreeputra → made their first commit to this issue’s fork.

This issue is addressed as part of 🐛 Acquia DAM Item Update Queue not being ran Active , so closing this issue. If you continue to experience the problem, please feel free to reopen.

This looks good, but we may need to update it once ✨ Support Key module inside Acquia DAM (sites) Needs work lands. Adding this information to the authentication page can be addressed in conjunction with #3549173: Separate DAM Authentication Settings from Image Styles in Configuration Form → .

rajeshreeputra → created an issue.

rajeshreeputra → made their first commit to this issue’s fork.

Merged!

ohhh, yes, updated.

@becw, you are right.

After thoroughly reviewing the processQueue() method, I found that this code causes the processing to exit early, so it never reaches the code further down that actually unpublishes the asset/media.

Will validate this one more time.

Updated CI template to run test in parallel, requesting review.

Change to Image Dimension Handling:

• The getImageDimensions method no longer immediately returns image property dimensions if found. Instead, it applies additional logic for original image formats.
• For original images missing width/height data, a default size of 480x360 pixels is returned.
• This change improves rendering robustness, especially when dealing with SVG or other images lacking explicit dimension metadata.
• No behavioral change occurs for non-original image styles — dimension retrieval via image style configuration is unchanged.

Requesting review.

rajeshreeputra → created an issue.

rajeshreeputra → made their first commit to this issue’s fork.

Status:

Unit

• Drupal 9 ✅
• Drupal 10 ✅
• Drupal 11.1 ✅
• Drupal 11.2 ✅

Kernel

• Drupal\Tests\acquia_dam\Kernel\ExpiredTagTest::testExpiryTag - This is already fixed in MR!188

Functional Javascript

Got warning, we'll investigate. Option --group cannot be used more than once

@cpierce42 Could you please share which version of Acquia DAM includes the “insert file as text with download” format, and provide a screenshot of how it appears? Also, if possible, a short video or GIF to showcase the functionality would be helpful.

I’ve investigated but have not been able to find this format in any version of Acquia DAM so far.

Validated changes in MR!197 and it fixes the items listed in #21 🐛 MultiFilter for checkbox and palette fields Active .

RTBC++

Please review.

This is not required.

Please feel free to reopen the issue if you find it has not yet been fixed in 4.1.1 version.

rajeshreeputra → made their first commit to this issue’s fork.

rajeshreeputra → made their first commit to this issue’s fork.

8.x-1.8 is the new tag.

This is fixed in 🐛 Unable to connect the site through Acquia Connector Active .

Please review.

Please review.

rajeshreeputra → created an issue.

rajeshreeputra → created an issue.

Requesting review.

Yes, the response is cached from 10 hours in DAM.

Could you please try with clearing cache once?

Added Drupal 9, 10, 11 in CI:

1. composer-drupal-core-9 runs for Drupal 9.
2. Previous major runs fro Drupal 10.
3. Current runs for Drupal 11 latest.

Next step:

1. Look into phpunit parallel test execution.

Added Drupal 9, 10, 11 in CI:

1. composer-drupal-core-9 runs for Drupal 9.
2. Previous major runs fro Drupal 10.
3. Current runs for Drupal 11 latest.

Next step:

1. Look into phpunit parallel test execution.

rajeshreeputra → made their first commit to this issue’s fork.

Requesting review.

rajeshreeputra → created an issue.

@becw AssetUpdateChecker take care of unpublishing the asset in Drupal.

Let us know if this is not working. Could you please share the version of Acquia DAM you are using.

Requesting review.

rajeshreeputra → created an issue.

Requesting review.

rajeshreeputra → created an issue.

rajeshreeputra → made their first commit to this issue’s fork.

@isholgueras I noticed that a hard dependency on the Key module has been added. Just to confirm my understanding: going forward, will the Acquia SEO Content Insights module solely use the Key module to populate credentials?

rajeshreeputra → changed the visibility of the branch 3538819-remove-acquiacmscommon-module to hidden.

rajeshreeputra → made their first commit to this issue’s fork.

Merged MR!23.

rajeshreeputra → created an issue.

rajeshreeputra → made their first commit to this issue’s fork.

rajeshreeputra → made their first commit to this issue’s fork.

Agree, this should support both old and new formats.

rajeshreeputra → made their first commit to this issue’s fork.

The KeyDeprecationTest still needs to be fixed because the method getKeysByStorageMethod() has been removed from the KeyRepository, but it is still being referenced in the test.

rajeshreeputra → made their first commit to this issue’s fork.

Can we get test fixed.

Pipeline is failing because of the module is not yet Drupal 11 compatible. Lets make it 💬 Drupal 11 compatibility fixes Active .

rajeshreeputra → created an issue.

rajeshreeputra → made their first commit to this issue’s fork.

Module is Drupal 10 compatible.

rajeshreeputra → made their first commit to this issue’s fork.

rajeshreeputra → made their first commit to this issue’s fork.

Started merge train.

We should add test coverage for this hence setting to needs work.

looks good, added to merge train.

Added to merge train.