Resolved conflict and rebased.
Incorporated feedback, hence setting to needs review.
Please review.
Based on the ongoing discussions in the referenced issues, will proceed with the exact ask of this issue without introducing new validations.
Requesting review.
Agree with you that this will introduce compatibility issues and should be implemented only in a new major version.
Sure @cmlara, will start work and discussion on 🐛 KeyProviderInterface Active .
Thank you @mxr576,
This is kinda great learning while working on this issue about choosing between memory cache and cache bin.
It's all about asking the right questions on how sensitive and secure the data needs to be. We need to think, "Is this data okay to just be around for a bit to keep it safe or stored for longer?".
Memory cache is fine for quick stuff, but if you need it saved, then cache bin is there, just need to be cautious about where the data might end up.
So yeah, it’s all about figuring out what’s most important for the situation, and then choose accordingly.
💬 Fix PHPCS warnings Active is merged!
Added return type to all interfaces to discuss and finalise accordingly. Then will add return type to all methods in classes.
Cleanup completed, requesting review.
Referencing existing issue to address PHPStan related warnings.
Implemented cache bin in latest commit. Requesting review.
Please review.
Rebased and added to 🌱 Planned for 1.21 version release Active .
📌 Update README.md as per README.md format Needs review and 📌 Fix eslint test Active now merged, added 📌 Modernize the Drush commands Needs review as ready for review.
Requesting review.
📌 Fix deprecation warning. Active is merged!
rajeshreeputra → changed the visibility of the branch 3300224-key-file-not to hidden.
With the understanding how the public:// and private:// stream wrappers function with S3FS. Will close the MR!6(keeping for future reference) and create new one.
Added Reference to release plan 1.21 version.
Updated MR with example as stated in #2, requesting review.
I have not yet utilized the s3fs module in Drupal, but I will give it a try. Then accordingly update here.
rajeshreeputra → changed the visibility of the branch 2985590-static-cache-does to hidden.
rajeshreeputra → made their first commit to this issue’s fork.
Hello @cmlara, updated to work with realpath, stream wrapper and remote urls. Could you please validate with s3 once. Will keep this in needs work status.
Hello @cmlara,
I am currently experiencing an issue when provided file path located on a different server or outside the Drupal project scope, as it is returning an following error. Hence I mentioned that we can use the realpath() method of FileSystem.
Could you please let me know if there's anything I'm missing that would enable me to provide a file path located on a different server or outside the Drupal project scope?
Created MR requesting review. Refer screenshot below:
rajeshreeputra → created an issue.
Created MR for easy review and merge with the patch provided in #11. Thanks!
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → created an issue.
We can use the realpath() method of FileSystem.
I have validated the MR changes with shield module and it work as expected. Hence requesting review.
rajeshreeputra → created an issue.
We should replace the drupal_static() function with entity.memory_cache service.
- Properly removes the line
$key_values = &drupal_static(__FUNCTION__, []);which was the original static cache implementation - Completely eliminates any references to the
$key_valuesarray - Updates the caching and retrieval logic to consistently use the memory cache service
- Uses prefixed keys (
key_value:$cache_id) to avoid potential collision with other cached data - Updates the return statement to get the value from the memory cache service
- Implements a proper cache deletion method in
deleteKeyValue()
Will focus on these 12 issue with current plan.
Added few other issue that are currently in review state.
Added in related issue.
rajeshreeputra → created an issue.
rajeshreeputra → created an issue.
Failing test is fixed in 📌 Fix deprecation warning. Active
rajeshreeputra → made their first commit to this issue’s fork.
Please review.
Adding this work in new module
Key Encrypt →
.
Please refer issue -
📌
Encrypt key value
Active
rajeshreeputra → created an issue.
Created separate issue for 📌 Fix deprecation warning. Active .
rajeshreeputra → created an issue.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → created an issue.
rajeshreeputra → created an issue.
Rebased and resolved the conflicts, requesting review.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
Changes are available in 1.20 release.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
ohh.. I got it, I miss understood the issue. Thank you @japerry!
rajeshreeputra → created an issue.
requesting early review.
rajeshreeputra → created an issue.
Hi @svenryen, I am interested.
rajeshreeputra → created an issue.
Started merge train.
Added to merge train.
Created MR against 2.x branch, waiting for CI pipeline.
rajeshreeputra → made their first commit to this issue’s fork.
Yes, both issues are related, but they address different aspects.
- 🐛 New Media Type with Identical Source as Existing Acquia DAM Media Type Incorrectly Links to Existing Media Type Active : pertains to the rendering of the asset for same type.
- ✨ Update asset bulk import functionality to work with multiple media type of same plugin. Active : deals with the process of importing assets when there are multiple media types available for the same media plugin.
Will validate this case as ✨ Category search functionality with media formatter filter. Active is now merged and released with 1.1.1 → version.
This issue arises when a node with translations is cloned without those translations.
Cloning the node with all translations, then deleting and re-translating it working.
Please review.
This is been covered in ✨ Category search functionality with media formatter filter. Active .
Updated, requesting review.
Waiting for merge of ✨ Provide asset groups filtering in bulk import assets functionality. Active to update it further accordingly.
Closing as covered in 🐛 Newly created media type doesn't have media_library entity view display preconfigured. Active .
Updated MR!139 with review feedback. Rebase completed with 1.1.x branch. Hence requesting review.
rajeshreeputra → changed the visibility of the branch 3515288-create-media-displays to active.
rajeshreeputra → changed the visibility of the branch 3515288-create-media-displays to hidden.
rajeshreeputra → created an issue.
rajeshreeputra → created an issue.
Requesting review.