rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
Thank you, @drunkenmonkey, for your thorough review and valuable feedback. I’ll take this forward and update the MR accordingly. Moving back in needs work.
rajeshreeputra → made their first commit to this issue’s fork.
Hi @joshi.rohit100,
Providing in place document title update filed is different from providing Linkit plugin support in Acquia DAM. I’ve created a separate
issue
💬
Provide Linkit plugin support in Acquia DAM
Active
specifically to track Linkit support in the Acquia DAM module.
Result not found message update looks like following screenshot:
It should, updated MR with the changes. Requesting early review.
This module will no longer receive regular updates, except for critical bug fixes. We recommend migrating to the Acquia DAM → module for ongoing support and enhancements.
Updated MR as per latest inputs/suggestions, requesting review.
- Added an update hook to migrate existing configurations to use key-based authentication.
1) For existing users, if key module is detected, run an update hook that creates a Key entity and moves the credentials there. If key module is not detected, do nothing.
- Added an install hook to update the configuration to use key-based authentication.
3) If a user enables Key module later on, run a post_install hook that migrates the credentials config to Key automatically.
- While the discussion is ongoing, created a key entity with the state key provider and kept in optional config.
4) Include a Key entity in the searchstax config under the 'optional' folder, since its only required to be installed if Key exists.
Updated service to remove protocol or trailing slashes from domains while using key module, requesting review.
@japerry, I’ll make sure to add a test for this by the end of the week.
rajeshreeputra → made their first commit to this issue’s fork.
@japerry, I like this idea. Will update the MR accordingly. Will create key entity with machine name: searchstax_credebtials, if you have any other suggestion for the same please provide.
Updated tests and it's green now, Hence moving ahead!
rajeshreeputra → changed the visibility of the branch 3552772-update-api-url to hidden.
@becw could you please try applying the changes from this MR, this should fix the issue you mentioned above point 8, 9.
Updated MR with proposed solution, requesting review.
Updated MR with following:
- Added requirement check in routing for point 1
- Updated config form to incorporate feedback for point 2 and 3.
After disconnecting a site, the authentication button appears twice. I believe it would be more effective not to display the Site Authentication button in first fieldset.
current:
Proposed:
2.x stable version is released. Hence closing this, feel free to reopen!
2.x stable version is released. Hence closing this, feel free to reopen!
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → made their first commit to this issue’s fork.
It appears this has already been addressed in version 4.x. Closing this for now, but please feel free to reopen if you notice any discrepancies.
Closing as we are unable to reproduce this issue. Please upgrade to the latest 4.1.1 release. If the issue persists, feel free to reopen.
Completed as part of 📌 Run Tests in Gitlab Parallelly Needs work .
rajeshreeputra → made their first commit to this issue’s fork.
@danflanagan8, update hook already present in 1.1.x release see.
rajeshreeputra → made their first commit to this issue’s fork.
rajeshreeputra → changed the visibility of the branch 3551212-update-api-endpoints to hidden.
rajeshreeputra → made their first commit to this issue’s fork.
This issue is addressed as part of 🐛 Acquia DAM Item Update Queue not being ran Active , so closing this issue. If you continue to experience the problem, please feel free to reopen.
This looks good, but we may need to update it once ✨ Support Key module inside Acquia DAM (sites) Needs work lands. Adding this information to the authentication page can be addressed in conjunction with #3549173: Separate DAM Authentication Settings from Image Styles in Configuration Form → .
rajeshreeputra → made their first commit to this issue’s fork.