Pune
Account created on 21 March 2016, over 8 years ago
#

Merge Requests

More

Recent comments

🇮🇳India Rajeshreeputra Pune

I concur with your assessment, @WalkingDexter, that support for D9 and D10.1 can be discontinued. Additionally, the changes related to PHPSC can be effectively addressed within the scope of a separate ticket. Will create separate ticket for the same and segregate the changes accordingly.

🇮🇳India Rajeshreeputra Pune

The changes appear to be in good, will plan to proceed with merge by this week.

🇮🇳India Rajeshreeputra Pune

Just as a quick update for your information, the changes outlined in this ticket have been carried over to ticket 📌 Automated Drupal 11 compatibility fixes for stable Needs review to ensure compatibility with the D11.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra changed the visibility of the branch project-update-bot-only to hidden.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra made their first commit to this issue’s fork.

🇮🇳India Rajeshreeputra Pune

Closing as this work as designed.

🇮🇳India Rajeshreeputra Pune

The selector #drupal-off-canvas is deprecated; this issue has been addressed in issue 🐛 Error on Drupal 10.3.0-beta1 because some core CSS libraries moved Needs work . The resolution can be found in the following commit.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra made their first commit to this issue’s fork.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra changed the visibility of the branch project-update-bot-only to hidden.

🇮🇳India Rajeshreeputra Pune

Created MR with required changes, hence requesting review.

🇮🇳India Rajeshreeputra Pune

We have observed that tests are failing in the upcoming minor and major releases because there is a new requirement dictating that, starting with version 10.3, the provider functions must be declared as static. It has come to our attention that the getRandomGenerator method within the RandomGeneratorTrait is not currently static.

We would greatly appreciate any guidance or insights from the maintainer and the community on how to best address this change. Your assistance in this matter would be invaluable.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra changed the visibility of the branch project-update-bot-only to hidden.

🇮🇳India Rajeshreeputra Pune

@Balu may we proceed with implementing the changes outlined in 🐛 PHP 8.2 compatibility RTBC and commence with the work?

🇮🇳India Rajeshreeputra Pune

Thanks @ufku for the quick update and release!

🇮🇳India Rajeshreeputra Pune

I believe that with the release of version 6.x, we should consider discontinuing support for early versions of Drupal and those that are end-of-life (EOL). I would appreciate the opinions of the maintainers on this matter. If necessary, we could maintain compatibility with earlier versions within the 5.x branch.

🇮🇳India Rajeshreeputra Pune

Verified changes with Drupal 11 rc version and working fine.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra made their first commit to this issue’s fork.

🇮🇳India Rajeshreeputra Pune

Hi @jrockowitz, Will get started with maintenance Drupal 9, 10, 11 compatibility and releases.

🇮🇳India Rajeshreeputra Pune

@naveenvalecha jQuery UI is now released with Drupal 11 compatibility, hence requesting review.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra made their first commit to this issue’s fork.

🇮🇳India Rajeshreeputra Pune

The CKE4to5 upgrade test is failing in the upcoming minor and major versions due to a new requirement stipulating that the provider function must be declared as static starting with version 10.3 and beyond. However, in Drupal 10.2 and previous versions, the CKE5 SmartDefaultSettingsTest provider method is not static.

We would greatly appreciate the input of the maintainer and community.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra changed the visibility of the branch 3420115-ci-test to hidden.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra made their first commit to this issue’s fork.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra changed the visibility of the branch 3433697-gitlab-ci-test to hidden.

🇮🇳India Rajeshreeputra Pune

As of PHP 8.3 the function assert_options() and the assert.* directives are deprecated and should not be used in production code. To enable assertions PHP should be configured with zend.assertions.

Looking for alternative meanwhile requesting opinion from maintainer and community for the same.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra made their first commit to this issue’s fork.

🇮🇳India Rajeshreeputra Pune

Changes looks good to me, will wait for 🐛 a Drupal 11 dev line is needed for CROP API. RTBC to get merged and released.

🇮🇳India Rajeshreeputra Pune

Changes looks good, CI is green. Hence RTBC.

🇮🇳India Rajeshreeputra Pune

Commits are cherry-picked from this issue to 📌 Add Drupal 11 support Needs work , please review.

🇮🇳India Rajeshreeputra Pune

@ankitv18 - As referenced in my previous comment #20 📌 Add Drupal 11 support Needs work , the commits have been cherry-picked from 📌 GitlabCI support: Fix all jobs validation errors and PHPUnit tests RTBC . Subsequently, we have added changes related to Drupal 11 compatibility. Once this merge request, or the one from 📌 GitlabCI support: Fix all jobs validation errors and PHPUnit tests RTBC , is accepted, updating the fork should suffice.

Regarding ESLINT issue 📌 GitlabCI: Fix ESLINT validation errors Active , please note that it has not been addressed in this merge request.

🇮🇳India Rajeshreeputra Pune

The 'Next major' test is currently failing due to jQuery UI's incompatibility with Drupal 11 and jQuery UI Touch Punch has dependency on it, as detailed in issue 📌 Automated Drupal 11 compatibility fixes for jquery_ui RTBC . Once the necessary updates are merged and released, we should see the test start running successfully.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra made their first commit to this issue’s fork.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra made their first commit to this issue’s fork.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra made their first commit to this issue’s fork.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra made their first commit to this issue’s fork.

🇮🇳India Rajeshreeputra Pune

Updated GitLab CI to test with Previous, Current and Next Major and minor releases.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra made their first commit to this issue’s fork.

🇮🇳India Rajeshreeputra Pune

Rebased with work from 📌 GitlabCI support: Fix all jobs validation errors and PHPUnit tests RTBC and added D11 support. Requesting review.

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra made their first commit to this issue’s fork.

🇮🇳India Rajeshreeputra Pune

Can be closed in favor of 📌 Automated Drupal 11 compatibility fixes for imce Needs review .

🇮🇳India Rajeshreeputra Pune

Rajeshreeputra made their first commit to this issue’s fork.

🇮🇳India Rajeshreeputra Pune

The 'Next major' test is currently failing due to jQuery UI's incompatibility with Drupal 11 and jQuery UI Tooltip has dependency on it, as detailed in issue 📌 Automated Drupal 11 compatibility fixes for jquery_ui RTBC . Once the necessary updates are merged and released, we should see the test start running successfully.

🇮🇳India Rajeshreeputra Pune

The 'Next major' test is currently failing due to following module's incompatibility with Drupal 11 and jQuery UI Spinner has dependency on it, as detailed in issue's:
jQuery UI - 📌 Automated Drupal 11 compatibility fixes for jquery_ui RTBC
jQuery UI Button - 📌 Automated Drupal 11 compatibility fixes for jquery_ui_button Needs review
Once the necessary updates are merged and released, we should see the test start running successfully.

🇮🇳India Rajeshreeputra Pune

The 'Next major' test is currently failing due to jQuery UI's incompatibility with Drupal 11 and jQuery UI Slider has dependency on it, as detailed in issue 📌 Automated Drupal 11 compatibility fixes for jquery_ui RTBC . Once the necessary updates are merged and released, we should see the test start running successfully.

Production build 0.69.0 2024