Fix errors reported by phpcs

Created on 13 March 2024, over 1 year ago

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇮🇳India chaitanyadessai Goa

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @chaitanyadessai
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India chaitanyadessai Goa

    Please review.

  • Status changed to Needs work over 1 year ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown.

  • First commit to issue fork.
  • Assigned to nitin_lama
  • Issue was unassigned.
  • 🇮🇳India sakthi_dev

    The provided patch applied without any errors.

    curl https://www.drupal.org/files/issues/2024-03-13/3427513-2.patch | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 65111  100 65111    0     0    97k      0 --:--:-- --:--:-- --:--:--   97k
    patching file assets/vendor/jquery.ui/themes/base/accordion.css
    patching file assets/vendor/jquery.ui/themes/base/autocomplete.css
    patching file assets/vendor/jquery.ui/themes/base/button.css
    patching file assets/vendor/jquery.ui/themes/base/checkboxradio.css
    patching file assets/vendor/jquery.ui/themes/base/controlgroup.css
    patching file assets/vendor/jquery.ui/themes/base/core.css
    patching file assets/vendor/jquery.ui/themes/base/datepicker.css
    patching file assets/vendor/jquery.ui/themes/base/dialog.css
    patching file assets/vendor/jquery.ui/themes/base/draggable.css
    patching file assets/vendor/jquery.ui/themes/base/menu.css
    patching file assets/vendor/jquery.ui/themes/base/resizable.css
    patching file assets/vendor/jquery.ui/themes/base/selectable.css
    patching file assets/vendor/jquery.ui/themes/base/selectmenu.css
    patching file assets/vendor/jquery.ui/themes/base/slider.css
    patching file assets/vendor/jquery.ui/themes/base/sortable.css
    patching file assets/vendor/jquery.ui/themes/base/spinner.css
    patching file assets/vendor/jquery.ui/themes/base/tabs.css
    patching file assets/vendor/jquery.ui/themes/base/theme.css
    patching file assets/vendor/jquery.ui/themes/base/tooltip.css
    patching file jquery_ui.libraries.yml
    

    But while running the command
    phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jquery_ui

    got the following errors

    FILE: /home/administrator/Projects/contribution/jquery_ui/assets/vendor/jquery.ui/themes/base/progressbar.css
    -------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    -------------------------------------------------------------------------------------------------------------
    
    
    FILE: /home/administrator/Projects/contribution/jquery_ui/CHANGELOG.txt
    -----------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------
     1 | WARNING | File encoding is invalid, expected UTF-8
    -----------------------------------------------------------------------
    
    Time: 99ms; Memory: 14MB
  • Pipeline finished with Success
    over 1 year ago
    Total: 3692s
    #119124
  • Status changed to RTBC over 1 year ago
  • Status changed to Needs work about 2 months ago
  • 🇮🇳India rajeshreeputra Pune

    Need to resolve the conflits.

  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    avpaderno changed the visibility of the branch 3427513-gitlab-ci-reports to hidden.

  • Pipeline finished with Success
    about 2 months ago
    Total: 132s
    #494234
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    The PHP_CodeSniffer errors/warnings have been already fixed, as GitLab CI does not report any PHP_CodeSniffer error/warning without doing any change.

  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    avpaderno changed the visibility of the branch 3427513-gitlabci-reports to hidden.

Production build 0.71.5 2024