scott_euser → credited sakthi_dev → .
Please review and merge.
sakthi_dev → created an issue.
@mandclu, May I know why we are using contributed book module as the module is included in core?
In site audit, it is showing that there is a duplicate entry for the module. Kindly help!
larowlan → credited sakthi_dev → .
Nice Initiative!
I'm also happy to support this module as a co-maintainer as the existing maintainers may not be able to release a tag for Drupal 9 and 10 and review the new feature request and support and active maintaining in future.
Rebased and resolved the conflicts.
sakthi_dev → made their first commit to this issue’s fork.
@gugalamaciek, could you please share the diff. I have created an MR for 11.x 2ith #49.
sakthi_dev → made their first commit to this issue’s fork.
Please review.
sakthi_dev → made their first commit to this issue’s fork.
sakthi_dev → made their first commit to this issue’s fork.
sakthi_dev → changed the visibility of the branch 3446228-remove-country-code to hidden.
@cassien
Can you please post the screenshot and reproducing steps. Hiding the branch.
sakthi_dev → made their first commit to this issue’s fork.
sakthi_dev → made their first commit to this issue’s fork.
sakthi_dev → made their first commit to this issue’s fork.
Created PR by resolving the issues reported by Upgrade Status. Please review.
sakthi_dev → made their first commit to this issue’s fork.
Please review.
sakthi_dev → made their first commit to this issue’s fork.
sakthi_dev → made their first commit to this issue’s fork.
@i-grou, The changes already present in 11.x.
sakthi_dev → made their first commit to this issue’s fork.
@bircher, Rebased and updated the test. Please review.
sakthi_dev → made their first commit to this issue’s fork.
@jingles1987, It's mentioned in the Filter document as "Lines and paragraphs are automatically recognized. The
line break,
paragraph and
close paragraph tags are inserted automatically. If paragraphs are not recognized simply add a couple of blank lines."
Created a separate log from this module. Please suggest what would be the best way of implementation.
@anybody, found that the watchdog message is handled in core. Can you please create issue in core and add it here as related issue?
As the latest dev branch is 11.x, created a MR for that branch. Hope this will resolve the needs review bot issue.
sakthi_dev → changed the visibility of the branch 3441015-title-of-a to hidden.
Updated the title/name of the permission. Also updated the IS.
sakthi_dev → made their first commit to this issue’s fork.
sakthi_dev → changed the visibility of the branch 3441015-title-of-a to active.
Thank you Bircher for commiting!
Converted the latest patch #10 to MR.
sakthi_dev → made their first commit to this issue’s fork.
Rebased with the latest changes in 11.x. Please review.
sakthi_dev → made their first commit to this issue’s fork.
@guymandude,
I wasn't able to reproduce the issue. Correct me if I'm doing something wrong.
Versions:
PHP: 8.1.27
Drupal: 10.2.5-dev
Conditional Field: 4.0.0-alpha5
- Installed Conditional Fields
- Created a new Content Type Landing Page and reused field Field Tags from Article Content Type
- Created a condition for the field tags if body has value for Landing Page
Not it's created in any of other Content type.
Rebased and resolved the conflicts. Please review.
sakthi_dev → made their first commit to this issue’s fork.
Hi @bircher, I'm bit confused should we change the implementation or should we add test here?
Created MR by resolving the test case failures. Please review.
sakthi_dev → made their first commit to this issue’s fork.
Resolved the test case fails. Please review.
sakthi_dev → made their first commit to this issue’s fork.
Updated the code to look for destination config ignore settings and if that config is there in destination then will ignore the configs added in destination. Please review. If there are some suggestion please let me know.
sakthi_dev → made their first commit to this issue’s fork.
Pipeline is fixed in https://www.drupal.org/project/config_ignore/issues/3432315 🐛 Ignoring any config entities with an empty config sync directory causes PHP error Needs review . It will be fixed once it is merged.
Thanks @bircher. Have updated the code to list the configs on which events based on mode selection instead of listing if there is a change. Please review.
@nitin_lama, Thanks for creating the MR.
@bircher. Is the current MR looks good? Can we add text like following?
About
This module helps the developer as well as site builder to manage the configuration effectively by restricting configuration override with earlier changes.
This also helps to deploy and maintain CI/CD effectively for the often changing configuration without losing the latest changes.
For more details please refer module page → also please refer README.txt.
Configuration
Configure the ignore settings in Configuration Page.
Updated the license identifier in composer.json. Please review. Also thanks @liam-morland.
sakthi_dev → made their first commit to this issue’s fork.
Hi @bircher and @JayDarnell, created the sub module for ignoring block content along with the test. Please review.
@JayDarnell, As there is no activity more than 2 months I unassigned you from this issue.
Changing the status to Needs Review. https://www.drupal.org/project/config_ignore/issues/3426026#comment-1550... 🐛 Issue with Config Ignore Module after Upgrade to Version 3.x Postponed: needs info
Hi @bircher, I think the information provided by @ajay-gadhavana is sufficient and understandable. The request is to show the diff configs which are ignored in Configuration Sync page. Updated the code without the dependency of config_filter. Please review and refer the screenshots.
Yeah as the part of the code dependent on the config filter module, it was removed in the issue https://www.drupal.org/project/config_ignore/issues/3099674 → .
Hi @ajay-gadhavana, I hope it was removed as a part of removal of dependency of config_filter. I'm looking to get the exact issue of that.
As if there is no config files in config sync then it is not required to validate the config ignore on Import. Please review.
sakthi_dev → made their first commit to this issue’s fork.
Fixed all the phpcs issues. Please review.
sakthi_dev → made their first commit to this issue’s fork.
Resolved the conflicts, please review if there is something needs to be updated.
sakthi_dev → made their first commit to this issue’s fork.
Fixed all the PHPCS issues. Please review.
sakthi_dev → made their first commit to this issue’s fork.
Created a MR with the provided patch as it's better to go with MR.
sakthi_dev → made their first commit to this issue’s fork.
Please review.
sakthi_dev → made their first commit to this issue’s fork.
Updated IS with the issues of phpcs.
Resolved the conflicts.
sakthi_dev → made their first commit to this issue’s fork.
Resolved the conflicts but still needs to address the above comments.
sakthi_dev → made their first commit to this issue’s fork.
Resolved the conflicts.
sakthi_dev → made their first commit to this issue’s fork.
The provided patch applied without any errors.
curl https://www.drupal.org/files/issues/2024-03-13/3427513-2.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 65111 100 65111 0 0 97k 0 --:--:-- --:--:-- --:--:-- 97k
patching file assets/vendor/jquery.ui/themes/base/accordion.css
patching file assets/vendor/jquery.ui/themes/base/autocomplete.css
patching file assets/vendor/jquery.ui/themes/base/button.css
patching file assets/vendor/jquery.ui/themes/base/checkboxradio.css
patching file assets/vendor/jquery.ui/themes/base/controlgroup.css
patching file assets/vendor/jquery.ui/themes/base/core.css
patching file assets/vendor/jquery.ui/themes/base/datepicker.css
patching file assets/vendor/jquery.ui/themes/base/dialog.css
patching file assets/vendor/jquery.ui/themes/base/draggable.css
patching file assets/vendor/jquery.ui/themes/base/menu.css
patching file assets/vendor/jquery.ui/themes/base/resizable.css
patching file assets/vendor/jquery.ui/themes/base/selectable.css
patching file assets/vendor/jquery.ui/themes/base/selectmenu.css
patching file assets/vendor/jquery.ui/themes/base/slider.css
patching file assets/vendor/jquery.ui/themes/base/sortable.css
patching file assets/vendor/jquery.ui/themes/base/spinner.css
patching file assets/vendor/jquery.ui/themes/base/tabs.css
patching file assets/vendor/jquery.ui/themes/base/theme.css
patching file assets/vendor/jquery.ui/themes/base/tooltip.css
patching file jquery_ui.libraries.yml
But while running the command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jquery_ui
got the following errors
FILE: /home/administrator/Projects/contribution/jquery_ui/assets/vendor/jquery.ui/themes/base/progressbar.css
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-------------------------------------------------------------------------------------------------------------
FILE: /home/administrator/Projects/contribution/jquery_ui/CHANGELOG.txt
-----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------
1 | WARNING | File encoding is invalid, expected UTF-8
-----------------------------------------------------------------------
Time: 99ms; Memory: 14MBI'm not sure about the exact functionality and not able to test it. Cleared the issue mentioned in Upgrade status module. Please review and post if there are any errors in the functionality. Thanks in advance.
sakthi_dev → made their first commit to this issue’s fork.
Rebased with 11.x and resolved conflicts.
sakthi_dev → made their first commit to this issue’s fork.
I couldn't find the variables in the file. Could you please reverify it once please?
The issue summary is of "Panopoly Images" but it is mapped as "Panopoly". Also issues are not allowed in Panopoly Images. This issue can be closed as won't fix.
Please review.
sakthi_dev → made their first commit to this issue’s fork.
Rebased with 11.x by resolving the conflicts.
sakthi_dev → made their first commit to this issue’s fork.
Rerolled the patch #94 with 11.x.
sakthi_dev → made their first commit to this issue’s fork.
sakthi_dev → made their first commit to this issue’s fork.
Addressed the comment #15. Please review.
sakthi_dev → made their first commit to this issue’s fork.
Fixed the remaining issues just keeping the function name to keep it backward compatible in other modules. Please review.