- Issue created by @alexpott
- Status changed to Needs review
9 months ago 1:12pm 2 April 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
We will need to update / maybe delete and create a new CR - https://www.drupal.org/node/3375456 โ
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
From @kim.pepper on gitlab:
I don't think we should revert the deprecations on UploadedFileInterface. ::isValid(), ::getError() and ::getErrorMessage() don't really apply to input stream uploaded files.
I don't agree I think we should keep them. Whatever we wrap input stream uploaded files can return TRUE from isValid().
The alternative is to make an addition to UploadedFileInterface and make that responsible for the validation. I think that this might be a good way to go as it put the responsibility in the correct place.
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
kim.pepper โ made their first commit to this issueโs fork.
- Status changed to RTBC
8 months ago 7:56am 9 April 2024 - ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
I think the approach for validation here is a better one that the current version.
RTBC for me.
- Status changed to Needs work
8 months ago 4:00am 10 April 2024 The Needs Review Queue Bot โ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- First commit to issue fork.
- Status changed to Needs review
8 months ago 4:17am 10 April 2024 - ๐ฎ๐ณIndia sakthi_dev
Rebased and resolved the conflicts. Please review.
- Status changed to RTBC
8 months ago 12:20pm 10 April 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
I redid the merge and got the same diff as @sakthi_dev so nice resolving.
-
larowlan โ
committed 79d00664 on 11.x
Issue #3437623 by alexpott, kim.pepper, sakthi_dev: \Drupal\file\Upload\...
-
larowlan โ
committed 79d00664 on 11.x
-
larowlan โ
committed 8be1a7db on 10.3.x
Issue #3437623 by alexpott, kim.pepper, sakthi_dev: \Drupal\file\Upload\...
-
larowlan โ
committed 8be1a7db on 10.3.x
- Status changed to Fixed
8 months ago 5:43am 11 April 2024 - ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
Committed to 11.x and backported to 10.3.x
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
I've updated the CR to reflect the changes - see https://www.drupal.org/node/3375456 โ
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
I created a new issue to follow this same pattern for
moveUploadedFile()
๐ Provide a method for FileUploads to be moved Active Automatically closed - issue fixed for 2 weeks with no activity.