mradcliffe → credited kim.pepper → .
Thanks @sandboxpl!
kim.pepper → changed the visibility of the branch 3495196-support-new-api to hidden.
kim.pepper → created an issue.
Updated the IS
📌 Define 'original' as property on the entity object Needs work is in which unblocks this.
The current development branch is 3.x. Please don't change the version.
Needs Work for the test failures.
I was able to reproduce the test fail locally, but wasn't able to work out what the cause is.
There are a few eslint errors too which could clean up the javascript but I assume that can be done in a follow up.
Addressed feedback
The others can be closed by a project owner.
It seems the Automated Drupal 11 compatibility bot force pushes over our MR.
I've created a new one.
Added the link to the follow up, so back to RTBC
The SVG Image → module does sanitization in the Formatter. https://git.drupalcode.org/project/svg_image/-/blob/3.x/src/Plugin/Field...
Why sure @drupalshapoopie ! It's these two objects:
- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/file/...
- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/file/...
Plus the logic of checking which type and saving an input stream to file.
Left some comments.
Feedback resolved. Back to RTBC
In
📌
Split File hooks into separate classes
Active
I split out hooks based on common dependencies, and kept those with no dependencies in the FileHooks
class.
Perhaps we should add an explicit check to see if the file is readable before the rename?
I created 📌 Move file_get_content_headers() to a static method on a utility class Active as a follow-up.
kim.pepper → created an issue.
We have 📌 [PP-1] Deprecate file_get_file_references(). Move the logic to file.usage service Postponed already.
Updated links to CR.
Good test coverage. I ran the test-only pipeline and it fails as expected. The current docblock already says it should return int|null
so there is no API breaks afaik, and we don't need a change record for a bug fix. I think we are safe to RTBC.
Created a draft CR. Will look at changing the links in the morning unless someone else gets there first.
Applied suggestions.
Sorry I should have postponed this on 📌 Split File hooks into separate classes Active
My understanding is no-one is using these classes directly nor sub-classing them so we should be ok. But happy to hear others views.
Thanks for the review. Addressed feedback.
There are existing tests for these hooks. We are just moving the code.
kim.pepper → created an issue. See original summary → .
kim.pepper → created an issue.
Added upgrade test
Removing 'Needs framework manager review' tag as @larowlan has reviewed.
Looks like we are triggering deprecation errors in Drupal\Core\File\MimeType\DefaultMimeTypeMap::getMapping()
and Drupal\Core\File\MimeType\DefaultMimeTypeMap::setMapping()
I squashed all the commits in the MR to make rebasing on 11.x easier.
Discussed with @larowlan and this should be a task.
Spoke to @xjm at DrupalCon Singapore contribution day, and she recommended tagging as Needs framework manager review.
@et.cetera see 🐛 ExtensionMimeTypeGuesser::guessMimeType must support file names with "0" (zero) like foo.0.zip Active for that bug fix.
Created 📌 Add an interface for FileUploadHandler Active
kim.pepper → created an issue. See original summary → .
Updated IS
Tests are green ✅ Ready for reviews
kim.pepper → changed the visibility of the branch 3046152-video-media-needs to hidden.
kim.pepper → changed the visibility of the branch 3046152-10-3-x to hidden.
Changed the post update hook to actually update the field formatter settings.
kim.pepper → made their first commit to this issue’s fork.
This was just a rebase on 11.x so putting back to RTBC
Commited to 2.x. Thanks!
kim.pepper → made their first commit to this issue’s fork.
Commited to 2.x. Thanks!
kim.pepper → made their first commit to this issue’s fork.
I've merged 11.x into this MR. Looks like the Hook Attributes work that got merged is triggering some deprecations that will need looking at.
If we do use Symfony\Contracts\Service\ResetInterface
we could collect all services implementing that interface at container build, and provide a simple way to call reset()
on them all when needed.
I've added more info to the readme.
This is a duplicate of 🐛 Logging is too noisy by default Closed: won't fix We don't have control over what the opensearch-php lib is logging. You can configure your own logger and use NullLogger if you don't want any logging.
Created a new MR because I don't know how to properly rebase via the gitlab UI. 😞
Rebased on 11.x, simplified the change, and added a test.
Confirmed the test-only pipeline failed:
There was 1 failure:
1) Drupal\KernelTests\Core\File\MimeTypeTest::testFileMimeTypeDetection
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'application/zip'
+'application/octet-stream'
Ah looks like you did test on 10.3.x already. We will need a test to show the before and after with the fix.
This may be resolved with 🐛 ExtensionMimeTypeGuesser::guessMimeType return less accurate MIME type when file extensions have multiple parts Active Are you able to test on 10.3.x?
Added a post update hook and an entity presave as per #43.
kim.pepper → made their first commit to this issue’s fork.
Adding credits
This seems like a legit response coming from OpenSearch. I'm not sure this module should be doing anything differently. Please comment if you think there is something we can try.
This was fixed in ✨ Ability to disable SSL verification for dev instances Active
quietone → credited kim.pepper → .
Committed to 2.x. Thanks!
I'm a bit late to the party but went looking for an issue like this after a recently being reminded of the poor DX of the current API.
I've tried to go through all 138 comments and it looks to me like they have all been addressed.
The new API in this issue feels like the right level of abstraction to me, and a core API plus experimental module seems like the right approach.
Looks like there is thorough test coverage too, and the IS is up to date.
We still need to get a framework manager to review, but otherwise I would RTBC it.
Looks great. I assume the re-index from one to another is relatively fast?
Confirmed the only changes in behat/mink v1.12.0 are PHP 8.4 compatibility fixes.
I think the right approach is an upgrade hook to set that value.
Reverted ✨ Ability to disable SSL verification for dev instances Active
Reverting this as we don't have an update hook to set the default value.
Committed to 2.x
Committed to 3.x. Thanks!
MR for 2.x needed with BC layer.
Committed to 2.x and 3.x Thanks!