🏄‍♂️🇦🇺Sydney, Australia
Account created on 24 September 2008, over 16 years ago
  • Co-Founder and Technical Director at PreviousNext 
  • Co-Founder and Technical Director at Skpr 
#

Merge Requests

More

Recent comments

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Thanks @sandboxpl!

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

kim.pepper changed the visibility of the branch 3495196-support-new-api to hidden.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

kim.pepper created an issue.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Updated the IS

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

📌 Define 'original' as property on the entity object Needs work is in which unblocks this.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

The current development branch is 3.x. Please don't change the version.

Needs Work for the test failures.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

I was able to reproduce the test fail locally, but wasn't able to work out what the cause is.

There are a few eslint errors too which could clean up the javascript but I assume that can be done in a follow up.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Addressed feedback

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

The others can be closed by a project owner.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

It seems the Automated Drupal 11 compatibility bot force pushes over our MR.

I've created a new one.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Added the link to the follow up, so back to RTBC

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Why sure @drupalshapoopie ! It's these two objects:

Plus the logic of checking which type and saving an input stream to file.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Left some comments.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Feedback resolved. Back to RTBC

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

In 📌 Split File hooks into separate classes Active I split out hooks based on common dependencies, and kept those with no dependencies in the FileHooks class.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Perhaps we should add an explicit check to see if the file is readable before the rename?

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Updated links to CR.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Good test coverage. I ran the test-only pipeline and it fails as expected. The current docblock already says it should return int|null so there is no API breaks afaik, and we don't need a change record for a bug fix. I think we are safe to RTBC.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Created a draft CR. Will look at changing the links in the morning unless someone else gets there first.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Applied suggestions.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Sorry I should have postponed this on 📌 Split File hooks into separate classes Active

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

My understanding is no-one is using these classes directly nor sub-classing them so we should be ok. But happy to hear others views.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Thanks for the review. Addressed feedback.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

There are existing tests for these hooks. We are just moving the code.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

kim.pepper created an issue. See original summary .

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

kim.pepper created an issue.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Added upgrade test

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Removing 'Needs framework manager review' tag as @larowlan has reviewed.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Looks like we are triggering deprecation errors in Drupal\Core\File\MimeType\DefaultMimeTypeMap::getMapping() and Drupal\Core\File\MimeType\DefaultMimeTypeMap::setMapping()

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

I squashed all the commits in the MR to make rebasing on 11.x easier.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Discussed with @larowlan and this should be a task.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Spoke to @xjm at DrupalCon Singapore contribution day, and she recommended tagging as Needs framework manager review.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

kim.pepper created an issue. See original summary .

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Updated IS

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Tests are green ✅ Ready for reviews

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

kim.pepper changed the visibility of the branch 3046152-video-media-needs to hidden.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

kim.pepper changed the visibility of the branch 3046152-10-3-x to hidden.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Changed the post update hook to actually update the field formatter settings.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

kim.pepper made their first commit to this issue’s fork.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

This was just a rebase on 11.x so putting back to RTBC

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Commited to 2.x. Thanks!

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

kim.pepper made their first commit to this issue’s fork.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Commited to 2.x. Thanks!

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

kim.pepper made their first commit to this issue’s fork.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

I've merged 11.x into this MR. Looks like the Hook Attributes work that got merged is triggering some deprecations that will need looking at.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

If we do use Symfony\Contracts\Service\ResetInterface we could collect all services implementing that interface at container build, and provide a simple way to call reset() on them all when needed.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

I've added more info to the readme.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

This is a duplicate of 🐛 Logging is too noisy by default Closed: won't fix We don't have control over what the opensearch-php lib is logging. You can configure your own logger and use NullLogger if you don't want any logging.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Created a new MR because I don't know how to properly rebase via the gitlab UI. 😞

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Rebased on 11.x, simplified the change, and added a test.

Confirmed the test-only pipeline failed:

There was 1 failure:
1) Drupal\KernelTests\Core\File\MimeTypeTest::testFileMimeTypeDetection
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'application/zip'
+'application/octet-stream'
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Ah looks like you did test on 10.3.x already. We will need a test to show the before and after with the fix.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Added a post update hook and an entity presave as per #43.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

kim.pepper made their first commit to this issue’s fork.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Adding credits

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

This seems like a legit response coming from OpenSearch. I'm not sure this module should be doing anything differently. Please comment if you think there is something we can try.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Committed to 2.x. Thanks!

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

I'm a bit late to the party but went looking for an issue like this after a recently being reminded of the poor DX of the current API.

I've tried to go through all 138 comments and it looks to me like they have all been addressed.

The new API in this issue feels like the right level of abstraction to me, and a core API plus experimental module seems like the right approach.

Looks like there is thorough test coverage too, and the IS is up to date.

We still need to get a framework manager to review, but otherwise I would RTBC it.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Looks great. I assume the re-index from one to another is relatively fast?

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Confirmed the only changes in behat/mink v1.12.0 are PHP 8.4 compatibility fixes.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

I think the right approach is an upgrade hook to set that value.

Reverted Ability to disable SSL verification for dev instances Active

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Reverting this as we don't have an update hook to set the default value.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Committed to 2.x

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Committed to 3.x. Thanks!

MR for 2.x needed with BC layer.

🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia

Committed to 2.x and 3.x Thanks!

Production build 0.71.5 2024