Thanks @webflo Can you please create an MR against 3.x as that's the active development branch. We can backport to 2.x.
The event is for altering validation constraints. If you are creating a new one, you probably want to implement your own ConstraintValidator plug-in that extends \Drupal\file\Plugin\Validation\Constraint\BaseFileConstraintValidator.
Committed to 8.x-1.x. Thanks!
Committed to 8.x-1.x
kim.pepper → created an issue.
Committed to 3.x and 2.x
kim.pepper → created an issue.
Commited to 2.x
Committed to 2.x
kim.pepper → created an issue.
Committed to 2.x
kim.pepper → created an issue.
Committed to 2x. and 3.x. Thanks!
Made it configurable and added an update hook. @yobottehg it would be great if you could test this out manually.
@yobottehg I've rebased this on 3.x.
Can you explain why you chose a value of 20 rather than any other arbitrary number? Also, should this be configurable?
New commits go into 3.x
Committed to 3.x.
Need to add the composer dependency.
kim.pepper → made their first commit to this issue’s fork.
Updated IS
kim.pepper → changed the visibility of the branch 3465857-bump-minimum-versions to hidden.
Ready for reviews. Would be good for someone who uses the AWS Signing Connector to do a manual test.
Can we just use \Drupal\Core\StreamWrapper\StreamWrapperInterface::realpath() ?
Is this something you can change directly on opensearch? We don't try and provide all the possible settings via the module. There would just be too many.
I think we should stick with events.
What if we do the same instead with this locale setting? Then we don't need any replacements.
That sounds great!
All stand as the legend leaves the room...
I think we have resolved all threads except one question for @alexpott about changes to MimeTypeMapFactory
quietone → credited kim.pepper → .
Went with the mark version.
Not sure which version is best:
kim.pepper → created an issue.
mradcliffe → credited kim.pepper → .
Created an issue for #23 📌 Support service closure shorthand syntax in YamlFileLoader Postponed
Postponing until this is available in a supported symfony version.
kim.pepper → created an issue.
A common pattern for sub-modules is to define the composer dependencies as 'suggest' and add a requirements check for the existence in the sub-module.
mradcliffe → credited kim.pepper → .
Thanks @sandboxpl!
kim.pepper → changed the visibility of the branch 3495196-support-new-api to hidden.
kim.pepper → created an issue.
Updated the IS
📌 Define 'original' as property on the entity object Needs work is in which unblocks this.
The current development branch is 3.x. Please don't change the version.
Needs Work for the test failures.
I was able to reproduce the test fail locally, but wasn't able to work out what the cause is.
There are a few eslint errors too which could clean up the javascript but I assume that can be done in a follow up.
Addressed feedback
The others can be closed by a project owner.
It seems the Automated Drupal 11 compatibility bot force pushes over our MR.
I've created a new one.
Added the link to the follow up, so back to RTBC
The SVG Image → module does sanitization in the Formatter. https://git.drupalcode.org/project/svg_image/-/blob/3.x/src/Plugin/Field...
Why sure @drupalshapoopie ! It's these two objects:
- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/file/...
- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/file/...
Plus the logic of checking which type and saving an input stream to file.
Left some comments.
Feedback resolved. Back to RTBC
In
📌
Split File hooks into separate classes
Active
I split out hooks based on common dependencies, and kept those with no dependencies in the FileHooks class.
Perhaps we should add an explicit check to see if the file is readable before the rename?
I created 📌 Move file_get_content_headers() to a static method on a utility class Active as a follow-up.
kim.pepper → created an issue.
We have 📌 [PP-1] Deprecate file_get_file_references(). Move the logic to file.usage service Postponed already.
Updated links to CR.
Good test coverage. I ran the test-only pipeline and it fails as expected. The current docblock already says it should return int|null so there is no API breaks afaik, and we don't need a change record for a bug fix. I think we are safe to RTBC.
Created a draft CR. Will look at changing the links in the morning unless someone else gets there first.
Applied suggestions.
Sorry I should have postponed this on 📌 Split File hooks into separate classes Active
My understanding is no-one is using these classes directly nor sub-classing them so we should be ok. But happy to hear others views.
Thanks for the review. Addressed feedback.
There are existing tests for these hooks. We are just moving the code.
kim.pepper → created an issue. See original summary → .
kim.pepper → created an issue.
Added upgrade test
Removing 'Needs framework manager review' tag as @larowlan has reviewed.
Looks like we are triggering deprecation errors in Drupal\Core\File\MimeType\DefaultMimeTypeMap::getMapping() and Drupal\Core\File\MimeType\DefaultMimeTypeMap::setMapping()
I squashed all the commits in the MR to make rebasing on 11.x easier.
Discussed with @larowlan and this should be a task.
Spoke to @xjm at DrupalCon Singapore contribution day, and she recommended tagging as Needs framework manager review.