🇦🇺Australia @kim.pepper

Discussed with @larowlan and this should be a task.

Spoke to @xjm at DrupalCon Singapore contribution day, and she recommended tagging as Needs framework manager review.

@et.cetera see 🐛 ExtensionMimeTypeGuesser::guessMimeType must support file names with "0" (zero) like foo.0.zip Active for that bug fix.

Created 📌 Add an interface for FileUploadHandler Active

kim.pepper → created an issue. See original summary → .

Updated IS

Tests are green ✅ Ready for reviews

kim.pepper → changed the visibility of the branch 3046152-video-media-needs to hidden.

kim.pepper → changed the visibility of the branch 3046152-10-3-x to hidden.

Changed the post update hook to actually update the field formatter settings.

kim.pepper → made their first commit to this issue’s fork.

This was just a rebase on 11.x so putting back to RTBC

Commited to 2.x. Thanks!

kim.pepper → made their first commit to this issue’s fork.

Commited to 2.x. Thanks!

kim.pepper → made their first commit to this issue’s fork.

I've merged 11.x into this MR. Looks like the Hook Attributes work that got merged is triggering some deprecations that will need looking at.

If we do use Symfony\Contracts\Service\ResetInterface we could collect all services implementing that interface at container build, and provide a simple way to call reset() on them all when needed.

I've added more info to the readme.

This is a duplicate of 🐛 Logging is too noisy by default Closed: won't fix We don't have control over what the opensearch-php lib is logging. You can configure your own logger and use NullLogger if you don't want any logging.

Created a new MR because I don't know how to properly rebase via the gitlab UI. 😞

Rebased on 11.x, simplified the change, and added a test.

Confirmed the test-only pipeline failed:

There was 1 failure:
1) Drupal\KernelTests\Core\File\MimeTypeTest::testFileMimeTypeDetection
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'application/zip'
+'application/octet-stream'

Ah looks like you did test on 10.3.x already. We will need a test to show the before and after with the fix.

This may be resolved with 🐛 ExtensionMimeTypeGuesser::guessMimeType return less accurate MIME type when file extensions have multiple parts Active Are you able to test on 10.3.x?

Added a post update hook and an entity presave as per #43.

kim.pepper → made their first commit to this issue’s fork.

Adding credits

This seems like a legit response coming from OpenSearch. I'm not sure this module should be doing anything differently. Please comment if you think there is something we can try.

This was fixed in ✨ Ability to disable SSL verification for dev instances Active

quietone → credited kim.pepper → .

Committed to 2.x. Thanks!

I'm a bit late to the party but went looking for an issue like this after a recently being reminded of the poor DX of the current API.

I've tried to go through all 138 comments and it looks to me like they have all been addressed.

The new API in this issue feels like the right level of abstraction to me, and a core API plus experimental module seems like the right approach.

Looks like there is thorough test coverage too, and the IS is up to date.

We still need to get a framework manager to review, but otherwise I would RTBC it.

Looks great. I assume the re-index from one to another is relatively fast?

Confirmed the only changes in behat/mink v1.12.0 are PHP 8.4 compatibility fixes.

I think the right approach is an upgrade hook to set that value.

Reverted ✨ Ability to disable SSL verification for dev instances Active

Reverting this as we don't have an update hook to set the default value.

Committed to 2.x

Committed to 3.x. Thanks!

MR for 2.x needed with BC layer.

Committed to 2.x and 3.x Thanks!

Created a MR for the 3.x branch.

kim.pepper → changed the visibility of the branch 3381020-ability-to-disable to hidden.

kim.pepper → changed the visibility of the branch 3.x to hidden.

kim.pepper → made their first commit to this issue’s fork.

This might be trickier than I imagined.
Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "cron", path: "cron -> automated_cron.subscriber".

Replaced the cron service proxy with a service closure.

I created 📌 Replace lazy service proxy generation with service closures Active to look at the service closure approach. It might be a big change to do in one go, so we could split it into smaller tasks.

kim.pepper → created an issue.

Created an MR for #13

kim.pepper → made their first commit to this issue’s fork.

Committed to 3.x and 2.x

kim.pepper → created an issue.

Committed to 3.x and 2.x. Thanks!

Added tests and answered question.

Thanks for this. Almost good to go. That ringphp dependency looks like a major PITA.

Yes, the AlterSettingsEvent should probably be called AlterIndexSettingsEvent.

We don't currently have anything to specifically update the server settings.

Thanks. Feedback addressed.

kim.pepper → changed the visibility of the branch 3.x to hidden.

kim.pepper → made their first commit to this issue’s fork.

I think you can only do this in the 6.1.x to provide a warning that a new param will be added in the next major:

public function getUrl(EntityInterface $entity /*, array $options = [] */);

xjm → credited kim.pepper → .

Yes, I think this is still useful as it reduces boilerplate and makes the definition of listeners simpler. Going to set back to RTBC.

Addressed all feedback. Thanks again.

kim.pepper → created an issue.

Discussed throwing an exception with @mstrelan and agreed that would be a behaviour change that would be out of scope for this issue.

Tests are passing.

kim.pepper → created an issue.

Rebased

Rebased.