Video media needs playsinline & muted options

back to RTbC. Patch in D 10.1.x is green

The last submitted patch, 28: 3046152-28.patch, failed testing. View results →

Random test failure.

The last submitted patch, 28: 3046152-28.patch, failed testing. View results →

Applying patch from #25 worked in my case as well. Tested on Drupal 9.5.

It is also worth noting that this functionality is crucial in accessibility. I was specifically searching for the solution because my videos refused to play on iphone devices. Having "autoplay" and "muted" is apparently not not enough for iphones and instead of at least showing the video with play button it simply decides to not render video at all, leaving the space blank. Adding "playsinline" from the patch actually solved the problem.

This will change exported configuration for field formatters, but there's no update to keep things in sync. Needs a post update to update configuration in the database, but also the same logic should happen in hook_ENTITY_TYPE_presave() to cover importing default configuration from modules and profiles. Quite a few examples in core to look at, views or any other updates for config entities implement similar patterns.

The issue title mentions muted, but the patch doesn't, should it? #3090641: Add 'muted' configuration to audio field formatter. → is for the audio formatter, not the video one.

@catch muted is already configurable in the video formatter. I guess, it wasn't, when the issue was created

Updated issue title and summary

Muted is already added, this ticket was renamed to deliver only playsinline setting.

Patch #28 applies cleanly in 11.x. Let's review everything and finally merge

Looking at #28 noticed we will need an upgrade path + tests for the upgrade because of the schema changes.

Drupal 10.2.0 stable was released on: 16 Dec 2023 by: xjm →
https://www.drupal.org/project/drupal/releases/10.2.0 →

Re-roled the patch to work with Drupal 10.2.0

Patch #49 worked for me
Drupal 10.2.1

Attached a static patch file for Drupal core 2024-06-20 10.3.x branch MR 8471, to use with composer patches

Patch #54 works for me on Drupal 10.3.6.

kim.pepper → made their first commit to this issue’s fork.

Added a post update hook and an entity presave as per #43.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Changed the post update hook to actually update the field formatter settings.

kim.pepper → changed the visibility of the branch 3046152-10-3-x to hidden.

kim.pepper → changed the visibility of the branch 3046152-video-media-needs to hidden.

Tests are green ✅ Ready for reviews

Updated IS

Small comment around upgrade path tests.

Added upgrade test

All feedback for this one appears to be addressed.

Applied the MR locally

Shouldn't the 2 checkboxes for "Muted" and "Plays inline" be above "Display of multiple files". almost missed them.