Merge Requests

More

Recent comments

šŸ‡ÆšŸ‡“Jordan Rajab Natshah Jordan

Thanks, Seamus, for filing the issue and the MR.
Moving our support ony for the 3.0.x branch
Dropped support for older versions.

šŸ‡ÆšŸ‡“Jordan Rajab Natshah Jordan

āœ… Released anchor_link-3.0.3 →

šŸ‡ÆšŸ‡“Jordan Rajab Natshah Jordan
  • Cleanup: Removed leftover files from NPM packaging after switching to Composer #13

āœ… Released Vardot/ckeditor5-anchor-drupal 2.0.3
- Works with Drupal >=10.5 || >=11.2
āœ… Released Vardot/ckeditor5-anchor-drupal 1.0.3
- Works with Drupal ^9 || <=10.4 || <=11.1

Doing the change to ^1.0.3 || ^2.0.3

šŸ‡ÆšŸ‡“Jordan Rajab Natshah Jordan
  • Cleanup: Removed leftover files from NPM packaging after switching to Composer #13

āœ… Released Vardot/ckeditor5-anchor-drupal 2.0.3
- Works with Drupal >=10.5 || >=11.2
āœ… Released Vardot/ckeditor5-anchor-drupal 1.0.3
- Works with Drupal ^9 || <=10.4 || <=11.1

Doing the change to ^1.0.3 || ^2.0.3

šŸ‡ÆšŸ‡“Jordan Rajab Natshah Jordan

Re-opened the issue to continue the discussion.

I have a questions:

Why the Drupal Core team did not add an implementation for Bookmarks yet?
Even tho that the bookmark plugin provided in the core CKEditor assets.
what do you think about this? had they disliked the name or the method? or no bandwidth time for that only?

I think LinkIt or the work on having LinkIt alike in Drupal core could be the winner option. What do you think?

šŸ‡ÆšŸ‡“Jordan Rajab Natshah Jordan

I see this.
Thanks, Joel, Wesley.
Removing the .gitignore from the library.

šŸ‡ÆšŸ‡“Jordan Rajab Natshah Jordan

Having CKEditor 5 Bookmark → on the table for experimentation. (Discussion is open internally about it )

As it is using the Drupal Core CKEditor asset code directly.

Maybe it could be a good one.
Please propose a Drupal Core issue to add CKEditor 5 Bookmark → to Drupal Core or Drupal CMS.

šŸ‡ÆšŸ‡“Jordan Rajab Natshah Jordan

Thanks, Michael, for following up.
I like the CKEditor 5 Bookmark → .. As a small and light plugin
It would be better than the big CKEditor 5 Plugin Pack →

Happy with the Bookmark ( as in page Anchor linking ) in Drupal CMS or Drupal Core.
Open the best command name when editing. I like the Bookmark name too.
Bookmarks could be confused with Bookmarked pages for users. a bit like LinkIt

Maybe it could be re-named to in-page/same-page bookmark or page location/position mark
Or Pagemark
Bookmark is the easiest to use as a Caption name.

The idea of using the big CKEditor 5 Plugin Pack is what I do not like.
It has not been added to Drupal Core or Drupal CMS yet.

CKEditor 5 Plugin Pack has commercial Premium Features, free and paid services (sometimes they are mixed)
You will for sure face issues like
šŸ› WProofreader Plugin Issue Active

šŸ‡ÆšŸ‡“Jordan Rajab Natshah Jordan

I agree with your logic on this. It is better than my logic
Thanks, Hendrik, for filing the issue and the MR.

šŸ‡ÆšŸ‡“Jordan Rajab Natshah Jordan

Switched to use vardot/ckeditor5-anchor-drupal
Following any fixes or needed changes for the library.

Released vardot/ckeditor5-anchor-drupal 2.0.1
Remove usage of autoanchor by @lmoeni in #5

Released vardot/ckeditor5-anchor-drupal 1.0.2
Backport: Remove usage of autoanchor to the 1.0.x branch by @hosterholz in #11
šŸ‡ÆšŸ‡“Jordan Rajab Natshah Jordan

āœ… Released anchor_link 3.0.2 →

šŸ‡ÆšŸ‡“Jordan Rajab Natshah Jordan

Thanks, please, create an issue fork. and let us have an MR to merge

šŸ‡ÆšŸ‡“Jordan Rajab Natshah Jordan

Is that for CKEditor 4.
It should be fixed, you are right.
Please, file an new issue, we will follow with that for sure

Production build 0.71.5 2024