Jordan
Account created on 10 July 2011, almost 13 years ago
  • Volunteer contributions at Webship 
  • Technical Product Lead at Vardot 
#

Merge Requests

More

Recent comments

🇯🇴Jordan Rajab Natshah Jordan

Thanks, Abdulrahman, for suggesting and patching

1. Creating issue forks to be able to commit with --author .. I can not see your --author email ( which switched to MR by Drupal.org )

2. Suggesting a better name for the config values in the settings.
Somthing like

  • Change none_option_color to show_none_for_color or show_none_option_color
  • Change none_option_size to show_none_for_size or show_none_option_size

Welcoming any better readable config names

🇯🇴Jordan Rajab Natshah Jordan

Seems this issue was fixed in the 2.x branch.
Removing the use of the patch when using ~2

🇯🇴Jordan Rajab Natshah Jordan

Thank you.
Tested and merged
After the fix

Vartheme BS4 settings of affix ( or could be in the sub theme )

No navbar affix

With navbar affix

🇯🇴Jordan Rajab Natshah Jordan

Thanks, Emircan, for reporting and patching!

1. Better to change bootstrap_barrio_affix to

  • vartheme_bs4_affix
  • VARTHEME_BS4_SUBTHEME_affix

in once('bootstrap_barrio_affix', '[data-toggle="affix"]', context).forEach(function () {
not to have many data-once attributes with the same bootstrap_barrio_affix
2. Please, create MR to commit/merge with your --author email as Drupal is not showing the --author anymore

🇯🇴Jordan Rajab Natshah Jordan

I do feel as of that Recipes has Config Actions, Entity Actions, Method Actions as verbs
I suggest that they start with a verb, or keep the subject targeted first.

The setup/install type
setup-my-ai-recipe
setup-webreleases
init-drupal-demo1
init-drupal-demo2

Adding features type
add-my-ai-recipe-option1
add-my-ai-recipe-option2
add-products
add-projects

Updates - update/change/switch
drupal_update_1003
users_update_10012
fix-mismatched-config-for
reset-default-config-for
remove-non-existent-permissions

Env
change-on-dev
change-on-test
change-on-prod

.. somthing as the folloiwng could be easer to understand from the first time

recipes:
  - add-article-content-type
  - add-taxonomy-tags

or

recipes:
  - init-article-content-type
  - init-taxonomy-tags

Having the following as -- the module/entity name first then the bundle

recipes:
  - content_type_article
  - taxonomy_tags
Production build https://api.contrib.social 0.62.1