- Issue created by @RobBNL
- ๐ฏ๐ดJordan Rajab Natshah Jordan
When I disable the BigPipe module, the issue disappears.
- ๐ฌ๐งUnited Kingdom catch
I can't reproduce this with the standard profile (ckeditor5 and big_pipe installed).
Can you try the following:
1. See if you can reproduce it on a clean install of Drupal 10.4 with only core.
2. As @cilefen says check if you have any ckeditor plugin modules installed and if so let us know which ones.
The most likely cause of this is ๐ Logic error in Drupal's lazy load for asset aggregation Active interacting badly with a (usually incorrect) contrib library definition. So a third step would be checking contrib library definitions to see if they specify weight for any files.
- ๐ณ๐ฑNetherlands RobBNL
Hi,
Thanks for the responses. I don't have time the next few days to check this on a fresh install of 10.4.
What I can say is that for me also if I uninstall the bigpipe module I no longer have this problem and I can again use the editor.I do not have any extra CKeditor plugins installed on this site
- ๐ฏ๐ดJordan Rajab Natshah Jordan
๐ The attachBehaviors() for document is only called after Big Pipe chunks are processed Fixed
๐ Logic error in Drupal's lazy load for asset aggregation ActiveBig Pipe is attempting to attach behaviors too early, and itโs affecting the Tour module as well.
// Attach behaviors early, if possible. Drupal.attachBehaviors(document);
- Merge request !10722Issue #3496329: Fix not loading CKEditor 5 and Tour on existing content after Drupal 10.4 update โ (Open) created by Rajab Natshah
- ๐ฏ๐ดJordan Rajab Natshah Jordan
Having a look at the logic in drupal.init.js file
// Allow other JavaScript libraries to use $. if (window.jQuery) { jQuery.noConflict(); } // Class indicating that JS is enabled; used for styling purpose. document.documentElement.className += ' js'; // JavaScript should be made compatible with libraries other than jQuery by // wrapping it in an anonymous closure. (function (Drupal, drupalSettings) { /** * Calls callback when document ready. * * @param {function} callback * The function to be called on document ready. */ const domReady = (callback) => { const listener = () => { callback(); document.removeEventListener('DOMContentLoaded', listener); }; if (document.readyState !== 'loading') { setTimeout(callback, 0); } else { document.addEventListener('DOMContentLoaded', listener); } }; // Attach all behaviors. domReady(() => { Drupal.attachBehaviors(document, drupalSettings); }); })(Drupal, window.drupalSettings);
Defines a behavior to be run during attach and detach phases.
Attaches all registered behaviors to a page element.
in the drupal.js fileDrupal.attachBehaviors = function (context, settings) { context = context || document; settings = settings || drupalSettings; const behaviors = Drupal.behaviors; // Execute all of them. Object.keys(behaviors || {}).forEach((i) => { if (typeof behaviors[i].attach === 'function') { // Don't stop the execution of behaviors in case of an error. try { behaviors[i].attach(context, settings); } catch (e) { Drupal.throwError(e); } } }); };
- ๐ฏ๐ดJordan Rajab Natshah Jordan
Given that a Drupal 10 site was installed with the minimal profile ( not the standard profile )
And later on the BigPipe and CKEditor5, Tour modules were installed
Then the wight of the BigPipe library will follow it's module wight
And affect the CKEditor 5, Tour, Maybe other modules. - Merge request !10753Issue #3496329: Fix not loading CKEditor 5 and Tour with BigPipe enabled after Drupal 10.4 update โ (Open) created by Rajab Natshah
- ๐ฏ๐ดJordan Rajab Natshah Jordan
rajab natshah โ changed the visibility of the branch 3496329-fix-10-4-x to hidden.
- Merge request !10754Issue #3496329: Fix not loading CKEditor 5 and Tour with BigPipe enabled after Drupal 10.4 update โ (Open) created by Rajab Natshah
- ๐ฏ๐ดJordan Rajab Natshah Jordan
Attached a static
drupal-core--2024-12-31--3496329--mr-10753.patch
file for the10.4.x
To be used with the Composer Patches - ๐บ๐ธUnited States smustgrave
Possible to get a test case showing the issue.
- ๐ฏ๐ดJordan Rajab Natshah Jordan
Faced another issue when added the
header: true
to thedrupal/big_pipe
library.
The status message will not show up in the site. - ๐ฏ๐ดJordan Rajab Natshah Jordan
Switched to use a custom domReady in the BigPipe script to let work as Drupal init to Attach behaviors early, if possible without errors
- ๐ฏ๐ดJordan Rajab Natshah Jordan
Attached a static
drupal-core--2024-12-31--3496329--mr-10753.patch
file for the10.4.x
to this point from MR10753.
To be used with the Composer Patches - ๐ฏ๐ดJordan Rajab Natshah Jordan
Attached a static
drupal-core--2024-12-31--3496329--mr-10753.patch
file for the10.4.x
to this point from MR10753.
To be used with the Composer Patches - ๐ฏ๐ดJordan Rajab Natshah Jordan
Attached a static
drupal-core--2025-01-02--3496329-32--mr-10753.patch
file for the10.4.x
to this point from MR10753.
To be used with the Composer Patches - ๐จ๐ฟCzech Republic jaroslav ฤervenรฝ
It helped me with the problem
https://www.drupal.org/project/collapsible_dnd/issues/3497645 ๐ Stop work after update Drupal 10.4 Active - ๐ท๐บRussia mr.pomelov Russia, Chelyabinsk
Drupal 10.4.1. Patch #33 ๐ฌ CKEditor stops loading on existing content after Drupal update to 10.4 Active work for me
- Status changed to Needs work
6 months ago 9:38am 27 March 2025 - ๐ซ๐ทFrance ericdsd France
Patch #33 works perfectly on core 10.4.5, is there still a reason to to keep Needs work status?
- ๐ฌ๐งUnited Kingdom catch
header: true means that big pipe will load a large amount of render blocking javascript, is that absolutely necessary to the fix here?
Ideally would come with test coverage but it might not be possible to reproduce consistently in a test?
- ๐บ๐ธUnited States jstoller
I experienced this issue when using ACE Code Editor along with CKEditor5 on Drupal 11.2.2, and MR !10754 fixes it.
- ๐ฎ๐ณIndia arnabcse2013 Bangalore
Thank you @Rajab for the MR.
Infact in my opinion I agree with @catch to not use the "header: true" as that will use a huge amount of render for javascript. This way we are just forcing the script to load in the header just to satisfy(May be a temp solution).
FYI, the "collapsible_dnd" module is also impacted and it is not rendering the "draggable collapser" correctly.
https://www.drupal.org/project/collapsible_dnd/issues/3497645 ๐ Stop work after update Drupal 10.4 Active -> The above patch from @Rajab for D10.4.x fixes the issue but creates additional errors in big_pipe.js in console and also stops showing the drupal msgs (I will try to some screenshots here).I am working to find some solution and will update in both the places.
- ๐ฌ๐งUnited Kingdom catch
Changes always go into the development branch first.
Have also experienced this where Big Pipe is affecting the loading of libraries in Claro: ๐ Tabledrag missalignment Active