Hi do you plan to create a new release with this fix ?
#66 works like a charm thanks a lot !
Uplodaed patch version of MR20 for convenience.
+1 for RTBC
Thank a lot, i confirm MR6 patch applies nicely on 2.0.1, uploaded it in patch format for convenience.
@Matthieuscarset, je me dis que ça mériterait même de générer ça avec une variable css
MR526 Works like charm on 3.0-rc14 thanks a lot @mrshowerman
+1 for RTBC
Uploaded MR562 as a patch for convenience purpose.
Uploading patch from MR 6796 #116 for core 10.3.5
Tested MR from #116 over core 10.3.5 on views embedded with viewsreference + viewsreference_filter + better_exposed_filter with success.
Thanks a lot !
Hi, i've also just experienced something similar again, not with a module installation but with an update, most probably Upgrading drupal/core (10.2.6 => 10.3.6)
.
I have a site with English as default and french enabled, after running updb configs from few views and content types got their localized config strings replaced by french ones.
It could be related with
views views_data_argument_plugin_id post-update Post update configured views for entity reference argument plugin IDs.
node set_node_type_description_and_help_to_null post-update Converts empty `description` and `help` in content types to NULL
Concerning the content types it's the description text that is repalced by its french translation.
@mrshowerman, i've tested your changes with success, it works like a charm, thank you for your fast move.
Also tested this patch over dev version and core 10.3.5 with success.
Glad to hear it's RTBC, let's get it merged so that we can go back to our lives :p
@jofitz
patch #7 has some extra modifications, that could probably be added to your MR.
Patch #7 works for me too thanks a lot
Hi i tested the patch against ctools 3.14.0
and views pages returns an error
Le site Web a rencontré une erreur inattendue. Veuillez essayer de nouveau plus tard.
Error: Call to a member function getBaseFieldDefinitions() on null in Drupal\ctools\Plugin\Block\EntityView->build() (line 138 of modules/contrib/ctools/src/Plugin/Block/EntityView.php).
Drupal\block\BlockViewBuilder::preRender(Array)
call_user_func_array(Array, Array) (Line: 111)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 797)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 386)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 458)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 204)
Drupal\Core\Render\Renderer->render(Array) (Line: 474)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 153)
__TwigTemplate_39d1120b7c348d10f138a3908dc12f89->doDisplay(Array, Array) (Line: 394)
Twig\Template->displayWithErrorHandling(Array, Array) (Line: 367)
Twig\Template->display(Array) (Line: 379)
Twig\Template->render(Array, Array) (Line: 40)
Twig\TemplateWrapper->render(Array) (Line: 53)
twig_render_template('themes/custom/frontend_b5/templates/layout/page.html.twig', Array) (Line: 372)
Drupal\Core\Theme\ThemeManager->render('page', Array) (Line: 445)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 204)
Drupal\Core\Render\Renderer->render(Array) (Line: 474)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 139)
__TwigTemplate_5bb4cd612af95b2749578fc18ced131c->doDisplay(Array, Array) (Line: 394)
Twig\Template->displayWithErrorHandling(Array, Array) (Line: 367)
Twig\Template->display(Array) (Line: 379)
Twig\Template->render(Array, Array) (Line: 40)
Twig\TemplateWrapper->render(Array) (Line: 53)
twig_render_template('themes/custom/frontend_b5/templates/layout/html.html.twig', Array) (Line: 372)
Drupal\Core\Theme\ThemeManager->render('html', Array) (Line: 445)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 204)
Drupal\Core\Render\Renderer->render(Array) (Line: 158)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 592)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 159)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 186)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 50)
Drupal\ban\BanMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
The patch work like charm over 1.2.1.
I agree with mrshowerman, as we really need to reduce the scope of the issue and the pain points for review if we want to have this issue fixed.
Once released we'll then be able to address optimizations and will be happy to test any MR from a new issue based on merged code.
I think Mrshowerman is probably right targetting > td:nth-child(3) will necessarily generate side effects either now or later.
Don't you think we could juste remove this part for now in order to have the main part of the fix committed, else it will never get into any release and it looks like a new release is close to arrive.
I guess we should also mention this doc https://cdn.ckeditor.com/ to better explain how to get the needed assets locally (as it is not crystal clear IMHO).
JavaScript URL Structure
The JavaScript URL structure for CKEditor 5 is as follows:
Open-source features: https://cdn.ckeditor.com/ckeditor5//ckeditor5.js
Premium features: https://cdn.ckeditor.com/ckeditor5-premium-features//ckeditor5-premium-features.jsCSS URL Structure
The CSS URL structure for CKEditor 5 is as follows:
Open-source features: https://cdn.ckeditor.com/ckeditor5//ckeditor5.css
Premium features: https://cdn.ckeditor.com/ckeditor5-premium-features//ckeditor5-premium-features.cssTranslations URL Structure
Open-source features: https://cdn.ckeditor.com/ckeditor5//translations/.js
Premium features: https://cdn.ckeditor.com/ckeditor5-premium-features//translations/.jsDon’t Know How To Start?
Try the CKEditor 5 Builder
Patch #31 Works on 10.2.7 too
+1 for RTBC
Hi @MrDaleSmith
i get your point but i really suggest that you create a new issue for that as it is not really a bug but more a a design choice to optimize. The important here is to make that long standing issue complete so that we can work on optimizing the rest upon a working base.
I see that your capture is a bit an extreme case with 6 nesting levels, but i agree that we shall optimize it but it deserves its own issue IMHO.
Note that patch from latest MR also applies fine to Gin 1.0-rc11.
Both patch #51 and MR 782 seem to only partially fix the issue, it allowed to fetch 83 avor 104 projects for updates instead of 8, but few remained unchecked.
after running drush php:eval "\Drupal::keyValue('update_fetch_task')->deleteAll();"
thet all 104 projects were fetched.
I confirm the issue is still present on 8.x-1.3,
MR9 fixes the issue.
Switched to RTBC
Hi i experienced the same issue.
I see that the point of @hmendes at #11 was ignored but i think his point is worth being discussed. And could possibly be worth adding an option to choose one behavior or another instead of simply adopting the current behavior that lets users with expired password fully use the site when using password reset (without really changing their pass).
ericdsd → created an issue.
ericdsd → created an issue.
@Joachim did you apply the patch as the commit is not in a release yet ?
It would indeed be a nice feature, of course there would be quite a lot of technical challenges like language support ...
i see there is a quite similar request here invoving more people.
https://www.drupal.org/project/layout_paragraphs/issues/3311074
✨
Copy paragraphs to Clipboard and paste them in other places
Active
I've tested MR 339 it works fine if i add
.paragraphs-tabs-wrapper .field-multiple-table > tbody > .draggable > td + td {
width: 95% !important;
}
Hi i do agree with Anybody, should we reopen this issue or create a new one to backport this to 5.0.
Both MR and patch works fine, took me at least one day to figure out what was the cause as the server always fall before we can know what module was responsible, thanks a lot for the patch.
It would be awesome to have a release for that, but i'm not sure the module is still supported, maybe it should be flagged as seeking co-maintainer.
Tested patch #2 it works like a charm
+1 for RTBC
Tested patch #2 it works like a charm
+1 for RTBC
Hi have the same output on drush cron after search_api_solr update
Tested MR, it works like a charm. +1 for RTBC
@K L Dickenson, i guess you mean
.paragraphs-tabs-wrapper .field-multiple-table > tbody > .draggable > td + td {
width: unset;
Hi justcaldwell that's of course what i'll also do, but it's clearly easier for editor to see the layout of the button style they use. That's why having a way to target option to apply custom style would be very nice to have.
Hi @Cilefen as far as i know, admin Toolbar only provides cache rebuild link if you have access to it and doesn't provide any specific permission or settings to bypass it.
Note on the project i most need this functionality admin toolbar is installed. My concern is that i don't want to grant Administer site configuration permission tu some users that might need to access to cache rebuild functionnality. Let me know if i missed something in admin Toolbar though.
Don't you think this issue is worth being reopened, as it's a real need for some people and it's neither complicated to fix nor bringing backward compatibility issue.
https://www.drupal.org/project/rebuild_cache_access →
module is helping but forces to have a big button in the toolbar that doesn't fit for everybody. If i'm not the only one to think this let me know.
@Ravi Kant, i actually suggest to add data-attributes to the back office widget options to allow making it more "wysiwyg", not to change the markup genrated in the frontend by the module.
I had the same issue with en entity reference revision inside a paragraph bundle. I tries the patch against bith 1.10 and 1.11 with no luck (event if the patch applied well).
I found the workaround for my case whitch to recreate my field as an Entity reference instead of an Entity reference revision (in my case i have no need form term's revisions).
Hi is there any chance to have a d10 release before the module gets completly abandonned ? I'd be happy to help testing.
Hi i'm reopening this issue as i axperience the same thing on core 10.2.1.
English is default but has en path prefix
French has no prefix and i used "Selected language" as last language selector.
My admininistration language is set to french and "Account administration pages" is enabled as first language selector.
(Note i have the same behaviour with Account administration pages disabled)
I create an english vocabulary and when i add an existing field (which is in english) from admin/structure/taxonomy/manage/theme/overview, then i cannot translate this field.
Les objets de configuration ont un code de langue différent, ils ne peuvent donc pas être traduits :
field.field.taxonomy_term.theme.field_class : fr
field.storage.taxonomy_term.field_class : en
If i do the same from en/admin/structure/taxonomy/manage/theme/overview
then my field has consistent langcodes in config and is translatable.
Workaround : if i set my user's Administration page to english then it forces "en" prefix on field creation page and allows making sure the field is created with consistent langcodes (en).
I have the same issue event without asset path.
Issue was indeed caused by previous patch not properly removed. Closing
ericdsd → created an issue.
I'll test it asap
Hi it would be really nice to have this MR merged into a new release to avoid relying on lenient plugin.
I have the same problem with core 10.1.6 as soon as "Content language" is enalbled in Content language selection (event if "url" is first). The Swithcer always generate the link by adding language_content_entity query string instend of using the right path prefix and url alias.
Hi now that it's RTBC, i think it would be nice to have a new release for that at least a beta, to avoid having to use lenient plugin.
It's already in pending layout proposal, closing the issue.
I have nearly the same issue, i only see one role (editor) on this page when i should see 3 (administrator, manager, editor)
Hi i also think node list are not meant to be stored in config.
If it's useful to some users for migration, then we might eventually allow user to choose where to store it in module's settings.
Don't you think we might make this issue move forward instead of keeping using it with a patch forever ?
I'll be happy to help testing.
Even if i've been waiting for real webp support for a long time, I sadly think doing so without fixing at least
Add fallback format support to responsive images
✨
Add fallback format support to responsive images
Needs work
is not a really a news, as lot of old mac users cannot update their os (eg. lots of artists still use macbook pro 2012, not mentioning poor people). It means that doing this we'll collectively enforce Apples programmed obsolescence by providing massivelly degraded web experience for people not able to change their computer every 6 years as Apple now forces people to to). In a more general way we should provide a more robust out of the box fallback methods to ease adopting new images and video formats like avif.
Do you think there is a chance to see fallback issue embedded in 10.2 too ?
Thanks a lot for the workaround in description
Great to see this issue is moving, i'll be glad to help testing once needed.
Hi IMHO clearing cache would deserve its own permission and even if a contrib module does it, it seems a bit overkill to require a module for that.
It's indeed a quite common request, and i don't see any technical drawback to create a dedicated permission, we could easilly even manage the BC change with an update hook giving this new permission to every user that has administer site configuration permission.
Concerning creating a permission per cache type, i'm not sure it is really usefull though and is more a edge case.
Made some extra test on gitpod, initial parse from recreate.sh import ins approx. 5mins,
but after that a regular
drush queue:run l10n_server_parser
that is not limited to a very shortlist of release takes forever.
After 8 min running here is where we stand:
gitpod@localizedrupalorg-web:/var/www/html$ drush queue:run l10n_server_parser
[notice] Retrieving drupal-9.5.0-beta2.tar.gz for parsing.
[warning] File /tmp/drupal-9.5.0-beta2.tar.gz already exists, deleting.
[notice] drupal-9.5.0-beta2.tar.gz (7828 files, 10553 strings) scanned.
[notice] Retrieving drupal-10.0.0-beta2.tar.gz for parsing.
[notice] drupal-10.0.0-beta2.tar.gz (6783 files, 10075 strings) scanned.
[notice] Retrieving drupal-9.3.22.tar.gz for parsing.
[notice] drupal-9.3.22.tar.gz (7774 files, 10462 strings) scanned.
[notice] Retrieving drupal-9.4.6.tar.gz for parsing.
I was at the speakers registration
Hi are there any blocking issue preventing merging this and making a new release ?
Hi it looks like this issue
https://www.drupal.org/project/drupal/issues/2920285
🐛
Update module can get 'stuck' with 'no releases available'
Needs work
if it's the case the drush command will fix it
HI if it's only a matter of depencies that differ for 10.0 to 10.1, wouldn't it be a solution to make a branch 2.x for 10.0 and 3.x for 10.1 with the same underlying code but not the same requirements ?
Hi is there any progress on this, i'd be happy to help testing as a non dev.
I agree with @ressa
composer create-project drupal/recommended-project:^10
should be removed, see composer output :
/var/www/html$ composer require 'drupal/recommended-project:^10' --update-with-dependencies --no-update
Info from https://repo.packagist.org: #StandWithUkraine
Root package 'drupal/recommended-project' cannot require itself in its composer.json
Note that when updating from 6.0.1 to 6.0.2
migrate:import doesn't implement --sync option anymore
i had to update from drush 10.6.2 to drush 11.6.0 to be able to run migrations with --sync
Hence i think we should at least include drush 11 requirement.
Let me know if you prefer to have a dedicated issue for that.
Thanks @deranga, for the workarround 8
Patch #2 solved the issue over 2.0.7 as i couldn't apply patch from #15 from composer
That was fast ! Thanks
ericdsd → created an issue.
Hi xmacinfo, note that renaming a php file to txt, makes it readable which is imho a lot worse.
some solutions could be :
- scaffolding in a dedicated directory that would remain writable eg. sites/examples/ as suggested in #111 (proper name might be discussed)
- not scaffolding it (eventually add a composer command to copy it when needed, or displaying a note telling where core example assets can be copied from)
but it's possible that it's not an issue anymore, i'll try to check again with a newer version
It occured on french site so it's probably related to some French translation