Add dependency to bcmath php extension because the php-analytics-data library does not specify that properly

Created on 17 August 2023, over 1 year ago

Problem/Motivation

Google analytics counter 4.x depends on Google\Protobuf which only suggest dependency to bcmath php-extention.

Steps to reproduce

On a server that doesn't have extbcmath installed
Install and enable google analytics counter
Setup api authentification
Run google_analytics_counter cron job
(can also be done using drush ev 'google_analytics_counter_cron()')

This will lead to :
[error] Error: Call to undefined function Google\Protobuf\Internal\bccomp() in Google\Protobuf\Internal\Message->convertJsonValueToProtoValue() (line 961 of /var/www/public_html/vendor/google/protobuf/src/Google/Protobuf/Internal/Message.php)

Proposed resolution

Google analytics counter indeed needs bcmath to run so i suggest that we had ext bcmath as as a requirement for this module.
Mention that dependency on module's page

πŸ› Bug report
Status

Fixed

Version

4.0

Component

Code

Created by

πŸ‡«πŸ‡·France ericdsd France

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024