Fix Required fields to really not be required

Patch #29 doesn't work with Drupal Commerce. It's still asking for variations SKU and Price.

@mjgruta, go into the product types configurations and check the "Allow more than one variation" checkbox. That will move the SKU and Variant Title off of the primary product entity form and allow you to perform a bulk edit.

There's also a workaround you can use in a pinch that works if any field doesn't play well with the patch.

Select the SKU and Price fields and enter a value in for each field. Now uncheck those fields as fields you want to edit. Whatever you just entered will not be applied. They'll remain filled in so you'll be able to submit the form, but the values will be ignored.

HI,

Patch #29 allows me to at least post the form but its still giving me an issue with a specific required field.

The field I want to change (Company) and the field which tosses the error (Review Author) are both entity reference fields. (Note: I do no want to change the Review Author field.). I have other required fields which are not throwing errors.

Thanks,
Eric

@aitala: From your screenshot, one could assume that you ticked "Review Author" before submitting the form. Even if I don't draw that conclusion, I would like to point out that the tick must of course not be set for required fields whose values you don't want to change.

HI,

I did not tick the 'Review Author' box before I submitted the form.

I ticked it which revealed the "Review Author (value 1) field required." notice otherwise all you see is the '1 error has been found: Review Author (value 1)' notice with no explanation. The only value I am trying to change is the Company field.

Eric

Patch #30 is not working for me too. Have a simple content type with required image field, but trying to bulk update a boolean field, getting error "Image field is required.".

Patch #30 did not solve the problem, it allows the form to be sent but title and URL are still required. Any updates on this one?

I updated the patch to work for nested form elements, change the required values to false, and remove validateRequired callbacks.
Please review the new patch.

Patch #45 is working in my case.

Patch #45 is working in my case.

Patch #45 isn't working for me when Address field has some required fields.

If I make them optional, then the updates for other fields go through, even when the Alt field of an image field is kept as Required.

Doesnt work with nested paragraph required fields.

Patch #45 doesn't work for me. It gives me this error:

TypeError: array_filter(): Argument #1 ($array) must be of type array, null given in array_filter() (line 436 of modules/contrib/views_bulk_edit/src/Form/BulkEditFormTrait.php).

The problem that triggers the error is that the values are no longer in the $form_state->getValues() but I do find them in the input.

$field_data = $form_state->getValue([$entity_type_id, $bundle]);

So if I replace this line with this, it works but I don't think this is a good solution.

$field_data = $form_state->getValue([$entity_type_id, $bundle]);
        if (!isset($field_data['_field_selector'])) {
          $input_data = $form_state->getUserInput();
          $field_data = $input_data[$entity_type_id][$bundle];
        }

For me patch #29 works, except for some entity reference fields that are still required. I added some code to the patch to fix my use-case.

Provided an update which uses the States API to switch the #required fields off/on based on whether the field was ticked or not. And recursively disables the #required and #access to fields which the user is uninterested in editing.

It should also work with various other field widgets such as Paragraphs or Media Library.

I believe the initial novalidate approach isn't advisable since you lose all client-side validations.

Addressed a flaw in logic where it's possible to accidentally flag a field as "required" as long as it had a #element_validate or #validate property.

Addressed an oversight in the #56 patch.

Thank you this is working with me

Patch #57 worked for me

I was getting two error messages like "An invalid form control with name ... is not focusable". The patch in #57 fixes one of them. The other message remains, causing the VBO action to fail. The error message that remains is about a required field that is part of a paragraph.

Agree with @Liam mortland patch #57 works for me too for the required field focusabled.
Best regards and thanks.

Patch #57 is working for me

Since it was tested by several people, I've moved it to reviewed and tested.
Best

Dear community, I'm going to add a piece of code in order to cover the fields provided by inline entity form.

Best regards

Hi all, I added the code, this can be reviewed.
Many thanks in advance.

#66 solved the issue in my case.

#66 works like a charm thanks a lot !
Uplodaed patch version of MR20 for convenience.
+1 for RTBC

I had been using #57, but it wasn't working anymore, so I checked #68, and it works.
Version 8.x-2.9