I added small improvement. I changed:
$form['check']['timeout']
to:
$form['check']['linkchecker_check_timeout']
@sakthi_dev I'll try to produce 11.x version in free minute... but can't promise when exactly.
Ups... I forgot about schema updates. So this is #49 + schema fixes.
#50 is #49 extended with End date optional #153 ( https://www.drupal.org/project/drupal/issues/2794481#comment-14839868 ✨ Allow end date to be optional Needs work )
Improved patch which covers:
- adds all_day column in DB for datetime range fields. Set it as disabled for all existing data with datetime type
- allow to enable all day dates for datetime type & set default value for it in field settings
- widget to set all day, making sure that date is stored in UTC when all day is selected (in general timezone is ignored when all day event is set)
- GraphQL - share allDay property for datetime range fields
- formatter - for now only supported inn default formatter. You can specify date format for all day and non all day dates
- js - when you'll select all day, time is set to 00:00:00 for start & end dates
Small improvement on admin settings form added.
gugalamaciek → created an issue. See original summary → .
joseph.olstad I'm glad I could help :)
FYI #11 looks good, I've added it to our site :)
@Joseph Fine for me :) That's why it's on review ;) I checked briefly, and I think you should change linkchecker.schema.yml as well.
As I see you've changed setting:
check.skip_unpublished
to:
search_published_contents_only
But when I check linkchecker.schema.yml, I have a feeling, that this property should be under check. So it should be rather check.search_published_contents_only. Also, if you want this change, I suggest to rename everywhere (e.g. form property as well). It will be less confusion for developers reading this code ;)
Ups... wrong patch. Don't use #2 and #3.
This patch catches TransferException and assigns 404 status code to errors "could not resolve host".
This patch catches TransferException and assigns 404 status code to errors "could not resolve host".
This patch catches TransferException and assigns 404 status code to errors "could not resolve host".
gugalamaciek → created an issue.
Proposed patch adds feature described in point 1. and implements performance improvements described in 2. - 4.
gugalamaciek → created an issue.
gugalamaciek → created an issue.
gugalamaciek → created an issue.
Consider scenario:
1. Open node page using shs. Terms are cached based on interface langauge (e.g. langA)
2. Open translations form. Data is get based on interface language (in most cases the same as in point 1.). So you create translation to langB, but you see term labels in langA.
What can be done is to change caching strategy from interface to content. So change this:
$this->contexts = ['languages:language_interface', 'user.roles'];
into this:
$this->contexts = array_merge(['languages:' . LanguageInterface::TYPE_CONTENT, 'user.roles']);
Terms are content, not interface. They should take into account content langauge, not interface langauge.
Proposed patch provides this change.
gugalamaciek → created an issue.
Small improvement for #2.
Patch for proposed resolution:
gugalamaciek → created an issue.
gugalamaciek → created an issue.
Patch for all work made in this issue.
Patch for all work made in this issue.
gugalamaciek → created an issue. See original summary → .