🇲🇾Malaysia @ckng

The real issue is Gutenberg editor is loaded on the frontend.

ckng → made their first commit to this issue’s fork.

Patch #7 works great.

Rebased and rerolled the patch.

Updated patch. Passed onInit, onAccept, onDecline to services' config settings.

Updated status, as JS logics are missing.

Tested MR!79 working. Generated the patch file.

See attached patch for 2.2.x.

Not working for us D10.4.0. Tested MR4630, patch #189.

We have
* Languages EN, ES, ZH-HANS, DE and FR.
* Content is translatable, but URL Alias field is not translatable.
* Manually set the alias.

Testing steps:
* Create a new EN content (source).
* Uncheck "Generate automatic URL alias".
* Put a manual alias, Save.
* DB showing alias langcode as "en".

* Create a translation, e.g. ES.
* Didn't touch alias field, value same as EN.
* Save.
* Alias showing as /es/node/NID.
* DB showing no alias is added, only has the "en" entry.

Same observation as #27 and patch #27 is working for us.

Patch #13 works for us.
Patch #15 using deprecated API and breaks the /admin/config/openai/chatgpt page.

Expanded the patch to cover other special characters: "&", "+", ";", ",". Since some of these are usually used with extra spaces e.g. "First & Second", "First; Second", "First+Second", are supported.

Incorrect patch, updated.

Rerolled with a fix as Claro base theme is `false`.

Testes patch #24, not working for us.
Desktop > 1200px, no touch, Save button and all on the right hand side are covered.

Rerolled for 2.3.x.

Attributes work is in progress in 🐛 Inconsistent `attributes` handling Active , however, it will have backward compatibility issue in some cases.

spaceless observation is invalid. The templates are using the updated spaceless filter in Radix, ie.

{% apply spaceless %}
...
{% endapply %}

But its usage is not comprehensive.

Rerolled, removed unrelated codes as mentioned in #9.

- restored image functionality when passing src directly

Backward incompatible tracking for subtheme:
- templates/field/image.html.twig

These are initial fixes. Note that haven't gone through all the components yet.
Unsure items, not used or will break backward compatibility, ie. subtheme needs to be updated:

• comment
• field
• field-comment
• fieldset
• nav
• node

ckng → created an issue.

Ran into the issue again. Rerolled and rebased to 2.1.x. Generated patch.

Rerolled and created MR.

Sorry, didn't mean to change that.
Tested 2.1.0, so far unable to reproduce the issue.

Incorrect patch file. Updated.

Rerolled.

Tested working, created patch file.

Rerolled and tested working for checkboxes, not working for select. Updated the code, but only partial fix, as multiple select only work for a single selection?

ckng → made their first commit to this issue’s fork.

Rebased the MR and rerolled the patch file.

Created patch file from MR 96.

Attached patch for 8.x-1.x version.

I'm maintaining a copy with a11y fixes at https://github.com/ckng/chosen. You can download the released zip.

Instruction for Drupal: https://github.com/ckng/chosen?tab=readme-ov-file#to-replace-drupal-chos...
Reproduced here:

Extract the released zip into THEMES/js/chosen, for example, where THEME is your theme name.

In your THEME.libraries.yml:

chosen:
  remote: https://github.com/ckng/chosen
  version: 2.2.1
  license:
    name: MIT
    url: https://github.com/ckng/chosen/blob/master/LICENSE.md
    gpl-compatible: true
  js:
    js/chosen/chosen.jquery.min.js: { minified: true }
  dependencies:
    - core/jquery

chosen.css:
  version: 2.2.1
  css:
    component:
      js/chosen/chosen.css: {}

In your THEME.info.yml, override fully the default from chosen_lib.

libraries-override:
chosen_lib/chosen: THEME/chosen
chosen_lib/chosen.css: THEME/chosen.css

Same patch from #12 but for 3.0.x.

We're also using facet link in menu, which we would like to be indexed. There is possibility some facets need to be excluded from noindex, or nofollow, or other settings.

So instead of applying noindex blanketly and depending on the 'f' parameters, have taken another approach by checking the active filter(s). Also added configuration to the block setting to allow robots meta selection. Default to 'all', ie. do nothing, which is excluded in the final robots, as we don't want to mix 'all' with 'noindex' or the other options.

This should work with facets pretty path, not tested though.

Added screenshot.

ckng → created an issue.

ckng → changed the visibility of the branch 3471287-tiny-media-library to hidden.

Updated patch with updated source and build.

ckng → made their first commit to this issue’s fork.

Looks like there shouldn't be any negative value here, changed to zero will allow the DB update.

Good question, let me run that through client.

Encounter same issue in DB update.
1.0.1 - no issues.
1.0.2 - DB update error.

$ composer update drupal/commerce_product_limits -W
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
  - Upgrading drupal/commerce_product_limits (1.0.1 => 1.0.2)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Downloading drupal/commerce_product_limits (1.0.2)
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Upgrading drupal/commerce_product_limits (1.0.1 => 1.0.2): Extracting archive
Generating optimized autoload files
53 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
Scaffolding files for pantheon-systems/drupal-integrations:
  - Skip [web-root]/sites/default/settings.php because it already exists and overwrite is false.
> DrupalProject\composer\ScriptHandler::createRequiredFiles
No security vulnerability advisories found.

$ drush updb -y                                    
 ------------------------- ----------- --------------- ------------------------------------ 
  Module                    Update ID   Type            Description                         
 ------------------------- ----------- --------------- ------------------------------------ 
  commerce_product_limits   9001        hook_update_n   9001 - Implements hook_update_N().  
 ------------------------- ----------- --------------- ------------------------------------ 


 // Do you wish to run the specified pending updates?: yes.                                                             

>  [notice] Update started: commerce_product_limits_update_9001
>  [error]  SQLSTATE[22003]: Numeric value out of range: 1264 Out of range value for column 'maximum_order_quantity_value' at row 5: ALTER TABLE commerce_product_variation__a7288e9c31 MODIFY maximum_order_quantity_value INT(10) UNSIGNED NOT NULL; Array
> (
> )
>  
>  [error]  Update failed: commerce_product_limits_update_9001 
 [error]  Update aborted by: commerce_product_limits_update_9001 
 [error]  Finished performing updates. 
Failed to execute command drush updb -y: exit status 1

The DB table table

maximum_order_quantity_value	tinyint(4)

There are negative values inside the maximum_order_quantity_value column. So UNSIGNED is causing the problem.

Just ran into exactly same issue. Tested patch #4, working for us.

- Not every site utilizes the Layout Builder, too.
- Looks like it is already using libraries-extend, and only override/redefine the specific behavior, or function.
- Moving to base theme would ease theme maintenance greatly, thanks.

The current implementation of core library JavaScript overrides within the Radix sub-theme introduces several challenges:

Low usage: Unless Bootstrap is used as admin theme or component such as modal is used in the frontend, these JS overrides are not needed at all.
Tight Coupling: The sub-theme becomes overly coupled to specific JavaScript libraries and their implementations, limiting flexibility and maintainability.
Subtheme Complexity: increased sub-theme complexity and making updates to the sub-theme potentially risky, hard to maintain.
Dependency Issues: Changes in the core libraries could break the overrides, leading to unexpected behavior and requiring constant maintenance.

To address these issues, I propose
- Decoupling the core library overrides from the sub-theme, move them to the base theme and making them optional. - OR - Decoupling it to a module, making them optional, and can be enabled or disabled as needed.
- Extend Libraries Rather Than Override: Prioritize extending core library functionality through inheritance or composition over direct overrides. Since what altered are mostly the markup, we only need to extend the behavior, prototype or function. Making it simpler to maintain and reduce conflict with changes from core.
- Provide clear documentation on how to use the override module and how to extend core libraries effectively. This will help developers understand the available options and make informed decisions.

Updated patch against 2.1.x.

ckng → made their first commit to this issue’s fork.

I believe this is a duplicate of ✨ Responsive image format for media Needs work . Use the patch in ✨ Responsive image format for media Needs work to achieve this.

First time using the new Navigation, great works here. I think the main UX feedback is the Create content area is it is rather confusing.

Here are some suggestions for Create content improvement

• Grouping content by type: This is a fantastic way to reduce clutter and make it easier for users to find what they need. By grouping similar entity types together (e.g., Content type, Media, User, Other), users can quickly scan the menu and identify the right option. This also helps address the potential name clashing, for example a "Video" content type and media type, as options within a group are less likely to have conflicting names.
• Turning off items: Providing the ability to disable unused features is a great way to personalize the experience. Users can choose to see only the create content types they use regularly, further simplifying the menu and reducing decision fatigue. For example, disabling "Media" if they are entered via content creation.
• Adding items: Offering options to extend the menu with additional items is powerful. This caters to users with specific needs. They can leverage functionalities from contributed modules or custom modules. This flexibility allows the menu to adapt to different workflows and user requirements.

doxigo, the codes changes for `page_header_container_classes` and `page_content_container_classes` are due to setting `page_header_container_type: false` or ``page_header_container_type: ''` were not working.

In the page-content.component.yml:

  page_header_container_type:
      type: ['string', 'boolean']
      title: Container
      description: container type
      default: ''
      enum:
        - false
        - ''
        - sm
        - md
        - lg
        - xl
        - xxl
        - fluid

Since we're supporting `false`, `''`, we're unable to use the `page_header_container_type|default` nor `page_header_container_type is empty` checks, as `null`, `false`, `''` are different. Hence the verbose check on `null` first then `is empty` to cover `false` and `''`. The patch fixes all 3 cases.

- Removed classes from page-content.twig, moved to page.twig as properties.
- Fixed 'container' property checking. Was not working for `false` and `''` cases, although specified in the as part of the `enum`.

ckng → created an issue.

Adopting the fix from #3228330-31: Bootstrap conflicts with Drupal core "placeholder" class → .

ckng → made their first commit to this issue’s fork.

ckng → created an issue.

Hi donquixote, there is no need to run npm inside the DDEV container when doing the build and compiling SCSS, so making nodejs version inside DDEV irrelevant in this case. Easiest is to do it directly under the local theme folder. The nvm already enforced the version on the user end. The nvm will need to be installed inside container if you prefer to do it there. The steps for both local folder and inside container are the same.

If you already install the nodejs via nvm, on the local theme folder, no DDEV command or environment involved.

$ cd web/themes/custom/ar_radix/
$ nvm use
$ npm install
$ npm run watch
$ npm run production

If you haven't install nodejs via nvm:
The same can be done inside the DDEV (or any docker-based) container.

// On local, you may may have run this, but you might have forgotten. 
$ nvm install lts/iron

// Or for container from local.
$ ddev nvm install lts/iron

// Or inside container.
$ ddev ssh
$ nvm install lts/iron

// Running build inside container.
$ ddev ssh
$ cd web/themes/custom/ar_radix/
$ nvm use
$ npm install
$ npm run watch
$ npm run production

Re: .nvmrc
Yes, correct. "lts/iron" means it will use the latest stable LTS version of v20.x.

Hope that helps.

In 2.x, the purchasable item commerce_product_variation is loading the entity with ['variation_id', 'sku']:

    $prepared_data['product_variation'] = $this->loadEntityValue(
      $data['order_item']['product_variation_entity'],
      'commerce_product_variation',
      ['variation_id', 'sku']
    );

But in 3.x, ['uuid', 'variation_id'] are passed. 'sku' is missing leading to error and unable to load the entity, as the $value queried in CommerceWebformOrderHandler->loadEntityValue() is the 'sku' value. But the source of the issue is the 'sku' key is missing from commerce_product_variation entity keys. Maybe we need a special handling here?

Facing the same issue when upgrading from 2.0.0-beta2 (core D9) to 3.0.0-beta10 (core D10), this should be the same as the current dev copy.

Patch in #17 not working for me.
atcDateStart and atcDateEnd are always using the `use_raw_value`. Updated patch to correct the logic checking.

ckng → made their first commit to this issue’s fork.

Updated from 4.1.4 => 4.1.8, visit /admin/config/search/simplesitemap/entities and the error message is thrown.

TypeError: Drupal\simple_sitemap\Plugin\simple_sitemap\UrlGenerator\EntityUrlGeneratorBase::__construct(): Argument #9 ($config_factory) must be of type Drupal\simple_sitemap\Plugin\simple_sitemap\UrlGenerator\ConfigFactoryInterface, Drupal\Core\Config\ConfigFactory given, called in /var/www/html/web/modules/contrib/simple_sitemap/src/Plugin/simple_sitemap/UrlGenerator/CustomUrlGenerator.php on line 92 in Drupal\simple_sitemap\Plugin\simple_sitemap\UrlGenerator\EntityUrlGeneratorBase->__construct() (line 105 of /var/www/html/web/modules/contrib/simple_sitemap/src/Plugin/simple_sitemap/UrlGenerator/EntityUrlGeneratorBase.php).

ckng → created an issue.

Good example if you want full control over the CKEditor styling.
However, a simpler way would be to just point `ckeditor5-stylesheets` to the theme generated `build/css/main.style.css`. So CKEditor style will follow theme look and feel.

Previous patch causes non-ajax loaded tabs to be bound twice.

@doxigo, it won't force the latest version, but the related major LTS version on the local that fulfill the requirement. In this case, user are not forced to use a specific version, as long as it is the same LTS major version.

@doxigo, instead of using a fixed version number in the `.nvmrc`, we want to use `lts/hydrogen` for v18.* or `lts/gallium` for v16.* instead.

Adding Drupal.behaviors.a11yParagraphTabs so ajax content will be triggered. See attached patch.

Patch #2 tested working.

With patch #103, works after cleared cache. However, issue reappears after some time. Caching issue?

Tested patch #35, working well for utm redirect loop issue.

Patch #8 tested working. Corrected the version.

Patch #30 is not working for me too. Have a simple content type with required image field, but trying to bulk update a boolean field, getting error "Image field is required.".

ckng → created an issue.

Patch #3 tested working.

Tested patch #55, works well.

Agreed this is an "extension" to what the theme currently support. Only worth as a documentation.

As for wildcard support in Laravel Mix, this is still not supported.
See https://github.com/laravel-mix/laravel-mix/issues/3300, https://github.com/laravel-mix/laravel-mix/issues/982.

A workaround is proposed https://github.com/laravel-mix/laravel-mix/issues/982#issuecomment-45485..., reproduced here

var fs = require('fs');
var path = require('path');
var files = fs.readdirSync('./resources/sass/pages');

for (var i=0; i<files.length; i++) {
  if(path.extname(files[i]) == '.scss') {
    mix.sass('resources/sass/pages/' + files[i], 'public/css/pages');
  }
}

Sure, see attached yml.

ckng → created an issue.

Running into site performance issue on saving nested paragraphs. With this patch and 🐛 Appending/removing a field item to a field item list doesn't notify the parent of the change Needs work , the same edit process dropped from 72,257ms to 12,182ms.

Per #8, reverted string changes.