🇲🇾Malaysia @ckng

I believe this is a duplicate of ✨ Responsive image format for media Needs work . Use the patch in ✨ Responsive image format for media Needs work to achieve this.

First time using the new Navigation, great works here. I think the main UX feedback is the Create content area is it is rather confusing.

Here are some suggestions for Create content improvement

• Grouping content by type: This is a fantastic way to reduce clutter and make it easier for users to find what they need. By grouping similar entity types together (e.g., Content type, Media, User, Other), users can quickly scan the menu and identify the right option. This also helps address the potential name clashing, for example a "Video" content type and media type, as options within a group are less likely to have conflicting names.
• Turning off items: Providing the ability to disable unused features is a great way to personalize the experience. Users can choose to see only the create content types they use regularly, further simplifying the menu and reducing decision fatigue. For example, disabling "Media" if they are entered via content creation.
• Adding items: Offering options to extend the menu with additional items is powerful. This caters to users with specific needs. They can leverage functionalities from contributed modules or custom modules. This flexibility allows the menu to adapt to different workflows and user requirements.

doxigo, the codes changes for `page_header_container_classes` and `page_content_container_classes` are due to setting `page_header_container_type: false` or ``page_header_container_type: ''` were not working.

In the page-content.component.yml:

  page_header_container_type:
      type: ['string', 'boolean']
      title: Container
      description: container type
      default: ''
      enum:
        - false
        - ''
        - sm
        - md
        - lg
        - xl
        - xxl
        - fluid

Since we're supporting `false`, `''`, we're unable to use the `page_header_container_type|default` nor `page_header_container_type is empty` checks, as `null`, `false`, `''` are different. Hence the verbose check on `null` first then `is empty` to cover `false` and `''`. The patch fixes all 3 cases.

- Removed classes from page-content.twig, moved to page.twig as properties.
- Fixed 'container' property checking. Was not working for `false` and `''` cases, although specified in the as part of the `enum`.

ckng → created an issue.

Adopting the fix from #3228330-31: Bootstrap conflicts with Drupal core "placeholder" class → .

ckng → made their first commit to this issue’s fork.

ckng → created an issue.

Hi donquixote, there is no need to run npm inside the DDEV container when doing the build and compiling SCSS, so making nodejs version inside DDEV irrelevant in this case. Easiest is to do it directly under the local theme folder. The nvm already enforced the version on the user end. The nvm will need to be installed inside container if you prefer to do it there. The steps for both local folder and inside container are the same.

If you already install the nodejs via nvm, on the local theme folder, no DDEV command or environment involved.

$ cd web/themes/custom/ar_radix/
$ nvm use
$ npm install
$ npm run watch
$ npm run production

If you haven't install nodejs via nvm:
The same can be done inside the DDEV (or any docker-based) container.

// On local, you may may have run this, but you might have forgotten. 
$ nvm install lts/iron

// Or for container from local.
$ ddev nvm install lts/iron

// Or inside container.
$ ddev ssh
$ nvm install lts/iron

// Running build inside container.
$ ddev ssh
$ cd web/themes/custom/ar_radix/
$ nvm use
$ npm install
$ npm run watch
$ npm run production

Re: .nvmrc
Yes, correct. "lts/iron" means it will use the latest stable LTS version of v20.x.

Hope that helps.

In 2.x, the purchasable item commerce_product_variation is loading the entity with ['variation_id', 'sku']:

    $prepared_data['product_variation'] = $this->loadEntityValue(
      $data['order_item']['product_variation_entity'],
      'commerce_product_variation',
      ['variation_id', 'sku']
    );

But in 3.x, ['uuid', 'variation_id'] are passed. 'sku' is missing leading to error and unable to load the entity, as the $value queried in CommerceWebformOrderHandler->loadEntityValue() is the 'sku' value. But the source of the issue is the 'sku' key is missing from commerce_product_variation entity keys. Maybe we need a special handling here?

Facing the same issue when upgrading from 2.0.0-beta2 (core D9) to 3.0.0-beta10 (core D10), this should be the same as the current dev copy.

Patch in #17 not working for me.
atcDateStart and atcDateEnd are always using the `use_raw_value`. Updated patch to correct the logic checking.

ckng → made their first commit to this issue’s fork.

Updated from 4.1.4 => 4.1.8, visit /admin/config/search/simplesitemap/entities and the error message is thrown.

TypeError: Drupal\simple_sitemap\Plugin\simple_sitemap\UrlGenerator\EntityUrlGeneratorBase::__construct(): Argument #9 ($config_factory) must be of type Drupal\simple_sitemap\Plugin\simple_sitemap\UrlGenerator\ConfigFactoryInterface, Drupal\Core\Config\ConfigFactory given, called in /var/www/html/web/modules/contrib/simple_sitemap/src/Plugin/simple_sitemap/UrlGenerator/CustomUrlGenerator.php on line 92 in Drupal\simple_sitemap\Plugin\simple_sitemap\UrlGenerator\EntityUrlGeneratorBase->__construct() (line 105 of /var/www/html/web/modules/contrib/simple_sitemap/src/Plugin/simple_sitemap/UrlGenerator/EntityUrlGeneratorBase.php).

ckng → created an issue.

Good example if you want full control over the CKEditor styling.
However, a simpler way would be to just point `ckeditor5-stylesheets` to the theme generated `build/css/main.style.css`. So CKEditor style will follow theme look and feel.

Previous patch causes non-ajax loaded tabs to be bound twice.

@doxigo, it won't force the latest version, but the related major LTS version on the local that fulfill the requirement. In this case, user are not forced to use a specific version, as long as it is the same LTS major version.

@doxigo, instead of using a fixed version number in the `.nvmrc`, we want to use `lts/hydrogen` for v18.* or `lts/gallium` for v16.* instead.

Adding Drupal.behaviors.a11yParagraphTabs so ajax content will be triggered. See attached patch.

Patch #2 tested working.

With patch #103, works after cleared cache. However, issue reappears after some time. Caching issue?

Tested patch #35, working well for utm redirect loop issue.

Patch #8 tested working. Corrected the version.

Patch #30 is not working for me too. Have a simple content type with required image field, but trying to bulk update a boolean field, getting error "Image field is required.".

ckng → created an issue.

Patch #3 tested working.

Tested patch #55, works well.

Agreed this is an "extension" to what the theme currently support. Only worth as a documentation.

As for wildcard support in Laravel Mix, this is still not supported.
See https://github.com/laravel-mix/laravel-mix/issues/3300, https://github.com/laravel-mix/laravel-mix/issues/982.

A workaround is proposed https://github.com/laravel-mix/laravel-mix/issues/982#issuecomment-45485..., reproduced here

var fs = require('fs');
var path = require('path');
var files = fs.readdirSync('./resources/sass/pages');

for (var i=0; i<files.length; i++) {
  if(path.extname(files[i]) == '.scss') {
    mix.sass('resources/sass/pages/' + files[i], 'public/css/pages');
  }
}

Sure, see attached yml.

ckng → created an issue.

Running into site performance issue on saving nested paragraphs. With this patch and 🐛 Appending/removing a field item to a field item list doesn't notify the parent of the change Needs work , the same edit process dropped from 72,257ms to 12,182ms.

Per #8, reverted string changes.