The 'image_loading' attribute is not respected

I have used an alternative approach to use the default image formatter and modify the result for svg images. This ensures that modifications in the default image formatter don't have to be re-implemented in this module.

Patch #8 tested working. Corrected the version.

Approach in #8 is much more future proof than the status quo. The improvement is most apparent when the patch is viewed in full context.

Similar implementation is done in https://www.drupal.org/project/svg_image/issues/3257729 📌 Formatters shouldn't repeat core code Needs review

Adding some coding standard fixes.

Relevant issues are:

• 🐛 SvgImageUrlFormatter parent construct wrong order Needs review Modified the way the plugin is instantiated. Additionally contains code style changes (underscore to camel case variable names).
• 📌 Schema inconsistent: width/height empty string vs null vs integer Fixed Changed the default values for @height@ and @width@ to @NULL@ instead of empty string. That one shouldn't actually have any impact. Unfortunately @3275057-12.patch@ contains a hunk with code style only changes in @SvgResponsiveImageFormatter::defaultSettings(). Reverted that one.

Looks good! Thanks for the fast follow-up.

Also working for me (v3.0.2), thanks.

Could the latest patch be provided as an MR and rebased on latest dev? Thanks!

Rerolled and created MR.

Looks like this MR include code from this issue : https://www.drupal.org/project/svg_image/issues/3257729 📌 Formatters shouldn't repeat core code Needs review

I think we should keep them separate.

And I'm not fond of calling getEntitiesToView(...) twice, in parent class and in our SVG formatters.

Actually, the current MR from 📌 Formatters shouldn't repeat core code Needs review is enough to fix this problem. Should we mark this a duplicate?

I guess so.

This could be closed now #3257729 is in.

Feel free to re-open if it doesn't fix this problem.