🇫🇷France @mably

Being hit by the same problem on my Ajax forms.

Culprit found, problem fixed, tests are green again.

Tests are failing. Needs work.

mably → created an issue.

With MR applied:

mably → created an issue.

Display after MR fix applied:

mably → created an issue.

May be we can imagine some kind of hybrid mode where we could select some entity types/bundles in the settings form and then only create per-bundle permissions corresponding to this selection of types/bundles.

That would definitely be an interesting feature to have.

Wondering if we shouldn't have a permission per bundle after seeing this issue: 📌 Create a admin page to define entities/bundles where access_unpublished should work Active

This looks like an easy fix.

Could you provide steps to reproduce the problem please?

MR 42 implements the new hook_access_unpublished_allowed_operations_alter hook.

Covered by a kernel test.

MR created with some kernel tests.

mably → made their first commit to this issue’s fork.

MR created. Functional Javascript test added.

We could add a 'custom' entry in the options list and if the 'custom' entry is selected, display an input field allowing to enter a custom expiration value.

An alter hook could be useful here.

Thanks @generalredneck!

Thanks @generalredneck, we are using this module on at least two big sites:

• https://www.bordeaux.fr
• https://www.bordeaux-metropole.fr

Happy to give back to the community.

Rebased and conflicts fixed.

I think Drupal 10.1 minimum will be required before merging.

mably → made their first commit to this issue’s fork.

Some improvements and fixes.

A functional test has been added.

You're welcome :)

Suggestions have been implemented.

mably → made their first commit to this issue’s fork.

A test has been added to this issue's MR.

We still need a way to grant this new permission to existing roles; otherwise most users will lose access to the token-generation form.

Ready to implement whichever solution is deemed appropriate.

mably → changed the visibility of the branch revert-12531709 to hidden.

mably → changed the visibility of the branch 8.x-1.x to hidden.

MR created with some tests.

mably → made their first commit to this issue’s fork.

"None" was in the original patch, I would rather go with an empty string too.

I can change the hook to process all existing tokens.

MR has been rebased.

mably → made their first commit to this issue’s fork.

MR created with some tests.

mably → made their first commit to this issue’s fork.

Created a merge request with the accompanying kernel test.

mably → made their first commit to this issue’s fork.

And it will also be automatically available in the node edit form:

As you said in a previous post, the "settings_form" id seems a bit too generic.

Nice catch @generalredneck!

The warnings should have disappeared now.

Added an empty-headers test case to ensure no warnings are triggered.

In your screenshot my user wants to remove the unlimited option and add a 4 weeks option.

It's there already a way to do that?

mably → created an issue.

Added a patch corresponding to the new MR 32. Tested successfully on Drupal 11.2.8.

I hadn’t planned to work on this module, but seeing that this major WSOD bug had been unresolved for nearly two years made me think some help might be needed.

Here is the message sent today to the current maintainers:

Hi,

We are using the "Access unpublished" module on some of our web sites.

I volunteer to maintain the module and pledge to work quickly on fixing the most urgent issues.

I have proposed a merge-request with functional tests to solve a major issue:

https://www.drupal.org/project/access_unpublished/issues/3421309 🐛 Unable to save 'access unpublished' setting form - TypeError: Drupal\Core\Render\Element::children(): Argument #1 ($elements) must be of type array, null given Active

You can check my profile here with all the modules I am currently maintaining:

https://www.drupal.org/u/mably →

Here is the issue relative to my maintainership offer:

https://www.drupal.org/project/access_unpublished/issues/3559337 💬 Offering to maintain Access unpublished Active

Regards.

Frank

mably → created an issue.

mably → changed the visibility of the branch 3421309-unable-to-save to hidden.

Looks like the patch has already been merged.

Does anybody know why this hasn't rather been fixed on core side?

Closing as problem should be fixed in 3.x and fix can't be easily backported to 2.0.x without breaking BC.

Sadly you don't provide any information that could help solve your problem.

Please don't reopen this issue unless you can provide a reproducible scenario on a fresh Drupal instance.

mably → created an issue.

Released in 3.4.0-rc1 → .

Thanks for the review @gabriel.passarelli !

Let's merge this.

Related class have been removed in this issue's MR: 📌 Replace DomainListCheck with permissions in routing.yml Fixed .

mably → created an issue.

Thanks @olivierg, it's released!

mably → created an issue.

A bunch of new functional tests have been added in issue ✨ Add a text filter to generate the Table of Contents in the text Needs review .

I guess it could be done using a custom provider.

But I do not think it's the current default behavior for any of the existing providers.

@olivierg can you confirm that it works fine for you so I can publish a new release?

Thanks.

It's merge! Thanks for all @olivierg.

Added a few functional tests.

Can we have an RTBC please?

Hi @olivierg, is there any test account available I could use to test the new code?

Didn't succeed to get one on the Post CH website.

Thanks for your help.

Thanks @hfernandes for the review!

I updated the code based on your suggestions.

Feel free to RTBC if everything seems ok.

Hi @olivierg, thanks for your patch.

Could you create a merge request please?

Haven't been able to reproduce the problem locally. Closing.

Closing for now. Feel free to reopen if needed.

Merged. Thanks!

Looks like everything is working again. 🎉

Ok, node field ToC is displaying again 😅

But Node block configuration is lost.

Looks like it hasn't been tested at all...

Looks like the table of contents are not rendering anymore 😉

Will have a deeper look tomorrow.

Works fine locally on Drupal 11.2.8.