Account created on 22 December 2015, almost 10 years ago
#

Merge Requests

More

Recent comments

🇫🇷France mably

mably → created an issue.

🇫🇷France mably

mably → created an issue.

🇫🇷France mably
🇫🇷France mably
🇫🇷France mably

mably → created an issue.

🇫🇷France mably
🇫🇷France mably

@cindytwilliams could you give a try to this issue's MR?

🇫🇷France mably

For some reason, domain_source_form_node_form_alter is now executed before domain_access_form_node_form_alter, which causes the issue.

🇫🇷France mably

Ok, thanks, will have a look at it.

🇫🇷France mably

Was it working fine in beta4 ?

🇫🇷France mably

"file_validate and related functions are deprecated and replaced with file.validator service and Constraint plugins"

https://www.drupal.org/node/3363700 →

🇫🇷France mably

Couldn't it be fixed by this other issue's MR ? 🐛 SVG validation error Active

🇫🇷France mably

FYI it's also possible to use grouped filters to define custom labels.

🇫🇷France mably
🇫🇷France mably

It would be really helpful to have a reproducible scenario on a fresh Drupal installation that works with beta3 but fails with beta4.

🇫🇷France mably

Would be great to be able to fix that server side using a dedicated views_filters_summay_der submodule.

🇫🇷France mably

It doesn't look like the standard Drupal autocomplete behavior.

I have something like "My content title (my_content_id)" on my side.

🇫🇷France mably
🇫🇷France mably

Thanks @gugalamaciek!

Not sure we want to add this code to the main module.

But we could create a new views_filters_summary_custom_labels dedicated submodule for that.

🇫🇷France mably
🇫🇷France mably
🇫🇷France mably

mably → created an issue.

🇫🇷France mably

It looks like the new LoggerFactory constructor parameter added in this issue creates a circular dependency problem with some other modules: 🐛 Circular reference detected Active .

🇫🇷France mably
🇫🇷France mably
🇫🇷France mably
🇫🇷France mably
🇫🇷France mably

@cgalibar please use the plugin alias hook of the commerce submodule.

🇫🇷France mably

Seems related to this issue 🐛 Vimeo hash parameter on private video url RTBC .

🇫🇷France mably
🇫🇷France mably

Thanks for the review @prashant.c, let's merge this!

🇫🇷France mably

Hi @prashant.c, could you give a try to this issue's MR please?

And switch it to RTBC if it solves your problem.

🇫🇷France mably

mably → made their first commit to this issue’s fork.

🇫🇷France mably

I would rather say: "Won't fix" for now.

If there is a real motivation behind such a change, and if we can get a good UX/UI design for it, why not

🇫🇷France mably

Looks like the exposed form is accessible like this:

$exposed_form = $this->view->display_handler->getOption('exposed_form');

May be we could inject the generated HTML directly in the exposed form instead of the area.

🇫🇷France mably

Sounds definitely like an interesting feature to have.

We just need to find the best way to do that.

🇫🇷France mably

Not sure we want to do that.

Seems like a radical change from current behavior.

🇫🇷France mably
🇫🇷France mably
🇫🇷France mably
🇫🇷France mably

mably → created an issue.

🇫🇷France mably

3 related issues have been merged.

Let's mark this as fixed.

🇫🇷France mably
🇫🇷France mably

mably → created an issue.

🇫🇷France mably
🇫🇷France mably

Ok, thanks, let's merge it!

🇫🇷France mably

I guess you are using this module:

https://www.drupal.org/project/views_core_entity_reference →

Let's see what we can do about it.

🇫🇷France mably

We’re always open to feedback and ideas on how to improve the TocJS module.

Feel free to share!

🇫🇷France mably
🇫🇷France mably
🇫🇷France mably

@leipomalla feel free to send me link by DM once it's available, I'll have a look at it.

🇫🇷France mably
🇫🇷France mably

Is there a public site available somewhere so I can check was the problem is exactly?

This is a basic feature of the module, used on hundreds of sites, so pretty surprising that it doesn't work.

🇫🇷France mably

@sokru I finally created an extra MR in this current issue.

Could you have a look at it and tell me if it fixes your problem?

🇫🇷France mably
🇫🇷France mably

As you can see on this page, no h3 are being picked up by TocJS.

So there is most probably a problem with your configuration.

TocJs can be configured at both the node type level and the block level.

Could it be that you’re looking at the wrong configuration?

🇫🇷France mably

@sokru should be easily fixable. Could you create an issue for it please?

🇫🇷France mably

Thanks for the fix!

🇫🇷France mably
🇫🇷France mably

Just started a fresh Drupal 10.5.3 instance with Domain 2.0.0-beta3.

I’m not seeing the redirect behavior you’re describing.

As far as I know, that isn’t a standard feature of the Domain Source module.

Could you try to reproduce your problem on a fresh Drupal 10 instance please?

Otherwise, I won’t be able to help you much.

🇫🇷France mably

Domain Unique Path Alias is also a third party module.

🇫🇷France mably

Some domain-related custom code may be?

🇫🇷France mably

Are you using any third-party domain module?

🇫🇷France mably

Merged.

Let's wait a few days before releasing 3.3.0-beta1.

🇫🇷France mably
🇫🇷France mably

@gugalamaciek what module are you using for your entity reference filters?

🇫🇷France mably

@murz we should be ready for merge, could you have a final look?

🇫🇷France mably
🇫🇷France mably

I have to admit, Claude gave me some clues ;)

Let's merge this!

🇫🇷France mably

Boolean label and 2D option values have been merged.

Only the entity reference filter remaining.

🇫🇷France mably

Current implementation is more a "Remove all" than a "Reset", am I right?

🇫🇷France mably

Looks like we simply needed to replace :

$this->view->preview

By:

$this->view->live_preview

@murz can you confirm that it also fixes the problem on your side?

Created a dedicated method in case we need to add other checks.

🇫🇷France mably
🇫🇷France mably

Thanks a lot @murz for all this investigation work.

Checking the route sounds like a nice solution, let's see what we can do with that.

🇫🇷France mably
🇫🇷France mably
🇫🇷France mably
🇫🇷France mably
🇫🇷France mably
🇫🇷France mably

mably → created an issue.

🇫🇷France mably

Thanks @murz, sounds like an interesting improvement.

Will make a few tweaks and merge it.

🇫🇷France mably
🇫🇷France mably

You are simply using the wrong configuration setting for that.

Here is the right one:

🇫🇷France mably

mably → created an issue.

🇫🇷France mably
🇫🇷France mably
🇫🇷France mably
🇫🇷France mably
🇫🇷France mably
🇫🇷France mably

Ok, on my side I have been working on a separate issue for the boolean part: ✨ Use exposed label for boolean filters when labels are disabled Active .

🇫🇷France mably
🇫🇷France mably

mably → created an issue.

🇫🇷France mably
🇫🇷France mably

mably → created an issue.

🇫🇷France mably
🇫🇷France mably

mably → created an issue.

🇫🇷France mably

mably → created an issue.

Production build 0.71.5 2024