🇫🇷France @mably

Filtering out /admin/* paths will give a far better performance boost.

So I'm not sure it is really useful and needed.

mably → created an issue.

mably → created an issue.

You're welcome 🙂

@nod_ how are we supposed to fix those phpcs warnings?

Remove "version" from the info file, it will be added by drupal.org packaging automatically (Drupal.InfoFiles.AutoAddedKeys.Version)

mably → made their first commit to this issue’s fork.

Not sure to understand what the problem is exactly.

Would you mind explaining a bit more in details?

Two merge requests have been merged into 3.x that are expected to deliver significant performance improvements:

• 📌 Improve DomainSourcePathProcessor class Active - Added a static cache of already processed paths. Can give a 25-30% performance gain on a basic page.
• ✨ Allow exclusion of specific path patterns in DomainSourcePathProcessor Active - Allows to exclude paths like /admin/* paths which can give a major performance boost.

Something like:

Not sure to understand what the problem is as it looks like we can already use a variable to define the sticky offset.

mably → changed the visibility of the branch 3546317-allow-exclusion-of to hidden.

@w01f thanks for the review!

If all the tickets I handle were as detailed as yours, that would be fantastic.

Let's merge this!

Found this somewhat related module: https://www.drupal.org/project/domain_access_search_api →

Added a static cache of already processed paths.

Improved outbound path processing time by 25-30% on a basic test page.

@w01f could you give a try to this issue's MR please?

Thanks @w01f!

It looks like a really nice feature to have.

Let's see what we can do.

mably → created an issue.

mably → created an issue.

Check this issue for an example of how it could be done: #3546074: Add hook to domain_source module to alter the list of disallowed routes → .

mably → created an issue.

mably → created an issue.

mably → created an issue.

If needed, a new lightweight SSO solution has been implemented in the Domain Extras → project.

A new lightweight SSO solution has been implemented in the Domain Extras → project.

If needed, I'm available for discussion on the #domain channel of the Drupal.org Slack → .

@emircan-erkul thanks a lot for the catch!

This was a nasty tagging bug.

This should be fixed in 3.0.0-alpha5 → .

mably → created an issue.

mably → made their first commit to this issue’s fork.

Could we have some RTBC please?

mably → created an issue.

You're welcome.

This behavior has changed in 3.x version.

Once the per-domain configuration is enabled, you are simply editing the configuration of the domain you are currently connected to.

There is no more a list of domain to chose from as you are editing the current-domain configuration.

The problem is most probably not related to the Taxonomy Term Glossary module, so I won't be able to help much here.

I've tried to cleanup the composer.json file a bit, just in case.

mably → made their first commit to this issue’s fork.

Thanks a lot @dhruv.mittal for the review.

Have you been able to test the related update hook?

I would not want to break hundreds of sites because of a failing update.

This should be fixed in 3.x.

Feel free to reopen if it's not the case.

A fix is not planned for the 2.0.x branch.

Tried to rebase the MR.

Is the problem still relevant on latest 2.0.x?

The use domain config ui permission should be enough to use the switch form.

Unless new, valuable information is provided, this issue will be closed in 3 months.

Probably fixed by 🐛 Prevent Unnecessary Redirects in Domain Source Submodule When Active Domain Matches Domain Source Active .

Setting to Fixed for now, as it is the default behavior in 3.x.

Feel free to reopen it and propose a patch if you think this should be implemented for 2.0.x.

Closing as it should be fixed by [2857402].

Ok, finally got to understand every part of it. We should be ready for merge.

The domain_access_module_implements_alter hook didn't solve the problem for me.

Had to increase the module_weight to make it work.

Could we have some RTBC please?

Feature has been moved to the Domain Extras → project within a dedicated domain_maintenance submodule.

Flagged as fixed, even if the fix is not in the main domain project.

Any further discussion should take place on the Domain Extras project page.

@rcodina unfortunately, I was unable to reproduce what you describe in your latest comment using version 2.0.x.

I do not have any UUIDs in the exported files.

Domain maintenance mode states must be removed on module uninstall.

mably → created an issue.

@kevinquillen config_ui doesn't use $_SESSION anymore in newly released version 3.x.

May be you could give it a try.

And 3.x too 😉

mably → created an issue.

Patch has been deployed in production for several months now. Everything is still running fine.

Thanks for the patch @mauhg! It's merged.

New issue created in the Domain Extras module: 📌 Upgrade loadAllDomainOverrides for Domain 3.x compatibility Active

mably → created an issue.

@guiu.rocafort.ferrer a new issue should be created on the Domain Extras → module page where the previous MR has been merged.

Marking as "Won't fix" as it will be fixed in the Domain Extras module's code.

Just created a new 3.x development branch there.

Thanks for the feedback. Let's merge this!

This will need an update to be compatible with the new 3.x version.

Is there a release notes generator handling the new commit format?

Released in 3.0.0-alpha1 → .

This problem will be fixed in the upcoming 3.x release.

mably → created an issue.

Have been included in the first beta release → of the new Domain Extras module.

Released in 3.1.0-beta1 → .

Thanks for this new feature!