🇫🇷France @mably

Thanks @hfernandes for the review!

I updated the code based on your suggestions.

Feel free to RTBC if everything seems ok.

Hi @olivierg, thanks for your patch.

Could you create a merge request please?

Haven't been able to reproduce the problem locally. Closing.

Closing for now. Feel free to reopen if needed.

Merged. Thanks!

Looks like everything is working again. 🎉

Ok, node field ToC is displaying again 😅

But Node block configuration is lost.

Looks like it hasn't been tested at all...

Looks like the table of contents are not rendering anymore 😉

Will have a deeper look tomorrow.

Works fine locally on Drupal 11.2.8.

Thanks @misterdidi.

Fix included in 1.1.0-rc1 release.

Closing as domain alias ordering have been added to 3.x.

Ok, thanks 👍

@yaqbick your commit made this whole MR mostly pointless, unless I miss something.

mably → created an issue.

FWIW the DomainListCheck class doesn't exist in Domain 3.x.

The string "DomainListCheck" can't be found at all in Domain 3.x source code.

So there is definitely something wrong with your configuration.

Probably some other module using a deprecated API.

Thanks @junaidpv for your feedback.

I'll publish a beta8 release in the coming hours.

@misterdidi ok, let's merge MR 5 then.

But what if a user wants to override a translation bundled with our plugin. How can it be done?

@bobburns Could you provide a reproducible scenario from a fresh Drupal instance?

mably → created an issue.

The solution here is probably to create new environments like DEV-ACQUIA and STAGE-ACQUIA.

Hi @madelyncruz, can you give us a bit more details on how to reproduce the problem? Haven't been able to reproduce it locally.

@gabriel.passarelli have implemented a service to generate the various forms.

Could you please review it and let me know if everything looks good to you?

mably → created an issue.

A new feature is being added to the Domain Extras project allowing to edit the list of Domain Alias environments: ✨ New Domain Alias submodule allowing the edit the environments settings value Active .

Might be a bit simpler to use than having to modify the settings.php file.

mably → created an issue.

@merilainen thanks for you comment, I've been able to reproduce the problem locally.

Looks like we might still want to generate URL for old existing submissions even after having disabled submission saving at the webform level.

May be we could simply disable URL token processing if the submission has no id? What do you think?

We could do somthing like:

  if (
    $type === 'webform_workflow'
    && isset($data['webform_submission'])
    && $data['webform_submission']->id() !== NULL
  ) {

Unless new, valuable information is provided, this issue will be closed in 3 months.

Unless new, valuable information is provided, this issue will be closed in 3 months.

Current implementation validates the workflow_state only.

Feel free to reopen or create a new issue to contribute other checks.

mably → made their first commit to this issue’s fork.

Wondering if we couldn't simply extend the webform.handler.email type.

mably → made their first commit to this issue’s fork.

Couldn't reproduce on 2.0.x.

Feel free to reopen if needed.

Hi @globexplorer, could you provide an MR on 2.0.x please?

mably → made their first commit to this issue’s fork.

mably → made their first commit to this issue’s fork.

I have tried to fix the validateWebformComposite function.

Tried to convert @mikat patch to an MR but I'm not really to understand what it's trying to do.

And tests are failing.

mably → made their first commit to this issue’s fork.

Related code does not exist anymore.

Hi @maxwellkeeble, could you explain a bit more in details what you are trying to achieve here? Thanks.

Hi @gabor.szabolcs, could you give a try to this issue's MR?

How come do we have to form elements with the same name here? 🤔

Is there any reason for it? Sound like a bug to fix.

Can confirm that this anomaly is still present in 2.0.x.

Merged 3 years ago, we can probably say it's fixed now.

Hi @yasmeensalah, is the problem still present in the 2.0.x branch?

Hi @whiplashomega, is the problem still present in the 2.0.x branch?

Could you provide a few more details on how to reproduce the issue?

@maxwellkeeble would you mind explaining a bit more in details what the problem is exactly?

For any further investigation, we’ll need a fully reproducible scenario on a fresh Drupal instance.

I have been able to handle two workflows on the same webform without any problem.

For any further investigation, we’ll need a fully reproducible scenario on a fresh Drupal instance.

For any further investigation, we’ll need a fully reproducible scenario on a fresh Drupal instance.

mably → created an issue.

@merilainen could you please share a few more details on how to reproduce the issue?

I would like to test the MR before merging. Thanks.

Been able to successfully test the patch. Merging.

Thanks @oscarfabian01!

@misterdidi tell me if it works for you so I can merge it.

Thanks!

Would be great to have some RTBC.

Wondering if using Drupal.t() couldn't be a better solution here...

Anyway, I updated the MR to parse the JS code to automatically create the translation JS file using a <lang>.po file.

mably → made their first commit to this issue’s fork.

mably → made their first commit to this issue’s fork.

Hi @gabriel.passarelli I worked on the code refactoring you mention in your last message.

Could you have a look at the MR and check if everything seems ok to you?

mably → made their first commit to this issue’s fork.

FYI Drupal 11.3.0-alpha1 has already been released → .

@prudloff could you have a look at my MR that adds the missing "loading" configuration option please? Thanks.