Thanks a lot @avpaderno!
Merged. Thanks @linhnm for the fix!
The MR looks fine.
I can see that the regexp corresponds to the one found here:
https://stackoverflow.com/questions/71000139/javascript-regex-for-youtub...
Tested successfully with the following urls here : https://regex101.com/r/5JhmpW/1
http://www.youtube.com/watch?v=0zM3nApSvMg&feature=feedrec_grec_index
http://www.youtube.com/user/IngridMichaelsonVEVO#p/a/u/1/QdK8U-VIH_o
http://www.youtube.com/v/0zM3nApSvMg?fs=1&hl=en_US&rel=0
http://www.youtube.com/watch?v=0zM3nApSvMg#t=0m10s
http://www.youtube.com/embed/0zM3nApSvMg?rel=0
http://www.youtube.com/watch?v=0zM3nApSvMg
http://youtu.be/0zM3nApSvMg
https://youtube.com/shorts/0dPkkQeRwTI?feature=share
https://youtube.com/shorts/0dPkkQeRwTIThanks for the patch @linhnm!
Could you create a merge-request please?
Hi Mike, thanks for having a look at our issue.
All the buttons are disabled by default and not displayed.
It should not affect existing installations and be backward compatible.
We are ok with merging this in a new 2.0.x branch of the module (this is what we are currently doing with the views_filters_summary → module).
Has been implemented in 3.0.x-dev using a info_alter hook in a dedicated submodule.
Has been implemented in 3.0.x-dev using a info_alter hook in a dedicated submodule.
You're welcome! Feel free to come back to me if you encounter any issue.
Has been implement in 3.0.x-dev via a hook in a submodule.
@khiminrm this last commit^^ should fix it.
@khiminrm I'll have a look at it, thanks 👍
Should be fixed in 3.0.x-dev branch.
Thanks for all you contributions!
Current fixes have been merged in 3.0.x-dev branch.
Keeping open for eventual futur uses.
Taxonomy term are automatically translated in Drupal 8+.
I guess this is for a very specific translation use case.
Should be fixed in 3.0.x-dev branch.
Most of these issues should be fixed in 3.0.x-dev branch.
This commit allows to inject a specific class in the page when the view uses Ajax:
https://git.drupalcode.org/project/views_filters_summary/-/commit/7e3234...
So I think this fixes this specific issue and we can now work on this one:
https://www.drupal.org/project/views_filters_summary/issues/3345403 🐛 Remove link removes all filters Fixed
Should be fixed in 3.0.x-dev branch, could you give it a try?
Some of those issues have been fixed in the 3.0.x-dev branch, could you give it a try?
Maintainership has been accepted, thanks.
Working on 3.0.x-dev branch, processing the issue backlog.
Should be fixed in 3.0.x-dev branch.
Fixed in 3.0.x-dev branch.
Date filters summary should now display fine in 3.0.x-dev branch, could you give it a try?
Fixed in branch 3.0.x-dev.
Fixed in new 3.0.x-dev branch.
Removal of the toc_ng module as it has been backported to toc_js.
Released as version 3.0.0-beta2.
Ok, I have tried to implement a first version of collapsible items, it is marked as experimental in the configuration screen:
This basic implementation is a proof-of-concept that will probably need to be improved later on:
New configuration option:
mably → created an issue.
The new configuration option:
Added an MR to this issue that allows you to override the default way to get the toc container.
You can check the code here: https://git.drupalcode.org/project/toc_js/-/merge_requests/21/diffs
It should allows you to do whatever you want to select the right container you are interested in.
Could you explain what can't be done in CSS exactly?
This particular case should be handled in your site theme. 2 sizes in definitely not enough, some people will need to be able to handle 3 or more different size levels... This definitely belongs to your theme CSS files.
The ToC title configuration option can be left empty or hidden in CSS as you did, I'm not a SEO expert so won't be able to give a more precise answer.
have not tested the autocomplete feature, but the datalist part seems to be working fine, thanks!
Could you provide a complete scenario for reproducing the bug?
On my side everything seems to be working fine:
Tested with latest code from this MR.
Are you sure to have download the module's code corresponding to this issue's MR?
I can definitely see the Toc container field in the block configuration of the layout builder:
You dont need a specific CSS class, we use the closest() jQuery API with a simple selector to get the parent container.
If your parent container is a div, just put div in the container selector field.
@w01f, could you give a try to this issue's MR that implements this new "toc container selector" option and tell us how it goes?
Here is a screenshot of the new configuration option:
Hi @w01f, thanks for your suggestion.
What do you think of adding a "toc container selector" configuration option allowing to choose on which parent element of the toc we want to apply visibility and stickiness ?
Nice work!
I think it would be preferable to create a dedicated submodule to avoid a dependency on the rather heavy webform module for those who don't need it, what do you think?
We cannot disable the toc_js block rendering as everything is done client-side.
May be we can add some custom CSS to the block when the toc is empty to allow hiding.
What are your suggestions?
The sticky positioning behavior is applied in its scrolling parent container only.
So your HTML must be specifically crafted for sticky behavior you want to get.
May be you'll find so more information here: https://www.lambdatest.com/blog/css-position-sticky-tutorial/
Fix for step 1 merged, we won't fix step 2 for now.
Let's go for a beta release then ;)
The problem is probably not related to toc_js as no javascript code modifies the li width or any other element width in the source code of the 3.0.x-dev version.
The problem is probably not related to toc_js as there is no occurence of sticky-wrapper in the module's source code for the 3.0.x-dev version.
And the module code doesn't add div tags between ul and li tags which is invalid:
Most of the issue backlog have been cleared, I think we may be ready for an alpha release...
A few commits have been added to 3.0.x-dev branch to fix highlighting with invisible headings.
Confirmed as fixed in 3.0.x-dev.
Merged.
Merged.
Merged.
Merged.