HTML code not added in new version

More than one thousand sites are using the 3.x version without any problem.

You must provide more information to enable further investigation.

What information do you need?

A repeatable scenario allowing to reproduce the bug on a fresh Drupal 11 instance for example.

<link rel="icon" type="image/png" href="/favicon-96x96.png?v=blJXMRWeAF" sizes="96x96" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg?v=blJXMRWeAF" />
<link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png?v=blJXMRWeAF" />
<meta name="apple-mobile-web-app-title" content="AsterX" />
<link rel="manifest" href="/site.webmanifest?v=blJXMRWeAF" />

The following files exist:
sites/default/files/favicons/apple-touch-icon.png
sites/default/files/favicons/favicon.svg.gz
sites/default/files/favicons/web-app-manifest-192x192.png
sites/default/files/favicons/favicon-96x96.png
sites/default/files/favicons/site.webmanifest
sites/default/files/favicons/web-app-manifest-512x512.png
sites/default/files/favicons/favicon.svg
sites/default/files/favicons/site.webmanifest.br
sites/default/files/favicons/favicon.svg.br
sites/default/files/favicons/site.webmanifest.gz

https://test.asterx.be/ is running version 3.0.0
https://asterx.be/ is running version 2.0.1

Have you tried removing those ?v=blJXMRWeAF parameters from your icons urls?

They should not be there.

ok, that helped, but is there a reason why a cashbusting parameter is not allowed in version 3.0.0?

Is this a bug or do I need to alter from now on the filenames when I update the favicon files? (I am using Cache-Control "public, max-age=31536000, immutable" HTTP Header in nginx)

The cache busting parameter should be added automatically.

As you can see there: https://www.bordeaux.fr

Is this a Drupal 11 feature as I see no parameter on my test site?

It's a Drupal standard feature that has been added to the 3.x version of the module.

That's a Drupal 11 feature? Maybe a note should be added in the docs for those who do not yet use Drupal 11?

That's not a Drupal 11 feature.

Do not reopen this issue but rather create another issue if you have a specific documentation request to make.

I just had the same issue on a D10 site when upgrading to v3.0.0 of the module (in preparation to upgrade to D11 in the future).

Removing the cachebusting 'v' parameters from the icon paths, which was as previously supplied by realfavicongenerator.net, fixed the problem.

I suspect many other sites will encounter this issue, because they will also have older code supplied by realfavicongenerator.net which contained the cachebusting.

It might be worth adding a note about this in the warning message/status report that is present when v3 of the module can't find the icon file paths, to say that cachebusting parameters should not be included in the file paths.

@natts, something like this?

That's a good start, but I think the statements should change from:

The favicon files are missing for the following tags. Go to configuration page to add missing files. Ensure that your file URLS do not include any cache-busting parameters.

To something more accurate, like:

The favicon files referenced in the following HTML tags either cannot be found, or include unnecessary cache-busting parameters (which must be removed). Please use the configuration page to amend the HTML and/or upload the missing favicon files.

@natts like this?

I haven't deployed the MR, but the error in the screenshot seems clear to me.

Looks much better to me, thanks.

Thank you for your feedback, I'll merge it.

Automatically closed - issue fixed for 2 weeks with no activity.