@sd123

Whilst I agree the theme could benefit from some additional cleanup love, I managed the not 100% smooth upgrade path. I see no need to replace Matt Bloomfield. If someone steps up to help, that would be fine as long as we take in mind the story of Jia Tan.

@tokosefi: the reason why we had to switch to a fork was because the initial maintainer disappeared and nobody initially could get commit access to make the theme compatible with new Drupal versions.

As far as I know the current maintainer is doing this in his limited free time and I respect that.

If you want dedicated support, I would suggest to get help at https://www.drupal.org/drupal-services →

Sounds the same to me. I have configured several limits on my server and I believe I also have had such error. Maybe this should be documented in either the interface or on the project page?

I just removed all excluded files and I can confirm it seems to be working now. It might have been a bug in minify.

At this moment I have all the following excluded and that works for me:

core/assets/vendor/ckeditor/ckeditor.js
core/assets/vendor/ckeditor/lang/*
core/assets/vendor/ckeditor5/*/*
modules/contrib/insert/js/*
modules/contrib/insert/js/editors/*
modules/contrib/token/js/*
themes/contrib/gin/dist/js/*
core/scripts/js/assets/ckeditor5Files.js
core/scripts/js/ckeditor5-check-plugins.js
core/scripts/js/ckeditor5-types-documentation.js
core/misc/*
core/modules/ckeditor5/*
core/modules/ckeditor5/js/*
core/modules/ckeditor5/js/*/*
core/modules/ckeditor/tests/*
core/modules/color/tests/*
core/modules/locale/tests/*
core/modules/quickedit/js/views/EntityToolbarView.js
core/modules/system/tests/*
core/modules/views/tests/*
core/tests/*
libraries/d3/test/*
libraries/jquery.inputmask/qunit/tests*
libraries/jquery.intl-tel-input/src/spec/tests/*
libraries/jquery.select2/tests/*
sites/default/files/*
vendor/jcalderonzumba/gastonjs/examples/*
vendor/jcalderonzumba/gastonjs/tests/*
*-min.js
*.min.js

Taking into account roblog's comments, I temporarily(??) fixed it with the following SQL on my database:

UPDATE key_value_expire SET value = REPLACE(value, '^^', '^') WHERE collection = 'update_available_releases' AND name = 'at_tool';

I am having the same issue with the 2.0.5 version of at_tool. Is there a patch for that version as well?

Note that my at_tool.info.yml is looking the same as in the patch but I still get the error.

No, as soon as it starts to minify the ckeditor stuff, it breaks. Disabling on admin pages does not help.

Oops, I overlooked that merge request.

I can confirm it also fixes the issue for me.

I think both JPEG XL and AVIF support will be best to have. The first format will be better in the long run since it will allow an easy and painless transition of existing websites because of it backward compatibility features with JPEG.

Ok, I am also getting the error without the Preview button. This is how I can trigger the error in the logs:

1. Put a space only in the Subject field.
2. Enter something in all other fields.
3. Press the Send message button.
4. The error "Subject field is required." appears on the screen + Deprecated function: preg_match() in ColorSystemBrandingBlockAlter.php is logged.

Step 1:

Step 2:

This is logged when pressing the Preview button:

Deprecated function: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in Drupal\color\ColorSystemBrandingBlockAlter::preRender() (line 27 of /PATH/TO/SITE/web/modules/contrib/color/src/ColorSystemBrandingBlockAlter.php) #0 /PATH/TO/SITE/web/core/includes/bootstrap.inc(164): _drupal_error_handler_real()
feb 14 11:25:03 vps1 drupal[512150]: #1 [internal function]: _drupal_error_handler()
feb 14 11:25:03 vps1 drupal[512150]: #2 /PATH/TO/SITE/web/modules/contrib/color/src/ColorSystemBrandingBlockAlter.php(27): preg_match()
feb 14 11:25:03 vps1 drupal[512150]: #3 [internal function]: Drupal\color\ColorSystemBrandingBlockAlter::preRender()
feb 14 11:25:03 vps1 drupal[512150]: #4 /PATH/TO/SITE/web/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php(111): call_user_func_array()
<snip>

ok, did some further testing. It turns out Insert works again when I disable the option to Aggregate JavaScript files. It looks that on my end AdvAgg is the culprit.

Hope this gets fixed though as without AdvAgg, I will have to drastically raise DDos limits in nginx. I am using Quicklink as well and in combination with unaggregated small JavaScript files, my connection limits are reached too fast.

I did some testing and it happens each time someone presses the preview button on the contact form.

As a workaround, I just removed the preview feature from my site.

PHP 8.2.7
Drupal 10.2.3

I created the attached patch based on the report but haven't tested it myself.

sd123 → created an issue.

sd123 → created an issue.

I had the same error as in comment 8 and created a patch.

I created a patch based on EricVL's comment.

I am also getting the Uncaught ReferenceError "CKEDITOR is not defined". I do not have a separate ckeditor.js file though as I am using JavaScript aggregation and AdvAgg Bundler

It indeed removed the warning but the issue is still there. One a new page I can insert an image.

The code then looks like this:
<img src="/sites/default/files/2024-02/image-test.jpg" width="648" height="365" class="image-insert__auto" data-insert-type="image" data-entity-type="file" data-entity-uuid="insert-auto-ca25496e-a969-435e-8b55-4be11b57f20e" data-insert-attach="{&quot;id&quot;:&quot;ca25496e-a969-435e-8b55-4be11b57f20e&quot;,&quot;attributes&quot;:{&quot;data-caption&quot;:[&quot;title&quot;]}}">

Note that it does not copy the selected alignment setting (I tried to align right in this example).

When I do page preview the image is showing well.

When I go back, the insert button stopped working. I cannot insert any image (I have other image fields), nor the inserted image settings can be updated (cfr. alignment setting).

I thus can only insert an image on a new page only and alignment settings aren't copied.

/admin/config/development/performance/advagg/bundler

If you do not see it, you may need to enable the "AdvAgg Bundler" submodule first.

It is possible that the minification does not work without the bundler option enabled because of the changes in Drupal.

AdvAgg needs a major rework since Drupal 10.1 and higher as Drupal is now doing the minification. You best disable JavaScript minification for now and eventually install the Minify JS module instead.

It works on my site with the following settings:

• the setting to combine CSS files enabled
• Enable advanced aggregation
• YUI Compressor selected
• Bundler is Active
• I have 3 css files with file size grouping logic
• Enable preprocess on all CSS is enabled

(keep in mind that AdvAgg still needs a major rework for Drupal 10.1 and higher)

Maybe this can help to debug the issue, when I open an existing patch on my patched site (patch #16), I am getting the following in my server logs:

jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: 1706694458|php|213.219.159.253|https://test.example.org/node/1031/edit|https://test.example.org/node/1031/edit|183||Warning: Undefined array key "width" in template_preprocess_responsive_image() (line 209 of /var/www/MYWEBSITE/web/core/modules/responsive_image/responsive_image.module) #0 /var/www/MYWEBSITE/web/core/includes/bootstrap.inc(164): _drupal_error_handler_real()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #1 /var/www/MYWEBSITE/web/core/modules/responsive_image/responsive_image.module(209): _drupal_error_handler()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #2 /var/www/MYWEBSITE/web/modules/contrib/insert/modules/insert_responsive_image/insert_responsive_image.module(69): template_preprocess_responsive_image()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #3 [internal function]: insert_responsive_image_insert_variables()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #4 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(409): call_user_func_array()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #5 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(388): Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #6 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(408): Drupal\Core\Extension\ModuleHandler->invokeAllWith()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #7 /var/www/MYWEBSITE/web/modules/contrib/insert/insert.module(208): Drupal\Core\Extension\ModuleHandler->invokeAll()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #8 [internal function]: _insert_field_process()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #9 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(1013): call_user_func_array()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #10 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(1076): Drupal\Core\Form\FormBuilder->doBuildForm()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #11 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(1076): Drupal\Core\Form\FormBuilder->doBuildForm()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #12 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(1076): Drupal\Core\Form\FormBuilder->doBuildForm()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #13 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(579): Drupal\Core\Form\FormBuilder->doBuildForm()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #14 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(325): Drupal\Core\Form\FormBuilder->processForm()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #15 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #16 [internal function]: Drupal\Core\Controller\FormController->getContentResult()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #17 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #18 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #19 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(121): Drupal\Core\Render\Renderer->executeInRenderContext()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #20 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #21 /var/www/MYWEBSITE/vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #22 /var/www/MYWEBSITE/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #23 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #24 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #25 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #26 /var/www/MYWEBSITE/web/core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #27 /var/www/MYWEBSITE/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\big_pipe\StackMiddleware\ContentLength->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #28 /var/www/MYWEBSITE/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #29 /var/www/MYWEBSITE/web/core/modules/ban/src/BanMiddleware.php(50): Drupal\page_cache\StackMiddleware\PageCache->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #30 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\ban\BanMiddleware->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #31 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #32 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #33 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #34 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\Core\StackMiddleware\StackedHttpKernel->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #35 /var/www/MYWEBSITE/web/index.php(19): Drupal\Core\DrupalKernel->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #36 {main}.
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: 1706694458|php|213.219.159.253|https://test.example.org/node/1031/edit|https://test.example.org/node/1031/edit|183||Warning: Undefined array key "height" in template_preprocess_responsive_image() (line 210 of /var/www/MYWEBSITE/web/core/modules/responsive_image/responsive_image.module) #0 /var/www/MYWEBSITE/web/core/includes/bootstrap.inc(164): _drupal_error_handler_real()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #1 /var/www/MYWEBSITE/web/core/modules/responsive_image/responsive_image.module(210): _drupal_error_handler()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #2 /var/www/MYWEBSITE/web/modules/contrib/insert/modules/insert_responsive_image/insert_responsive_image.module(69): template_preprocess_responsive_image()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #3 [internal function]: insert_responsive_image_insert_variables()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #4 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(409): call_user_func_array()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #5 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(388): Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #6 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(408): Drupal\Core\Extension\ModuleHandler->invokeAllWith()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #7 /var/www/MYWEBSITE/web/modules/contrib/insert/insert.module(208): Drupal\Core\Extension\ModuleHandler->invokeAll()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #8 [internal function]: _insert_field_process()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #9 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(1013): call_user_func_array()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #10 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(1076): Drupal\Core\Form\FormBuilder->doBuildForm()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #11 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(1076): Drupal\Core\Form\FormBuilder->doBuildForm()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #12 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(1076): Drupal\Core\Form\FormBuilder->doBuildForm()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #13 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(579): Drupal\Core\Form\FormBuilder->doBuildForm()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #14 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(325): Drupal\Core\Form\FormBuilder->processForm()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #15 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #16 [internal function]: Drupal\Core\Controller\FormController->getContentResult()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #17 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #18 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #19 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(121): Drupal\Core\Render\Renderer->executeInRenderContext()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #20 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #21 /var/www/MYWEBSITE/vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #22 /var/www/MYWEBSITE/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #23 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #24 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #25 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #26 /var/www/MYWEBSITE/web/core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #27 /var/www/MYWEBSITE/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\big_pipe\StackMiddleware\ContentLength->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #28 /var/www/MYWEBSITE/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #29 /var/www/MYWEBSITE/web/core/modules/ban/src/BanMiddleware.php(50): Drupal\page_cache\StackMiddleware\PageCache->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #30 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\ban\BanMiddleware->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #31 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #32 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #33 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #34 /var/www/MYWEBSITE/web/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\Core\StackMiddleware\StackedHttpKernel->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #35 /var/www/MYWEBSITE/web/index.php(19): Drupal\Core\DrupalKernel->handle()
jan 31 10:47:38 myserver drupal-MYWEBSITE[3523015]: #36 {main}.

It is still not working as how it should with this patch but already a little bit better.

Without this patch the following happens when I create a new node and try to insert a new image by clicking on the 'Insert' button: the 'Browse...' buttons and "No files selected." areas from the other optional image fields grey out for about a second but nothing is inserted.

With this patch: inserting works for a new page with a fresh image, but after previewing or saving the page, inserting the image stops working again and the same behaviour happens with the "No files selected." areas being greyed out for about a second.

sd123 → created an issue.

Step 3 is the command to create the symlink. The subtheme that I created using AT Tool 2.0 contained links to /path/to/site/web/themes/contrib/at_theme/at_core/...

Hence, I created a symbolic link (symlink) that points /path/to/site/web/themes/contrib/at_theme/ to /path/to/site/web/themes/contrib/adaptivetheme. So my subtheme keeps pointing to files in /path/to/site/web/themes/contrib/at_theme/at_core, but that is no problem as it points to /path/to/site/web/themes/contrib/adaptivetheme/at_core/... thanks to the symbolic link.

That's strange. I used AT Tool 2.0 to create the subtheme and it is under themes/custom. Note that I am also using composer

Anyhow, just login to the console on your server and try the following with your staging site:

1. cd /path/to/site/web/themes/contrib
2. mv at_theme at_theme.orig
3. ln -s /path/to/site/web/themes/contrib/adaptivetheme/ at_theme
4. cd /path/to/site
5. drush cr

If that works well, you can remove at_theme from composer.json, delete the at_theme.orig directory, and try everything on your production site.

I believe this is what I did.

In WEBDIR/themes/contrib I deleted "at_theme" directory and replaced it with a symlink to the "adaptivetheme" directory.

This is open source. Feel free to take up maintainership of at_theme or pay someone to do so if you think it can be better.

Switching back to the original Adaptive Theme is not so hard. You can even keep using your AT2 created subtheme if you just create a symlink that directs .../web/theme/contrib/at_theme to .../web/theme/contrib/adaptivetheme/

PS: note that mattbloomfield created this fork because the original theme could not receive updates for a long time due to the original creator being missing.

Is there a good reason why in the latest 5.2 release a dependency was added to the contrib stable project instead of using stable9 which is shipped with Drupal 10.x?

I did not experience any incompatibilities on my sites with stable9 but maybe there are?

Personally, I prefer using as few contrib code as possible...

Insert still does not work here in a text area that is of the type "Full HTML" or "Filtered HTML" in Drupal 10.2.1.

Good news! As far as I can see Drupal 10.2.1 fixes this bug. No patches to MinifyHTML are needed.

I still cannot insert images in Filtered HTML fields with 3.0.0-beta3 and Drupal 10.2.

Neither the patch nor the merge request work. The patch from roshni27 fails to copy the theme logo because the trailing slash is missing so that it fails to find the logo.

The merge request leads to the following error:

Uncaught PHP Exception ArgumentCountError: "Too few arguments to function Drupal\Core\Asset\CssOptimizer::__construct(), 0 passed in web/themes/contrib/adaptivetheme/at_core/forms/color/color_submit.php on line 132 and exactly 1 expected" at web/core/lib/Drupal/Core/Asset/CssOptimizer.php line 34" while reading response header from upstream

I disabled the Minified Source HTML checkbox and trying to reactivate, I am now getting the same error as @zcht. Even deinstalling the module does not work

Regarding Bundler: it also looks like the Target Number Of CSS/JS Bundles Per Page setting stopped working correctly. I am getting less bundles, but more than the target number.

• CSS: I get 8 bundles with setting 3, and 6 bundles with setting 2.
• JS: I get 1 bundle more than the configured value.

If this can help: my DEV site does not have ssl and so neither http2 is used in nginx.

@slydevil: I may be wrong, but I do not think it is already possible to use http3 with Apache.

@danthorne: can you try to temporarily disable PHP-FPM and use mod_php instead? If that works, the errors are maybe correlated with how Drupal 10.2 interacts with PHP-FPM.

I do not think it is related to http3. I am using nginx/1.22.1 (no http3) with PHP-FPM 8.2 and I am also getting issues on my DEV site when Minified Source HTML is enabled.

When I use the search form to search for VALUE, it works. But when I search for VALUE again, I get a blank page and the following error in the console:

Failed to load resource: net::ERR_INCOMPLETE_CHUNKED_ENCODING

I can clear caches, but the error returns. It only keeps working when I disable Minified Source HTML.

Neither patch #2, nor the merge request seem to be working. I am using 6.0.0-alpha1 and Drupal 10.0.11 and have the following other patches active:

"Deprecated function: Creation of dynamic property": "https://www.drupal.org/files/issues/2023-07-28/3375725-5.patch",
"Missing *.min.js.map files": "https://git.drupalcode.org/project/advagg/-/merge_requests/21.patch"

Following up on my own feedback: I tested upgrading Drupal 9.5.11 sites to Drupal 10.0.11 whilst running both on PHP 8.2 and that seems to work. Thus, there is no need to downgrade to PHP 8.1 using third-party packages on for instance Debian Bookworm that ships with PHP 8.2 only.

I am not experiencing this issue with Drupal 10.0.11, Nginx and PHP-FPM 8.2.

@Lincoln-Batsirayi: I do not know which version you are using, but note that AdvAgg is not yet compatible with Drupal 10.1!

Just to add: you also can temporarily enable "show the label" and then translate the string, save the extension settings, and then disable the "show the label" setting again. Disadvantage: the string cannot be translated on a multilingual website. I thus prefer my patch, but maybe the field to set the text should be removed now as it becomes useless with my patch.

I can confirm your PR looks to solve the issue, however, by testing I discovered 2 more deprecations when saving the extension settings:

Creation of dynamic property Drupal\at_core\Layout\Layout::$layout_path is deprecated in Drupal\at_core\Layout\Layout->__construct() (line 27 of /at_core/src/Layout/Layout.php)
Creation of dynamic property Drupal\at_core\Layout\Layout::$layout_cid is deprecated in Drupal\at_core\Layout\Layout->__construct() (line 28 of /at_core/src/Layout/Layout.php)

I can confirm the error is gone with the patch of seogow.

You are trying the upgrade on your production site? May I suggest to create a staging copy → of your site? I have a "test." subdomain for this.

Is the Drupal 9.5 column still up to date? Doesn't Drupal 9.5.10 and higher support PHP 8.2 as well?

Or is the PHP 8.2 support not tested enough to execute a flawless upgrade to Drupal 10?

The reason why I postponed my upgrade is because Debian 11 that I was using ships with PHP 7.4 whilst Drupal 12 ships with PHP 8.2. This forced me to install unofficial apt package sources → to get PHP 8.1 on Drupal 12 to initiate the upgrade of Drupal.

I suppose I will not be the only one who was or is hesitant to upgrade because of this. So, if an upgrade from Drupal 9.5.10+ is possible and stable using PHP 8.2, updating that table will help people.

Did you execute step 1, temporarily changing permissions? It seems you need to alter these commands to your directories: https://www.drupal.org/docs/upgrading-drupal/upgrading-from-drupal-8-or-... →

I would try the following:

composer self-update

If you have the latest version or if that does not help, maybe you can first try to upgrade to 10.0.11 first to see if that helps:

composer require 'drupal/core-recommended:10.0.11' 'drupal/core-composer-scaffold:10.0.11' 'drupal/core-project-message:10.0.11''drush/drush:^12' --update-with-all-dependencies --no-update

composer update

If that not helps, you can try this:

composer require 'drupal/core-recommended:10.0.11' 'drupal/core-composer-scaffold:10.0.11' 'drupal/core-project-message:10.0.11' 'drupal/core:10.0.11' 'drush/drush:^12' --update-with-all-dependencies --no-update

composer update

If that works, do not forget to manually delete the lmine with 'drupal/core:10.0.11' from composer.json.

Done.

Well, I now see Drupal 9.5.10 release notes → read:

This release allows Drupal core-recommended to install and run on PHP 8.2.

Does this mean it is supposed to work with 8.2, an upgrade using PHP 8.2 is possible, and did people forgot to updated the table?

To answer my own question: I tried option 2 and that seems to work. Not sure if that is the best.

PS: I also noticed Drupal 9.5.11 at first sight seems compatible with PHP 8.2 as everything appeared to be working. Maybe this table → needs an update? Or did I just had luck?

@NickDickinsonWilde: would it also be possible to add a note about Drupal 10.1 that is shown in Upgrade Status? I only found out about the compatibility issues after doing a test upgrade and I guess I will be the only one that follows the upgrade instructions → who will find out.

Maybe it can be a simple note in the Plan column like Quicklink has.

I think it will be better if Drupal automatically generates both .gz and .br static versions of all svg assets in the theme and uploaded images. Then the webserver can serve all those files.

@jaimeah: I would skip support for JPEG XR and JPEG 2000. Instead add support for AVIF and for sure JPEG XL which allows for backward compatibility with JPEG.

I have altered my configuration as follows:

    # Serve images that do not need compression
    location ~* \.(png|jpg|jpeg|gif|ico)$ {
        add_header Cache-Control 'public, max-age=31536000, immutable';
        try_files $uri @rewrite;
        expires max;
        log_not_found off;
    }
    # Serve static compressed versions of files
    location ~* \.(js|css|svg|webmanifest)$ {
        add_header Cache-Control 'public, max-age=31536000, immutable';
        try_files $uri @rewrite;
        expires max;
        log_not_found off;
        brotli_static on;
        gzip_static on;
    }

This works with Drupal 9.5 (not yet tested with 10.x as I am still preparing the upgrade).

This looks better to me as what is proposed here, as it looks for all files independent of the directory. For instance, I have the Matomo plugin installed. This plugins creates ^/sites/.*/files/matomo/matomo.(js|js.gz) which is not intercepted with the proposed config (the static brotli version was created manually).

Or am I mistaken and has my configuration disadvantages or will it not work with Drupal 10.x?

sd123 → created an issue.

Another use case I had for this module is to serve static Brotli compressed CSS and JS assets. It meant smaller files to transfer that are faster to decompress.

I hope core will introduce this soon (with support for static br and gz duplicates of svg images too).

Maybe it are dependencies of modules you had installed in the past but are not using today? Have to tried removing them?

@RedEight: did you encounter any issues be changing base theme to stable9? I am this month in the process of migrating to Drupal 10.

You should switch back to the original Adaptivetheme that now got D10 compatible.

sd123 → created an issue.

ok, but then there still is a bug: I have Brotli support installed. The optimized files all have Brotli versions because of this. However the aggregated files do not get a Brotli version. Probably because Drupal core does not support Brotli. This renders Brotli support in AdvAgg useless.

AdvAgg should somehow help Drupal to generate Brotli versions of the aggregated JS/CSS when Brotli is enabled.

sd123 → created an issue.

This patch makes the string translatable.

sd123 → created an issue.

sd123 → created an issue.

sd123 → created an issue.