Contrib.social

Fix error in CkEditor

Open on Drupal.org →
Created on 19 September 2022, almost 2 years ago
Updated 30 October 2023, 8 months ago

Problem/Motivation

In 🐛 CKEditor has errors when JS is aggregated Fixed a workaround was added for the core/assets/vendor/ckeditor/ckeditor.js path and prevent aggregation for CkEditor. The CkEditor module has been moved to contrib for Drupal 10 ( https://www.drupal.org/project/ckeditor → ). We should probably make the check more flexible to work with CkEditor 5 and the contrib module as well.

Steps to reproduce

  1. Enable the https://www.drupal.org/project/ckeditor → module
  2. Enable advagg module and aggregate JS
  3. Create some content with a CkEditor field, the field should be broken.

Proposed resolution

Make the check for the ckeditor.js more generic.

Remaining tasks

User interface changes

-

API changes

-

Data model changes

-

🐛 Bug report
Status

RTBC

Version

5.0

Component

Code

Created by

🇳🇱Netherlands seanB Netherlands

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Needs work over 1 year ago
  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    GasparM

    It works perfectly, thanks

  • First commit to issue fork.
  • Comment over 1 year ago →
    🇮🇳India urvashi_vora Madhya Pradesh, India

    I was facing the same issue with CKEditor and ADVAGG.

    Thanks for saving the struggle. Patch 3310388_6.patch worked perfectly.

    RTBC++

    Committing the patch #6 for helping the maintainers.

  • @urvashi_vora opened merge request.
  • Comment about 1 year ago →
    🇸🇮Slovenia joco_sp

    #6 worked. Thank you

  • Comment about 1 year ago →
    🇮🇳India raghwendra

    In version "6.0.0-alpha1" Advagg didn't see the code therefore not able to apply the patch. Any solutions ckeditor 5 and latest Advagg for Drupal 10 version ?

  • Comment 10 months ago →
    🇺🇸United States sleewok

    Yep, CKEditor is broken with 6.0.x-dev. If aggregation is enabled it will not load.

  • Comment 8 months ago →
    sd123

    Neither patch #2, nor the merge request seem to be working. I am using 6.0.0-alpha1 and Drupal 10.0.11 and have the following other patches active:

    "Deprecated function: Creation of dynamic property": "https://www.drupal.org/files/issues/2023-07-28/3375725-5.patch",
"Missing *.min.js.map files": "https://git.drupalcode.org/project/advagg/-/merge_requests/21.patch"
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024