Account created on 18 August 2013, over 11 years ago
#

Merge Requests

More

Recent comments

🇸🇮Slovenia joco_sp

In my case the #3 solution also worked.

🇸🇮Slovenia joco_sp

Thank you @adamps. The patch from https://www.drupal.org/project/exif_orientation/issues/3477919 🌱 Overall status Active worked for me using the 8.x-1.x-dev version.

🇸🇮Slovenia joco_sp

The patch worked for me for 8.x-1.7. Thank you.

🇸🇮Slovenia joco_sp

@tasc good suggestion. I added the filter and moved the more_text and less_text to it.

This is available in 3.0.0-alpha3.

I am keeping this task open, because I think it would be good to put also the other data to the filter.

🇸🇮Slovenia joco_sp

There was a problem with the usage of the variables in the Drupal.t() function, so I create the filter for that.
This is available in 3.0.0-alpha3.

🇸🇮Slovenia joco_sp

@julienvey what did you did so that the string was visible in the interface translation? Or how did you translate it?

🇸🇮Slovenia joco_sp

Thank you @Gmaheux.

This is now available in 3.0.0-alpha2

🇸🇮Slovenia joco_sp

This is a good suggestion for a new feature.

Currently the read more/less texts are defined in the CKEditor settings for the Text format and are the same everywhere. If we want to have different read more/less texts per element there is much more work to be done. The CKEditor5 plugin has to be rewritten to allow for editing the data-readmore-more-text and data-readmore-less-text per element.

I am keeping the issue open, because it would be a nice feature, but currently there is no plan to implement it. I am also adjusting the tile of the task, so that it reflects the proposed feature.

Relate issue https://www.drupal.org/project/ckeditor_readmore/issues/3225661 Configuration in field-values Active

🇸🇮Slovenia joco_sp

@Gmaheux thank you for the fixed. I removed toggler.classList.add(classes.replace(/ /g, ","));, because then the classes are duplicated. Is there a reason you added it?

🇸🇮Slovenia joco_sp

Thank you. Will be added to the next release.

🇸🇮Slovenia joco_sp

We're not using this module anymore, because it was too buggy. Instead we now use an external service.

🇸🇮Slovenia joco_sp

I tried the #2 on the 2.0.0-alpha5 version and it works.

As this is quite problematic if you refresh the page after you get the error, because it completely delete the node I agree with @andreasderijcke that this is a major issue. I am also changing the status back to RTBC.

🇸🇮Slovenia joco_sp

I don't know who is a tourist for you, but did you check the permissions for that role? There are many that can prevent non-admin users to use them.
Did you check if that user has the permission to use the Editable fields (see screenshot)? Or if the user can edit this entity? You also have the option to bypass the access for a dedicated field (see the screenshot).

🇸🇮Slovenia joco_sp

I like the "editablefields-popup-edit-link", so I added it. Of course it can be changed to whatever the maintainers prefer :)

🇸🇮Slovenia joco_sp

Example of the working widget. As I mentioned above, I had to change the "Select fallback display mode:" to "teaser".

I'm not sure what would be the best fix for the code. As a temporary solution I am creating a new display view for that mode with the wanted fields and selecting it as a fallback.

🇸🇮Slovenia joco_sp

When debugging the EditableFieldsFieldFormatter.php on line 230, it looks like it's going into a loop and if I comment out this whole part, the node is shown with the editable field.

// Popup version.
if ($this->getSetting('behaviour') === 'popup') {}

I think that the problem is in the return, because it is returning the same field on the same display and therefore it goes into a loop. If I change this to "teaser" it works. Now just the "Edit" link is displayed twice when I save the form in the popup.

🇸🇮Slovenia joco_sp

Thank you @andrew.wang, but in the meantime I found this module Keep referenced entities .

Before re-applying for Prevent term delete I would like to try out Keep referenced entities, because if it will work as expected, it will be even better for our case. I like it more that it covers all entities. If it won't work then I'll come back to this module.

🇸🇮Slovenia joco_sp

Thank you. It's added to 2.x. It will be available in the next release.

🇸🇮Slovenia joco_sp

As @Anas_maw mentioned, this was solved in the parent issue.

🇸🇮Slovenia joco_sp

Thank you all for the support.
I merged it with the 2.x branch and it will be available in the next release.

🇸🇮Slovenia joco_sp

Instead of

$time = (int) $time;

I added

$time = (float) $time;

otherwise you are getting the read time of 0 min. Additionally we could show also seconds, but this would be a new feature.

🇸🇮Slovenia joco_sp

Thank you @HeikkiY. I commited it to 2.x branch. It will be available in the next release.

🇸🇮Slovenia joco_sp

It will be available in the next release.

🇸🇮Slovenia joco_sp

@malcomio thank you for the support and wait. I used the solution from the related issue 🐛 I get an error when previewing a node. Fixed as it checks for the id sooner.

🇸🇮Slovenia joco_sp

Quite an old issue :D Thank you for your support.
I committed it do 2.x. It will be available in the next release.

🇸🇮Slovenia joco_sp

Thank you all for the support. I merged the patch #14. It will be available in the next release.

🇸🇮Slovenia joco_sp

@cmconklin thank you for expressing the interest to co-maintain the module. I added you :)

🇸🇮Slovenia joco_sp

@vishal.kadam thank you for the review.

I applied the fixes.

🇸🇮Slovenia joco_sp

Thank you @gisle. I contacted both maintainers and applied for security advisory policy.

🇸🇮Slovenia joco_sp

Thank you @andrew.wang. I opened a new one on the project's page Offering to maintain Prevent Term Delete 💬 Offering to maintain Prevent Term Delete Active .

🇸🇮Slovenia joco_sp

Hi @cmconklin did you apply for speeding up the deployment of your issue ( https://www.drupal.org/project/ckeditor_readmore/issues/3388400 CKEditor 5 Support Fixed ) or did you want to make more contributions to the module?

🇸🇮Slovenia joco_sp

Hello @apaderno.
Is there a chance that I can become the co-maintainer/maintainer of this module ( https://www.drupal.org/project/prevent_term_delete )? We are using it on some websites and for almost half a year we are running it with patches.

For the start I would like to make a Drupal 10 release and fix some other issues that are also tested and ready to be committed:
- https://www.drupal.org/project/prevent_term_delete/issues/3354210 📌 Automated Drupal 10 compatibility fixes RTBC
- https://www.drupal.org/project/prevent_term_delete/issues/3157733

I also contacted karthikeyan-manivasagam, but as you didn't have any luck getting his response, I decided to write also here. In case this can speed up the process and make it possible.

🇸🇮Slovenia joco_sp

Thank you. Then I am closing this as it is outdated.

🇸🇮Slovenia joco_sp

@cossovich thank you. This functionality is now in 3.x

🇸🇮Slovenia joco_sp

levmyshkin nice feature :)
As 2.x is deprecated, this has to be ported to 3.x

🇸🇮Slovenia joco_sp

PROMES are you still facing this issue? Did you uninstall it first or just removed it with composer remove?
We should test this on 3.x version, because 2.x is not supported anymore.

🇸🇮Slovenia joco_sp

I tried the solution, but it didn't work in the 3.x

🇸🇮Slovenia joco_sp

Libraries are solved in 3.x. If there is a problem with translation, please open another task or check if there is already one open on this subject.

🇸🇮Slovenia joco_sp

Thank you. I updated the description.

🇸🇮Slovenia joco_sp

Thank you all for the support! :)
I merged the code from #3388400 CKEditor 5 Support Fixed and created the 3.0.0-alpha1 release.

🇸🇮Slovenia joco_sp

Thank you all involved into making this possible!! :)
I merged it to the 3.x version and deployed it to the 3.0.0-alpha1. In that version, I also removed CKEditor4 files.

🇸🇮Slovenia joco_sp

Patch #25 worked for me on 8.x-3.1.
I didn't try the previous solutions, but all once error messages are gone and the popup is working again.

I am changing the priority to Major, because the bug makes the popup unusable.

🇸🇮Slovenia joco_sp

Hopefully I put the changes in the correct branches.

🇸🇮Slovenia joco_sp

The issue is still present. We have it on multiple websites. Core Drupal 10.2.2 and the module version 2.1.0. It's happening only for the anonymous users and on the production websites.

I managed to pintpoint the cause to the core aggregation of the JavaScript files.

Two solutions worked for me. Either attach the library to the head

default:
  version: VERSION
  header: true # Added
  js:
    js/obfuscate_email.js: {}
  dependencies:
    - core/drupal

or do not preprocess it

default:
  version: VERSION
  js:
    js/obfuscate_email.js: {preprocess: false} # Added
  dependencies:
    - core/drupal

I prefer the option to put it in the head.

🇸🇮Slovenia joco_sp

@micropat Thank you.
I can confirm, that the error message is not visible anymore. For the future will have it in mind and report the false positive directly on the form you mentioned.

🇸🇮Slovenia joco_sp

We applied the patch on multiple websites (also on version 10.2.2) and it seams that the patch solved that issue for us.

🇸🇮Slovenia joco_sp

@Vivek_Lnwebworks all are public.
Also, if you try the one drupalassociation you'll get the same output.

https://api.woxo.tech/instagram?source=drupalassociation

What alternatives to api.woxo.tech would you suggest?

Production build 0.71.5 2024