- Issue created by @chaseconklin
- First commit to issue fork.
- 🇧🇪Belgium matthijs
I created a MR from the patch + a few Drupal 10 related changes:
- The more and less texts are now translatable config
- Removed jQuery once dependency
- Removed CKEditor dependency
- Drupal 10 compatibility
It seems to be working fine for me, but I did not thoroughly code review the initial patch.
- First commit to issue fork.
- 🇺🇸United States asherry
I hope it's ok but I merged in the changes from 📌 Automated Drupal 10 compatibility fixes Needs review . I did this primarily because there was no composer.json file in this repo and it was already created there. I couldn't actually use the work here in composer until that was done.
Hopefully this will create less merge conflicts after that ticket is merged and then this one comes after.
Alternatively we might want to consider a 3.x branch and leave the 2.x branch to be compatible with Drupal 10 + ckeditor4.
- First commit to issue fork.
- 🇬🇧United Kingdom mattjones86 🇬🇧 GMT+0
Added
.toLowerCase()
because for some reasonelement.innerText
uses the CSS styled version.In our case our CSS styling was applying
text-transform: uppercase
and this was breaking the toggle. - Status changed to RTBC
10 months ago 12:52pm 18 January 2024 - 🇬🇧United Kingdom mattjones86 🇬🇧 GMT+0
Setting this to RTBC because I think it would be good to have a release out there.
Worked great for me.
- 🇺🇸United States imran1217
I tried MR changes as patch (https://git.drupalcode.org/project/ckeditor_readmore/-/merge_requests/4....) but its not getting applied on ckeditor_readmore (2.0.0)
- 🇬🇧United Kingdom mattjones86 🇬🇧 GMT+0
I think those numbers are misleading due to the default branch on the upstream still being set to
7.x-1.0
.https://git.drupalcode.org/issue/ckeditor_readmore-3388400/-/network/fea...
- Status changed to Fixed
8 months ago 6:29pm 27 March 2024 - 🇸🇮Slovenia joco_sp
Thank you all involved into making this possible!! :)
I merged it to the 3.x version and deployed it to the 3.0.0-alpha1. In that version, I also removed CKEditor4 files. - Status changed to Fixed
8 months ago 6:36pm 27 March 2024