πŸ‡ΊπŸ‡ΈUnited States @imran1217

Account created on 3 February 2020, almost 5 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States imran1217

Hi @ yce β†’ ,

Can you please elaborate on the 2nd step?

On pages where the layout builder is enabled, CKEditor5 fields are available only within blocks. Therefore, I provided an example of adding a text block that includes a body field, which allows you to embed videos.

Please refer attach screenshot for more details.

I've tried to add the video to ckeditor using the media module, but I only see the video's title, the player does not load at all.

Not sure what could be the reason but in my case it works fine.

However the script shouldn't run in the ckeditor anyway (on the node edit form), I would rather display the preview or thumbnail image in the editor instead, much safer. It may require some customization though.

I am already using this approach as a workaround and would like the Brightcove team to adjust the player script to work with CKEditor5 as well (on the node edit form).

Thanks!

πŸ‡ΊπŸ‡ΈUnited States imran1217

Re-roll of patch in #254 against facets version 2.0.9

πŸ‡ΊπŸ‡ΈUnited States imran1217

Thanks chandu7929, validated this MR changes and I can confirm this fixes the issue. Hence RTBC

πŸ‡ΊπŸ‡ΈUnited States imran1217

My bad, it was due to ckeditor_readmore β†’ . This can be close I will create issue in that module issue queue. Thanks for quick check.

πŸ‡ΊπŸ‡ΈUnited States imran1217

I have created MR by combining issue #3368736 changes here, and using this MR as patch everything is working fine.

"drupal/ckeditor5_font": {
                "3368736 - 'no config schema' Error": "https://git.drupalcode.org/project/ckeditor5_font/-/merge_requests/8.patch",
                "3350333 - TypeError: array_filter(): Argument #1 ($array) must be of type array": "https://www.drupal.org/files/issues/2023-04-21/3350333-5.patch"
            }
πŸ‡ΊπŸ‡ΈUnited States imran1217

Ah! it caused by one of the patch I am using : https://www.drupal.org/project/ckeditor5_font/issues/3368736 πŸ› Error after update to Drupal 10.1.0 Active need to fix there, I'll update it.

"drupal/ckeditor5_font": {
                "3368736 - 'no config schema' Error": "https://www.drupal.org/files/issues/2024-01-25/ckeditor5_font-schema-fix-3368736-40.patch",
                "3350333 - TypeError: array_filter(): Argument #1 ($array) must be of type array": "https://www.drupal.org/files/issues/2023-04-21/3350333-5.patch"
            }
πŸ‡ΊπŸ‡ΈUnited States imran1217

I have following sets of module enabled, getting same error. Is there a way we can disable that schema check unit it get fixed?

Modules

drupal/ckeditor5_font       1.1.2-beta1 Allows to control the text and background color directly inside the CKEditor 5 interface.
drupal/ckeditor5_fullscreen 1.0.0-beta8 A Fullscreen / Maximize button for CKeditor5
drupal/ckeditor5_template   1.0.7       Integrates the CKEditor 5 templates plugin.

Errors:

The website encountered an unexpected error. Try again later.

LogicException: The mapping definition at `ckeditor5.plugin.ckeditor5_list:properties` is invalid: its `label` key contains a string. It must be an array. in Drupal\Core\Config\Schema\Mapping->__construct() (line 38 of core/lib/Drupal/Core/Config/Schema/Mapping.php). 
πŸ‡ΊπŸ‡ΈUnited States imran1217

Thanks @RoSk0 patching symfony/framework-bundle fixes the issue.

πŸ‡ΊπŸ‡ΈUnited States imran1217

Update z-index value in MR please review.

πŸ‡ΊπŸ‡ΈUnited States imran1217

@occupant - I verified on both beta8 as well on dev branch but still other modal not appearing in full screen, but if I change the z-index value to 100 from 1000 I can see any other modal. See the attach screenshot

πŸ‡ΊπŸ‡ΈUnited States imran1217

I am able to apply the patch using MR (https://git.drupalcode.org/project/ckeditor_templates/-/merge_requests/4...) and has to run the following command.

composer require drupal/ckeditor_templates:1.2.0 --prefer-source

It seems to be working fine, I have manually re-created all the ckeditor4 templates to ckeditor5.

πŸ‡ΊπŸ‡ΈUnited States imran1217

Not able to apply patch from MR with any version of ckeditor_bootstrap_grid

πŸ‡ΊπŸ‡ΈUnited States imran1217

I am not able to apply patch from the MR since its 1 commit behind, I think we need rebase the MR.

πŸ‡ΊπŸ‡ΈUnited States imran1217

I tried MR changes as patch (https://git.drupalcode.org/project/ckeditor_readmore/-/merge_requests/4....) but its not getting applied on ckeditor_readmore (2.0.0)

πŸ‡ΊπŸ‡ΈUnited States imran1217

Can we have this merge and get the drupal 10 compatible releases?

πŸ‡ΊπŸ‡ΈUnited States imran1217

@imalabya - Can you please merge the MR and do the release?

πŸ‡ΊπŸ‡ΈUnited States imran1217

I tried the MR patch (https://git.drupalcode.org/project/saml_attributes_mapping/-/merge_reque...), but it didn't get applied. Though the patch ( https://www.drupal.org/files/issues/2023-10-06/d10-deprecation-fixes.patch β†’ ) gets applied cleanly, I think the MR need to be updated accordingly.

πŸ‡ΊπŸ‡ΈUnited States imran1217

Hi @jrglasgow
Adding core_version_requirement: ^8 || ^9 || ^10 in responsive_views_grid.info.yml file should be fine, The MR should contains this change.

πŸ‡ΊπŸ‡ΈUnited States imran1217

Can we have at least one release for Drupal 10?

πŸ‡ΊπŸ‡ΈUnited States imran1217

I think it already been reported and have merge in dev https://www.drupal.org/project/lang_dropdown/issues/3348277 πŸ› Fix TypeError: array_keys(): Argument #1 ($array) must be of type array, null given in Language Drop down Block class Fixed , do we have plan to release this?

Production build 0.71.5 2024