🇧🇪Belgium @Matthijs

Matthijs → created an issue.

Just to be clear: I meant when I created this module (3 years ago). At that time there were a few long-standing open issues with pending patches that I needed in all my projects because otherwise the module didn't work (at least not for Belgian numbers). And those patches didn't seem to get committed, even tough they were tested and reviewed by various people.

But I see both your modules have a recent release, so I was obviously wrong! And no need to apologize, we're all aware of how time consuming an issue queue can be. I don't think I ever reached out, I just started this module because I also had the requirement to format phone number in the DB for e.g. searching and exporting (unless I'm mistaken this wasn't/isn't supported by your modules?) and I didn't want to create a patch and had to maintain it for a long time until it got merged.

Anyhow, I agree that core should have at least some basic functionality regarding phone numbers, but I'm afraid this is never gonna happen since this will yet be another library requirement also needing maintenance.

Thanks!

Any news on this?

I started this module because because those two other modules were kinda broken/dead at that time (no clue what their current state is) + it felt kinda odd having two modules for these features.

Joining forces might be an option, but the most logical scenario would be that the other modules are deprecated and an upgrade path is provided. WDYT? Did you open an issue on the other 2 modules as well?

Thanks for reporting. I changed the constructor property promotion to old school arguments.

Matthijs → created an issue.

Since the embedded cache tag hashing tries to fix the same thing as #2952277 it would make sense to use the minificator from that issue. So the MR I opened removes the existing mechanism and uses the minificator service instead (and thus depends on the patch from #2952277).

Matthijs → made their first commit to this issue’s fork.

Thanks for the MR, it looks okay (I can't easily test it either), so I merged it.

We noticed a performance impact on our project due to this patch (the query took often 300-500ms) and decided to remove it.
As a safety (in case it ever gets merged) I converted the patch from #130 into an MR and added a config option to enable wildcard support.

I did not update any tests, these might still need changes.

Matthijs → made their first commit to this issue’s fork.

Patch applied and comitted, thanks!

Changing the project after 2 weeks as described on https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →

Project link: https://www.drupal.org/project/cache_debug →

Forgot to mention this, but before creating this issue I also contacted Josh Waihi via his profile to ask the same thing.

Hi,

Good news, this module ain't dead! I just consider it feature-complete (as stated on the home page) and since I don't have any projects using it I did not make is D10 compatible.

That said, I do fillow-up the queue for any new issues and try to repond within an appropriate time, but my effort will be limited to reviewing and merging. E.g. in the case of #264483 I asked to rework the hook into an event and use DI where applicable.

I will try tot review your D10/11 compatibily patch later this or next week.

PS: the other maintainers are no longer actively involved, I developed and maintain the D8+ version.

Matthijs → created an issue.

Matthijs → created an issue.

Created a new one especially for you ;-)

Changes merged, thanks for your contribution.

Matthijs → created an issue.

It should be usable everywhere, the only requirement is a valid oidc session.

Since the cache ID is actually cached, the $vary_headers passed to \Drupal\page_cache\StackMiddleware\PageCache::getCacheId() actually did nothing.

I created a merge request from #2430335-194: Browser language detection is not cache aware → and did some changes to cache the cache ID by $vary_headers.

Matthijs → made their first commit to this issue’s fork.

Matthijs → created an issue.

Great!

I prefer not to do that because in that case a value of "000000" will be considered empty as well.

I did a small change, can you check if the latest dev version fixes your issue?

I cannot reproduce this on PHP 8.1.26, but I think this might happen if the default value is applied. So i'm wondering:

• Is the element actually rendered?
• Is it fixed if you change the #default_value in \Drupal\signaturefield\Element\Signature::getInfo() to an empty string?

Patch committed, thanks for the effort!

I'm not familiar with the Code Challenge Method, so I had to look it up. It would seem logical that this should be an option + your patch contains a hardcoded challenge, which is not ok.

Thanks for your merge request!

I'm not a big fan constructor property promotion since it causes mixed casing for class properties, so please change that as well.

Glad you git it fixed!

Can you check if the sop/jwx package is properly installed andere can be autoloaded?
It's in the composer dependencies, but it seems missing in your installation.
It's this class that can't be autoloaded: https://github.com/sop/jwx/blob/master/lib/JWX/JWT/JWT.php

I created an MR that uses the processed text and truncates the HTML without removing/breaking HTML tags or entities.

Matthijs → made their first commit to this issue’s fork.

@recrit Thanks. It didn't want to change to the MR because I wasn't sure if the issue was caused by my custom code and existed for others as well.

Might be related to my custom code, but I noticed that with #93 the ajax event handler is bound multiple times. This happens because `this.$exposed_form` contains all forms. I fixed this by replacing `this.$exposed_form` with a constant and added the form as argument to the `attachExposedFormAjax` function.

Matthijs → created an issue.

Thanks for your report.

This module uses the default validation handling (e.g. https://git.drupalcode.org/project/telephone_advanced/-/blob/1.x/src/Plu...), so this message is themed by your theme. I suggest you open an issue in that project, since I cannot fix it here.

I can confirm the patch fixes the issue.

Replied in the threads. I would suggest to fix these last 3 issues, then it's RTBC.

Drupal 10 with CKEditor 5 support can be found in #3388400.

I created a MR from the patch + a few Drupal 10 related changes:

• The more and less texts are now translatable config
• Removed jQuery once dependency
• Removed CKEditor dependency
• Drupal 10 compatibility

It seems to be working fine for me, but I did not thoroughly code review the initial patch.

Matthijs → made their first commit to this issue’s fork.

Matthijs → created an issue.

Matthijs → created an issue.

Patch applied and committed, thanks!

I personally don't think changing the functions outcome is a problem since it's not a class method, but if you do I suggest to move my changes to a new function, use that everywhere and adjust the existing function to call the new one and return a value in the same format as before.
WDYT?

This MR changes the return of saml_sp_authn_context_class_refs() and adds an alter hook.

Matthijs → created an issue.

As a simple solution I added the _maintenance_access option to the required routes, but we might want to add an IdP specific configuration toggle for this?

Matthijs → created an issue.

Patch applied + applied some more changes + committed. Thanks!

Patch applied and committed, thanks!

You can find my complete code attached. Please note that I extracted this from a project without testing.

@weseze: maybe update the merge request as well with your change to AddSectionToLibraryForm.

Fixed the a notice due to the none-existing AuthenticateEvent::$cancel_main_authentication property.

@Jaypan I guess you mean #19, I added it to the view render element using hook_element_info_alter().

/**
 * Implements hook_element_info_alter().
 */
function my_module_element_info_alter(array &$info): void {
  array_unshift($info['view']['#pre_render'], [ViewElement::class, 'preRenderElement']);
}

Matthijs → created an issue.

I noticed this fix was (probably unintentionally) reverted by the changes for #3356242?

Matthijs → created an issue.

The PR changes the maxlength of the label textfield to 50 instead of altering the field definition like the patch does.
I've hidden the patch because it deletes all existing entities during the update hook, which looks dangerous to me.

Matthijs → made their first commit to this issue’s fork.

I was gonna open an MR to fix this, but a fix was already committed.

Matthijs → made their first commit to this issue’s fork.

Thanks for the patch. It appears the static analysis didn't find all Drupal 10 compatibility issyes, sorry for that!

Thanks for the patch, committed to 2.x

I just found another cause for this issue: if your content to be indexed contains a view element, \Drupal\views\ViewExecutable::getExposedInput() will try to start a session (and thus send headers) to restore the stored exposed filters.

I refactored my workaround described in #3274158-3: RuntimeException while trying to render item → to fix this and ended up with a pre render callback to set the exposed filters:

public static function preRenderElement(array $element): array {
  if (!static::getSearchApiStatus()->isIndexing()) {
    return $element;
  }

  // Initialize the exposed filters so Views won't start the session.
  // @see \Drupal\views\ViewExecutable::getExposedInput()
  /** @var \Drupal\views\ViewExecutable $view */
  $view = $element['#view'];
  $view->initDisplay();
  $view->setExposedInput(['' => '']);

  // Disable render caching.
  $element['#cache']['max-age'] = 0;

  return $element;
}

The branch was already D10 compatible, but for some reason Drupal.org didn't create a new dev version.
I just created release 1.0.2, which is D10 compatible.

Fixed, thanks for mentioning! Will merge asap, but wanted to do some testing first. Unless you tested it already?

Changed some class names, added an interface for the validator and fixed some code styles issues.

I extended the patch from #2979223-57: Add option to show current search string in facet summary → with the fix from 🐛 Facets with ajax enabled and no source path results in /views/ajax?f... urls RTBC

Matthijs → made their first commit to this issue’s fork.

Matthijs → made their first commit to this issue’s fork.

A similar issue exists for the contact preferences and interests (I presumed the latter, didn't test/verified it). The MR resolves this.

Matthijs → made their first commit to this issue’s fork.

Responded in MR.

Thanks for your MR. That's a useful feature indeed, but I added some remarks/toughts to the MR.

Nothing to be honest, I just forgot I didn't create a Drupal 10 compatible release yet... So just created one now!

Matthijs → created an issue.

Thanks for your MR! I like the idea, but I did some tests with the getLocale() method (since I didn't know that one) and for me it always returned "en" even though I was browsing the site in Dutch (nl).
Wouldn't it be better to store the current language in the state, so we can rely on that instead of the request object?

Matthijs → created an issue.

Giving the canvas a width of 100% would result in signature images of various widths (since the image is as wide as the canvas).
This may give some unwanted side effects, so I'd propose to allow an admin to specify the width in % and thus explicitly enable this behavior. I'd keep the height as a required and fixed value, not sure why you suggest it would become optional?

Added missing return types for Migrate Plus 6.x compatibility