Contrib.social

Attach tags via a Purge plugin rather than emitting tag header directly

Open on Drupal.org →
Created on 21 May 2021, over 3 years ago
Updated 18 October 2024, 2 months ago

Problem/Motivation

This module currently attaches cache tags directly, in an event subscriber. But the Purge module allows us to provide a plugin. Doing it this way will allow us to play more nicely in the Purge ecosystem, reduce custom code, and make it easier to benefit from work like this ✨ Minify the cache tags sent in the header Needs work .

📌 Task
Status

Needs review

Version

5.0

Component

Code

Created by

🇺🇸United States azinck

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 2 months ago →
    🇺🇸United States jastraat

    Re-rolled for 5.x. This should be used in combination with the purge patch that minifies headers.

  • @jastraat opened merge request.
  • Comment about 2 months ago →
    🇺🇸United States moshe weitzman Boston, MA

    LGTM. Unfortunate that we need to wait for that dependency. Meanwhile, is there any testing we can add? Any upgrade path?

  • Comment about 2 months ago →
    🇺🇸United States jastraat

    I don't believe there's an upgrade path needed; when I tested after applying the patch the cache tags were simply updated to the shorter versions in the header.

    I believe this patch could be applied separately from the purge patch however. It just wouldn't have the benefits of a shorter edge cache tag header without the purge patch.

    I agree that tests would be a good addition; we could update the existing tests to not look for the removed subscriber..?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024