🇺🇸United States @moshe weitzman

I think that Drush command makes sense.

moshe weitzman → created an issue.

I dont see the benefit of using a custom logger here. I suggest removing the logger related code from the constructor and create().

Boldly upping priority because these headers are a foundational part of perf improvement on all Drupal sites.

The way I read catch's reply, I think this can be closed.

I have used this on Acquia in the past. Any plan should work there. I installed this module recently on a non-acquia site and it worked well. You will have to debug.

Ah right, ignore that. ddev-selenium-standalone-chrome recently got a release to start using the W3C proptocol. Perhaps try upgrading to latest release there. And make sure your drupal/core is up to date.

WHats your version of drupal/core-dev? Some googling suggested you must be very recent on your webdriver packages.

This docs improvement looks pretty helpful and not controversial.

smustgrave → credited moshe weitzman → .

Sorry for the delay. We'll need some more info in order to know what change might be needed.

Answering the question with a question: Where do we document events that modules can subscribe to? Service tags that modules can implement? Plugins that modules can implement?

Ugh. When an Attribute is read (via reflection), it throws a fatal when the constant is undefined This is why we cant have nice things.

Totally agree with this. I am not worried about a couple hundred constant definitions in a large codebase. *.api.php files are a Drupalism that should be on its way out IMO.

Thanks. Would the DA consider a less conservative approach which is to open the API, and then close off endpoints when/if a problem arises. I know this is a slightly riskier path but it comes with significant velocity gains for the project IMO.

This would be interesting for the ECA ecosystem, I think.

Bump. Within the docs component, this is critical.

Would still be helpful

Seems like a serious issue. I'd like to move this to the queue component because claimItem() bugs affect non-cron queues as well. Alas I dont think that component exists.

Hi all. Lots of good discussion here. I'm happy to discuss and hopefully find a way for this ecosystem to build on top of ddev-drupal-contrib (I'm the maintainer).

The latest MR from @lussoluca looks great to me.

I think .ai-get-module could go into ddev-drupal-contrib in some fashion. Maybe it becomes `ddev poser require`. If no second argument is provided, we assume install for backwards compat with current poser. Until then, its fine for ai-get-module to live in this module.

Drush ran into this. The fix for us was to allow phpunit 11 in our require-dev.

I 100% agree about removing Doxygen that adds nothing.

I agree that this is valuable beyond just core. Today I need it for drush site:install - https://github.com/drush-ops/drush/issues/6310.

moshe weitzman → changed the visibility of the branch 3535184-use-autowire-in to hidden.

moshe weitzman → created an issue.

We managed to finally make progress here via 📌 Slowly, very slowly start OOPifying the render system Needs review . IMO this issue is so outdated it can be closed.

LGTM

See the Contributing section of README - use `ddev poser`.

Tests fixed just now. gitlab_templates had changed its MINK_ARGS env var name

moshe weitzman → made their first commit to this issue’s fork.

I pushed a few changes. The module_installer in setUp() is get the error Error: Call to undefined method Drupal\Core\ProxyClass\Extension\ModuleInstaller::moduleExists(). So thats commented out for now. The new test passes on my machine. Please confirm that Chrome is doing what its supposed to do.

Still not sure whats up with Selenium Chrome.

Parent is in.

No objection here. Looks nice and small.

I'm unsure if the phpunit fails are due to this PR or not. It was working two months ago - https://git.drupalcode.org/project/dtt/-/pipelines

Added on d.o.

Let me klnow if more is needed.

All feedback addressed. Back to RTBC.

MR looks good to me. I am not too familiar with fibers but the comments do a decent job of explaining why this is needed ... There is currently a test failure in Drupal\Tests\demo_umami\FunctionalJavascript\OpenTelemetryFrontPagePerformance

xjm → credited moshe weitzman → .

Drupal Commerce has a similar need. When you buy a product, it should be frozen in time, and not subject to future edits. I’m not sure if they solve this by refusing. Worth a look.

In general this proposal makes sense to me. There are.a couple downsides. Namely teachers Can’t easily fix typos in a course and have that affect students in progress. Same for scoring. Also we could see revision bloat similar to what happens on sites that use paragraphs module.

I'm seeing these entries taking up quite a lot of space in the key_value table. Are these entries a sort of cache? If so, maybe we could communicate that better by using key_value_expirable? I dont care how long the expiration time is - just that these rows are safe to truncate.

SELECT SUM(LENGTH(value)) as sum,collection FROM key_value GROUP BY collection ORDER BY sum DESC;

1689040	pathauto_state.user
1225681	entity.definitions.installed
952891	entity.storage_schema.sql
883792	pathauto_state.media
607280	pathauto_state.node
158688	media
133320	pathauto_state.taxonomy_term
76369	entity.update_backup
48466	state
46668	update_fetch_task
36336	entity.definitions.bundle_field_map
31820	config.entity.key_store.field_config
31354	post_update

I've reviewed this a few times and its ready IMO. Great work especially to @ghost of drupal past and @nicxvan

phenaproxima → credited moshe weitzman → .

dww → credited moshe weitzman → .

My site experienced this as well. After updating the code, and running drush deploy, we had this error. Running drush cache:rebuild after the deployment resolved the issue so I'm not able to invest time in finding the root cause.

Great to see this Roadmap.

Some nice to have (if applicable):

1. Use SDC
2. Integrate a top level menu item into Navigation module (maybe this is done automatically)

I'm curious about this as well.

moshe weitzman → created an issue.

I wish Drupal would make an API for stuff like this. Then callers like drush twig:debug would be isolated from implementation changes. Raw key-value is not enough of an API.

Why bother with deprecation? The method does not nearly do the job. Anyone who tried to use it would know that.

I'm not sure if you are referring to an admin creating a profile in the UI, or creating a user in the UI. I'm referring to creating a user.

Creating a user as an admin has the effect that the newly created profile is not marked as default because the admin is the owner and thus \Drupal\profile\Entity\Profile::preSave thinks that a profile already exists. This is the code that leads to a wrong value of default - https://git.drupalcode.org/project/profile/-/blob/8.x-1.x/src/Entity/Pro...

See https://www.drupal.org/project/dtt/issues/3436284 🐛 DTT can use different cached container than running site causing issues with testing Fixed for complications from this approach. I’m not sure about the header proposal.

I’ll be there. Somehow I’m still doing the Drupal!

Thanks so much for kicking this off.

Bump priority since its woefully out of date.

I wrote a patch for datalayer module that might be a helpful model - https://www.drupal.org/project/datalayer/issues/3345817 🐛 Pages are uncacheable because of the cache context user Fixed

Since D7 is now EOL, I think this is Wont Fix.

socialnicheguru, I am not seeing this in current Group module (3.3.3). Leaving as RTBC.

g4mbini → credited moshe weitzman → .

Yes, that was it.

I dont know how feasible it is, but it would be great if the content installed by the demo_umami install profile would look great when rendered by this theme.

1. The article list shows images but the hyperlkinks to detail pages are broken
2. Article detail pages look messy

These issues are probably not this theme's concern, but here I am so I mention it.

Fresh install. Here are all the versions

asm89/stack-cors                         v2.2.0            Cross-origin resource sharing library and stack middleware
chi-teck/drupal-code-generator           4.1.0             Drupal code generator
composer/installers                      v2.3.0            A multi-framework Composer library installer
composer/semver                          3.4.3             Semver library that offers utilities, version constraint parsing an...
consolidation/annotated-command          4.10.1            Initialize Symfony Console commands from annotated command class me...
consolidation/config                     3.1.0             Provide configuration services for a commandline tool.
consolidation/filter-via-dot-access-data 2.0.2             This project uses dflydev/dot-access-data to provide simple output ...
consolidation/log                        3.1.0             Improved Psr-3 / Psr\Log logger based on Symfony Console components.
consolidation/output-formatters          4.6.0             Format text by applying transformations provided by plug-in formatt...
consolidation/robo                       5.1.0             Modern task runner
consolidation/site-alias                 4.1.1             Manage alias records for local and remote sites.
consolidation/site-process               5.4.2             A thin wrapper around the Symfony Process Component that allows app...
dflydev/dot-access-data                  v3.0.3            Given a deep data structure, access data by dot notation.
doctrine/annotations                     2.0.2             Docblock Annotations Parser
doctrine/deprecations                    1.1.4             A small layer on top of trigger_error(E_USER_DEPRECATED) or PSR-3 l...
doctrine/lexer                           2.1.1             PHP Doctrine Lexer parser library that can be used in Top-Down, Rec...
drupal/core                              11.1.2            Drupal is an open source content management platform powering milli...
drupal/core-composer-scaffold            11.1.2            A flexible Composer project scaffold builder.
drupal/core-project-message              11.1.2            Adds a message after Composer installation.
drupal/core-recommended                  11.1.2            Core and its dependencies with known-compatible minor versions. Req...
drupal/ui_icons                          1.1.0-beta3       The UI Icons module is a generic icon manager for Drupal.
drupal/ui_patterns                       2.0.0-rc2         Define and expose self-contained UI components and use them seamles...
drupal/ui_skins                          1.1.0-alpha3      Allow handle some theme settings like CSS variables.
drupal/ui_styles                         1.15.0            Define styles from modules and themes.
drupal/ui_styles_block                   1.15.0            Apply styles to blocks in the block layout.
drupal/ui_suite_daisyui                  dev-4.0.x 33f226b A site-builder friendly DaisyUI theme, using the UI Suite modules.
drush/drush                              13.3.3            Drush is a command line shell and scripting interface for Drupal, a...
egulias/email-validator                  4.0.3             A library for validating emails against several RFCs
grasmash/expander                        3.0.1             Expands internal property references in PHP arrays file.
grasmash/yaml-cli                        3.2.1             A command line tool for reading and manipulating yaml files.
guzzlehttp/guzzle                        7.9.2             Guzzle is a PHP HTTP client library
guzzlehttp/promises                      2.0.4             Guzzle promises library
guzzlehttp/psr7                          2.7.0             PSR-7 message implementation that also provides common utility methods
illuminate/collections                   v11.41.3          The Illuminate Collections package.
illuminate/conditionable                 v11.41.3          The Illuminate Conditionable package.
illuminate/contracts                     v11.41.3          The Illuminate Contracts package.
illuminate/macroable                     v11.41.3          The Illuminate Macroable package.
justinrainbow/json-schema                5.3.0             A library to validate a json schema.
laravel/prompts                          v0.1.25           Add beautiful and user-friendly forms to your command-line applicat...
league/container                         4.2.4             A fast and intuitive dependency injection container.
masterminds/html5                        2.9.0             An HTML5 parser and serializer.
mck89/peast                              v1.16.3           Peast is PHP library that generates AST for JavaScript code
nikic/php-parser                         v5.4.0            A PHP parser written in PHP
pear/archive_tar                         1.5.0             Tar file management class with compression support (gzip, bzip2, lz...
pear/console_getopt                      v1.4.3            More info available on: http://pear.php.net/package/Console_Getopt
pear/pear-core-minimal                   v1.10.16          Minimal set of PEAR core files to be used as composer dependency
pear/pear_exception                      v1.0.2            The PEAR Exception base class.
phootwork/collection                     v3.2.3            The phootwork library fills gaps in the php language and provides b...
phootwork/lang                           v3.2.3            Missing PHP language constructs
php-tuf/composer-stager                  v2.0.0            Stages Composer commands so they can be safely run on a production ...
phpowermove/docblock                     v4.0              PHP Docblock parser and generator. An API to read and write Docblocks.
psr/cache                                3.0.0             Common interface for caching libraries
psr/container                            2.0.2             Common Container Interface (PHP FIG PSR-11)
psr/event-dispatcher                     1.0.0             Standard interfaces for event handling.
psr/http-client                          1.0.3             Common interface for HTTP clients
psr/http-factory                         1.1.0             PSR-17: Common interfaces for PSR-7 HTTP message factories
psr/http-message                         2.0               Common interface for HTTP messages
psr/log                                  3.0.2             Common interface for logging libraries
psr/simple-cache                         3.0.0             Common interfaces for simple caching
psy/psysh                                v0.12.7           An interactive shell for modern PHP.
ralouphie/getallheaders                  3.0.3             A polyfill for getallheaders.
revolt/event-loop                        v1.0.6            Rock-solid event loop for concurrent PHP applications.
sabberworm/php-css-parser                v8.7.0            Parser for CSS Files written in PHP
sebastian/diff                           5.1.1             Diff implementation
symfony/console                          v7.2.1            Eases the creation of beautiful and testable command line interfaces
symfony/dependency-injection             v7.2.3            Allows you to standardize and centralize the way objects are constr...
symfony/deprecation-contracts            v3.5.1            A generic function and convention to trigger deprecation notices
symfony/error-handler                    v7.2.3            Provides tools to manage errors and ease debugging PHP code
symfony/event-dispatcher                 v7.2.0            Provides tools that allow your application components to communicat...
symfony/event-dispatcher-contracts       v3.5.1            Generic abstractions related to dispatching event
symfony/filesystem                       v7.2.0            Provides basic utilities for the filesystem
symfony/finder                           v7.2.2            Finds files and directories via an intuitive fluent interface
symfony/http-foundation                  v7.2.3            Defines an object-oriented layer for the HTTP specification
symfony/http-kernel                      v7.2.3            Provides a structured process for converting a Request into a Response
symfony/mailer                           v7.2.3            Helps sending emails
symfony/mime                             v7.2.3            Allows manipulating MIME messages
symfony/polyfill-ctype                   v1.31.0           Symfony polyfill for ctype functions
symfony/polyfill-iconv                   v1.31.0           Symfony polyfill for the Iconv extension
symfony/polyfill-intl-grapheme           v1.31.0           Symfony polyfill for intl's grapheme_* functions
symfony/polyfill-intl-idn                v1.31.0           Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions
symfony/polyfill-intl-normalizer         v1.31.0           Symfony polyfill for intl's Normalizer class and related functions
symfony/polyfill-mbstring                v1.31.0           Symfony polyfill for the Mbstring extension
symfony/polyfill-php81                   v1.31.0           Symfony polyfill backporting some PHP 8.1+ features to lower PHP ve...
symfony/polyfill-php83                   v1.31.0           Symfony polyfill backporting some PHP 8.3+ features to lower PHP ve...
symfony/process                          v7.2.0            Executes commands in sub-processes
symfony/psr-http-message-bridge          v7.2.0            PSR HTTP message bridge
symfony/routing                          v7.2.3            Maps an HTTP request to a set of configuration variables
symfony/serializer                       v7.2.3            Handles serializing and deserializing data structures, including ob...
symfony/service-contracts                v3.5.1            Generic abstractions related to writing services
symfony/string                           v7.2.0            Provides an object-oriented API to strings and deals with bytes, UT...
symfony/translation-contracts            v3.5.1            Generic abstractions related to translation
symfony/validator                        v7.2.3            Provides tools to validate values
symfony/var-dumper                       v7.2.3            Provides mechanisms for walking through any arbitrary PHP variable
symfony/var-exporter                     v7.2.0            Allows exporting any serializable PHP data structure to plain PHP code
symfony/yaml                             v7.2.3            Loads and dumps YAML files
twig/twig                                v3.19.0           Twig, the flexible, fast, and secure template language for PHP

ui icons is 1.1.0-beta3

The error happens on any page. Some more site info in case its helpful

Drupal version   : 11.1.2
Site URI         : https://my-drupal-site.ddev.site
DB driver        : mysql
DB hostname      : db
DB port          : 3306
DB username      : db
DB name          : db
Database         : Connected
Drupal bootstrap : Successful
Default theme    : ui_suite_daisyui
Admin theme      : claro
PHP binary       : /usr/bin/php8.3
PHP config       : /etc/php/8.3/cli/php.ini
PHP OS           : Linux
PHP version      : 8.3.14
Drush script     : /var/www/html/vendor/bin/drush.php
Drush version    : 13.3.3.0
Drush temp       : /tmp
Drush configs    : /var/www/html/vendor/drush/drush/drush.yml
Install profile  : standard
Drupal root      : /var/www/html/web
Site path        : sites/default
Files, Public    : sites/default/files
Files, Temp      : /tmp

I'm just experimenting with all the new toys. Not urgent.

moshe weitzman → created an issue.

When files are remote (S3fs, stage file proxy), it makes even less sense to for Drupal to fetch them and send a StreamedResponse. Could we use the code from #5 just for remote files? Then a different issue could discuss using a redirect for local files.

Updated the MR and now using the Issue summary template.

May I gently suggest that when we ask to use the issue summary template, we don't also switch to Needs Work just for that reason. Its more important to fix a bug than it is to use the official template.

moshe weitzman → made their first commit to this issue’s fork.

The LRU cache finally landed in Drupal core (see related issues). It is likely that migrate can remove its memory handling as a result.

Also, it sometimes takes a tall wall of Attributes to specify a command. That wall gets unnecessarily wide if you need a full namespace in every line. That would be so tedious to read.

I apologize for chiming in at the end here. The interaction looks awkward to me. Specifically, there are 3 areas involved. The toolbar with the green Live, the expanding header where you begin the workspace selection. And then confirm dialog. This is a lof of jumping. Did we consider doing this all in one expanding menu, and doing away with the confirm dialog? Its not actually destructive to change your workspace. Its just your personal view of the content.

Please disregard this comment if the team disagrees,.

add command name

This has kinda been discussed in the gitlab_templates queue. https://www.drupal.org/project/infrastructure/issues/3445532 🐛 Random HTTP timeouts for GitLab CI jobs Active

This would be hard for this module to get right. I suggest scheduling that entity_reference_revisions pruning drush command to run periodically.

I vote for a release ... We can deal with bug reports as they arrive.

Given that code review looks good, and automated tests are passing with this MR, I think we should merge and release. Or at least merge.

Made 1 fix to the MR. Now RTBC

moshe weitzman → made their first commit to this issue’s fork.

Any chance we can roll a D11 compatible release?

FWIW, I would not be surprised if automatic cron took some time to run, after it gets installed. In other words, I think it would be fine if it did nothing at install time. Its OK that module information would be unavailable for a bit.

mcdruid → credited moshe weitzman → .

was merged

composer ignores require-dev except for the root composer.json. So the effect of this addition is for this module's testing of itself and nothing more.

Devel maintainer here - thanks for doing this. I'm sure folks will like it. is there any way we could make the list of links in the new menu configurable? Thats what I was hoping for by building upon the Development menu. That way folks could use the menu UI to customize.

Merged a while ago

moshe weitzman → made their first commit to this issue’s fork.

That got merged into 11 and 10.4 so closing this. Please reopen if I am mistaken.

phpunit calls this PreConditions. Drupal module requirements have install time check as well.

4,x no longer maintained except major issues

Fixed a while ago

LGTM. Unfortunate that we need to wait for that dependency. Meanwhile, is there any testing we can add? Any upgrade path?

I wonder why tests are green even before this change.