Bump priority since its woefully out of date.
I wrote a patch for datalayer module that might be a helpful model - https://www.drupal.org/project/datalayer/issues/3345817 🐛 Pages are uncacheable because of the cache context user Fixed
Since D7 is now EOL, I think this is Wont Fix.
socialnicheguru, I am not seeing this in current Group module (3.3.3). Leaving as RTBC.
g4mbini → credited moshe weitzman → .
Yes, that was it.
I dont know how feasible it is, but it would be great if the content installed by the demo_umami install profile would look great when rendered by this theme.
- The article list shows images but the hyperlkinks to detail pages are broken
- Article detail pages look messy
These issues are probably not this theme's concern, but here I am so I mention it.
Fresh install. Here are all the versions
asm89/stack-cors v2.2.0 Cross-origin resource sharing library and stack middleware
chi-teck/drupal-code-generator 4.1.0 Drupal code generator
composer/installers v2.3.0 A multi-framework Composer library installer
composer/semver 3.4.3 Semver library that offers utilities, version constraint parsing an...
consolidation/annotated-command 4.10.1 Initialize Symfony Console commands from annotated command class me...
consolidation/config 3.1.0 Provide configuration services for a commandline tool.
consolidation/filter-via-dot-access-data 2.0.2 This project uses dflydev/dot-access-data to provide simple output ...
consolidation/log 3.1.0 Improved Psr-3 / Psr\Log logger based on Symfony Console components.
consolidation/output-formatters 4.6.0 Format text by applying transformations provided by plug-in formatt...
consolidation/robo 5.1.0 Modern task runner
consolidation/site-alias 4.1.1 Manage alias records for local and remote sites.
consolidation/site-process 5.4.2 A thin wrapper around the Symfony Process Component that allows app...
dflydev/dot-access-data v3.0.3 Given a deep data structure, access data by dot notation.
doctrine/annotations 2.0.2 Docblock Annotations Parser
doctrine/deprecations 1.1.4 A small layer on top of trigger_error(E_USER_DEPRECATED) or PSR-3 l...
doctrine/lexer 2.1.1 PHP Doctrine Lexer parser library that can be used in Top-Down, Rec...
drupal/core 11.1.2 Drupal is an open source content management platform powering milli...
drupal/core-composer-scaffold 11.1.2 A flexible Composer project scaffold builder.
drupal/core-project-message 11.1.2 Adds a message after Composer installation.
drupal/core-recommended 11.1.2 Core and its dependencies with known-compatible minor versions. Req...
drupal/ui_icons 1.1.0-beta3 The UI Icons module is a generic icon manager for Drupal.
drupal/ui_patterns 2.0.0-rc2 Define and expose self-contained UI components and use them seamles...
drupal/ui_skins 1.1.0-alpha3 Allow handle some theme settings like CSS variables.
drupal/ui_styles 1.15.0 Define styles from modules and themes.
drupal/ui_styles_block 1.15.0 Apply styles to blocks in the block layout.
drupal/ui_suite_daisyui dev-4.0.x 33f226b A site-builder friendly DaisyUI theme, using the UI Suite modules.
drush/drush 13.3.3 Drush is a command line shell and scripting interface for Drupal, a...
egulias/email-validator 4.0.3 A library for validating emails against several RFCs
grasmash/expander 3.0.1 Expands internal property references in PHP arrays file.
grasmash/yaml-cli 3.2.1 A command line tool for reading and manipulating yaml files.
guzzlehttp/guzzle 7.9.2 Guzzle is a PHP HTTP client library
guzzlehttp/promises 2.0.4 Guzzle promises library
guzzlehttp/psr7 2.7.0 PSR-7 message implementation that also provides common utility methods
illuminate/collections v11.41.3 The Illuminate Collections package.
illuminate/conditionable v11.41.3 The Illuminate Conditionable package.
illuminate/contracts v11.41.3 The Illuminate Contracts package.
illuminate/macroable v11.41.3 The Illuminate Macroable package.
justinrainbow/json-schema 5.3.0 A library to validate a json schema.
laravel/prompts v0.1.25 Add beautiful and user-friendly forms to your command-line applicat...
league/container 4.2.4 A fast and intuitive dependency injection container.
masterminds/html5 2.9.0 An HTML5 parser and serializer.
mck89/peast v1.16.3 Peast is PHP library that generates AST for JavaScript code
nikic/php-parser v5.4.0 A PHP parser written in PHP
pear/archive_tar 1.5.0 Tar file management class with compression support (gzip, bzip2, lz...
pear/console_getopt v1.4.3 More info available on: http://pear.php.net/package/Console_Getopt
pear/pear-core-minimal v1.10.16 Minimal set of PEAR core files to be used as composer dependency
pear/pear_exception v1.0.2 The PEAR Exception base class.
phootwork/collection v3.2.3 The phootwork library fills gaps in the php language and provides b...
phootwork/lang v3.2.3 Missing PHP language constructs
php-tuf/composer-stager v2.0.0 Stages Composer commands so they can be safely run on a production ...
phpowermove/docblock v4.0 PHP Docblock parser and generator. An API to read and write Docblocks.
psr/cache 3.0.0 Common interface for caching libraries
psr/container 2.0.2 Common Container Interface (PHP FIG PSR-11)
psr/event-dispatcher 1.0.0 Standard interfaces for event handling.
psr/http-client 1.0.3 Common interface for HTTP clients
psr/http-factory 1.1.0 PSR-17: Common interfaces for PSR-7 HTTP message factories
psr/http-message 2.0 Common interface for HTTP messages
psr/log 3.0.2 Common interface for logging libraries
psr/simple-cache 3.0.0 Common interfaces for simple caching
psy/psysh v0.12.7 An interactive shell for modern PHP.
ralouphie/getallheaders 3.0.3 A polyfill for getallheaders.
revolt/event-loop v1.0.6 Rock-solid event loop for concurrent PHP applications.
sabberworm/php-css-parser v8.7.0 Parser for CSS Files written in PHP
sebastian/diff 5.1.1 Diff implementation
symfony/console v7.2.1 Eases the creation of beautiful and testable command line interfaces
symfony/dependency-injection v7.2.3 Allows you to standardize and centralize the way objects are constr...
symfony/deprecation-contracts v3.5.1 A generic function and convention to trigger deprecation notices
symfony/error-handler v7.2.3 Provides tools to manage errors and ease debugging PHP code
symfony/event-dispatcher v7.2.0 Provides tools that allow your application components to communicat...
symfony/event-dispatcher-contracts v3.5.1 Generic abstractions related to dispatching event
symfony/filesystem v7.2.0 Provides basic utilities for the filesystem
symfony/finder v7.2.2 Finds files and directories via an intuitive fluent interface
symfony/http-foundation v7.2.3 Defines an object-oriented layer for the HTTP specification
symfony/http-kernel v7.2.3 Provides a structured process for converting a Request into a Response
symfony/mailer v7.2.3 Helps sending emails
symfony/mime v7.2.3 Allows manipulating MIME messages
symfony/polyfill-ctype v1.31.0 Symfony polyfill for ctype functions
symfony/polyfill-iconv v1.31.0 Symfony polyfill for the Iconv extension
symfony/polyfill-intl-grapheme v1.31.0 Symfony polyfill for intl's grapheme_* functions
symfony/polyfill-intl-idn v1.31.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions
symfony/polyfill-intl-normalizer v1.31.0 Symfony polyfill for intl's Normalizer class and related functions
symfony/polyfill-mbstring v1.31.0 Symfony polyfill for the Mbstring extension
symfony/polyfill-php81 v1.31.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP ve...
symfony/polyfill-php83 v1.31.0 Symfony polyfill backporting some PHP 8.3+ features to lower PHP ve...
symfony/process v7.2.0 Executes commands in sub-processes
symfony/psr-http-message-bridge v7.2.0 PSR HTTP message bridge
symfony/routing v7.2.3 Maps an HTTP request to a set of configuration variables
symfony/serializer v7.2.3 Handles serializing and deserializing data structures, including ob...
symfony/service-contracts v3.5.1 Generic abstractions related to writing services
symfony/string v7.2.0 Provides an object-oriented API to strings and deals with bytes, UT...
symfony/translation-contracts v3.5.1 Generic abstractions related to translation
symfony/validator v7.2.3 Provides tools to validate values
symfony/var-dumper v7.2.3 Provides mechanisms for walking through any arbitrary PHP variable
symfony/var-exporter v7.2.0 Allows exporting any serializable PHP data structure to plain PHP code
symfony/yaml v7.2.3 Loads and dumps YAML files
twig/twig v3.19.0 Twig, the flexible, fast, and secure template language for PHP
ui icons is 1.1.0-beta3
The error happens on any page. Some more site info in case its helpful
Drupal version : 11.1.2
Site URI : https://my-drupal-site.ddev.site
DB driver : mysql
DB hostname : db
DB port : 3306
DB username : db
DB name : db
Database : Connected
Drupal bootstrap : Successful
Default theme : ui_suite_daisyui
Admin theme : claro
PHP binary : /usr/bin/php8.3
PHP config : /etc/php/8.3/cli/php.ini
PHP OS : Linux
PHP version : 8.3.14
Drush script : /var/www/html/vendor/bin/drush.php
Drush version : 13.3.3.0
Drush temp : /tmp
Drush configs : /var/www/html/vendor/drush/drush/drush.yml
Install profile : standard
Drupal root : /var/www/html/web
Site path : sites/default
Files, Public : sites/default/files
Files, Temp : /tmp
I'm just experimenting with all the new toys. Not urgent.
moshe weitzman → created an issue.
When files are remote (S3fs, stage file proxy), it makes even less sense to for Drupal to fetch them and send a StreamedResponse. Could we use the code from #5 just for remote files? Then a different issue could discuss using a redirect for local files.
Updated the MR and now using the Issue summary template.
May I gently suggest that when we ask to use the issue summary template, we don't also switch to Needs Work just for that reason. Its more important to fix a bug than it is to use the official template.
moshe weitzman → made their first commit to this issue’s fork.
The LRU cache finally landed in Drupal core (see related issues). It is likely that migrate can remove its memory handling as a result.
Also, it sometimes takes a tall wall of Attributes to specify a command. That wall gets unnecessarily wide if you need a full namespace in every line. That would be so tedious to read.
I apologize for chiming in at the end here. The interaction looks awkward to me. Specifically, there are 3 areas involved. The toolbar with the green Live, the expanding header where you begin the workspace selection. And then confirm dialog. This is a lof of jumping. Did we consider doing this all in one expanding menu, and doing away with the confirm dialog? Its not actually destructive to change your workspace. Its just your personal view of the content.
Please disregard this comment if the team disagrees,.
This has kinda been discussed in the gitlab_templates queue. https://www.drupal.org/project/infrastructure/issues/3445532 🐛 Random HTTP timeouts for GitLab CI jobs Active
This would be hard for this module to get right. I suggest scheduling that entity_reference_revisions pruning drush command to run periodically.
I vote for a release ... We can deal with bug reports as they arrive.
Given that code review looks good, and automated tests are passing with this MR, I think we should merge and release. Or at least merge.
Made 1 fix to the MR. Now RTBC
moshe weitzman → made their first commit to this issue’s fork.
Any chance we can roll a D11 compatible release?
FWIW, I would not be surprised if automatic cron took some time to run, after it gets installed. In other words, I think it would be fine if it did nothing at install time. Its OK that module information would be unavailable for a bit.
mcdruid → credited moshe weitzman → .
was merged
composer ignores require-dev except for the root composer.json. So the effect of this addition is for this module's testing of itself and nothing more.
Devel maintainer here - thanks for doing this. I'm sure folks will like it. is there any way we could make the list of links in the new menu configurable? Thats what I was hoping for by building upon the Development menu. That way folks could use the menu UI to customize.
Merged a while ago
moshe weitzman → made their first commit to this issue’s fork.
That got merged into 11 and 10.4 so closing this. Please reopen if I am mistaken.
phpunit calls this PreConditions. Drupal module requirements have install time check as well.
4,x no longer maintained except major issues
Fixed a while ago
LGTM. Unfortunate that we need to wait for that dependency. Meanwhile, is there any testing we can add? Any upgrade path?
I wonder why tests are green even before this change.
moshe weitzman → created an issue.
Thanks. Once we have ✨ Directory based automatic service creation Needs review , we could add the RegisterListenersPass compiler pass and then get #[AsListener] classes registered as services and listeners. I'm not sure the intermediate step in this MR provides much value. If others think so, feel free to mark this RTBC.
Actually, I am wondering why we have both:
- A service is declared in core.services.yml for maintenance_mode_subscriber
- Various #[EventListener] appear on various methods on the same file. Wouldn't the nicer usage be to omit the yml declared service and rely on Attribute based creation of Listeners? The MR suggests that all we are saving is the getSubscribedEvents() method. I had higher hopes than that :). Maybe we need more plumbing elsewhere in core for what I describe.
This hasn't run since the switch to Gitlab 3 months ago. A bunch of D11 compat went in.
The ddev contrib plugin requires users to run `ddev poser` instead of composer install/update. that ensures a composer.json is present. See the readme for more info.
I reviewed the code and the draft CR. LGTM. Nice work.
📌 Replace ContainerAwareEventDispatcher with Symfony EventDispatcher Fixed was merged. Changing status per the most recent comments. Please update to a different status as needed.
That test approach sounds reasonable to me. Its OK that it may occasionally need updating if default batch size changes, and so on.
I dont see any library. I'd say we should truncate and keep the rightmost info in the url. The hostname is never useful.
Good idea. Followup created at https://www.drupal.org/project/dtt/issues/3477088 ✨ Implementing a PHPUnit\Event\Test\FinishedSubscriber that checks for conditions to fail the test Active . This MR is now merged.
moshe weitzman → created an issue.
Code is now removed.
Did you read my comment? We dont need to replace a use statement if its code is no longer needed.
Do we still need to call mutateBase? Maybe this code can be removed.
Sounds good. Maybe there is code out there that makes urls shorter in a smart way that saves useful information.
This got merged.
LGTM. Anyone object?
Thanks. Seems like there is nothing left to do in DTT. All our users will get this feature automatically when they upgrade to Drupal 11.1+. Before then, they can use https://gitlab.com/weitzman/logintrait
Drops Drupal 9 support as thats long EOL. This can be avoided if maintainers really prefer.
moshe weitzman → created an issue.
moshe weitzman → created an issue.
FYI, devel's tests started failing after this merge. Its not clear to me why, since devel uses lazy builders. https://gitlab.com/drupalspoons/devel/-/issues/541.
moshe weitzman → created an issue.
Superceded by https://www.drupal.org/project/entity_reference_revisions/issues/3474265 📌 Modernize Drush integration Needs review
moshe weitzman → created an issue.
Looks great.
Maybe add a line to composer.json to assure the commands keep working when folks upgrade votingapi.
"conflict": {
"drush/drush": "<12.5.1",
}
Agree with most of the proposed resolution. My thoughts:
- Move long form texts to a new /docs folder in core (and contrib). The folder contains markdown files. Publish the docs via mkdocs or any other static site generator (SSG) that core prefers. mkdocs is the the SSG behind DDEVand Drush docs. We already support this in our Gitlab templates. Benefits:
- Once we are fully on Gitlab, it becomes super friendly to non devs and lazy devs to submit an MR via the Gitlab UI to change the docs.
- Docs can change along with code
- Docs automatically vary by branch.
- Retire the api module and use Doctum or similar external project to generate our API docs. We can start with Drupal 12, and keep the API module docs as more or less static for older versions.
LGTM.
That issue is now fixed so this one is too.
$ composer require weitzman/drupal-test-traits --dev -vvv
...
Installs: weitzman/drupal-test-traits:2.3.1
- Downloading weitzman/drupal-test-traits (2.3.1)
Downloading https://git.drupalcode.org/api/v4/projects/project%2Fdtt/repository/archive.zip?sha=5e3df23c93f4f3e4f34fd7677df10bc06616f4ce
I've come across this too when testing the Drush site:install command on sqlite.
IMO this is beyond the scope of this project. I suggest finding some code on Gitlab or elsewhere for this and adding a custom job.
moshe weitzman → created an issue.
moshe weitzman → created an issue.
moshe weitzman → created an issue.
moshe weitzman → created an issue.
moshe weitzman → created an issue.
Would be helpful if someone tried this MR with Drush recipe command - https://www.drush.org/13.x/commands/recipe/. Drush just includes the symfony command from Drupal as is so hopefully it works fine. Testing would be to make sure recipe options appear in command help and can be used successfully.
Released
I just created a release there for 2.3.1 and its been packaged. The Gitlab Packagist integration doesn't report any communication with packagist.org in its logs so this issue persists. I think we need to follow https://www.drupal.org/project/project_composer/issues/3464712 ✨ Regression: RC releases have empty dist information Needs work for updates.
Note that is affects DTT as well - https://git.drupalcode.org/project/dtt/. We just moved to drupal.org for project hosting and it would be nice to have dist downloads instead of git clone.
Would it make sense to try to serve these projects from the packages.drupal.org endpoint, and not rely on packagist? Or maybe some other way to avoid being recognized as a Gitlab repo type?
I've seen that too, for many years. Its frustrating. I did some experimenting and a possible fix for this is indeed to make releases in Gitlab, instead of just tags. That causes downloads of URLs like https://gitlab.com/api/v4/projects/weitzman%2Flogintrait/repository/arch... for the project https://gitlab.com/weitzman/logintrait. Unfortunately drupalcode.org prohibits making Gitlab releases. I get 404 at https://www.drupal.org/project/dtt/releases/new →
I found https://www.drupal.org/project/project_composer/issues/3464712 ✨ Regression: RC releases have empty dist information Needs work which looks very related.
I'm happy with the MR as is. Feel free to merge it when you are satisfied.
This was merged
hestenet → credited moshe weitzman → .
The other option is to remove drush as a dependency. Its implied. For same reason, we should remove the dependency on drupal/core IMO.
Was merged separately
IMO this is outdated at this point.
merged. thanks.
That sounds like a feature request for Pantheon (if their workarounds are not sufficient). Acquia and Platform support setting env variables, as do things like .htaccess and nginx config.
Like I said, DotEnv is really made for local development, so all this talk of web hosting demonstrates how people will be confused if this goes in. If people really want this feature, its a composer require away.
I could easily see us taking the base added here and doing a lot of special things in follow-ups. Like injecting the DB credentials for the primary/default DB automatically. Or providing an env variable override process for settings and config. But the base logic/support would be needed first.
I'm totally on board with settings.php honoring env variables. IMO thats the first part to do, not the last.
What I have seen is that .env files are helpful for local development, and less so for staging and prod servers which have other means of writing env variables. Given that we have standardized on DDEV for local dev, which already support setting env variables from config or .env files, do we really need this? The OP was written in an age before Docker based local dev.
It seems like the additional tests are not coming quickly. Would maintainers consider fixing the bug without tests? Otherwise we are forcing everyone to live with a bug because we are worried that the bug might return one day.