Unable to use --repeat since Drupal 10.3

Open on Drupal.org →

Created on 22 August 2024, 2 months ago

Problem/Motivation

Repeating tests fails with the following error:

Drupal\Tests\moduleName\ExistingSite\ExampleTest::testLlama
Behat\Mink\Exception\ElementNotFoundException: Element matching xpath "//form[@id='user-logout-confirm']" not found.

This seems to be due to changes in core around the user logout process. If the user is not logged in the logout confirm form is not shown. But the underlying issue is that we're not resetting the user session in tear down.

Steps to reproduce

phpunit tests/ExampleTest.php --repeat=2

Proposed resolution

Add $this->loggedInUser = false;, or alternatively $this->drupalResetSession(), to ::tearDownDrupal

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Needs review

Component

Code

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!9Unable to use --repeat since Drupal 10.3
Merged
🇦🇺Australia mstrelan
updated 2 months ago

Comments & Activities

Issue created by @mstrelan
Merge request !9Reset loggedInUser → (Merged) created by mstrelan
Status changed to Needs review 2 months ago2:55am 22 August 2024
Comment 2 months ago →
🇦🇺Australia mstrelan
Comment 2 months ago →
🇦🇺Australia acbramley
Nice catch!

This property is defined in UiHelperTrait, this may cause issues if the 2 traits don't exist on a test class right? (Although I don't know if that situation is realistic)
Comment 2 months ago →
🇦🇺Australia mstrelan
Possibly core should do this, but I'm not sure if core has the same problem. I guess we could check if the property exists.
Comment about 1 month ago →
🇺🇸United States moshe weitzman Boston, MA
This got merged.
Comment 21 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024