Add trait for setting temporary config values

Open on Drupal.org →

Created on 27 May 2024, 7 months ago

Problem/Motivation

Sometimes we want to set config values for a test and restore them afterwards. In fact, we already do this in MailCollectionTrait.

Steps to reproduce

Proposed resolution

Add ConfigTrait
Move MailCollectionTrait::$originalConfiguration to ConfigTrait
Add ::setConfigValues() and ::restoreConfigValues to ConfigTrait
Refactor MailCollectionTrait::startMailCollection and MailCollectionTrait::startMailSystemCollection to use ConfigTrait::setConfigValues
Refactor MailCollectionTrait::restoreMailSettings to use ConfigTrait::restoreConfigValues

Remaining tasks

Test coverage

User interface changes

API changes

Added ConfigTrait
MailCollectionTrait now makes use of ConfigTrait

Data model changes

✨ Feature request

Status

Active

Component

Code

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!5Add trait for setting temporary config values
Merged
🇦🇺Australia mstrelan
updated 3 months ago

Comments & Activities

Issue created by @mstrelan
Merge request !5Add ConfigTrait → (Merged) created by mstrelan
Status changed to Needs work 7 months ago4:29am 27 May 2024
Comment 7 months ago →
🇦🇺Australia mstrelan
NW for tests but would be happy to get feedback
Status changed to RTBC 4 months ago8:22pm 10 August 2024
Comment 4 months ago →
🇺🇸United States moshe weitzman Boston, MA
I'm happy with the MR as is. Feel free to merge it when you are satisfied.
Status changed to Fixed 2 months ago12:38am 22 October 2024
Comment 2 months ago →
🇦🇺Australia mstrelan
This was released in 2.4.0
Comment about 2 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024