- Issue created by @catch
- First commit to issue fork.
- Merge request !7299Issue #3437162: Move twig_debug and other development toggles into raw key/value β (Closed) created by plopesc
- Status changed to Needs review
9 months ago 8:32am 3 April 2024 - πͺπΈSpain plopesc Valladolid
Twig debug and related development toggles from "Development settings" page moved to raw key value storage as part of the MR.
- Status changed to Needs work
9 months ago 11:27am 3 April 2024 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to Needs review
9 months ago 12:11pm 3 April 2024 - πͺπΈSpain plopesc Valladolid
Conflicts resolved and tests are green again. Back to NR.
- Status changed to RTBC
9 months ago 10:27pm 4 April 2024 - πΊπΈUnited States smustgrave
So tested this one out by applying the MR locally and still using the new development setting for debugging
From what I can tell everything remained the same.
Refactoring appears fine to me.
- Status changed to Needs work
9 months ago 10:45pm 4 April 2024 - π¨πSwitzerland berdir Switzerland
Thanks for working on this.
The update function should also delete those keys then from state.
Not sure if we should do a change record just in case someone wrote some custom code related to these keys or used drush sset in their workflow.
- Status changed to Needs review
9 months ago 5:50am 5 April 2024 - πͺπΈSpain plopesc Valladolid
Thank you for your feedback.
Obsolete state keys are removed as part of the post_update hook.
Created change record draft: https://www.drupal.org/node/3438802 β - Status changed to RTBC
9 months ago 1:38pm 5 April 2024 - πΊπΈUnited States smustgrave
Deletion from state has been added
Reviewed the CR and it reads well. Always get a huge thank you for adding before/after examples
- Status changed to Fixed
9 months ago 7:23am 8 April 2024 - π¬π§United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks! I have to resolve a couple of merge conflicts on the 10.3.x cherry-pick. Straightforward enough but let's hope they actually were (had to add an extra commit for one thing already).
Automatically closed - issue fixed for 2 weeks with no activity.