Clean up services, add autowiring, make use of new features, and fix deprecations

Open on Drupal.org →

Created on 16 May 2024, 7 months ago

Problem/Motivation

This issue resolves to make use of new features, and fix deprecations.

Add Autowiring aliases so we can autowire Purge services into our own project services — https://www.drupal.org/node/3323122 →
Switch to Logger injection via autoconfiguration — https://www.drupal.org/node/3395436 →
Switch to event subscriber autoconfiguration so we dont need to add tags. — https://www.drupal.org/node/3357408 →
DiagnosticsService and TagsHeadersService make use of the ContainerAwareTrait/Interface which is deprecated and being removed. The usage of this is exclusively for "lazy-loading" the services. We can switch to service closures in order to keep this lazy behaviour. — https://www.drupal.org/node/3360604 →

Proposed resolution

The proposed changes require Drupal 10.2, which in a few weeks will be the lowest supported version of Drupal. So we can up the Purge project minimums.

Update services.yml and add appropriate infrastructure to make use of new features

The changes here introduce no new behaviours.

Remaining tasks

Review, test, commit

User interface changes

None

API changes

Changes to some service constructors
Changes to internals of our services that wouldnt be expected to be modified downstream or have an API contract.

Data model changes

Nil.

📌 Task

Status

Active

Version

3.5

Component

Code

Created by

🇦🇺Australia dpi Perth, Australia

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!41Clean up services, add autowiring, make use of new features, and fix deprecations
Open
🇦🇺Australia dpi
updated 6 months ago

Comments & Activities

Issue created by @dpi
Merge request !41Clean up services, add autowiring, make use of new features, and fix deprecations → (Open) created by dpi
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
last update 7 months ago
121 pass, 87 fail
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
last update 7 months ago
121 pass, 87 fail
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: php8.3_mysql8_ignore
last update 7 months ago
215 pass, 78 fail
Comment 7 months ago →
🇺🇸United States japerry KVUO
Thanks for looking at this, as it will be required for D11 compatibility. I've added this issue to our internal D11 tracker as well.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
last update 6 months ago
121 pass, 87 fail
Comment 2 months ago →
🇺🇸United States moshe weitzman Boston, MA
This hasn't run since the switch to Gitlab 3 months ago. A bunch of D11 compat went in.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024