Also finding that adding asset on a List, where not all components have an asset with that asset name, an error is shown.
As a part of this we should be able to validate whether a file truly exists, and add it conditionally.
Maybe consider adding a param to Asset attr that can ignore non existent files, or throw errors on missing files (default).
Of course, otherwise the Asset attr can be added to individual components/enum-case rather than an asset-attr thats echo'ed from the top of an enum.
We'll do it outside of BCA for now, but may revisit due to need for a flexible weighting system.
Theres been discussions of if or how to scan vendor for plugins before, I dont have references on hand.
I think core would want to look at composer autoload namespace and directories and scan them; whereas the change here is a simple list of which classes to include. No directory scans.
For selfish reasons I dont really have time on hand to look through core, as this is very much a side thing of what I'm working on for PNX. I'd prefer a quick merge but otherwise will advise to use a patch in the meantime.
container.namespaces includes only Drupal extensions.
The desire for this issue is to include classes defined in vendor.
Tests can be arranged if we can agree on implementation/direction.
Cred for auto-invoke idea.
e67ead44 includes integration for 0.2.0 except for Asset globs, which need more time as I found typical issues related to how Drupal libraries are relative to app root, and the generic local asset attributes, Css and Js, don't know how to find files (unless they are absolute).
Deferred and will be integrated independently, after probably more abstraction work in dpi/pinto lib @ ✨ Add support for Asset globs Active
For SMS Framework v4, the topics discussed here can be achieved with https://comms.docs.contrib.social/sms/verification/code-generator
For SMS Framework v4, the topics discussed here can be achieved with https://comms.docs.contrib.social/sms/verification/conditional
Project is obsolete now that SMS Framework provides support for services, including Clickatell.
Project is obsolete now that SMS Framework provides support for services, including Clickatell.
Project is obsolete now that SMS Framework provides support for services, including Clickatell.
Project is obsolete now that SMS Framework provides support for services, including Clickatell.
Project is obsolete now that SMS Framework provides support for services, including Clickatell.
Project is obsolete now that SMS Framework provides support for services, including Clickatell.
Project is obsolete now that SMS Framework provides support for services, including Clickatell.
dpi → created an issue. See original summary → .
dpi → created an issue. See original summary → .
I'd like to understand the pain point a little better. Why not use put things in Hooks/ namespace and let it all get registered for you? That way you don't need to put anything in any services file?
Is there a particular reason why that doesnt work for you? Are you using services.yml for some reason?
Manually tagging services and adding to the yml files is something I consider to be a very rare occurrence, not business-as-usual.
Latest rework for SMS Framework depends on this change to invert how verifications work.
dpi → created an issue. See original summary → .
The rearchitected version of the project, as an integration of Notifier, has been pushed to v4.
Thanks, I'm finding this produces silly errors in my 11.1 builds also.
Added feedback to MR, otherwise this is a nice quick fix.
Closing per 🌱 [policy] Announcing closure of 3.x issues if they are not applicable for V4 Active .
Reports are not a concept that exists in future versions of SMS Framework.
Is this because the exception is caught in the code above SmsProcessor in the queue runner? Drush, etc?
Perhaps SmsProcessor should catch and swallow SmsStorageException, or event better, an even narrower exception extending that?
I'm not sure if we can change the behaviour at this point.
For now I'm closing this issue in the name of 🌱 [policy] Announcing closure of 3.x issues if they are not applicable for V4 Active , however if a patch is devised with the rework I'll consider it. But the changes will not apply to the new versions of SMS Framework, only these legacy version.s
Nothing new since you last posted this, either ;) 💬 Integration with ECA, http://drupal.org/project/eca Active
I dont think that'll happen.
Also #2712599-3: [meta] Rules integration →
This functionality shouldnt need to be implemented in the core sms project.
@socialnicheguru v11 and greater. You can see a WIP set of code at https://git.drupalcode.org/project/smsframework/-/merge_requests/35
The enabling/disabling of a verification depending on the entity and phone number context via event is implemented via \Drupal\sms\PhoneNumberVerification\Event\EntityPhoneNumberVerification::$shallSendVerification in v4.
The code component is no longer necessary as there is a specific service for that. Entity and phone number are provided as context.
Closing per 🌱 [policy] Announcing closure of 3.x issues if they are not applicable for V4 Active
Seems verifications shouldnt be sent unless phone numbers change
https://git.drupalcode.org/project/smsframework/-/blob/3.0.x/src/Provide...
Closing as outdated, the code for this will change again in v4, but may be relevant. Open a bug ticket with a resolution if it still applies.
Another duplicate issue was created later @ ✨ Mandatory phone number verification Needs work , there has been more discussion there over time.
Closing this one as a result
This feature will not exist in future versions, 🌱 [policy] Announcing closure of 3.x issues if they are not applicable for V4 Active .
These systems are reworked for v4 🌱 [policy] Announcing closure of 3.x issues if they are not applicable for V4 Active .
Much of this is being reworked.