breaks if no composer.json is present on the module?

Also added https://github.com/ddev/ddev-drupal-contrib/issues/79

Thanks for reporting this. I would be surprised if the changes made in 💬 Inform jobs about the "composer" job exit status and bail out early Active actually cause this problem, it could have been a problem before.

Please can you link to the pipeline that fails, so we can investigate.

It's definitely an issue in the "ddev" contrib plugin, so there is no issue here. Thanks for creating the issue in the other queue as well.

We already account for the case when there is no composer.json file here: https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes...

      if [[ -f composer.json ]]; then
        cp composer.json composer.json.backup
      else
        echo "{}" > composer.json
      fi

Excellent, I will fix it on ddev then.

I think what 💬 Inform jobs about the "composer" job exit status and bail out early Active made was for this to fail silently on ddev.

The ddev contrib plugin requires users to run `ddev poser` instead of composer install/update. that ensures a composer.json is present. See the readme for more info.

@moshe weitzman thanks! I read the readme and I run `ddev poser` and failed! It was what prompted this issue

PR added to https://github.com/ddev/ddev-drupal-contrib/pull/80 - thanks all!

In response to #5

I think what #3471235: Inform jobs about the "composer" job exit status and bail out early made was for this to fail silently on ddev.

If the changes made in that issue did cause a silent fail, when it was not a silent fail before, then that needs to be addressed from the gitlab side. Can you show a pipeline from before that change, when no composer.json causes a noisy (that is, not silent) fail in a pipeleine. Then we can investigate.

Sorry if I am adding something without an actual live error. I didn't see this on a pipeline, I saw it on ddev. I guess you wouldn't see a fail on a missing composer.json file because of what was explained to me on #4.

But ddev-drupal-contrib addon tries to emulate gitlab ci and uses the same script so that's why I thought I should at least mention this. But honestly, it maybe a non issue for gitlab ci.

I saw the account for no composer.json was added/updated on ✨ Preserve original composer.json in the modules directory Fixed .