- Issue created by @mstrelan
- Merge request !9269Issue #3469309: Use one-time login link instead of user login form in BrowserTestBase tests → (Closed) created by mstrelan
- Status changed to Needs work
11 months ago 11:20pm 20 August 2024 - 🇦🇺Australia mstrelan
Locally I have
\Drupal\Tests\block_content\Functional\BlockContentListTest
passing but it looks like there are lots of fails in other tests. - Status changed to Needs review
11 months ago 3:52am 21 August 2024 - 🇦🇺Australia mstrelan
Well that was fun. There are three tests remaining that use the login form. One is the UserLoginTest, so we need to keep that. The other two seem to be oddities that could probably be fixed, perhaps in a followup.
It's hard to evaluate if this is overall faster than before because there is such variability in the test suite times. I did see one run that was under five minutes. In my local testing I found a saving of around 200ms per login. So that's roughly 5 mins total savings over 1500 logins.
- Status changed to Needs work
10 months ago 6:11pm 29 August 2024 - 🇺🇸United States smustgrave
Follow ups appear to be mentioned in the threads.
- Status changed to Needs review
10 months ago 10:15pm 29 August 2024 - 🇦🇺Australia mstrelan
- Remove the duplicate
::userPassResetUrl
method and updated the existinguser_pass_reset_url
function to use current time as discussed with @catch in Slack. - Updated
UserLoginTest::testLoginCacheTagsAndDestination
to explicitly submit the login form instead of relying on::drupalLogin
- Added 📌 Placeholder follow-up for 3469309 Postponed
- Remove the duplicate
- 🇺🇸United States smustgrave
So have re-ran twice and keep getting failures, but not entirely sure why.
- Status changed to RTBC
10 months ago 2:04pm 30 August 2024 - 🇺🇸United States smustgrave
Nice. Believe feedback has been addressed. The one thread wasn't sure about
- Status changed to Fixed
10 months ago 10:10pm 6 September 2024 - 🇫🇷France nod_ Lille
Committed and pushed bf4ae81164 to 11.x and 39f2b9f40b to 11.0.x and b16714a919 to 10.4.x and 332f671c2d to 10.3.x. Thanks!
- 🇫🇷France nod_ Lille
LocaleTranslationUiTest fails on 11.0.x, 10.4.x, and 10.3.x
- Status changed to Downport
10 months ago 11:01pm 6 September 2024 - 🇦🇺Australia mstrelan
We can probably add
protected bool $useOneTimeLoginLinks = FALSE;
to the failing test.
- Status changed to Needs review
10 months ago 12:21am 7 September 2024 - Status changed to RTBC
10 months ago 1:57pm 9 September 2024 - 🇺🇸United States smustgrave
11.0 appears to be passing
Was confused for a second why 11.0 but see that 11.x wasn't reverted
- Status changed to Fixed
10 months ago 2:49pm 9 September 2024 - 🇫🇷France nod_ Lille
Committed and pushed 104f82857d to 11.0.x and b868899be1 to 10.4.x and 47614c4759 to 10.3.x. Thanks!
- Status changed to Needs work
10 months ago 6:48am 17 September 2024 - 🇳🇱Netherlands daffie
LocaleTranslationUiTest fails on 11.x with PostgreSQL!
Setting the priority to critical.
- 🇦🇺Australia mstrelan
I won't get to this for a bit, but see #17 and 21 and apply this to 11.x, it was already applied to the other branches.
- Merge request !9513Resolve #3469309 "Fix for localetranslationuitest on postgresql" → (Closed) created by daffie
- Status changed to Fixed
10 months ago 9:11am 17 September 2024 - 🇬🇧United Kingdom catch
I've cherry-picked
104f8285
forwards to 11.x, tentatively marking fixed but please re-open if there's still a problem. Automatically closed - issue fixed for 2 weeks with no activity.