- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-127659These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.9
- palantirnet/drupal-rector: 0.20.1
- 🇺🇸United States John Franklin
There is one patch from Project Update Bot to replace a call to
file_save_data()
that is already in the 3.x branch. The other items cited are deprecations against OpenID Connect itself. Near as I can tell, all that needs to be done to be Drupal 11 ready is to tag this module as such in the .info.yml file. (So far as we can tell at the Drupal 11.0-alpha1 point, anyway.) This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-199781These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.3
- First commit to issue fork.
- 🇦🇺Australia acbramley
acbramley → changed the visibility of the branch project-update-bot-only to hidden.
- 🇦🇺Australia acbramley
acbramley → changed the visibility of the branch 3433705-automated-drupal-11 to hidden.
- 🇦🇺Australia acbramley
I've rolled updates against 3.x and attempted to fix all the phpunit deprecations. The following failures need to be investigated (I've tried but these are extremely complicated unit tests so I'm not sure if I've broken something or something has changed):
1.
OpenIDConnectTest::testCompleteAuthorization
- only the 4th test case is failing. This is because preAuthorize is set to FALSE which means none of the config gets mocked.
2.OpenIDConnectTest::testConnectCurrentUser
- All test cases are failing here because for some reason the email is getting set twice. I tried to debug this but have no idea why this is happening. - Status changed to Needs work
3 months ago 1:04am 10 September 2024 - 🇦🇺Australia mstrelan
I did some debugging for
OpenIDConnectTest::testCompleteAuthorization
in Drupal 10.3.x with a breakpoint in\Drupal\openid_connect\OpenIDConnect::completeAuthorization
. In the 3.x branch the$context
variable isFALSE
so we never try to access the config, so never get the fail, but in the branch for this MR the context is an array with the account object set. I'll dig a little deeper as to why that might be different. - 🇦🇺Australia mstrelan
Further debugging found that in
\Drupal\openid_connect\OpenIDConnect::buildContext
the invocation ofopenid_connect_pre_authorize
yields different results between branches. In 3.x it returns an array but in this branch it returns NULL. So most likely one of the changes towithConsecutive
has broken this test. - 🇺🇸United States BenStallings
I can't vouch for all of the functionality, but I was able to enable the module in Drupal 11 without error.
- First commit to issue fork.
-
jcnventura →
committed 772f39b1 on 3.x authored by
acbramley →
Issue #3433705 by project update bot, mstrelan, acbramley, benstallings...
-
jcnventura →
committed 772f39b1 on 3.x authored by
acbramley →
- 🇺🇸United States pmagunia Philadelphia 🇺🇸
It looks like an Entity Query is being made without an AccessCheck:
- 🇦🇺Australia mstrelan
@pmagunia probably best to open a separate issue for that. Left feedback regardless.
- 🇵🇹Portugal jcnventura
Let's keep this here, it makes no sense now to move this back to "Fixed".
- 🇺🇸United States pmagunia Philadelphia 🇺🇸
Thanks @mstrelan.
I just corrected my previous commit.
-
jcnventura →
committed 1c1f25f3 on 3.x authored by
pmagunia →
Issue #3433705 by mstrelan, pmagunia, jcnventura: Add missing access...
-
jcnventura →
committed 1c1f25f3 on 3.x authored by
pmagunia →
- Status changed to Fixed
about 1 month ago 10:19am 21 November 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- 🇺🇸United States moshe weitzman Boston, MA
Any chance we can roll a D11 compatible release?