Thank you for the background, @joachim. Given that, it sounds like "works as designed" is a more appropriate status for this ticket.
@anybody I resolved the merge conflict, but I do not find any parent classes of these classes that specify return types. If you know of one that is relevant to this ticket, please let me know which one you're referring to. Thanks!
@anybody only if the parent classes support it. I didn't look into these specifically, but my experience has been that defining a return type in a child class's method can make it incompatible with the parent's method, so I didn't mess with that, I just addressed the phpstan warnings.
OK, with the patch for #3541582 applied to jsonapi_extras, this should work now!
@dieterholvoet it occurred with the body field, a plain text field, and a list field.
OK, I've taken this on... unfortunately it can't be fixed solely within this module. I've opened a ticket in jsonapi_extras module to add the necessary context, and once we have a MR for that, I'll update this ticket with an MR. https://www.drupal.org/project/jsonapi_extras/issues/3541582 ✨ pass context in ContentEntityDenormalizer Active
benstallings → created an issue.
I am also having this problem after upgrade. The patch from #3540426 hides the red asterixes appropriately, but the fields are still required to submit the form when they should not be.
Here's another clue that might help: If I edit the field, I see that the required strategy is set to Required by Role and everything looks good. But if I click the Core strategy, it shows the field is required. (This agrees with the config file: in v1.3 it was required: false but now it is required: true.) If I uncheck the required box and save while the Core strategy is still selected, that change gets saved. But if I switch back to the Required by Role strategy, the Core required box gets checked again immediately and gets saved with required: true.
If I manually change the config file to say required: false and import, the change either does not import or does not stay changed. Exporting config results in required: true.
benstallings → made their first commit to this issue’s fork.
Ready for review!
never mind my objections, @apmsooner, I will use your simpler approach. Thank you for the feedback!
@apmsooner you make a good point that we could just add a custom filter. My thinking was that since 9x as many sites are already using VERF as are using Custom Field, and since Custom Field already has 5 submodules including integrations with GraphQL and Linkit, this could just be one more submodule providing an integration.
benstallings → created an issue.
benstallings → created an issue.
benstallings → created an issue.
Because this alters the same file as https://www.drupal.org/project/comingsoon_mode/issues/3532828 ✨ Provide options for login & registration links Active I'm going to address it there to prevent merge conflicts.
benstallings → created an issue.
benstallings → created an issue.
I'm sorry to say I'm unable to get the patch to apply to a 3.0.0 installation.
benstallings → created an issue. See original summary → .
benstallings → changed the visibility of the branch 3532828-login-reg-links to hidden.
benstallings → created an issue.
Phpstan now reports:
------ -----------------------------------------------------------------------
Line drush/delete_all.drush.inc
------ -----------------------------------------------------------------------
119 Class Drupal\delete_all\Controller\UserDeleteController constructor
invoked with 0 parameters, 1 required.
122 Function drush_get_option not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
143 Function drush_choice not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
147 Function drush_user_abort not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
154 Function drush_confirm not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
168 Function drush_user_abort not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
181 Class Drupal\delete_all\Controller\ContentDeleteController
constructor invoked with 0 parameters, 1 required.
184 Function drush_get_option not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
207 Function drush_choice not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
211 Function drush_user_abort not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
218 Function drush_confirm not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
232 Function drush_user_abort not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
260 Class Drupal\delete_all\Controller\EntityDeleteController constructor
invoked with 0 parameters, 1 required.
266 Function drush_get_option not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
272 Function drush_set_error not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
280 Function drush_choice not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
297 Function drush_get_option not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
304 Function drush_set_error not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
313 Function drush_choice not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
325 Function drush_confirm not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
345 Function drush_user_abort not found.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ -----------------------------------------------------------------------
------ ----------------------------------------------------------------------
Line src/Controller/EntityDeleteController.php
------ ----------------------------------------------------------------------
29 \Drupal calls should be avoided in classes, use dependency injection
instead
------ ----------------------------------------------------------------------
benstallings → made their first commit to this issue’s fork.
benstallings → created an issue.
benstallings → created an issue.
benstallings → created an issue.
benstallings → created an issue.
I'll take a look next week. Thanks for the prodding, @mandclu!
Unfortunately I rebased the branch on 2.2.x without being able to change the target in gitlab, so the MR is still pointed at 2.0.x. @urvashi_vora, are you able to change the target branch in the MR? Sorry about that.
updating to point at the latest dev
@dieterholvoet passing now!
benstallings → created an issue.
benstallings → created an issue.
After rebasing on 3.0.x, the patch #16 is no longer necessary.
So I capitalized null in the test as well, and now I don't understand what phpunit is saying about why it is failing.
OK, but I had already made that change in the MR before either of you commented about it. So the error message must be due to something else.
Now I'm getting,
1) Drupal\Tests\flysystem_s3\Unit\AwsCacheAdapterTest::testBasicGetSetDelete
Failed asserting that false is null.
When I run phpunit on my local, it complains about a bunch of missing composer dependencies. One at a time, of course. If I require each of them, I eventually get
PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function Drupal\Tests\flysystem_s3\Unit\Flysystem\S3Test::__construct(), 0 passed in /var/www/html/vendor/phpunit/phpunit/src/Framework/TestBuilder.php on line 138 and exactly 1 expected in /var/www/html/web/modules/composer/flysystem_s3/tests/src/Unit/Flysystem/S3Test.php:48
This doesn't address all of the complaints, but it's a start!
benstallings → created an issue.
benstallings → made their first commit to this issue’s fork.
whoops, wrong version
OK, but not all of the methods in that class are static! And the parent class already implements ContainerFactoryPluginInterface, so all we need to do is use the $instance = parent::create() pattern.
- defineOptions(), optionsSummary(), and buildOptionsForm() need the module_handler service injected
- buildOptionsForm() also needs the stream_wrapper_manager and plugin.manager.facets.facet_source services injected
updating to point at latest version
Still getting phpunit errors, but we're a lot closer!
benstallings → created an issue.
Showing a merge error
benstallings → created an issue.
benstallings → created an issue.
It would be great to get this merged into dev so that other modules that depend on it, such as RJSF, can require this dependency without patching.
Note that the composer test is currently failing because this MR has not yet been merged: https://www.drupal.org/project/jsonrpc_autocomplete/issues/3431493 📌 Automated Drupal 11 compatibility fixes for jsonrpc_autocomplete RTBC
benstallings → created an issue.
benstallings → created an issue.
benstallings → created an issue.
benstallings → created an issue.
I evidently did something wrong with the Http plugin, as it is now failing unit tests, but I don't understand what happened.
benstallings → created an issue.
benstallings → created an issue.
Looks like it's failing unit tests, so I must have broken something - flagging as Needs Work