Account created on 27 November 2007, almost 17 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States BenStallings

Thanks for catching my mistake, @zeeshan_khan!

🇺🇸United States BenStallings

@emilorol thanks for the fix. See MR!47.

🇺🇸United States BenStallings

I can verify that 2.x-dev is installable with composer in Drupal 11 and can be enabled. Thanks for merging this, @sjerdo!

🇺🇸United States BenStallings

I can confirm that this installs in Drupal 11 and can be enabled.

🇺🇸United States BenStallings

I added a composer.json file so that the module can be installed with composer in Drupal 11.

🇺🇸United States BenStallings

benstallings made their first commit to this issue’s fork.

🇺🇸United States BenStallings

I can verify that the project-update-bot-only branch installs in Drupal 11 and can be enabled!

However, I notice there are dire warnings that we are not supposed to change this branch because it can be overwritten at any time. So maybe make a new branch? :)

Thanks, @grevil!

🇺🇸United States BenStallings

Note that drupalcode indicates this branch has a merge conflict, but that does not appear to actually be the case.

🇺🇸United States BenStallings

MR!9 installs with composer and can be enabled in Drupal 11. Since the testing errors are on the release branch as well, I'm going to assume they're out of scope of this ticket.

🇺🇸United States BenStallings

MR!50 installs with composer and can be enabled in Drupal 11. Since the release branch also fails testing, I'm going to consider the testing problem to be outside the scope of this ticket.

🇺🇸United States BenStallings

It looks like the tests are passing now! With the addition of a composer.json file, the module now installs with composer and can be enabled in Drupal 11. Just need someone else to confirm, please.

🇺🇸United States BenStallings

MR!15 can now be installed & enabled in Drupal 11.

🇺🇸United States BenStallings

once I resolved the merge conflict, this worked fine!

🇺🇸United States BenStallings

Looks like this has been merged! Thanks, lussoluca!

🇺🇸United States BenStallings

MR!10 adds a composer.json so that the fork can be installed with composer.

🇺🇸United States BenStallings

When I try to install this with composer, I get

No valid composer.json was found in any branch or tag of https://git.drupalcode.org/issue/email_confirmer-3451035, could not load a package from it.

🇺🇸United States BenStallings

No luck, mradcliffe... with my composer.json repositories set up like so

        {
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/theme_switcher-3434980.git"
        },
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8"
        }

I get

$ composer require drupal/theme_switcher:3434980-gitlabci-dev
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Root composer.json requires drupal/theme_switcher 3434980-gitlabci-dev, found drupal/theme_switcher[dev-8.x-1.x] but it does not match the constraint.

🇺🇸United States BenStallings

OK, somebody else please test my MR!20. Thank you!

🇺🇸United States BenStallings

I spoke too soon, this still needs work:

web/modules/contrib/geofield_map/src/Form/GeofieldMapSettingsForm.php 151 Call to deprecated function format_size(). Deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Use Drupal\Core\StringTranslation\ByteSizeMarkup::create($size, $langcode) instead.

web/modules/contrib/geofield_map/geofield_map.info.yml 3 Value of core_version_requirement: ^9.3 || ^10 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.
web/modules/contrib/geofield_map/modules/geofield_map_extras/geofield_map_extras.info.yml 3 Value of core_version_requirement: ^8.8 || ^9 || ^10 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.

🇺🇸United States BenStallings

When I try to install, I get "No valid composer.json was found in any branch or tag of https://git.drupalcode.org/iss
ue/verf-3435339, could not load a package from it."

🇺🇸United States BenStallings

When I try to install, I get "No valid composer.json was found in any branch or tag of https://git.drupalcode.org/iss
ue/uuid_extra-3435312, could not load a package from it."

🇺🇸United States BenStallings

I'm not able to install MR!8 for some reason -- composer can't seem to find the 3434980-gitlabci-dev branch in the fork.

🇺🇸United States BenStallings

I was able to install & enable this in Drupal 11. Great work!

🇺🇸United States BenStallings

I was able to install & enable this in Drupal 11.

🇺🇸United States BenStallings

I was able to install & enable this in Drupal 11. Thanks!

🇺🇸United States BenStallings

I was able to install & enable this in Drupal 11.

🇺🇸United States BenStallings

This does not appear to have been merged into the 2.0.3 branch. Please try again! Thanks!

🇺🇸United States BenStallings

I spoke too soon... in addition to the things that have been fixed on this branch, Upgrade Status reports:

web/modules/composer/context/modules/context_ui/src/Plugin/Block/ContextInspector.php 37 Calls to function kpr should not exist.

web/modules/composer/context/src/Reaction/Blocks/Controller/ContextReactionBlocksController.php 188 The 'context_ui/admin' library is not defined because the defining extension is not installed. Cannot decide if it is deprecated or not.

web/modules/composer/context/modules/context_ui/src/Controller/ContextUIController.php 183 The 'context_ui/admin' library is not defined because the defining extension is not installed. Cannot decide if it is deprecated or not.

web/modules/composer/context/modules/context_ui/src/Controller/ContextUIController.php 259 The 'context_ui/admin' library is not defined because the defining extension is not installed. Cannot decide if it is deprecated or not.

🇺🇸United States BenStallings

I am no expert in this module, but I was able to install and use it with MR!59.

🇺🇸United States BenStallings

dang it, forgot the attachment. Here is the attachment for comment #9.

🇺🇸United States BenStallings

Here's an updated patch that changes $query->get() to $query->all() for compatibility with Symfony 6.

🇺🇸United States BenStallings

@mandclu sorry, I have no idea when the change was made to Symfony.

🇺🇸United States BenStallings

Apologies, I meant to post this on entity_share module and got confused!

🇺🇸United States BenStallings

@mandclu yes, but it is botched. The MR contains nothing, and I can't figure out how to fix it, hence the patch.

🇺🇸United States BenStallings

BenStallings changed the visibility of the branch 3414404-badrequesthttpexception-input-value to hidden.

🇺🇸United States BenStallings

@sharique yes, and I had already done so at https://git.drupalcode.org/project/pet/-/merge_requests/5/diffs?diff_id=... , but for some reason https://git.drupalcode.org/project/pet/-/merge_requests/5/diffs shows an incorrect "latest version" until you select "latest version" again.

🇺🇸United States BenStallings

@danrod created!

🇺🇸United States BenStallings

@Sharique I've updated the branch, but I am unable to reopen the issue. It says "Only maintainers can reopen."

🇺🇸United States BenStallings

Looks like this is already done.

🇺🇸United States BenStallings

looks like this is already in place, sorry.

Production build 0.71.5 2024