Account created on 27 November 2007, almost 18 years ago
#

Merge Requests

More

Recent comments

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

The problem I seem to be having with applying the patch from MR!8 is that the 3.x dev branch it builds on does not seem to be accessible with composer. Regardless of how I require it, I keep getting the 3.0.0 release, which is behind dev. Any tips?

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

#18 is out of date - that change is already in MR!8. See https://git.drupalcode.org/project/delete_all/-/merge_requests/8/diffs

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

bumping up the priority

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

bumping up the priority

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

bumping the priority up

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

@rcodina it looks like the current dev branch supports D11, so the status here should be Fixed. But yes, a release would be great!

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

I'm confused - MR !76 is showing 0 changes.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

Works for me!

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

OK, if you're able to provide a patch or push to the MR, please do! thank you!

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

Taking @berdir's advice to heart, I've opened https://www.drupal.org/project/ultimate_cron/issues/3547668 ๐Ÿ“Œ use short array syntax Active

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

OK so a lot of the phpcs complaints turn out to pertain to code that was included in the release but that is not actually functional yet. I wonder if it would be better to move that code into a branch and not include it in the release at all until it is functional.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

rebased on the current head

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

Sure, but I'm puzzled that the test results at https://git.drupalcode.org/issue/saml_sp-3547318/-/pipelines/601659 don't show additional phpcs issues. What warnings and errors are you seeing?

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

version 4.3.4 already supports Drupal 11.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

benstallings โ†’ created an issue.

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings
Production build 0.71.5 2024