remove unnecessary \Drupal call for injected dependency

Created on 23 May 2025, about 1 month ago

Problem/Motivation

This fixed issue → injected the menuParentFormSelector dependency into MenuBlock.php, but the blockForm() method still retrieves the dependency directly from \Drupal::service().

Steps to reproduce

phpstan analyse -l0 menu_block/src

Proposed resolution

Use the menuParentFormSelector property rather than calling \Drupal::service().

Remaining tasks

make a MR

📌 Task

Status

Active

Version

1.0

Component

Code

Created by

🇺🇸United States BenStallings

Live updates comments and jobs are added and updated live.

Merge Requests

!40remove unnecessary \Drupal call for injected dependency
Open
🇺🇸United States BenStallings
updated about 1 month ago

Comments & Activities

Issue created by @BenStallings
Merge request !40remove unnecessary Drupal service call → (Open) created by BenStallings
Pipeline finished with Failed
about 1 month ago
Total: 240s
#505150
Comment about 1 month ago →
🇺🇸United States BenStallings
Pipeline finished with Success
about 1 month ago
Total: 199s
#505164

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024