\Drupal calls should be avoided in classes, use dependency injection instead

Created on 18 July 2023, 12 months ago

Problem/Motivation

FILE: ...home/lenovo/d7to9/web/modules/contrib/layout_paragraphs/tests/modules/layout_paragraphs_custom_host_entity_test/src/Form/LpHostEntityForm.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
 23 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/lenovo/d7to9/web/modules/contrib/layout_paragraphs/src/Plugin/Field/FieldWidget/LayoutParagraphsWidget.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERROR AND 1 WARNING AFFECTING 1 LINES
----------------------------------------------------------------------------------------------------------------------------------
 311 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig layout_paragraphs/

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Needs review

Version

2.0

Component

Code

Created by

🇮🇳India roshni27

Live updates comments and jobs are added and updated live.

Dependency Injection (DI)

Comments & Activities

Issue created by @roshni27
Issue was unassigned.
Status changed to Needs review 12 months ago9:29am 18 July 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update 12 months ago
5 pass, 38 fail
Comment 12 months ago →
🇮🇳India roshni27
Please the patch.
Comment 12 months ago →
System Message
The last submitted patch, 2: dependency-injection-3375154-2.patch, failed testing. View results →
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update 12 months ago
5 pass, 38 fail
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update 12 months ago
5 pass, 38 fail
@urvashi_vora opened merge request.
Comment 12 months ago →
🇮🇳India urvashi_vora Madhya Pradesh, India
Please review the PR.

Thanks

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024