\Drupal calls should be avoided in classes, use dependency injection instead

FILE: ...home/lenovo/d7to9/web/modules/contrib/layout_paragraphs/tests/modules/layout_paragraphs_custom_host_entity_test/src/Form/LpHostEntityForm.php --------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------------- 23 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/layout_paragraphs/src/Plugin/Field/FieldWidget/LayoutParagraphsWidget.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERROR AND 1 WARNING AFFECTING 1 LINES ---------------------------------------------------------------------------------------------------------------------------------- 311 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead ----------------------------------------------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @roshni27
Issue was unassigned.
Status changed to Needs review about 2 years ago9:29am 18 July 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update about 2 years ago
5 pass, 38 fail
Comment about 2 years ago →
🇮🇳India roshni27
Please the patch.
Comment about 2 years ago →
System Message
The last submitted patch, 2: dependency-injection-3375154-2.patch, failed testing. View results →
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
5 pass, 38 fail
First commit to issue fork.
Merge request !134Issue #3375154: \Drupal calls should be avoided in classes, use dependency injection instead → (Open) created by urvashi_vora
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update about 2 years ago
5 pass, 38 fail
Comment about 2 years ago →
🇮🇳India urvashi_vora Madhya Pradesh, India
Please review the PR.

Thanks
Comment about 1 month ago →
🇺🇸United States BenStallings
updating to point at the latest dev
Comment about 1 month ago →
🇺🇸United States BenStallings
Unfortunately I rebased the branch on 2.2.x without being able to change the target in gitlab, so the MR is still pointed at 2.0.x. @urvashi_vora, are you able to change the target branch in the MR? Sorry about that.

\Drupal calls should be avoided in classes, use dependency injection instead

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!134\Drupal calls should be avoided in classes, use dependency injection instead
Open

Comments & Activities

\Drupal calls should be avoided in classes, use dependency injection instead

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!134\Drupal calls should be avoided in classes, use dependency injection insteadOpen

Comments & Activities

!134\Drupal calls should be avoided in classes, use dependency injection instead
Open