phpstan reports, among other things,
------ ------------------------------------------------------------------------------
Line src/DataParserPluginBase.php
------ ------------------------------------------------------------------------------
77 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------------ -------------------------------------------------------------------------------------------------------------------------------------
Line src/Plugin/migrate/process/DomStrReplace.php
------ -------------------------------------------------------------------------------------------------------------------------------------
215 Method Drupal\migrate_plus\Plugin\migrate\process\DomStrReplace::getSubject() should return string but return statement is missing.
231 Method Drupal\migrate_plus\Plugin\migrate\process\DomStrReplace::getSearch() should return string but return statement is missing.
245 Method Drupal\migrate_plus\Plugin\migrate\process\DomStrReplace::getReplace() should return string but return statement is missing.
------ ------------------------------------------------------------------------------------------------------------------------------------------- ----------------------------------------------------------------------------------------------------------------------------------------------
Line src/Plugin/migrate/process/EntityGenerate.php
------ ----------------------------------------------------------------------------------------------------------------------------------------------
92 Method Drupal\migrate_plus\Plugin\migrate\process\EntityGenerate::generateEntity() should return int|string but return statement is missing.
------ ---------------------------------------------------------------------------------------------------------------------------------------------------- ------------------------------------------------------------------------------
Line src/Plugin/migrate/source/Url.php
------ ------------------------------------------------------------------------------
64 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------------ ------------------------------------------------------------------------------
Line src/Plugin/migrate_plus/data_fetcher/Http.php
------ ------------------------------------------------------------------------------
64 \Drupal calls should be avoided in classes, use dependency injection instead
81 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------
phpstan analyse -l0 migrate_plus
make a MR
Active
6.0
Miscellaneous
I evidently did something wrong with the Http plugin, as it is now failing unit tests, but I don't understand what happened.
I didn't notice this was opened until just now. But 📌 Fix remaining code quality findings Active is getting pretty close. I'll likely close this as duplicate.