- Issue created by @project update bot
- last update
9 months ago 3 pass This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β these changes make this module compatible with Drupal 11! π
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-127659These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.9
- palantirnet/drupal-rector: 0.20.1
- last update
9 months ago 3 pass - Status changed to RTBC
5 months ago 2:52pm 9 August 2024 - πΊπΈUnited States BenStallings
I was able to install & enable this in Drupal 11.
Was able to install and enable 3.1.4 with patch #2, however, update status scan reports this issue as well
CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Queue UI 3.1.4
Scanned on Thu, 08/15/2024 - 15:43.web/modules/contrib/queue_ui/src/Form/ItemDetailForm.php:
+--------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status | line | message |
+--------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Ignore | 131 | Call to deprecated method renderPlain() of interface
Drupal\Core\Render\RendererInterface. Deprecated in
drupal:10.3.0 and is removed from drupal:12.0.0. Use
Drupal\Core\Render\RendererInterface::renderInIsolation()
instead.
|
+--------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+- πΊπΈUnited States emilorol
The fix for line 131 of "queue_ui/src/Form/ItemDetailForm.php" is this one:
$data = $this->renderer->renderPlain($data);
Change to this:
$data = $this->renderer->renderInIsolation($data);
- πΊπΈUnited States BenStallings
@emilorol thanks for the fix. See MR!47.
- πΊπ¦Ukraine voleger Ukraine, Rivne
3.1.x will not receive Drupal 11 compatibility. Please prepare changes to 3.2.x branch
- Status changed to Needs work
3 months ago 11:42am 12 September 2024 - π―π΅Japan ptmkenny
@benstallings Can you target 3.2.x for your MR? I tried to move it for you, but it seems only the person who created the merge request or a maintainer can change the target.
- π―π΅Japan ptmkenny
I fixed the call to renderInIsolation, which was incorrect. renderInIsolation was introduced in 10.3, so using it without the deprecation helper will throw an exception on Drupal 10.2 and below.
- First commit to issue fork.
- π«π·France nicolasgraph Strasbourg
nicolasgraph β changed the visibility of the branch renderInIsolation to hidden.
- π«π·France nicolasgraph Strasbourg
After pulling 3.2.x in the MR ; there is not much to change !
upgrade_status is already happy - π―π΅Japan ptmkenny
This looks ok to me, but another option is to drop the core version requirement from composer.json.
Requiring drupal/core in composer.json is not required β (if it is not required, the core version is pulled in from mymodule.info.yml), and it creates additional work every time core is updated.
-
voleger β
committed 160807a2 on 3.2.x authored by
nicolasgraph β
Issue #3434070: Automated Drupal 11 compatibility fixes for queue_ui
-
voleger β
committed 160807a2 on 3.2.x authored by
nicolasgraph β
Automatically closed - issue fixed for 2 weeks with no activity.