🇺🇦Ukraine @voleger

Yes, 📌 Convert theme engines into services Needs work makes sense.
I'm closing the duplicated issue

It needs work for test coverage based on the steps to reproduce.

Settings.php overrides are unsuitable for the modules that try to control the backend of the queue worker.
I like the idea of keeping the current approach to override the backend service.

What if, instead of extending attribute/annotation, we introduce an extension point by dispatching an event right after determining the service name?

Oh, thanks.
I'm postponing that on 📌 [Plan] Determine how to deprecate procedural hooks. Active

How do we deprecate the procedural hook with the OOP hook? Is there any approach declared? And what needs to be done with `\Drupal::` calls? How do you set dependency injection for OOP hook implementation?

Is there any additional information about proper dependency injection practice for OOP hook implementation?

voleger → created an issue.

Tests are not passed.

We need to improve the token integration test with cases of uploaded files without extension.

Good, we need a test case that creates an entity with a pre-uploaded file.

I reached a recently active maintainer, @bceyssens, via LinkedIn, but he could not make the change or set me as the project's maintainer.

voleger → created an issue.

It looks like that was addressed in the latest release in the scope of Drush command refactoring https://git.drupalcode.org/project/filefield_paths/-/blob/8.x-1.0-beta8/...

If the issue still exist - let me know

Thanks

Wondering if the module can do all of that during the uninstallation:
- set the default value of the base field definition or initial value to `NULL` or `` (or move this to the hook field info alter and implement one more hook update for this)
- set base field field definition as not required
- do base field definition update

Then, let the system purge the field.

What do you think?

Closed [33293876] as duplicate of this issue.

Please follow the existing issue #2685731: How to uninstall this module ? → . Anyway, the changes from the patch need to be moved to the MR. Thanks.

It has to be fixed in #2858308: File paths are written to the DB with back slashes on Windows servers → . If the problem still exists, open a new issue.

Please open a new issue with more details and steps to reproduce if the problem still exists.

Needs MR

Testing for a new token is necessary to ensure it works as expected.

Needs MR

Needs MR

Needs MR

Needs MR

Needs MR

Tabs are present on a recent releases.

Needs MR for proposed changes.

Thanks. Changes look good, but two PHPCS issues must be addressed before merging.

Fixed

The pipeline passed, and there are reported issues that can be addressed in follow-ups.

voleger → created an issue.

Looks good, thanks

voleger → made their first commit to this issue’s fork.

Nice feature. Please prepare a MR and add test coverage.

Needs rebase.

Thanks

voleger → made their first commit to this issue’s fork.

Do not use attached patches.

As a workaround use #12 approach with private://filefield_paths (which is preferred) or public://filefield_paths.

Disallowing using temporary:// schema makes sense. But we need better test coverage for that.

It is definitely good to add a test for the drush command. If you have a good example to follow - please let me know. I created a follow-up issue - 📌 Add test coverage for the Drush command Active

voleger → created an issue.

All passed

Thank you very much! Only the Drush command port is left, and this is the scope of ✨ Port Drush integration for File (Field) Paths Active .
Merged, fixed.

voleger → made their first commit to this issue’s fork.

Introduced MR which contains #130 patch.

Here is an example of how users can check project members' roles.

Uploading the patch from the MR for the 2.0.x branch

voleger → created an issue.

Sorry for off-top,
The project https://www.drupal.org/project/update_advanced → looks interesting.
@dww can you grant me a maintainer role at https://www.drupal.org/project/update_advanced → ? I'm preparing the port for D11 🌱 ported to Drupal 8 Active

@dww please add me to the maintainers list. I'll help with Drupal 11 port

And please open a PR for testing changes on the existing tests.

A test is needed to reproduce the issue and show that the change is fixing it.

voleger → made their first commit to this issue’s fork.

voleger → created an issue.

joelpittet → credited voleger → .

8.2.x branch is not planned to support Drupal 11

Added initial refactoring of Drush commands

voleger → made their first commit to this issue’s fork.

Added comment on how to resolve the PHPCS issue

Fixed thanks

I think that may work. The goal is to make phpstan check run "green".

Fixed, thanks

voleger → changed the visibility of the branch 3434755-automated-drupal-11 to active.

voleger → changed the visibility of the branch 3434755-automated-drupal-11 to hidden.

Fixed, thanks

voleger → made their first commit to this issue’s fork.

It is merged in the wrong branch, which is already unsupported. So, the main branch is still not fixed.

Please introduce the phpstan baseline file and add an entry related to deprecation lines in the service, and we will be ready to merge changes.
See https://project.pages.drupalcode.org/gitlab_templates/jobs/phpstan/

Please follow up ✨ Port Drush integration for File (Field) Paths Active

Needs MR for compatibility with Drush and Drupal ^10.3

Rebase after 📌 Fix more coding standards Needs review merge

I will merge this now, as I'm working on 📌 Update .gitlab-ci.yml file Needs work . I'll make further changes there. Thanks

voleger → made their first commit to this issue’s fork.

Merge the patch from the issue #2911652: Implements hook_filefield_paths_process_file breaking → , moving credits

I'm moving the fix to the issue 📌 Update .gitlab-ci.yml file Needs work . Thanks.

voleger → created an issue.

Use >=3.1.0 version for Drupal 11 based projects

voleger → created an issue.