- Issue created by @kim.pepper
- Merge request !5958Issue #3410938 Create enums for RequirementSeverity and deprecate constants → (Open) created by kim.pepper
- Status changed to Needs review
12 months ago 10:52pm 26 December 2023 - 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Created a MR, but I know there will be test fails. I think the biggest issue is going to be BC support and converting from int values stored in config.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Remaining tasks:
- Handle BC for contrib modules that will still be using constants.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
I think this issue is big enough without trying to introduce enums for RequirementPhase at the same time.
Also adding that we are deprecating
drupal_requirements_severity()and moving this to the enum. - Status changed to Needs work
12 months ago 7:09pm 27 December 2023 - 🇺🇸United States smustgrave
Can we add a simple deprecation test to make sure the current constants are returning a deprecation warning.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Yeah, I think we need tests to make sure the BC layer works when using those constants.
- Status changed to Needs review
12 months ago 3:00am 3 January 2024 - 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Added a bc test for
getMaxSeverity(). There are a few instances where we check the severity status. - Status changed to Needs work
12 months ago 2:48pm 3 January 2024 - 🇺🇸United States smustgrave
BC tests added look great! Moving to NW for the CR.
- Status changed to Needs review
12 months ago 11:16pm 4 January 2024 - Status changed to RTBC
12 months ago 3:02pm 5 January 2024 - Status changed to Needs work
11 months ago 5:50pm 20 January 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to RTBC
11 months ago 10:22pm 21 January 2024 - Status changed to Needs work
10 months ago 1:35pm 13 February 2024 - Status changed to Needs review
10 months ago 7:18am 19 February 2024 - Status changed to Needs work
10 months ago 3:58pm 19 February 2024 - 🇺🇸United States smustgrave
There was 1 error: 1) Drupal\Tests\system\Functional\UpdateSystem\UpdateScriptTest::testRequirements Behat\Mink\Exception\ResponseTextException: The text "This is a requirements warning provided by the update_script_test module." was not found anywhere in the text of the current page. /builds/issue/drupal-3410938/vendor/behat/mink/src/WebAssert.php:907 /builds/issue/drupal-3410938/vendor/behat/mink/src/WebAssert.php:293 /builds/issue/drupal-3410938/core/tests/Drupal/Tests/WebAssert.php:956 /builds/issue/drupal-3410938/core/modules/system/tests/src/Functional/UpdateSystem/UpdateScriptTest.php:150 /builds/issue/drupal-3410938/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 - 🇦🇺Australia dpi Perth, Australia
Added further feedback, tests still failing.
