[pp-3] Split up and refactor system_requirements() into OOP hooks

I solved the couple of codesniffing and Stan issues just to see what happens with the tests.

berdir → closed merge request !10557

Started a new merge request, did runtime/update with an internal method that keeps $phase and only removed the install stuff. copied the install requirements from the old MR.

only did enough changes to make phpstan/phpcs happy.

I think this approach makes sense, we are going to have to break this up piece by piece

There are some suspicious failures though.

I think we should do the minimal like you did here then work on organization in follow ups.

nicxvan → changed the visibility of the branch 11.x to hidden.

There is something going on with the file system, all of the failures are related to that, I don't see what is missing in the conversion though.

Ok i got this a lot closer I think nightwatch is failing though.

nicxvan → changed the visibility of the branch 3493718-system-requirements-new to hidden.

It was random.

Appears to have some open threads.

Addressed the comments

believe all feedback has been addressed. Seems like a good conversion least to me.

This will conflict with 📌 Create enums for RequirementSeverity and RequirementPhase Active which is more urgent to get into 11.2.x, so marking this postponed on that one.

Blocker is in. Needs rebase and conflict resolution to use the new enum.

Rebased, this is ready for review again!
Created the follow up: 📌 [pp-1] Deprecate drupal_verify_install_file Active

Still haven't had time for a thorough look at the meat of this MR, but I keep finding nits on the outskirts. 😂 Won't bother NW'ing over these, to encourage real reviews of the real changes, but wanted to open threads for now. Hopefully I can make some time on Tuesday to do a real review of the important parts.

📌 Add value objects to represent the return of hook_requirements Needs work is blocked on this.

I will address @dww's comments now.

I'm not sure what other review this needs it's essentially a one for one move to the new classes.

Added some minor feedback to the MR. Also crossing off "Rebase and port to use the new RequirementSeverity enum." from the IS.

I've addressed all feedback, applied suggestions and searched for other instances to resolve those as well.

Ok all threads resolved!

Sorry, found an errant reference to pgsql module. Not setting RTBC because I haven't done the T part of it. I'm assuming we have sufficient test coverage though, but that may be naive.

Good catch!

This is the requirements implementation with the most testing both explicit and implicit.

It's also as minimal as conversion as possible.

Now that 11.2 is out maybe we can get this in.

nicxvan → closed merge request !11508

nicxvan → changed the visibility of the branch 3493718-split-requirements-minimum to hidden.

Ok I regenerated the MR.

I put the existing system requirement on the install class and call that from the hook.

I did not change any functional bits, I only changed references and line lengths.

Since I did not change any functionality I had to regenerate the baseline since there are some baseline issues for system requirements.

I will keep an eye on tests.

It looks like baseline did remove a couple of extra items that were not touched here. I suspect it's just been a while since a full baseline has been regenerated with new rules.

nicxvan → closed merge request !12114

This is ready for review again.

I took @mstrelan's advice and copied the current system_requirements verbatim to a helper on the Install class.

I then call this with the correct phase.

Since I didn't make any functional changes the baseline only shifted rather than being resolved.

The only changes I made after copying the function:

• Comment line length
• Copied helper function systemAdvisoriesRequirements
• Cast php version to a string for version_compare https://git.drupalcode.org/project/drupal/-/merge_requests/12449/diffs?c...

Any other changes are minor and easy to see in the MR