Account created on 23 February 2007, over 17 years ago
  • Developer at SkilldΒ  …
#

Merge Requests

More

Recent comments

πŸ‡«πŸ‡·France andypost

as the function argument changed issue needs change record

πŸ‡«πŸ‡·France andypost

Polished IS a bit but it needs more clean-up especially for CLI

πŸ‡«πŸ‡·France andypost

There's more places to clean-up

πŸ‡«πŸ‡·France andypost

There's some repeatable failure for mysql as well, maybe the issue in transition out of mysql_safe... I will check deeper this weekend

πŸ‡«πŸ‡·France andypost

Here's 2 places which cause warnings when config:inspect executed

 [warning] Undefined array key "type" Mapping.php:143
 [warning] Undefined array key "type" Mapping.php:143
 [warning] Undefined array key "type" Mapping.php:143
 [warning] Undefined array key "type" Mapping.php:143

Probably there's more places

πŸ‡«πŸ‡·France andypost

patches are no longer used to run tests, please update MR or create new one

πŸ‡«πŸ‡·France andypost

only beta versions of jQuery and UI remains in beta, and there's no schedule for stable releases

πŸ‡«πŸ‡·France andypost

Help module can provide special section plugin, or even help topic which will be generated from changelog for example

πŸ‡«πŸ‡·France andypost

Thank you! Great integration to add!
Let's get more opinions on a way to integrate, for example https://docs.gitlab.com/ee/administration/admin_area.html#user-impersona...

+++ b/masquerade.module
@@ -254,3 +254,20 @@ function masquerade_migration_plugins_alter(array &$migrations) {
+function masquerade_preprocess_menu_region__footer(array &$variables): void {
+  if (\Drupal::service('masquerade')->isMasquerading()) {
+    $variables['items']['masquerade_switch_back'] = [
+      'title' => t('Unmasquerade'),
+      'url' => Url::fromRoute('masquerade.unmasquerade'),

Curios if it needs cache metadata?!

Moreover we can display the block with quick links and so on.

Is there a way to configure how to display in navigation as I know nothing about it's API

πŸ‡«πŸ‡·France andypost

prophecy again is very slow on new PHP version compatibility

πŸ‡«πŸ‡·France andypost

justinrainbow/json-schema | v5.2.13 | 5.3.0
one more compatible extension with PHP 8.4, next composer release will contain it

πŸ‡«πŸ‡·France andypost

Both but second has less changes

πŸ‡«πŸ‡·France andypost

Published PHP 8.4_alpha1 image

πŸ‡«πŸ‡·France andypost

Second MR probably preferable

πŸ‡«πŸ‡·France andypost

Last commit should be removed as production images will be rolled

πŸ‡«πŸ‡·France andypost

Looks everything works without extra packages, so we can simplify in follow-up other db-images (no extra dependencies to install)

πŸ‡«πŸ‡·France andypost

Filed core issue for testing new images and daily run or default πŸ“Œ Add core testing with Mysql 8.4 LTS Needs review

πŸ‡«πŸ‡·France andypost

Pushed dev image

- added mysql:8.4 image with updated script to use bash while ! echo > /dev/tcp/localhost/3306; do sleep 1; done to wait for port
- updated mysql:8 image inline with 8.4 - transition from mysql_safe and fix encodings dir

πŸ‡«πŸ‡·France andypost

Base image for `mysql-8` also needs update

mysql                                       8                           736ced9665e8   39 hours ago        583MB
mysql                                       8.4                         736ced9665e8   39 hours ago        583MB
mysql                                       8.0                         0b60ddd8609d   39 hours ago        572MB
πŸ‡«πŸ‡·France andypost

Before looking for workarounds please consider if you really need this method as it very internal to ThemeExtensionList::doGetBaseThemes() which you can decorate/access in a hacky way

But custom code is not expected to use this method

πŸ‡«πŸ‡·France andypost

HTTP request to core/modules/statistics/statistics.php (yay! special case!)

IS should not mention removed in 11.x statistics module

πŸ‡«πŸ‡·France andypost

I find $override_handler_plugin_id over-complicated - handler is always plugin and the method name already suppose to return handler getHandler() so $override_plugin_id is more reasonable

πŸ‡«πŸ‡·France andypost

Nice idea but tests are failed, so there's usage to clean-up

πŸ‡«πŸ‡·France andypost

Please create MR from the branch to 11.x

πŸ‡«πŸ‡·France andypost

Probably better to re-purpose the issue to provide exporter as importer already in core

πŸ‡«πŸ‡·France andypost

As I see only 4 usages left

$ git grep database_drivers
core/tests/Drupal/KernelTests/Core/Database/SelectExtenderTest.php:122:    $additional_class_loader->addPsr4("Drupal\\core_fake\\Driver\\Database\\coreFake\\", __DIR__ . "/../../../../../tests/fixtures/database_drivers/module/core_fake/src/Driver/Database/CoreFake");
core/tests/Drupal/KernelTests/Core/Database/SelectExtenderTest.php:123:    $additional_class_loader->addPsr4("Drupal\\core_fake\\Driver\\Database\\CoreFakeWithAllCustomClasses\\", __DIR__ . "/../../../../../tests/fixtures/database_drivers/module/core_fake/src/Driver/Database/CoreFakeWithAllCustomClasses");
core/tests/Drupal/Tests/Core/Database/ConnectionTest.php:324:    $additional_class_loader->addPsr4("Drupal\\core_fake\\Driver\\Database\\CoreFake\\", __DIR__ . "/../../../../../tests/fixtures/database_drivers/module/core_fake/src/Driver/Database/CoreFake");
core/tests/Drupal/Tests/Core/Database/ConnectionTest.php:325:    $additional_class_loader->addPsr4("Drupal\\core_fake\\Driver\\Database\\CoreFakeWithAllCustomClasses\\", __DIR__ . "/../../../../../tests/fixtures/database_drivers/module/core_fake/src/Driver/Database/CoreFakeWithAllCustomClasses");
πŸ‡«πŸ‡·France andypost

andypost β†’ made their first commit to this issue’s fork.

πŸ‡«πŸ‡·France andypost

dev image created now needs mongodb database image

πŸ‡«πŸ‡·France andypost

I think it needs change record as of behavior change - unserialize with allowed classes may fail for existing sites which has a bet on existing way to unserialize. Test surely needs improvement

πŸ‡«πŸ‡·France andypost

I think it needs change record and detail the docs comment about return value

πŸ‡«πŸ‡·France andypost

proper status to deprecate in 11.x and remove in 12

πŸ‡«πŸ‡·France andypost

Thank you, I'm using the module and gonna fix it and create beta release while https://ddd2024.drupalcamp.bg/

πŸ‡«πŸ‡·France andypost

Looks like 2.x can work on some 10.x

PS: related 3.x πŸ“Œ Automated Drupal 10 compatibility fixes Needs work

πŸ‡«πŸ‡·France andypost

I don't think the issue needs change record as behaviour was wrong and it's sad that someone is using wrong expectations.
Having CR for bug reports is useless cognitive load imo

πŸ‡«πŸ‡·France andypost

There's fresh approach to add the Symfony Runtime's frontend in ✨ CLI entry point in Drupal Core (Dex) Needs review

Re @sinasalek there's long way to clean all static variables before Drupal sites can benefit of pre-bootstrapped kernel

πŸ‡«πŸ‡·France andypost

I've no idea how xdebug can be used as it can't even complete running, so promoting it over pcov sounds a nonsense

πŸ‡«πŸ‡·France andypost

Looks ready to go, comments make sense, thank you!

πŸ‡«πŸ‡·France andypost

Great point about performance of discovery, probably it needs something generalized like file cache as except services there's plugins and help topics and twog components

πŸ‡«πŸ‡·France andypost

+1 sounds like solution to long lasting set of issues, it could be extendable via dex drush

PS looking how to extend it for xhprof but SF runtime backend is one more strong reason

πŸ‡«πŸ‡·France andypost

Looks it have no effect now, so not sure about change record

πŸ‡«πŸ‡·France andypost

Updated IS as few methods gone already

πŸ‡«πŸ‡·France andypost

Needs work to fix failed tests or change comments and add todo links to follow-ups

πŸ‡«πŸ‡·France andypost

Moreover the help module's topics using core search implementing HelpSearch plugin and have tricks with cron-indexing

Production build 0.69.0 2024