🇫🇷France @andypost

updated 8.3 image as contrib module's CI is broken anyway

added to summary https://www.mongodb.com/community/forums/t/php-mongodb-2-0-0-bsonarray-b...

IIRC the reason to keep only latest image is security because distros getting updates and PHP has monthly release cycle, so no reason to bloat storage...

So semver should be local and applicable for nightly somehow

Creating a database is a nice nitpick, back to RTBC

Needs deprecation test and looks RTBC

Great idea to turn app into context! btw the real problem here is the Request object which could be any flavor (Symfony, Swoole, PSR, ...) so runtime or frontend controller must care about converting incoming request into consumable by core

andypost → created an issue.

Thank you all!
Published https://www.drupal.org/project/queue_unique/releases/4.0.0 →

Looking at changes I think we need new major (4.x) version

needs rebase to allow testing php 8.4/8.5 - images are pushed (8.4 at least) https://git.drupalcode.org/project/drupalci_environments/-/jobs/4991982

pushed to dev upgrade to 8.4 and 8.5

there's no original file infomation and cropping, it's just input with some image file and output to compare or 2 outputs to compare

Webdriver is the only update image now 📌 CI: Using stale drupalci chromedriver image (`chromedriver` is stale, `webdriver-chromedriver` gets updates) Active

It's more about related

- 📌 Create the database driver for MySQLi for async queries Active
- 📌 Forbid limited length primary and unique keys, allow only in indexes Needs work

Let's get maintainer's opinion as extending indexes is tricky, moreover this partial indexes are only supported by Mysql

About skipping it could have option to not convert if size is bigger, which looks counterintuitive...

In perfect world only dimensions probably available but even in AVIF you have a set of images with different sizes in one file.

OTOH would be great to think about this plugin in context of real usage via responsive images, that's where fallback is discussed as well and that's where we can apply complex rules

Hope it will not break responsive images further

With this title we can just add optional setting to existing plugin when AVIF is selected to configure "file size to start acting"?

Related is commited 🐛 Separate MIME type mapping from ExtensionMimeTypeGuesser Needs work

It means to create a new ConvertConditional plugin or extending existing one with extra configuration?

Let's use ICU variant - shsh as the summary states

I'm ok to step in as maintainer but would be great to get more people, @bnjmnm has no bandwidth for it #3007167-58: [policy] Deprecate field_layout module and move it to contrib →

@catch that's why I consider it task as async code was never supposed to be supported

There's many bugs in config translation and locale so I'm not sure we can guess anything until the flow is settled

IMO the cause here is ✨ Configuration langcode is forced to site default language Needs work

The deprecation of SessionManager could go separate issue

I mean 📌 Implement Symfony SessionListener Active

I find it good to go and let's discus disruption in 📌 Deprecate custom keys in $_SESSION Active

Applied clean-up and D12, IMO looks RTBC and is not disruptive since D8

andypost → made their first commit to this issue’s fork.

As I get it just need deprecation test

is that really a bug? looks more like task kind

For MR to 11.x

Meantime new PECL 2.0.0 release is out https://github.com/mongodb/mongo-php-driver/releases/tag/2.0.0

There's some deprecations and so I filed 📌 Upgrade mongodb to 2.0 Active

andypost → created an issue.

There's no alternative yet, so I'm willing to maintain it in contrib

Would be great to have a follow-up to decide on policy to update the images as browsers has a very fast release cycle

move to contrib is independent of modernizing data model, so follow-up is 📌 Make regions and fields pluggable or alterable in EntityDisplayFormBase Active

Rtbc++ for db dumps there's follow-up 📌 Create standard steps for creating database dumps Active

It looks like a blocker for deprecation 📌 Deprecate non-W3C compliant testing Active

PS: not clear state of w3c testing in contrib as it reported blocked too #3462681: Add W3C compliant JS testing →

new images will go to new registry, nightly tested

I bet it fixed, next PHP 8.4 rebuild is next week

Thank you

updated IS, as I greped for hook the typo fix added

So it's no longer a bug

The issue is still valid - this hooks

1. +++ b/core/modules/workspaces/workspaces.install
   @@ -30,8 +30,8 @@ function workspaces_requirements($phase) {
   -function workspaces_module_preinstall($module) {
   -  if ($module !== 'workspaces') {
   +function workspaces_module_preinstall($module, bool $is_syncing) {
   +  if ($module !== 'workspaces' || $is_syncing) {
   

   not sure it needed today

2. +++ b/core/profiles/demo_umami/modules/demo_umami_content/demo_umami_content.install
   @@ -10,8 +10,8 @@
   -function demo_umami_content_module_preinstall($module) {
   -  if ($module === 'demo_umami_content' && !\Drupal::service('config.installer')->isSyncing()) {
   +function demo_umami_content_module_preinstall($module, bool $is_syncing) {
   +  if ($module === 'demo_umami_content' && !$is_syncing) {
   

   this change still missing

AVIF is expensive (x2-x3 vs WEBP on compression) so fits for hires images mostly

I find it good/handy feature with CR)

Moreover AVIF is specifically good for big sizes with fallback

Thank you 🙏

I'm sure it must be fixed in drush instead of core, moreover I'm using to provide URL for drush via command line instead of global option specifically for multi-site clients to point which site I'm contacting. Without it drush unable to select proper "sites/domain.tld"

PS so many efforts put on removal of base_url from core... so please don't wire it again

It could be tricky with domain → contrib module and trusted_host_patterns setting

not clear why ordering has changes https://git.drupalcode.org/project/drupal/-/commit/0b61d1dacd6d8026d5eb1...

and todo needs follow-up

IIRC this change was done in PHP 7.1 so it's safe enough to use new approach, moreover there's not a lot of distros which shipping old GD library.
Moreover the most of PHP builds using bundled GD library

the module moved to contrib

this plugin now living in action module

it happened

Wait till 11.2 release

as of core 11.2 expected in June but first alpha of PHP 8.5 in July the only thing to change is CORE_PHP_NEXT after it #3513062-2: Allow opt-in PHP 8.5 testing →

PS: usually in PHP lots of deprecations are commited in late beta cycle(

There's following settings https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes...

  # The minimum supported version of PHP for the current stable version of Drupal.
  CORE_PHP_MIN: '8.3'

  # The maximum/latest supported version of PHP for the current stable version of Drupal.
  CORE_PHP_MAX: '8.4'

  # The next/prerelease version of PHP targeted for support by the current stable version of Drupal.
  CORE_PHP_NEXT: '8.4'

  # The minimum version of PHP targeted for support by the next Major release of Drupal.
  CORE_NEXT_PHP_MIN: '9.0'

  # The maximum/latest version of PHP targeted for support.
  CORE_NEXT_PHP_MAX: '9.0'

  # The next/prelease version of PHP targeted for support by the next Major release of Drupal.
  CORE_NEXT_PHP_NEXT: '9.0'

So after 11.2 the `CORE_PHP_NEXT` should be increased to 8.5

Filed for contrib 📌 Allow opt-in PHP 8.5 testing Active

andypost → created an issue.

I bet contrib testing needs some changes in templates but surely doable

As I see rebuild went fine https://git.drupalcode.org/project/drupalci_environments/-/pipelines/448339

Looks complete, 12.x issue could live on its own!
So the issue could be closed

The only meaningful for 11.x is rename to prevent confusion 📌 Rename update module back to Update Status Active

Checked usage in contrib and it could be found in DB-mocks of D7 http://codcontrib.hank.vps-private.net/search?text=UpdaterFileTransferEx...

RTBC as both code and CR looks ready

I'd like to set RTBC but probably exception classes needs constructor to throw deprecation...
but they are inherited so both will throw

Better to provide both cookie and query-string options

+++ b/src/Form/ConfigForm.php
@@ -47,6 +52,7 @@ class ConfigForm extends ConfigFormBase {
+    $instance->settings = $container->get('settings');

I find it strange to have this in settings singleton, moreover it needs docs and tricky for non-tech users

please use config as other issue with cookie doing, you can always override config value via settings

Please add a code comment and simplify condition, also would be great to set expectations in test

Moreover I'd like to see merged approach with secret defined like ✨ Feature request: Ability to profile any page on demand Needs review

merged to 2.x-dev

I created 2.x branch and merging new features there

needs rebase

Created release https://www.drupal.org/project/xhprof/releases/2.0.0-beta1 →

Gonna start 2.x with it, the rest should be fixed in follow-ups

I find the code good to go but let's do that in 2.x branch

Nice catch, needs backport to 10.4 at least

Triggered build for production so image can be used without ci-yml hacks https://git.drupalcode.org/project/drupalci_environments/-/jobs/4644983

merged to production branch to make sure scheduling will be triggered on Friday (when current security releases of PHP will be rolled out)

but kernel test repeatedly fail

---- Drupal\KernelTests\Core\Image\ToolkitGdTest ----
Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Fail      Other      phpunit-9.xml        0 Drupal\KernelTests\Core\Image\Toolk
    PHPUnit Test failed to complete; Error: PHPUnit 10.5.38 by Sebastian Bergmann and contributors.
    
    Runtime:       PHP 8.5.0-dev
    Configuration: /builds/issue/drupal-3512558/core/phpunit.xml.dist
    
    ............FF...............FF...............FF...............  63 / 120 ( 52%)
    FF...............FF...............FF.....................       120 / 120 (100%)
    
    Time: 01:44.995, Memory: 10.00 MB
    
    Toolkit Gd (Drupal\KernelTests\Core\Image\ToolkitGd)
     ✔ Manipulations with 0
     ✔ Manipulations with 1
     ✔ Manipulations with 2
     ✔ Manipulations with 3
     ✔ Manipulations with 4
     ✔ Manipulations with 5
     ✔ Manipulations with 6
     ✔ Manipulations with 7
     ✔ Manipulations with 8
     ✔ Manipulations with 9
     ✔ Manipulations with 10
     ✔ Manipulations with 11
     ✘ Manipulations with 12
       ┐
       ├ Image 'image-test.png' object after 'rotate_5' action has the correct color placement at corner '0' - Actual: {255,0,93,0}, Expected: {255,0,255,0}, Distance: 26244, Tolerance: 0
       ├ Failed asserting that 26244 is equal to 0 or is less than 0.                                                                                                                      
       │
       │ /builds/issue/drupal-3512558/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:90
       │ /builds/issue/drupal-3512558/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:357
       ┴
     ✘ Manipulations with 13
       ┐
       ├ Image 'image-test.png' object after 'rotate_transparent_5' action has the correct color placement at corner '0' - Actual: {255,93,93,46}, Expected: {255,255,255,127}, Distance: 59049, Tolerance: 0
       ├ Failed asserting that 59049 is equal to 0 or is less than 0.                                                                                                                                        
       │
       │ /builds/issue/drupal-3512558/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:90
       │ /builds/issue/drupal-3512558/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:357
       ┴
     ✔ Manipulations with 14
     ✔ Manipulations with 15

Build tests fail for reason as Prophecy is strict in composer for supported versions

PHPStan passed but it does not use even 8.4 syntax

PHP runtime version: 8.5
PHP version for analysis: 8.3 (from config.platform.php in composer.json)
PHPStan version: 2.0.4

I think we can reuse the issue to add daily test with 8.5

Fixed image tag to `dev`

andypost → made their first commit to this issue’s fork.

I think it's fine to rebuild at 00 12 * * 5 Etc/UTC

testing scheduled build https://git.drupalcode.org/project/drupalci_environments/-/jobs/4644211

@mondrake the drupalci/php-8.5-ubuntu-apache:dev image is pushed, please give a try to it so I can merge to production and setup rebuild

Yes, that's the plan, just need to script updates of image for example weekly

Maybe deprecation of hooks could be done in module handler? gonna dig it