Looking at CI jobs I see no viable perf regression, so except fixing the last test it looks ready to go (good to get it in in early days on 11.2)
Looks great and ready to go!
Just not sure about return type which I think which be iterable (traversable) instead of array
Ludwig already mentioning that it should be replaced, so asked how to backport route in #3377094-17: Retire Ludwig? →
Module needs new issue to deal with 11.2 upgrade which gonna remove authorize.php route
#3491731-35: Remove the ability to update modules and themes via authorize.php →
Guess moving route should not be a blocker
Probably CI images needs update #3468905: Update default system encoding setting for Mysql images → before merging it as all Mysql 8.0+ images complain in logs about default encoding
Probably core needs own issue to discus default encoding additionally to ✨ Make ROW_FORMAT configurable Needs work
- InnoDB tables have a max index length of 767 bytes (in MySQL 5.6 and older) or 3072 bytes (MySQL 5.7+ with innodb_large_prefix enabled).
- UTF-8 MB4 encoding uses up to 4 bytes per character, meaning strings longer than 191 characters can exceed the max index size.
Undrafted MR
Looks it still blocked on 📌 Replace \PDO::FETCH_* constants to indicate fetch mode with an enumeration Active
Docs should be added
Module could provide hybrid context and raise required OT version to 1.1
Kinda
use OpenTelemetry\Context\ContextStorage;
use OpenTelemetry\Context\FiberBoundContextStorage;
class HybridContextStorage extends ContextStorage {
private $fiberStorage;
private $defaultStorage;
public function __construct() {
$this->fiberStorage = new FiberBoundContextStorage();
$this->defaultStorage = new ContextStorage();
}
public function current(): Context {
if (\Fiber::getCurrent()) {
return $this->fiberStorage->current();
}
return $this->defaultStorage->current();
}
public function attach(Context $context): Scope {
if (\Fiber::getCurrent()) {
return $this->fiberStorage->attach($context);
}
return $this->defaultStorage->attach($context);
}
}
Yes, there's server-setup.sh script which can be improved, so only a backend question remains - fpm or what?!
I did it intentionally because Mysql 9.x is Innovation releases (9.0 is outdated) and latest PHP is 8.4 so oldest and newest combinations are covered
Moreover in related we can use better matrix 📌 [CI] Introduce a separate stage for unit tests Active
Curious how we can create image containing both nginx and apache
looks failures are random
meantime mysql 9.1 is out so tested it
So filed 📌 Upgrade Mysql 9.0 CI job to use 9.1 image Active
andypost → created an issue.
Added testing using latest Mysql 8.4 and Postgresql 17
so I changed pgsql:17 for merge request job to use PHP 8.4 to re-use in daily testing
10.4/10.5 still needs 🐛 Big pipe cannot handle (GET) form redirects (EnforcedResponseException) Needs work
possibly, a rector rule could look for:
loops with a condition that returns the current element -array_find
loops with a condition that returns the current key -array_find_key
loops with a condition that returns FALSE -array_all
loops with a condition that returns TRUE -array_any
Fixed CI as config validation job does not calling composer with new lock file after reverting commit
so now job has
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 1 update, 0 removals
- Downloading symfony/polyfill-php84 (v1.31.0)
- Installing symfony/polyfill-php84 (v1.31.0): Extracting archive
- Upgrading drupal/core (11.x-dev 71e78e0 => 11.x-dev 4a48295): Source already presentWith PHP 8.4 and
✨
Add symfony/polyfill-php84 and make use of new array functions
Needs work
there's new [#Deprecated] attribute with since argument, so would be great to discus it in
✨
Adopt #[Deprecated] attribute
Active
#[Attribute(Attribute::TARGET_METHOD|Attribute::TARGET_FUNCTION|Attribute::TARGET_CLASS_CONSTANT)]
final class Deprecated
{
public readonly ?string $message;
public readonly ?string $since;
public function __construct(?string $message = null, ?string $since = null) { /* … */ }
}
Looks in PHP 8.5 this attribute can be applied to constants if RFC pass https://wiki.php.net/rfc/attributes-on-constants
Curious if it solve 🐛 Class "Doctrine\Deprecations\Deprecation" not found Active
I bet it duplicates 📌 Update Composer dependencies for 10.4.0-RC1 Active
This week is enough updates for release
I bet it will effect on tmpfs usage, moreover ATM mysql:8 image sometimes fail to start
Looking at changes I see no reason to provide BC and deprecations
Great clean-up!
Deprecation may need route aliases
what is a fate of authorize.php as it looks not deprecated yet?
Looking ahead it sounds like good idea, moreover in a light of new HTML 5 DOM in PHP 8.4
@spokje thank you, after rebase it passed
Twig has no effect on failure
There was 1 failure:
1) Drupal\Tests\jsonapi\Functional\NodeTest::testGetIndividual
Failed asserting that 'MISS' is identical to true.
/builds/issue/drupal-3490183/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122
/builds/issue/drupal-3490183/vendor/phpunit/phpunit/src/Framework/Constraint/IsIdentical.php:80
/builds/issue/drupal-3490183/core/modules/jsonapi/tests/src/Functional/ResourceTestBase.php:758
/builds/issue/drupal-3490183/core/modules/jsonapi/tests/src/Functional/ResourceTestBase.php:861
/builds/issue/drupal-3490183/core/modules/jsonapi/tests/src/Functional/NodeTest.php:340
/builds/issue/drupal-3490183/vendor/phpunit/phpunit/src/Framework/TestResult.php:729Filed follow-up 📌 Add daily testing with PHP 8.4 Active
andypost → created an issue.
There's 3.16 release but looks to downgrades detected https://github.com/twigphp/Twig/blob/v3.16.0/CHANGELOG
Added it for 10.4/10.5 in 📌 Update Composer dependencies for 10.4.0-RC1 Active
As twig 3.15 merged it can use more updates
+--------------------+---------+---------+
| Production Changes | From | To |
+--------------------+---------+---------+
| twig/twig | v3.15.0 | v3.16.0 |
+--------------------+---------+---------+
+------------------------------------+----------+----------+
| Dev Changes | From | To |
+------------------------------------+----------+----------+
| composer/ca-bundle | 1.5.3 | 1.5.4 |
| drupal/coder | 8.3.25 | 8.3.26 |
| google/protobuf | v4.28.3 | v4.29.1 |
| phpstan/phpstan | 1.12.11 | 1.12.12 |
| sirbrillig/phpcs-variable-analysis | v2.11.19 | v2.11.21 |
+------------------------------------+----------+----------+
andypost → made their first commit to this issue’s fork.
Meantime PHP 8.4 is out)
OOP hooks arrived
November'25-July'26 https://symfony.com/releases/8.0
So wait for SF 8.0 for removal deprecation in core/lib/Drupal/Core/CoreServiceProvider.php
https://git.drupalcode.org/project/drupal/-/commit/e39157a2add9041503902...
There's at least silencing in core/.deprecation-ignore.txt and it needs to figure out more
Looks ok to me
on second time package manager's build tests passed with rc5
Rebased, reverted to php-tuf/composer-stager:v2.0.0-rc5 as 2 tests failing reproducible and update coder to
8.3.26 →
andypost → created an issue.
This dependency becomes a blocker for stable release, see 📌 Update Composer dependencies for 11.1.0-RC1 Active
The php-tuf/composer-stager is an experimental module's dependency so should not block release
I find it ready!
PHPUnit 11 has own meta issue 🌱 [meta] Support PHPUnit 11 in Drupal 10 Postponed
The last PHP 8.4 fix been commited, so the only question is should we add a daily or on-commit run via 📌 [PP-2] Add core testing withPHP 8.4 Postponed
Probably daily run could be added too!
The last remaining bit is to enable CI 📌 [PP-2] Add core testing withPHP 8.4 Postponed
both blockers are in
both 10.4/10.5 passed https://git.drupalcode.org/issue/drupal-3427903/-/pipelines/353325
Passed as addition https://git.drupalcode.org/project/drupal/-/merge_requests/10379/diffs?c...
10.5 failed one unit test https://git.drupalcode.org/issue/drupal-3427903/-/jobs/3523954
---- Drupal\Tests\Core\Database\ConditionTest ----
Status Group Filename Line Function
--------------------------------------------------------------------------------
Fail Other phpunit-77.xml 0 Drupal\Tests\Core\Database\Conditio
PHPUnit Test failed to complete; Error: PHPUnit 9.6.21 by Sebastian
Bergmann and contributors.
Testing Drupal\Tests\Core\Database\ConditionTest
....................... 23 / 23
(100%)
Time: 00:00.120, Memory: 8.00 MB
OK (23 tests, 33 assertions)
Remaining self deprecation notices (4)
1x: Invalid characters in query operator: IS NOT NULL) ;INSERT INTO
{test} (name) VALUES ('test12345678'); --
1x in ConditionTest::testCompileWithSqlInjectionForOperator from
Drupal\Tests\Core\Database
1x: Invalid characters in query operator: IS NOT NULL) UNION ALL SELECT
name, pass FROM {users_field_data} --
1x in ConditionTest::testCompileWithSqlInjectionForOperator from
Drupal\Tests\Core\Database
1x: Invalid characters in query operator: IS NOT NULL) UNION ALL SELECT
name FROM {TEST_UPPERCASE} --
1x in ConditionTest::testCompileWithSqlInjectionForOperator from
Drupal\Tests\Core\Database
1x: Invalid characters in query operator: = 1 UNION ALL SELECT password
FROM user WHERE uid =
1x in ConditionTest::testCompileWithSqlInjectionForOperator from
Drupal\Tests\Core\Databaseit needs more work for 10.4.x/10.5.x
Filed follow-up 🌱 [META] Replace E_USER_WARNING with Exception Handling for Edge Cases in Error Reporting Active
Updated summary and CR
andypost → created an issue.
Looks good to go!
The drupal_common_theme() gone via
📌
Convert system_theme to OOP or remove it
Active
Surely it needs change record as method supposed to be introduced instead of constant
History can have per user LRU memory cache but it needs reasons
added suggestion
Probably it was a cause of 2.8.1 composer regression https://github.com/composer/composer/pull/12109#issuecomment-2400181869
real deprecation going in 8.5 https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_reflectionsetacc...
There's a list of deprecations for PHP 8.5 already https://wiki.php.net/rfc/deprecations_php_8_5
So it makes sense to catch them in core or via https://github.com/php/php-src/pull/10050
Looks like duplicate of
added suggestion and asked why phpunit-11 is not follow-up?
Official migration docs said different
Calling trigger_error() with error_level being equal to E_USER_ERROR is now deprecated.
Such usages should be replaced by either throwing an exception, or calling exit(), whichever is more appropriate.
Moreover exit() (die() too) now a userland function
Ref https://www.php.net/manual/en/migration84.incompatible.php#migration84.i...
So only 1 failure for 10.4 left
---- Drupal\Tests\Core\Database\ConditionTest ----
Status Group Filename Line Function
--------------------------------------------------------------------------------
Fail Other phpunit-77.xml 0 Drupal\Tests\Core\Database\Conditio
PHPUnit Test failed to complete; Error: PHPUnit 9.6.21 by Sebastian
Bergmann and contributors.
Testing Drupal\Tests\Core\Database\ConditionTest
....................... 23 / 23
(100%)
Time: 00:00.194, Memory: 8.00 MB
OK (23 tests, 33 assertions)
Remaining self deprecation notices (4)
1x: Invalid characters in query operator: IS NOT NULL) ;INSERT INTO
{test} (name) VALUES ('test12345678'); --
1x in ConditionTest::testCompileWithSqlInjectionForOperator from
Drupal\Tests\Core\Database
1x: Invalid characters in query operator: IS NOT NULL) UNION ALL SELECT
name, pass FROM {users_field_data} --
1x in ConditionTest::testCompileWithSqlInjectionForOperator from
Drupal\Tests\Core\Database
1x: Invalid characters in query operator: IS NOT NULL) UNION ALL SELECT
name FROM {TEST_UPPERCASE} --
1x in ConditionTest::testCompileWithSqlInjectionForOperator from
Drupal\Tests\Core\Database
1x: Invalid characters in query operator: = 1 UNION ALL SELECT password
FROM user WHERE uid =
1x in ConditionTest::testCompileWithSqlInjectionForOperator from
Drupal\Tests\Core\Database
Patches for 10.5 and 10.4 are the same but I've created new MR
This is a hard blocker for PHP 8.4
and tests are green!
Rebased, now only 2 packages
+--------------------------+---------+---------+
| Dev Changes | From | To |
+--------------------------+---------+---------+
| phpspec/prophecy | v1.19.0 | v1.20.0 |
| phpspec/prophecy-phpunit | v2.2.0 | v2.3.0 |
+--------------------------+---------+---------+