🇫🇷France @andypost

It looks like a blocker for deprecation 📌 Deprecate non-W3C compliant testing Active

PS: not clear state of w3c testing in contrib as it reported blocked too #3462681: Add W3C compliant JS testing →

new images will go to new registry, nightly tested

I bet it fixed, next PHP 8.4 rebuild is next week

Thank you

updated IS, as I greped for hook the typo fix added

So it's no longer a bug

The issue is still valid - this hooks

1. +++ b/core/modules/workspaces/workspaces.install
   @@ -30,8 +30,8 @@ function workspaces_requirements($phase) {
   -function workspaces_module_preinstall($module) {
   -  if ($module !== 'workspaces') {
   +function workspaces_module_preinstall($module, bool $is_syncing) {
   +  if ($module !== 'workspaces' || $is_syncing) {
   

   not sure it needed today

2. +++ b/core/profiles/demo_umami/modules/demo_umami_content/demo_umami_content.install
   @@ -10,8 +10,8 @@
   -function demo_umami_content_module_preinstall($module) {
   -  if ($module === 'demo_umami_content' && !\Drupal::service('config.installer')->isSyncing()) {
   +function demo_umami_content_module_preinstall($module, bool $is_syncing) {
   +  if ($module === 'demo_umami_content' && !$is_syncing) {
   

   this change still missing

AVIF is expensive (x2-x3 vs WEBP on compression) so fits for hires images mostly

I find it good/handy feature with CR)

Moreover AVIF is specifically good for big sizes with fallback

Thank you 🙏

I'm sure it must be fixed in drush instead of core, moreover I'm using to provide URL for drush via command line instead of global option specifically for multi-site clients to point which site I'm contacting. Without it drush unable to select proper "sites/domain.tld"

PS so many efforts put on removal of base_url from core... so please don't wire it again

It could be tricky with domain → contrib module and trusted_host_patterns setting

not clear why ordering has changes https://git.drupalcode.org/project/drupal/-/commit/0b61d1dacd6d8026d5eb1...

and todo needs follow-up

IIRC this change was done in PHP 7.1 so it's safe enough to use new approach, moreover there's not a lot of distros which shipping old GD library.
Moreover the most of PHP builds using bundled GD library

the module moved to contrib

this plugin now living in action module

it happened

Wait till 11.2 release

as of core 11.2 expected in June but first alpha of PHP 8.5 in July the only thing to change is CORE_PHP_NEXT after it #3513062-2: Allow opt-in PHP 8.5 testing →

PS: usually in PHP lots of deprecations are commited in late beta cycle(

There's following settings https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes...

  # The minimum supported version of PHP for the current stable version of Drupal.
  CORE_PHP_MIN: '8.3'

  # The maximum/latest supported version of PHP for the current stable version of Drupal.
  CORE_PHP_MAX: '8.4'

  # The next/prerelease version of PHP targeted for support by the current stable version of Drupal.
  CORE_PHP_NEXT: '8.4'

  # The minimum version of PHP targeted for support by the next Major release of Drupal.
  CORE_NEXT_PHP_MIN: '9.0'

  # The maximum/latest version of PHP targeted for support.
  CORE_NEXT_PHP_MAX: '9.0'

  # The next/prelease version of PHP targeted for support by the next Major release of Drupal.
  CORE_NEXT_PHP_NEXT: '9.0'

So after 11.2 the `CORE_PHP_NEXT` should be increased to 8.5

Filed for contrib 📌 Allow opt-in PHP 8.5 testing Active

andypost → created an issue.

I bet contrib testing needs some changes in templates but surely doable

As I see rebuild went fine https://git.drupalcode.org/project/drupalci_environments/-/pipelines/448339

Looks complete, 12.x issue could live on its own!
So the issue could be closed

The only meaningful for 11.x is rename to prevent confusion 📌 Rename update module back to Update Status Active

Checked usage in contrib and it could be found in DB-mocks of D7 http://codcontrib.hank.vps-private.net/search?text=UpdaterFileTransferEx...

RTBC as both code and CR looks ready

I'd like to set RTBC but probably exception classes needs constructor to throw deprecation...
but they are inherited so both will throw

Better to provide both cookie and query-string options

+++ b/src/Form/ConfigForm.php
@@ -47,6 +52,7 @@ class ConfigForm extends ConfigFormBase {
+    $instance->settings = $container->get('settings');

I find it strange to have this in settings singleton, moreover it needs docs and tricky for non-tech users

please use config as other issue with cookie doing, you can always override config value via settings

Please add a code comment and simplify condition, also would be great to set expectations in test

Moreover I'd like to see merged approach with secret defined like ✨ Feature request: Ability to profile any page on demand Needs review

merged to 2.x-dev

I created 2.x branch and merging new features there

needs rebase

Created release https://www.drupal.org/project/xhprof/releases/2.0.0-beta1 →

Gonna start 2.x with it, the rest should be fixed in follow-ups

I find the code good to go but let's do that in 2.x branch

Nice catch, needs backport to 10.4 at least

Triggered build for production so image can be used without ci-yml hacks https://git.drupalcode.org/project/drupalci_environments/-/jobs/4644983

merged to production branch to make sure scheduling will be triggered on Friday (when current security releases of PHP will be rolled out)

but kernel test repeatedly fail

---- Drupal\KernelTests\Core\Image\ToolkitGdTest ----
Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Fail      Other      phpunit-9.xml        0 Drupal\KernelTests\Core\Image\Toolk
    PHPUnit Test failed to complete; Error: PHPUnit 10.5.38 by Sebastian Bergmann and contributors.
    
    Runtime:       PHP 8.5.0-dev
    Configuration: /builds/issue/drupal-3512558/core/phpunit.xml.dist
    
    ............FF...............FF...............FF...............  63 / 120 ( 52%)
    FF...............FF...............FF.....................       120 / 120 (100%)
    
    Time: 01:44.995, Memory: 10.00 MB
    
    Toolkit Gd (Drupal\KernelTests\Core\Image\ToolkitGd)
     ✔ Manipulations with 0
     ✔ Manipulations with 1
     ✔ Manipulations with 2
     ✔ Manipulations with 3
     ✔ Manipulations with 4
     ✔ Manipulations with 5
     ✔ Manipulations with 6
     ✔ Manipulations with 7
     ✔ Manipulations with 8
     ✔ Manipulations with 9
     ✔ Manipulations with 10
     ✔ Manipulations with 11
     ✘ Manipulations with 12
       ┐
       ├ Image 'image-test.png' object after 'rotate_5' action has the correct color placement at corner '0' - Actual: {255,0,93,0}, Expected: {255,0,255,0}, Distance: 26244, Tolerance: 0
       ├ Failed asserting that 26244 is equal to 0 or is less than 0.                                                                                                                      
       │
       │ /builds/issue/drupal-3512558/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:90
       │ /builds/issue/drupal-3512558/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:357
       ┴
     ✘ Manipulations with 13
       ┐
       ├ Image 'image-test.png' object after 'rotate_transparent_5' action has the correct color placement at corner '0' - Actual: {255,93,93,46}, Expected: {255,255,255,127}, Distance: 59049, Tolerance: 0
       ├ Failed asserting that 59049 is equal to 0 or is less than 0.                                                                                                                                        
       │
       │ /builds/issue/drupal-3512558/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:90
       │ /builds/issue/drupal-3512558/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:357
       ┴
     ✔ Manipulations with 14
     ✔ Manipulations with 15

Build tests fail for reason as Prophecy is strict in composer for supported versions

PHPStan passed but it does not use even 8.4 syntax

PHP runtime version: 8.5
PHP version for analysis: 8.3 (from config.platform.php in composer.json)
PHPStan version: 2.0.4

I think we can reuse the issue to add daily test with 8.5

Fixed image tag to `dev`

andypost → made their first commit to this issue’s fork.

I think it's fine to rebuild at 00 12 * * 5 Etc/UTC

testing scheduled build https://git.drupalcode.org/project/drupalci_environments/-/jobs/4644211

@mondrake the drupalci/php-8.5-ubuntu-apache:dev image is pushed, please give a try to it so I can merge to production and setup rebuild

Yes, that's the plan, just need to script updates of image for example weekly

Maybe deprecation of hooks could be done in module handler? gonna dig it

Closed as duplicate ✨ D11 release Active

please use general compatibility issue

it needs extra script to run it using Gitlab's scheduler

would be great to have a test for the feature as globing has nuances per platform

I think zstd also should be added

Let's do that for ubuntu images as debian ones are outdated

Thank you! change record could be published I bet

Could it be closed? as alternate approach commited?

@dww can you move existing MR here https://git.drupalcode.org/project/drupal/-/merge_requests/10461

1st issue is in, now deprecation of a file transfer and frontend 📌 Deprecate authorize.php and the FileTransfer system Active

@cmlara thanks updated commit to both yq jq https://git.drupalcode.org/project/drupalci_environments/-/commit/5d1853...

PS: this week new PHP releases will out, meantime I did update prod images with fresher PECL

merged to dev so it can be tested https://git.drupalcode.org/project/drupalci_environments/-/jobs/4611960

btw menus probably should be required migration as core has fixed default list independently from menu module since 8.x #2085243: Rename Menu module into Menu UI module →

As jq is instalkled as dependency here's MR

Looks it's only few packages python3-argcomplete python3-toml python3-xmltodict python3-yaml

root@821a35c6e52f:/var/www/html# apt install jq yq
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following additional packages will be installed:
  libjq1 python3-argcomplete python3-toml python3-xmltodict python3-yaml
The following NEW packages will be installed:
  jq libjq1 python3-argcomplete python3-toml python3-xmltodict python3-yaml yq
0 upgraded, 7 newly installed, 0 to remove and 30 not upgraded.
Need to get 409 kB of archives.
After this operation, 1357 kB of additional disk space will be used.
Do you want to continue? [Y/n] ^C
root@821a35c6e52f:/var/www/html# apt install jq   
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following additional packages will be installed:
  libjq1
The following NEW packages will be installed:
  jq libjq1
0 upgraded, 2 newly installed, 0 to remove and 30 not upgraded.
Need to get 206 kB of archives.
After this operation, 481 kB of additional disk space will be used.
Do you want to continue? [Y/n] 

I mean adding yq requires to add python interpreter with few dependencies, IMO it's useless for CI image

download and update modules and themes through the web interface

using update manager UI)

thank you, fixed relnote

both removed functions has zero usage in contrib

added both CR and relnote

rebased and pushed 2 more commits to remove remains of _update_manager_access()

as both kinds of compression are common I think better to add them to images, just file issue to https://www.drupal.org/project/issues/drupalci_environments →

idea looks good, personally I think jq is the most common and it should be enough

who can review dependencies and security consequences?

It looks blocked on

- 📌 [policy no patch] Make it possible to mark plugins as deprecated Needs work
- 📌 Create a way to declare a plugin as deprecated Needs work

From documentation POV it's more handy (both for human and AI) to have short comment with @internal and reason why this point is not supposed to be extensible

Looking back at amount of wasted time of community on issues like "make this place extensible" and sometimes unexpected future of new code I strongly against using final

Moreover making open source it looks a nonsense to spend time on closing/protecting it

phpstan needs fixes

yesterday faced the same working on 📌 Remove UI and routes for the ability to update modules and themes via update.module and authorize.php Active
ref https://git.drupalcode.org/issue/drupal-3502973/-/jobs/4561201
basically it vary

    Standard Performance (Drupal\Tests\standard\FunctionalJavascript\StandardPerformance)
     ✘ Standard performance
       ┐
       ├ Failed asserting that two arrays are identical.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊      ],
       ┊      'CacheSetCount' => 45,
       ┊      'CacheDeleteCount' => 0,
       ┊ -····'CacheTagChecksumCount'·=>·38,
       ┊ -····'CacheTagIsValidCount'·=>·43,
       ┊ +····'CacheTagChecksumCount'·=>·37,
       ┊ +····'CacheTagIsValidCount'·=>·42,
       ┊      'CacheTagInvalidationCount' => 0,
       ┊      'CacheTagLookupQueryCount' => 21,
       ┊      'CacheTagGroupedLookups' => Array &2 [
       │
       │ /builds/issue/drupal-3502973/core/tests/Drupal/Tests/PerformanceTestTrait.php:679
       │ /builds/issue/drupal-3502973/core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php:175
       │ /builds/issue/drupal-3502973/core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php:57

usage in contrib

- http://codcontrib.hank.vps-private.net/search?text=UpdateManagerUpdate&f...
- http://codcontrib.hank.vps-private.net/search?text=UpdateReady&filename=

I think it ready for reviews

- forms and routes are removed
- subscriber no longer needed
- tests are cleaned/removed and somehow perf tests doing less
- mentions of routes/classes removed

Closing in favour of 📌 Remove UI and routes for the ability to update modules and themes via update.module and authorize.php Active

what's left here to do? maybe just a change record?

+1 and I'd raised priority as it will help wasm previews

That's about difference between Ш and Щ

Used to grep and a bit disappointed as both are valid but maybe not aligned with ICU

core/lib$ git grep "'shch'"
Drupal/Component/Transliteration/data/uk.php:21:  0x449 => 'shch',

is correct for Ukraine

core/lib$ git grep "'sch'"
Drupal/Component/Transliteration/data/kg.php:21:  0x449 => 'sch',
Drupal/Component/Transliteration/data/x04.php:13:  0x40 => 'r', 's', 't', 'u', 'f', 'kh', 'c', 'ch', 'sh', 'sch', '', 'y', '', 'e', 'yu', 'ya',

so both letters are covered 'sh', 'sch' for Russian but as comment #6 already said it's preferable to continue use it - both ts and sch https://en.wikipedia.org/wiki/GOST_7.79-2000

raised about 'sh', 'shch' in 🐛 Is there a typo in the Russian transliteration table? Postponed: needs info

new RFC happening https://wiki.php.net/rfc/true_async