Account created on 23 February 2007, about 17 years ago
  • Developer at SkilldΒ  …
#

Merge Requests

More

Recent comments

πŸ‡«πŸ‡·France andypost

Yes, as link to official docs said, to use assertions you need to enable development mode via pho.ini and then you can disable(0) it via ini_set('zend.assertions', 0); and enable when needed in tests

πŸ‡«πŸ‡·France andypost

Polished a bit new code

Re#68

Looking at UpdateKernel and InstallerKernel I see both overriding initializeContainer but calling parent, so I think it's ok to keep it in DrupalKernel

πŸ‡«πŸ‡·France andypost

andypost β†’ changed the visibility of the branch 2368263-remove-the-persist to hidden.

πŸ‡«πŸ‡·France andypost

Thank you! Still needs work to fix CS and

only need some test coverage for the new RouteProvider::getRouteAliases() method now.

πŸ‡«πŸ‡·France andypost

Curious is there a way to measure effect of changing driver's protocol?

πŸ‡«πŸ‡·France andypost

I bet there's a way to get version, maybe some meta data but some images are no longer rebuildable as Debian distro evolving

So it will be a trick to align versions and keep them updated, as security releases arriving not only for MySQL/pgsql but for it's dependencies too

πŸ‡«πŸ‡·France andypost

It was the last in list, so META can be closed as well!

PS: please close MR

πŸ‡«πŸ‡·France andypost

Last issue fixed

Closing it in favor of follow-up to fix remaining mentions in comments πŸ“Œ Replace remaining mentions of REQUEST_TIME in comments Active

Removed/re-titled a child issue as not a part of it πŸ“Œ FIx TODO in Drupal\entity_test\Plugin\Field\FieldType\ChangedTestItem Active

πŸ‡«πŸ‡·France andypost

Thank you πŸ‘

πŸ‡«πŸ‡·France andypost

checked - only mentions in comments are left

πŸ‡«πŸ‡·France andypost

Main issue with AVIF ATM is write support in imagick/gmagick (libheif vs libavif)

I think it could be contrib module to ensure each image-style or responsive set has specific convertion as the last effect

πŸ‡«πŸ‡·France andypost

Maybe better to address Attribute and "attribution-discovery" deprecations in follow-up as ATM core needs deprecation for annotation discovery

Additionally to #167 there's PHP RFC for the #[Deprecated] attribute which has stuck
- https://github.com/php/php-src/pull/11293
- https://wiki.php.net/rfc/deprecated_attribute

But PhpStorm has implementation which has growing adoption
- https://packagist.org/packages/jetbrains/phpstorm-attributes/stats
- https://github.com/JetBrains/phpstorm-attributes

πŸ‡«πŸ‡·France andypost

Core issues merged to 10.2 so the issue unblocked!

πŸ‡«πŸ‡·France andypost

Thank you a lot, it is great help for default content!

πŸ‡«πŸ‡·France andypost

As this was fixed in 9.5 I bet it safe to try remove protection

πŸ‡«πŸ‡·France andypost

Would be great to file rector issue for conversions

πŸ‡«πŸ‡·France andypost

The KV store is not a cache, caches are fixed already

πŸ‡«πŸ‡·France andypost

As of form state, it probably needs some prefix for cache keys to make serialization swappable

πŸ‡«πŸ‡·France andypost

Renaming an image makes the old image working so we can rename it later again without issue

Should we rename image if Ubuntu will package 3.46 at the time of release, so we end up with tons of image at dockerhub #3421477: Include DB type and major and minor version in TARGET_DB name β†’

πŸ‡«πŸ‡·France andypost

It should be sqlite-3.45 but Ubuntu may upgrade it before stable release to 3.46

πŸ‡«πŸ‡·France andypost

I gonna change image name as suggested today

πŸ‡«πŸ‡·France andypost

@fjgarlin nice idea, technically we should start use tags for images so renames could go easily

πŸ‡«πŸ‡·France andypost

It was testing MR

πŸ‡«πŸ‡·France andypost

andypost β†’ changed the visibility of the branch 3420974-mariadb-10.6-testing to hidden.

πŸ‡«πŸ‡·France andypost

Pushed 8.3-ubuntu image and MR is ready for review

πŸ‡«πŸ‡·France andypost

Renamed image and updated MR to see if tests are passing

πŸ‡«πŸ‡·France andypost

From slack @fjgarlin

So how about:

  • 8.3-sqlite3.2-apache
  • 8.3-sqlite3.5-apache

That way we’d just need to change the _TARGET_PHP from 8.3 to 8.3-sqlite3.2 for the sqlite jobs

πŸ‡«πŸ‡·France andypost

Will roll it on 15/02 or Friday

πŸ‡«πŸ‡·France andypost

image pushed so removing testing commit and using new image https://git.drupalcode.org/project/drupalci_environments/-/jobs/808648

maybe the new job should be added to daily ones?

πŸ‡«πŸ‡·France andypost

Pipeline passed, gonna merge it to production

πŸ‡«πŸ‡·France andypost

Second commit can be removed after testing of the image

πŸ‡«πŸ‡·France andypost

andypost β†’ made their first commit to this issue’s fork.

πŸ‡«πŸ‡·France andypost

it needs issue to add the image to core, working on image

πŸ‡«πŸ‡·France andypost

I gonna upgrade CI docker images to latest 15.6/16.2 follow #3421217: Upgrade Postgresql 15.6/16/2 β†’

πŸ‡«πŸ‡·France andypost

Btw latest 2.7.0 release of composer is security release, so 10.2 probably should require it too!

Same time they releases lts release https://github.com/composer/composer/releases/tag/2.2.23

πŸ‡«πŸ‡·France andypost

Thank you for elaboration! Sounds like solid plan, maybe rector's rule to have predictable conversion would be great addition)

πŸ‡«πŸ‡·France andypost

Baseline needs clean-up

  Line   core/lib/Drupal/Core/KeyValueStore/DatabaseStorageExpirable.php                               
 ------ ---------------------------------------------------------------------------------------------- 
         Ignored error pattern #^Call to deprecated constant REQUEST_TIME\:                            
         Deprecated in drupal\:8\.3\.0 and is removed from drupal\:11\.0\.0\.                          
         Use \\Drupal\:\:time\(\)\->getRequestTime\(\); $# in path                                     
         /builds/issue/drupal-3112295/core/lib/Drupal/Core/KeyValueStore/DatabaseStorageExpirable.php  
         was not matched in reported errors.  
πŸ‡«πŸ‡·France andypost

Is there a way to prevent commiting new code with non-static methods?

πŸ‡«πŸ‡·France andypost

Addressed feedback (there was some typos)

πŸ‡«πŸ‡·France andypost

andypost β†’ made their first commit to this issue’s fork.

πŸ‡«πŸ‡·France andypost

Looks it needs to upgrade this images for new security releases

πŸ‡«πŸ‡·France andypost

As this image will be stable in April lets wait for it

πŸ‡«πŸ‡·France andypost

Thank you, CR looks updated, so could be published and MR removed

πŸ‡«πŸ‡·France andypost

Not sure the new method is the best solution but it will need CR anyway

πŸ‡«πŸ‡·France andypost

rebased and addressed feedback

πŸ‡«πŸ‡·France andypost

@niko- please create new release from 8.x-2.2 tag

Production build https://api.contrib.social 0.61.6-2-g546bc20