🇫🇷France @andypost

Thank you, better to link'em

Looks like it needs new config and content entities to replicate the test

andypost → created an issue.

Filed test change for #3555375-4: Change use of Contact in \Drupal\Tests\user\Functional\UserPermissionsTest::testAccessBundlePermission →

I found no testing config entity with canonical route so changed test to use comment module

andypost → made their first commit to this issue’s fork.

the failure is caused by interface where NULL is expected array key and result

https://git.drupalcode.org/project/drupal/-/merge_requests/13219/diffs?c...

---- Drupal\Tests\layout_builder\FunctionalJavascript\BlockFilterTest ----
Status      Duration Info                                                                               
--------------------------------------------------------------------------------------------------------
Fail          5.639s testBlockFilter                                                                 
Failure       5.881s *** Process execution output ***                                                
    PHPUnit 11.5.42 by Sebastian Bergmann and contributors.
    
    Runtime:       PHP 8.5.0RC4
    Configuration: /builds/issue/drupal-3546535/core/phpunit.xml.dist
    
    F                                                                   1 / 1 (100%)
    
    HTML output was generated.
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_layout_builder_FunctionalJavascript_BlockFilterTest-1-38229833.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_layout_builder_FunctionalJavascript_BlockFilterTest-2-38229833.html
    
    
    Time: 00:05.755, Memory: 8.00 MB
    
    Block Filter (Drupal\Tests\layout_builder\FunctionalJavascript\BlockFilter)
     ✘ Block filter
       ┐
       ├ Failed asserting that actual size 3 matches expected size 2.
       │
       │ /builds/issue/drupal-3546535/core/modules/layout_builder/tests/src/FunctionalJavascript/BlockFilterTest.php:110
       ┴
    
    FAILURES!
    Tests: 1, Assertions: 16, Failures: 1.

Thank you! now the test pass

Agree this fix is cleaner

Thank you! ++ to fix the test and wait PHP 9.0

.png
.jpg
.gif
.svg

why not .wepb and .avif as core has limited set of supported image formats, but what about fonts?

Nice find, looks ready

fixed perf test and it looks ready to go (needs some time to update all runners with fresh image)

Hope this upgrade will not break 10.x branch

New image for PHP 8.4 pushed to dev https://git.drupalcode.org/project/drupalci_environments/-/commit/deda6c...

added commit to test it, will push remaining upgrade after testing

andypost → made their first commit to this issue’s fork.

Setting up nodejs (20.19.5-1nodesource1) ...
Setting up yarn (1.22.22-1) ...

I will split MR into parts so testing will be faster

@smustgrave there's today's release with RC3 https://github.com/ddev/ddev/releases/tag/v1.24.9

+1 rtbc

caching also needs some work but having hundreds of menu links makes node-edit form very slow

I bet the question is about how "theme://{$theme}/path/to/resource" is parsing /path/to/resource part using .. and other hacks

Looks good to go, tests fails because of unrelated deprecations

I bet it needs CR and update CR https://www.drupal.org/node/2150267 → which is wrongly points to $request->get() but should tell to use one of properties

Call to deprecated method get\\(\\) of class Symfony\\\\Component\\\\HttpFoundation\\\\Request\\:
since Symfony 7\\.4, use properties `\\-\\>attributes`, `query` or `request` directly instead

Drupal GitLabCI

is using bundled into php-src forked source of libgd which is updated but other envs can try link to system library which usually very dated

sorry

Thank you! I think it ready to go and improving tests

PS: added MR's diff for testing and now only composer's tests fail https://git.drupalcode.org/issue/drupal-3523596/-/pipelines/645292

updated 8.5 image is pushed (contains fix for AVIF/HEIF)

Added patch for AVIF/HEIF to 8.5 PHP CI image but I see no changes in GD tests
Tests: 120, Assertions: 1277, Failures: 27.

Previous pipeline showed 1 new failure which no longer valid

 ✘ Node page administrator
       ┐
       ├ Failed asserting that two arrays are identical.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊  Array &0 [
       ┊ -····'QueryCount'·=>·525,
       ┊ -····'CacheGetCount'·=>·550,
       ┊ +····'QueryCount'·=>·522,
       ┊ +····'CacheGetCount'·=>·530,
       ┊      'CacheGetCountByBin' => Array &1 [
       ┊ -········'config'·=>·201,
       ┊ -········'bootstrap'·=>·28,
       ┊ -········'discovery'·=>·112,
       ┊ +········'config'·=>·195,
       ┊ +········'bootstrap'·=>·27,
       ┊ +········'discovery'·=>·110,
       ┊          'data' => 72,
       ┊ +········'entity'·=>·23,
       ┊          'dynamic_page_cache' => 2,
       ┊ -········'default'·=>·45,
       ┊ -········'entity'·=>·23,
       ┊ +········'default'·=>·34,
       ┊          'render' => 39,
       ┊          'menu' => 28,
       ┊      ],
       ┊ -····'CacheSetCount'·=>·455,
       ┊ +····'CacheSetCount'·=>·456,
       ┊      'CacheDeleteCount' => 0,
       ┊      'CacheTagInvalidationCount' => 0,
       ┊      'CacheTagLookupQueryCount' => 47,
       │
       │ /builds/issue/drupal-3523596/core/tests/Drupal/Tests/PerformanceTestTrait.php:692
       │ /builds/issue/drupal-3523596/core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryAuthenticatedPerformanceTest.php:123

Looks ok but not clear why only interface updated, it's already API change in interface so implementation could be updated same time

ref https://git.drupalcode.org/project/drupal/-/merge_requests/13602/diffs?c...

IP address could be NULL (even SF fixed it) so not sure now flood may work in CLI where request has no IP or runtime where server is misconfigured

Trixie is out only in august and 13.1 is the starting point where people starting to adopt new version, so yes, better to stick to SURY or docker images

SF updates landed and 📌 Fix string type hints to Container getters for PHP 8.5 Needs review should fix component unit test

thank you, rebased to make sure component tests are green!

one more commited 📌 Remove use of Contact from config_translation tests Active

random failure, and no test coverage for empty string

does it need follow-up for SF 7.4?

Also it needs follow-up for PHP 8.5+ to fix reInjectMe() to use __serialize() as part of 📌 Deal with PHP 8.5 depration of __sleep()/__wakeup() Active

Good idea, moreover it will help to fix injection of theme_installer and config.installer

good idea, replaced and rebased

rebased and a bit more updates

+------------------------+--------+--------+
| Dev Changes            | From   | To     |
+------------------------+--------+--------+
| drupal/coder           | 8.3.30 | 8.3.31 |
| mglaman/phpstan-drupal | 2.0.9  | 2.0.10 |
| nikic/php-parser       | v5.6.1 | v5.6.2 |
| webmozart/assert       | 1.11.0 | 1.12.0 |
+------------------------+--------+--------+

yes, and while comment's module fate is unclear we lack of opinions

Looks it needs follow-up to get rid of __clone() for PHP 8 serialize but ++

There's a chance to stop using masterminds/html5 dependency adopting native PHP 8.4 parser

So could have ✨ Explore PHP 8.4 native HTML 5 parser vs html5-php Active

hope fixed

somehow it started to fail

rebased after previous removals

it will help to split it to contib without dated drupal_migrate_ui

removed from umami

now
- 📌 Remove use of Contact from config_translation tests Active
- 📌 Move mention of Contact from core help to contact module Active
- recipe and migrations

It needs trick to replace Input's test

  Input (Drupal\KernelTests\Core\Recipe\Input)
     ✘ Default value from config
       ┐
       ├ Drupal\Core\Recipe\RecipeFileException: There is no /builds/issue/drupal-3553006/core/recipes/feedback_contact_form/recipe.yml file
       │
       │ /builds/issue/drupal-3553006/core/lib/Drupal/Core/Recipe/Recipe.php:115
       │ /builds/issue/drupal-3553006/core/lib/Drupal/Core/Recipe/Recipe.php:90
       │ /builds/issue/drupal-3553006/core/tests/Drupal/KernelTests/Core/Recipe/InputTest.php:66

as contact on way out of core, I think it could be moved to contrib as not a priority for the phase

after removal from standard profile it looks the low hanging fruit as ready

removal from standard profile is done!

Filed change record https://www.drupal.org/node/3553411 → looking for help to improve

I find it ready

try to avoid $_ENV, getenv and putenv and exclusively rely on $_SERVER as an environment variable source

Strong ++ as it requirement for FrankenPHP which is ZTS and help to 📌 Add Caddyfile configuration Active

needs more work to fix tests

Yes, removed SF update as I tested that component tests pass.

The removed test cases are exactly testing the case which is not valid according to interface

Superseded by 📌 Update Composer dependencies for 11.3.0 Active

With this updates and 📌 Fix string type hints to Container getters for PHP 8.5 Needs review component unit tests pass on php8.5

fixed all methods using ID, fix for tests needed

andypost → created an issue.

@longwave yes, so curious as @alexpott asked to split deprecations move into separate issue

discussed with @xjm at Drupalcon and priority to clean-up standard profile and tests first for 11.3 and it's ok to do deprecation in 11.4/12

Looks ready now

andypost → created an issue.

needs split into set of issues per component at least and debug each case

- Container could add typehint and remove broken tests
- NestaedArray needs to fix test and provide typehint
- Lazy collection needs to check for null and skip
- DiscoveryTrait.php should not allow null plugin

discussed with Alexpott and we decided to split it for SF, masterminds and doctrine

reroll

Raising priority as upgrade of masterminds library caused tests to fail in #3551569: Update symfony/* with dependencies for PHP 8.5 →

As newer masterminds/html5 fail our tests it makes sense to start transition to native HTML5 parser ✨ Explore PHP 8.4 native HTML 5 parser vs html5-php Active

Filed upstream issue https://github.com/php/php-src/issues/20201

andypost → created an issue. See original summary → .

Hope I fixed tests

Looks ready to go

andypost → made their first commit to this issue’s fork.

rebased and fixed perf tests

andypost → made their first commit to this issue’s fork.

I see it has conflicts with 📌 Remove Contact module from the Standard profile Active

andypost → made their first commit to this issue’s fork.

doctrine/lexer could use update separate issue as its dependency doctrine/deprecations going to require-dev
https://github.com/doctrine/lexer/blob/3.0.x/UPGRADE.md

Doctrine\Common\Lexer\Token no longer implements ArrayAccess. Parameter type declarations have been added to Doctrine\Common\Lexer\AbstractLexer and Doctrine\Common\Lexer\Token. You should add both parameter type declarations and return type declarations to your lexers, based on the @return phpdoc.

the breaking change in masterminds/html5 2.10 breaks 2 tests #5

Looking at numbers it looks bad idea to reintroduce and maintain custom dispatcher

Nice improvement!

filed another MR without deps as 2 tests fail and and probably masterminds is the cause

+-----------------------+-------+---------+
| Production Changes    | From  | To      |
+-----------------------+-------+---------+
| doctrine/deprecations | 1.1.5 | REMOVED |
| doctrine/lexer        | 2.1.1 | 3.0.1   |
| masterminds/html5     | 2.9.0 | 2.10.0  |
+-----------------------+-------+---------+

+-----------------------+------+-------+
| Dev Changes           | From | To    |
+-----------------------+------+-------+
| doctrine/deprecations | NEW  | 1.1.5 |
+-----------------------+------+-------+

errors are

    Image Url Provider (Drupal\Tests\ckeditor5\FunctionalJavascript\ImageUrlProvider)
     ✔ Alt text required with Restricted
     ✔ Alt text required with Unrestricted
     ✔ Alignment with Block·image
     ✔ Alignment with Inline·image
     ✘ Width with Image·resize·with·percent·unit·(only·allowed·in·HTML·4)
       ┐
       ├ Failed asserting that two strings are identical.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊ -'33%'
       ┊ +'88'
       │
       │ /builds/issue/drupal-3551569/core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTestProviderTrait.php:231
       ┴
     ✘ Width with Image·resize·with·(implied)·px·unit
       ┐
       ├ Failed asserting that two strings are identical.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊ -'100'
       ┊ +'88'
       │
       │ /builds/issue/drupal-3551569/core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTestProviderTrait.php:231
       ┴

and

Image Test Provider (Drupal\Tests\ckeditor5\FunctionalJavascript\ImageTestProvider)
     ✔ Alt text required with Restricted
     ✔ Alt text required with Unrestricted
     ✔ Alignment with Block·image
     ✔ Alignment with Inline·image
     ✘ Width with Image·resize·with·percent·unit·(only·allowed·in·HTML·4)
       ┐
       ├ Failed asserting that two strings are identical.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊ -'33%'
       ┊ +'40'
       │
       │ /builds/issue/drupal-3551569/core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTestProviderTrait.php:231
       ┴
     ✘ Width with Image·resize·with·(implied)·px·unit
       ┐
       ├ Failed asserting that two strings are identical.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊ -'100'
       ┊ +'40'
       │
       │ /builds/issue/drupal-3551569/core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTestProviderTrait.php:231
       ┴

updated IS and filed - #3551569: Update symfony/* with dependencies for PHP 8.5 →