Support brotli compression of assets

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Added rerolls of patch #20 and the non-`.htaccess` version of #22 on Drupal 10.1.x.

So taking a look at this

Could we add it's own test case? Seems some tests had to be updated for it but not sure if it's actually testing.

Since the schema is updating most likely will need an upgrade path + upgrade path tests.

If this new setting is required (which seems to be) it will require a change record also

Thanks!

What if new compression algo will be added to browsers?

Better to deprecate "gzip" option in favor of "compress" which will be common trigger to produce all possible assets archives.
Also it could be a sequence of algo to limit :

compress:
- gzip
- brotli

+++ b/core/lib/Drupal/Core/Asset/AssetDumper.php
@@ -77,6 +77,16 @@ public function dumpToUri(string $data, string $file_extension, string $uri): st
+    if (extension_loaded('brotli') && \Drupal::config('system.performance')->get($file_extension . '.brotli')) {

+++ b/core/modules/system/config/install/system.performance.yml
@@ -4,6 +4,7 @@ cache:
 css:
   preprocess: true
   gzip: true
+  brotli: false

@@ -12,4 +13,5 @@ fast_404:
 js:
   preprocess: true
   gzip: true
+  brotli: false

Not sure it makes sense to introduce new configuration and without UI, it could re-use "gzip" setting to produce compressed assets using gzip/brotli

A compress item with a sequence sounds good.

Having said that we've got the problem that the .htaccess rules can't be configured - they will always need to check in order of likelihood-of-support first. So if we add brotli support to htaccess but it's disabled by the site, the rewrite rules will still look for those files.

Makes me wonder if we should just do 'compress' as a boolean and write out everything we possibly can.

Added rerolls of patches in #24 on Drupal 10.2.x. I think they should also apply on 11.x-dev.

Added rerolls of patches in #29 on Drupal 10.2.x.

Is there a variable we can set in settings.php?

Not sure how tests can cover it but CR should mention update of nginx conf as well