- Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
about 2 years ago Not currently mergeable. - @catch opened merge request.
- First commit to issue fork.
- @catch opened merge request.
- 🇬🇧United Kingdom catch
The fork was too far behind (early 10.x branch) to be able to rebase on, so cherry-picked the one commit that still applied to 11.x, recreated one more of @neclimdul's and pushed a new branch.
Also adding PermissionsHashGenerator here after discovering it makes debugging test cache changes unhelpfully difficult. We probably need to split that to its own issue though because it'll likely need constructor deprecations and a double check that it's definitely not security sensitive (I don't think it is though, it's a hash of permissions, not account information otherwise).
- First commit to issue fork.
- 🇺🇸United States nicxvan
Is there a reason not to use xxh3?
It seems to be supported and faster, but I'll admit I'm not super familiar with this so I may be missing something.
- 🇬🇧United Kingdom catch
Can't see any reason not to use xxh3, probably got thrown off by it being 'new' but it was included in PHP 8.1
- 🇬🇧United Kingdom catch
The MR is back to green, but we need to figure out scope here. There are other sha256 and other hash usages in core we can probably convert.
Also not sure whether we want to spin-off PermissionsHashGenerator and any other logic changes to their own issues. Also noticed in the twig change that we're using Crypt::base64Encode() purely to base64 encode a hash but I think that's already the case with xxh3 so we could probably use xxh3 for that case too.