Automated Drupal 11 compatibility fixes for bartik

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

This patch was created using these packages:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.7
3. palantirnet/drupal-rector: 0.20.1

This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.10
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.2, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.2

Color's tests depends on it

Hey guys. Is there something more needed before you can cut a release for D11 ? I would think not since @andypost marked it RTBC 5 months ago, but if you are missing something, I can probably do it.

I bet it needs to check CI template as very probably it needs changes but it doable in follow-up if any maintainer can be found

I tested MR!8 on Drupal 11 and it worked fine
RTBC +1

I suggest making a 2.0.x branch which supports Drupal 11 and has a minimum of Drupal 10.3. That way, there is no need for the DeprecationHelper::backwardsCompatibleCall().

FWIW, on my mac, for some reason patch fails to apply when using composer install --prefer-dist, but passes with composer install --prefer-source.

Is there any update - i do like an idea to release a 2.0 branch.
Is anyone able to release a new version?

FWIW until this is merged, one can use composer require "mglaman/composer-drupal-lenient": "^1.0" and add this fragment in composer.json, in the extra section.

    "drupal-lenient": {
      "allowed-list": ["drupal/bartik"]
    }

+1 RTBC. Looks great.

I also approve of the idea of a 2.x branch and release.

There should also be a 1.0.x release node made so that a development snapshot gets generated and 1.0.x is an option in the "Version" pop-up menu.

I sent a message to lauriii → asking for this to be merged.

@andypost why is it core_version_requirement: '>=10.1.3 || ^11'?

I believe that's the version that introduced DeprecationHelper::backwardsCompatibleCall()

https://git.drupalcode.org/project/bartik/-/merge_requests/8/diffs#d47bc...

Why not like this?

core_version_requirement: '^10.1.3 || ^11'

At this point, perhaps it should be:

core_version_requirement: '^10.3 || ^11.0'

Yes, if the maintainer creates new 2.x branch, then that makes sense.

A new version 2 would be great. Maybe one of the maintainers can create the new branch and create a release.

">=10.1.3" is definitely wrong, that would include any future major version.

Don't care if it requires 10.3 or the helper is used, but this should be fixed, that will cause problems in the future.

requiring 10.3 would not need a new major version, even 10.3 is unsupported now and updating requirements is fine in a minor.

Tests are failing pretty hard due to the composer.json. I don't think that's required, defining repositories like that is not valid in a module/theme and there are no dependencies except core. Lets remove that?

Tests are now passing. The problem was the repositories key in composer.json. The tests also needed an update.

Personally I prefer not mixing in coding standard and spelling fixes in a compatibility issue, it just makes it much larger and those aren't necessary to have a green MR. But it's done, so leaving that to a maintainer to decide.

I'd also completely remove the composer.json, it doesn't add any value, that will be overwritten anyway on drupal.org and the description is outdated, this isn't a core theme anymore. But that too is a maintainer decision.

I'm OK with everything @berdir said.

I have put everything from this issue that is not related to Drupal 11 compatibility into 📌 Add composer.json Active . Tests are passing there. Merge that first and this issue becomes only about Drupal 11.

Hello Team,
I tested and it is working fine with Drupal 11, can we merge and create D11 compatible release so this package available for Drupal 11.
Thanks

I would also very much like a working release for this.

Made a patch file in the meantime.

The patch in #34 didn't work for me. The attached patch did, however.

Using ByteSizeMarkup::create() has the effect of dropping support for anything older than Drupal 10.2.