Discus adoption of #NoDiscard and PHP 8.5

added list of implemented https://wiki.php.net/rfc#php_85

https://wiki.php.net/rfc/deprecations_php_8_5

I did not mean to open a fork… must have tapped something inadvertently.

First Phpstan error on 8.5 alpha3

     Internal error: AST failed to parse in located source (line 3): Syntax                             
     error, unexpected T_CLONE, expecting T_EXIT or T_STRING or T_READONLY or                           
     '(', Syntax error, unexpected T_VARIABLE, Syntax error, unexpected ')'                             
                                                                                                        
     <?php                                                                                              
                                                                                                        
     function clone(object $object, array $withProperties = []): object                                 
     {                                                                                                  
     }                                                                                                  
      while analysing file                                                                              
     /builds/issue/drupal-3523596/core/tests/Drupal/KernelTests/Core/Entity/ContentEntityCloneTest.php  

The ToolkitGdTest test fails probably because of

- https://github.com/php/php-src/pull/17375
- https://github.com/php/php-src/pull/19107

     ✘ Manipulations with 29
       ┐
       ├ Image 'image-test.gif' object after 'rotate_5' action has the correct color placement at corner '0' - Actual: {255,0,93,0}, Expected: {255,0,255,0}, Distance: 26244, Tolerance: 0
       ├ Failed asserting that 26244 is equal to 0 or is less than 0.             
       │
       │ /builds/issue/drupal-3523596/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:90
       │ /builds/issue/drupal-3523596/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:357
       ┴
     ✘ Manipulations with 30
       ┐
       ├ Image 'image-test.gif' object after 'rotate_transparent_5' action has the correct color placement at corner '0' - Actual: {255,93,0,46}, Expected: {255,255,255,127}, Distance: 97830, Tolerance: 0
       ├ Failed asserting that 97830 is equal to 0 or is less than 0.             
       │
       │ /builds/issue/drupal-3523596/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:90
       │ /builds/issue/drupal-3523596/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:357
       ┴

Filed issue for the test 🐛 Fix ToolkitGdTest n PHP 8.5 Active

Also created 2 fixes for commited deprecations (will be released on August 13)

📌 Remove remaining usage of setAccessible() Active
📌 Clean-up deprecated non-standard cast names Active

one more deprecation to fix #2901831: Only use colons in case statements →

A bit more deprecations

php message: PHP Deprecated: Case statements followed by a semicolon (;) are deprecated, use a colon (:) instead in /var/www/html/web/vendor/react/promise/src/functions.php on line 300

https://github.com/reactphp/promise/commit/d3998c8a5d3cff0b39b2f332da550...

php message: Failed to log error: Deprecated function: Function curl_close() is deprecated since 8.5, as it has no effect since PHP 8.0 in GuzzleHttp\Handler\CurlFactory->__destruct() (line 732 of /var/www/html/web/vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php). #0 /var/www/html/web/core/includes/bootstrap.inc(104): _drupal_error_handler_real()
#1 /var/www/html/web/vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php(732): _drupal_error_handler()
#2 [internal function]: GuzzleHttp\Handler\CurlFactory->__destruct()
#3 {main}

need new issue for guzzle

https://github.com/nikic/PHP-Parser/commit/02dcdd74bb328ca0bd9b9e459ca25...

and one more

vendor/sebastian/recursion-context/src/Context.php:148
    Method SplObjectStorage::contains() is deprecated since 8.5, use method SplObjectStorage::offsetExists() instead

- https://github.com/guzzle/guzzle/issues/3297
- https://github.com/Lullabot/php-webdriver/pull/16
- https://github.com/minkphp/MinkBrowserKitDriver/pull/185

Updated IS with curent state

one more deprecation commited https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_passing_integers...

@andypost now 📌 Bump PHPUnit to ^11.5.32 with all dependencies for testing with PHP 8.5 Active fixes some of the dependencies telated issues

4 deps left https://github.com/phpDocumentor/ReflectionDocBlock/releases/tag/5.6.3

https://github.com/phpspec/prophecy/commit/b6eee2b6fc274809c107bb0fb6ee2...

New URI class commited https://wiki.php.net/rfc/url_parsing_api

Filed separare issue for Guzzle upgrade 📌 Upgrade Guzzle to 7.10 for PHP 8.5 support Active

Beta2 is tagged and all tests fail again because PDO constants are deprecated

    1 test triggered 3 PHP deprecations:
    
    1) /builds/issue/drupal-3523596/core/modules/mysql/src/Driver/Database/mysql/Connection.php:124
    Constant PDO::MYSQL_ATTR_USE_BUFFERED_QUERY is deprecated since 8.5, use Pdo\Mysql::ATTR_USE_BUFFERED_QUERY instead
    
    Triggered by:
    
    * Drupal\Tests\workflows\Kernel\ComplexWorkflowTypeTest::testLoadMultipleByType
      /builds/issue/drupal-3523596/core/modules/workflows/tests/src/Kernel/ComplexWorkflowTypeTest.php:27
    
    2) /builds/issue/drupal-3523596/core/modules/mysql/src/Driver/Database/mysql/Connection.php:128
    Constant PDO::MYSQL_ATTR_FOUND_ROWS is deprecated since 8.5, use Pdo\Mysql::ATTR_FOUND_ROWS instead
    
    Triggered by:
    
    * Drupal\Tests\workflows\Kernel\ComplexWorkflowTypeTest::testLoadMultipleByType
      /builds/issue/drupal-3523596/core/modules/workflows/tests/src/Kernel/ComplexWorkflowTypeTest.php:27
    
    3) /builds/issue/drupal-3523596/core/modules/mysql/src/Driver/Database/mysql/Connection.php:133
    Constant PDO::MYSQL_ATTR_MULTI_STATEMENTS is deprecated since 8.5, use Pdo\Mysql::ATTR_MULTI_STATEMENTS instead
    
    Triggered by:
    
    * Drupal\Tests\workflows\Kernel\ComplexWorkflowTypeTest::testLoadMultipleByType
      /builds/issue/drupal-3523596/core/modules/workflows/tests/src/Kernel/ComplexWorkflowTypeTest.php:27

tracking of deprecations https://github.com/php/php-src/issues/19468

Needs separate issues

- https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_driver_specific_...

- https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_arrayobject_and_...

I think we should open a new issue to discuss #NoDiscard so retitling this one.

Updated MR status in the issue summary a bit. It looks like justinrainbow/json-schema is planning to do a release tomorrow, if we're able to update to that next week then I think that will get us to clean phpunit test runs on PHP 8.5

@andypost are there already issues open for the remaining core changes like the mysql driver?

I need to file new issues for mysql, migrate and chr(), probably last 2 could be done in one task

The biggest challenge is 🐛 Fix ToolkitGdTest n PHP 8.5 Active

PS: once justinrainbow/json-schema will be merged, composer should create another release and it will fix package manager tests

updated IS with new releases

Filed
- 📌 Address PHP 8.5 deprecations of driver specific PDO constants and methods Active
- 📌 Fix PHP 8.5 deprecations of chr() and array iterator Active

Waiting for next composer release

https://github.com/composer/composer/pull/12517

The #Deprecated attribute now allowed for traits to deprecate https://github.com/php/php-src/commit/34a6e86282508d3b3c592d7156727204aa...