- Issue created by @andypost
- ๐ซ๐ทFrance andypost
added list of implemented https://wiki.php.net/rfc#php_85
- First commit to issue fork.
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
I did not mean to open a forkโฆ must have tapped something inadvertently.
- ๐ซ๐ทFrance andypost
First Phpstan error on 8.5 alpha3
Internal error: AST failed to parse in located source (line 3): Syntax error, unexpected T_CLONE, expecting T_EXIT or T_STRING or T_READONLY or '(', Syntax error, unexpected T_VARIABLE, Syntax error, unexpected ')' <?php function clone(object $object, array $withProperties = []): object { } while analysing file /builds/issue/drupal-3523596/core/tests/Drupal/KernelTests/Core/Entity/ContentEntityCloneTest.php
- ๐ซ๐ทFrance andypost
The
ToolkitGdTest
test fails probably because of- https://github.com/php/php-src/pull/17375
- https://github.com/php/php-src/pull/19107โ Manipulations with 29 โ โ Image 'image-test.gif' object after 'rotate_5' action has the correct color placement at corner '0' - Actual: {255,0,93,0}, Expected: {255,0,255,0}, Distance: 26244, Tolerance: 0 โ Failed asserting that 26244 is equal to 0 or is less than 0. โ โ /builds/issue/drupal-3523596/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:90 โ /builds/issue/drupal-3523596/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:357 โด โ Manipulations with 30 โ โ Image 'image-test.gif' object after 'rotate_transparent_5' action has the correct color placement at corner '0' - Actual: {255,93,0,46}, Expected: {255,255,255,127}, Distance: 97830, Tolerance: 0 โ Failed asserting that 97830 is equal to 0 or is less than 0. โ โ /builds/issue/drupal-3523596/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:90 โ /builds/issue/drupal-3523596/core/tests/Drupal/KernelTests/Core/Image/ToolkitGdTest.php:357 โด
- ๐ซ๐ทFrance andypost
Filed issue for the test ๐ Fix ToolkitGdTest n PHP 8.5 Active
- ๐ซ๐ทFrance andypost
Also created 2 fixes for commited deprecations (will be released on August 13)
๐ Remove remaining usage of setAccessible() Active
๐ Clean-up deprecated non-standard cast names Active - ๐ซ๐ทFrance andypost
one more deprecation to fix #2901831: Only use colons in case statements โ
- ๐ซ๐ทFrance andypost
A bit more deprecations
php message: PHP Deprecated: Case statements followed by a semicolon (;) are deprecated, use a colon (:) instead in /var/www/html/web/vendor/react/promise/src/functions.php on line 300
https://github.com/reactphp/promise/commit/d3998c8a5d3cff0b39b2f332da550...
php message: Failed to log error: Deprecated function: Function curl_close() is deprecated since 8.5, as it has no effect since PHP 8.0 in GuzzleHttp\Handler\CurlFactory->__destruct() (line 732 of /var/www/html/web/vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php). #0 /var/www/html/web/core/includes/bootstrap.inc(104): _drupal_error_handler_real() #1 /var/www/html/web/vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php(732): _drupal_error_handler() #2 [internal function]: GuzzleHttp\Handler\CurlFactory->__destruct() #3 {main}
need new issue for guzzle
- ๐ซ๐ทFrance andypost
https://github.com/nikic/PHP-Parser/commit/02dcdd74bb328ca0bd9b9e459ca25...
and one more
vendor/sebastian/recursion-context/src/Context.php:148 Method SplObjectStorage::contains() is deprecated since 8.5, use method SplObjectStorage::offsetExists() instead
- ๐ซ๐ทFrance andypost
one more deprecation commited https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_passing_integers...
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
@andypost now ๐ Bump PHPUnit to ^11.5.32 with all dependencies for testing with PHP 8.5 Active fixes some of the dependencies telated issues
- ๐ซ๐ทFrance andypost
- ๐ซ๐ทFrance andypost
New URI class commited https://wiki.php.net/rfc/url_parsing_api