- Issue created by @andypost
- Merge request !13107PHP 8.5 deprecations of driver specific PDO constants #3543710 → (Closed) created by andypost
- 🇮🇹Italy mondrake 🇮🇹
PDO driver subclasses were introduced by PHP 8.4 so I think we can use them also in 8.4. and not just in 8.5.
- 🇬🇧United Kingdom catch
Apart from #4 this looks good to me. We could maybe open a stub 12.x ticket to check all usages of
PHP_VERSION_ID
for clean-up, probably one ticket for all of those would be enough. - 🇫🇷France andypost
Filed for #5 📌 [12.x] Clean up PHP_VERSION_ID conditions for unsupported PHP versions Postponed
@mondrake yes, subclasses added in 8.4 so I checked and see that constants added as well
php -r 'echo \PDO\Mysql::ATTR_FOUND_ROWS;' 1005
so I lowered version check but phpstan probably has no valid stubs and can't find this classes, probably because it consuming PHP version from composer where it's 8.3
- 🇫🇷France andypost
maybe instead of inline comment better to update phpstan's baseline?
- 🇬🇧United Kingdom catch
Yeah I can also live with the inline ignores - it's a very specific case and we can remove them as soon as we require PHP 8.5.
Committed/pushed to 11.x, thanks!