- Issue created by @mondrake
- 🇮🇹Italy mondrake 🇮🇹
The remaining failures are due to issues in Prophecy and in PhpDocumentor.
- 🇫🇷France andypost
Please update https://github.com/Lullabot/php-webdriver/releases/tag/v2.0.7 as well as it makes more tests to pass
- 🇫🇷France andypost
Curious if the changes in table clean-up will help to close related #2949229: SQLite findTables Returns Empty Array on External DB. →
EDIT sadly no
- 🇫🇷France andypost
PHP 8.5 changes are backported to 10.x so part of it should do too
- 🇮🇹Italy mondrake 🇮🇹
PHPUnit 11.5.33 is out and contains the fix that will allow 📌 Deprecate expectDeprecation(), use PHPUnit's expectUserDeprecationMessage() instead Postponed to proceed. Let’s bump to that.
- 🇫🇷France andypost
one more deprecation
1) /builds/issue/drupal-3541427/vendor/phpspec/prophecy/src/Prophecy/Call/CallCenter.php:87 Method SplObjectStorage::attach() is deprecated since 8.5, use method SplObjectStorage::offsetSet() instead Triggered by: * Drupal\Tests\Core\Entity\EntityUnitTest::testPostSave /builds/issue/drupal-3541427/core/tests/Drupal/Tests/Core/Entity/EntityUnitTest.php:411 * Drupal\Tests\Core\Entity\EntityUnitTest::testPostSaveBundle /builds/issue/drupal-3541427/core/tests/Drupal/Tests/Core/Entity/EntityUnitTest.php:433
- 🇫🇷France andypost
Looking for reviews https://github.com/phpspec/prophecy/pull/647
- 🇫🇷France andypost
With
sed -i 's/attach/offsetSet/' vendor/phpspec/prophecy/src/Prophecy/Call/CallCenter.php # TODO: wait for release
the test pass - 🇫🇷France andypost
will be fixed
┊ -'REPEATABLE-READ' ┊ +'READ-COMMITTED'
- 🇮🇹Italy mondrake 🇮🇹
Working on this to update to PHPUnit 11.5.34 that
Do not configure report_memleaks setting (which will be deprecated in PHP 8.5) for PHPT processes
- 🇮🇹Italy mondrake 🇮🇹
Added a job to test kernel/functional/build tests under PHP 8.5, allowing failures for now.
- 🇫🇷France andypost
Would be great to add updated compsoer https://getcomposer.org/changelog/2.8.11 (as it require newer react/promise)
- 🇫🇷France andypost
Last blockers are
- https://github.com/minkphp/MinkBrowserKitDriver/pull/185
- new release of prophecy - 🇮🇹Italy mondrake 🇮🇹
Anyone up to RTBC here so at least we cut some of the noise in the logs?
- 🇫🇷France andypost
as of beta2 new failures
1) /builds/issue/drupal-3523596/vendor/justinrainbow/json-schema/src/JsonSchema/Uri/Retrievers/FileGetContents.php:57 The predefined locally scoped $http_response_header variable is deprecated, call http_get_last_response_headers() instead
- 🇫🇷France andypost
I see the rest of new deprecations require own issues so it's good to go as is... at least core will produce less noise in pipelines
- 🇬🇧United Kingdom catch
Committed/pushed to 11.x, thanks!
We need to update these dependencies as far as we can on 10.6 in case we're able to support PHP 8.5 there, I guess it will depend whether the upstream dependencies will backport these fixes to earlier branches or whether we end up having to skip some deprecations or shim things.
Since we can't do a direct backport here, tagging for a follow-up.
- 🇫🇷France andypost
Filed 📌 Update PHPUnit dependencies for PHP 8.5 support in Drupal 10.6 Active