- ๐ฎ๐ณIndia akulsaxena
Removed the Baseline entry for StubEntityStorageBase as suggested
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
The PHPStan job is failing, because the new return type introduced makes the added entry on the PHPStan baseline no longer needed. Needs to remove that entry (or regenerate the baseline).
- ๐ฎ๐ณIndia akulsaxena
Hey @quietone,
I have added the return type to the new methods in the Stub file as requested.
Please review. - First commit to issue fork.
Hey,
I have added the return types to the stub file as suggested.
Please review.- ๐ณ๐ฟNew Zealand quietone
There should be return types on the new methods.
- ๐ณ๐ฟNew Zealand quietone
I think there should be return types on the new methods in the stub file.
- ๐ณ๐ฟNew Zealand quietone
@mondrake, thanks for keeping this up to date.
Committed to 11.x and cherry-picked to 11.1.x
Thanks!
-
quietone โ
committed 88413a56 on 11.x
Issue #3480419 by mondrake, smustgrave, catch: Method...
-
quietone โ
committed 88413a56 on 11.x
-
quietone โ
committed 11103e23 on 11.1.x
Issue #3480419 by mondrake, smustgrave, catch: Method...
-
quietone โ
committed 11103e23 on 11.1.x