Hungary
Account created on 28 September 2003, over 20 years ago
  • Initiative coordinator coordinator at Acquia 
#

Merge Requests

More

Recent comments

🇭🇺Hungary Gábor Hojtsy Hungary

Duh, Moshe says the last line that I was complaining about is not from Drush but probably ddev :D So nothing to see here. Let's introduce the exit code then and accept our fate of running from ddev resulting in confusing messaging. Can someone help convert the patch to MR to help run it against our CI?

🇭🇺Hungary Gábor Hojtsy Hungary

Worked on this a bit today. Here is an attached patch that removes a lot of the custom styles and instead uses the standard classes from Claro. The Gin theme also supports those standard classes. The result looks good in Claro I think as-is, even though it looses some custom styling, I think its fine for the greater good. It also looks fine in Gin as-is. I also attempted to gut Gin of all the upgrade status styling (it has it at various places!), and its not markedly different, so most of those styles could be removed. What's definitely lost then is the select all checkbox border. The custom icons from Gin are lost either way due to the new more standard class names on table rows. Either way, a LOT of Gin CSS could be dropped following this Upgrade Status patch. I am wondering how to coordinate that?

🇭🇺Hungary Gábor Hojtsy Hungary

@andypost that still does not change how Drush interprets the result though?

🇭🇺Hungary Gábor Hojtsy Hungary

Yeah a 11.0.x will be created when 11.0.x diverges from the future 11.1.x (which is initially done on 11.x as well). Basically 11.x is "main" but many d.o tools can't handle a number-less branch, so we did not name it main.

🇭🇺Hungary Gábor Hojtsy Hungary

Wow, there is also Add options to provide drush analyze output in JSON and CSV Needs review , but this may guide the JSON format better to align with an industry solution :)

🇭🇺Hungary Gábor Hojtsy Hungary

Slightly updated to check the specific requirement as per the docs. Since this version of the project is not compatible with Drupal 8, its not likely that modules would still have the supported combination, but if they do, they would get the "module not compatible with next major version" message first, and when that is resolved would get the core key message. Please review.

🇭🇺Hungary Gábor Hojtsy Hungary

Gábor Hojtsy made their first commit to this issue’s fork.

🇭🇺Hungary Gábor Hojtsy Hungary

You wrote "causes errors" but did not specify the errors. What are the errors?

🇭🇺Hungary Gábor Hojtsy Hungary

I've been looking at how to integrate this more seamlessly. There is also Add options to provide drush analyze output in JSON and CSV Needs review which adds JSON on the drush CLI (and a little script to further process it which we could also add to the module as an option). It has different logic from your setup and less involved in how it builds the data. I think a middle ground would be good as well as ideally as much code reuse as possible between the output formats IMHO.

🇭🇺Hungary Gábor Hojtsy Hungary

I've been looking at how to integrate this more seamlessly. There is also Add UI option to export Upgrade Status results as CSV Needs review which adds CSV on the UI. It has different logic from your setup and more involved in how it build the data. I think a middle ground would be good as well as ideally as much code reuse as possible between the output formats IMHO.

🇭🇺Hungary Gábor Hojtsy Hungary

All good now. The MR also adds Drush 11 checking to Drupal 9 to 10 upgrades, which is useful IMHO. That was missing before. I also tested that today on a throwaway drupalpod Drupal 9 site with the MR.

🇭🇺Hungary Gábor Hojtsy Hungary

This is where the code lies to check it https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/syste... we should see if we can reuse this by invoking it instead of copying it.

🇭🇺Hungary Gábor Hojtsy Hungary

But the site status report identifies it correctly so its still on our code to fix.

🇭🇺Hungary Gábor Hojtsy Hungary

Hm, Drupal 11.x has this code to match mariadb version numbering, which we already rely on:

  protected function getMariaDbVersionMatch(): ?string {
    // MariaDB may prefix its version string with '5.5.5-', which should be
    // ignored.
    // @see https://github.com/MariaDB/server/blob/f6633bf058802ad7da8196d01fd19d75c53f7274/include/mysql_com.h#L42.
    $regex = '/^(?:5\.5\.5-)?(\d+\.\d+\.\d+.*-mariadb.*)/i';

    preg_match($regex, $this->getServerVersion(), $matches);
    return (empty($matches[1])) ? NULL : $matches[1];
  }

So its a number (dot) number (dot) number, followed by anything (dash) "mariadb" followed by anything.

It would be 10.4.32 here if it would not be (plus) "maria" (without the dash and "db"). Wondering how widespread this is.

🇭🇺Hungary Gábor Hojtsy Hungary

MySQL/MariaDB are not properly checked yet, but otherwise looks good on drupalpod/gitpod.

🇭🇺Hungary Gábor Hojtsy Hungary

Keeping v4 did not help, Drupal 9 would also take v5 and still fail there. It does not fail in Drupal 10 because the code it would affect does not actually run, so it does not help. Would be nice if composer would have optional dependencies based on dependency criteria haha. Since we don't seem to need it in the Drupal 10 to 11 path. Anyway, until then the solution is to make it work :) Help still welcome.

🇭🇺Hungary Gábor Hojtsy Hungary

Updating credits. Tests prove this works well.

🇭🇺Hungary Gábor Hojtsy Hungary

Added tests prove this works on PHP 8.3 and will ensure this keeps working on PHP 8.3. Thanks all for your effort and sorry this took so much time! Enjoy!

🇭🇺Hungary Gábor Hojtsy Hungary

No, I checked and there is BC code for all of them included. 3.x does not need those fixes as its topped at Drupal 9.

🇭🇺Hungary Gábor Hojtsy Hungary

Some of this still needs fixing in 4.x actually :O

🇭🇺Hungary Gábor Hojtsy Hungary

Why not add both JSON and CSV then? Also there is already the checkstyle output and the ascii output, but they are done in different methods? Why integrate this one in a single method?

🇭🇺Hungary Gábor Hojtsy Hungary

Gábor Hojtsy made their first commit to this issue’s fork.

🇭🇺Hungary Gábor Hojtsy Hungary

The error already includes the file path which is the most we can do to help resolve the issue.

 throw new \Exception('Unable to decode composer information from ' . $composer_json_path . '.');
🇭🇺Hungary Gábor Hojtsy Hungary

Slightly earlier the ".css in directory name considered a file" problem was resolved in 🐛 CSSDeprecationAnalyzer::getAllCSSFiles() returns directories with a name that ends in ".css" Fixed , but the code would still traverse into the non-intended directories and find CSS files there, even though it should not. I adapted the patch based on the suggestion from @joelpittet, so the behaviour is more adaptive to site configuration. Please review the MR, I am hiding the patch.

🇭🇺Hungary Gábor Hojtsy Hungary

Resolving this in 📌 Composer conflict prevents search_api_solr to be installed Active , sorry for the late reaction.

🇭🇺Hungary Gábor Hojtsy Hungary

Resolving this in 📌 Composer conflict prevents search_api_solr to be installed Active , sorry for the late reaction. Will carry your credits to there.

🇭🇺Hungary Gábor Hojtsy Hungary

Are you experiencing 🐛 Getting upexpected item 'parameteres > drupal' Postponed: needs info as well?

🇭🇺Hungary Gábor Hojtsy Hungary

Interesting, the module's default .neon file (see https://git.drupalcode.org/project/upgrade_status/-/blob/4.x/deprecation...) does not have Drupal in the parameters list and neither should the processed version have that. What is the content of the .neon file from the error message?

This one: /tmp/upgrade_status/deprecation_testing.neon

🇭🇺Hungary Gábor Hojtsy Hungary

Added the specific command to the project page, thanks!

🇭🇺Hungary Gábor Hojtsy Hungary

Found a drush docs bug while reviewing this MR :) https://github.com/drush-ops/drush/pull/5874 But this MR itself looks solid.

🇭🇺Hungary Gábor Hojtsy Hungary

Search API Solr is mentioned in the issue summary. That is still not resolved IMHO. At least definitely not for 8.3. See 📌 Composer conflict prevents search_api_solr to be installed Active though for the solution.

🇭🇺Hungary Gábor Hojtsy Hungary

With this MR on drupalpod, I can verify the new dependency is used:

gitpod /workspace/DrupalPod (main) $ composer show drupal/upgrade_status
Notice: running 'composer show drupal/upgrade_status' in ddev
name     : drupal/upgrade_status
descrip. : Review Drupal major upgrade readiness of the environment and components of the site.
keywords : 
versions : * 4.x-dev
type     : drupal-module
license  : GNU General Public License v2.0 or later (GPL-2.0-or-later) (OSI approved) https://spdx.org/licenses/GPL-2.0-or-later.html#licenseText
homepage : http://drupal.org/project/upgrade_status
source   : []  
dist     : [path] repos/upgrade_status 8e9851b3b4666d8c3f2a1d699a04cf8dfe75f582
path     : /var/www/html/repos/upgrade_status
names    : drupal/upgrade_status

requires
dekor/php-array-table ^2.0
mglaman/phpstan-drupal ^1.0.0
nikic/php-parser ^4.0.0
phpstan/phpstan-deprecation-rules ^1.0.0
symfony/process ^3.4|^4.0|^5.0|^6.0
webflo/drupal-finder ^1.2

I can require Search API Solr on top of this without issue:

gitpod /workspace/DrupalPod (main) $ composer require drupal/search_api_solr
Notice: running 'composer require drupal/search_api_solr' in ddev
./composer.json has been updated
Running composer update drupal/search_api_solr
Loading composer repositories with package information
Updating dependencies
Lock file operations: 6 installs, 0 updates, 0 removals
  - Locking drupal/search_api (1.31.0)
  - Locking drupal/search_api_solr (4.3.2)
  - Locking halaxa/json-machine (1.1.4)
  - Locking laminas/laminas-stdlib (3.19.0)
  - Locking maennchen/zipstream-php (3.1.0)
  - Locking solarium/solarium (6.3.5)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 6 installs, 0 updates, 0 removals
  - Downloading halaxa/json-machine (1.1.4)
  - Downloading solarium/solarium (6.3.5)
  - Downloading maennchen/zipstream-php (3.1.0)
  - Downloading laminas/laminas-stdlib (3.19.0)
  - Downloading drupal/search_api (1.31.0)
  - Downloading drupal/search_api_solr (4.3.2)
  - Installing halaxa/json-machine (1.1.4): Extracting archive
  - Installing solarium/solarium (6.3.5): Extracting archive
  - Installing maennchen/zipstream-php (3.1.0): Extracting archive
  - Installing laminas/laminas-stdlib (3.19.0): Extracting archive
  - Installing drupal/search_api (1.31.0): Extracting archive
  - Installing drupal/search_api_solr (4.3.2): Extracting archive
7 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
95 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
PHP CodeSniffer Config installed_paths set to ../../drupal/coder/coder_sniffer,../../sirbrillig/phpcs-variable-analysis,../../slevomat/coding-standard,vendor/drupal/coder/coder_sniffer
phpstan/extension-installer: Extensions installed
> repos/add-project-as-symlink.sh
Replace project with a symlink
No security vulnerability advisories found.
Using version ^4.3 for drupal/search_api_solr

The text to table conversion is as good as before:

gitpod /workspace/DrupalPod (main) $ drush upgrade_status:analyze admin_toolbar
Notice: running 'drush upgrade_status:analyze admin_toolbar' in ddev
 [notice] Processing /var/www/html/web/modules/contrib/admin_toolbar.

================================================================================
Admin Toolbar,  3.4.2
Scanned on Wed, 02/21/2024 - 10:39

FILE: web/modules/contrib/admin_toolbar/admin_toolbar_search/src/SearchLinks.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 123  Relying on entity queries to check access by default is     
                    deprecated in drupal:9.2.0 and an error will be thrown from 
                    drupal:10.0.0. Call                                         
                    \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
                    TRUE or FALSE to specify whether access should be checked.  
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/admin_toolbar/admin_toolbar_tools/src/Plugin/Derivative/Extr
aLinks.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 114  Relying on entity queries to check access by default is     
                    deprecated in drupal:9.2.0 and an error will be thrown from 
                    drupal:10.0.0. Call                                         
                    \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
                    TRUE or FALSE to specify whether access should be checked.  
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/admin_toolbar/admin_toolbar_search/admin_toolbar_search.modu
le

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 76   The 'admin_toolbar_search/search' library is not defined    
                    because the defining extension is not installed. Cannot     
                    decide if it is deprecated or not.                          
--------------------------------------------------------------------------------
Check manually 120  The 'admin_toolbar_search/search' library is not defined    
                    because the defining extension is not installed. Cannot     
                    decide if it is deprecated or not.                          
--------------------------------------------------------------------------------

FILE: web/modules/contrib/admin_toolbar/admin_toolbar.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^9.2 || ^10 is not       
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/admin_toolbar/admin_toolbar_links_access_filter/admin_toolba
r_links_access_filter.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^9.2 || ^10 is not       
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/admin_toolbar/admin_toolbar_search/admin_toolbar_search.info
.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^9.2 || ^10 is not       
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/admin_toolbar/admin_toolbar_tools/admin_toolbar_tools.info.y
ml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^9.2 || ^10 is not       
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

Look good?

🇭🇺Hungary Gábor Hojtsy Hungary

Ok after various trials in a gitpod instance I figured its probably best to go with a text table generator that has much less dependencies. We only use the whole thing in one place after all :D So we can replace with a more lightweight solution like https://packagist.org/packages/dekor/php-array-table

🇭🇺Hungary Gábor Hojtsy Hungary

I tried a fresh composer setup:

gitpod /workspace/DrupalPod (main) $ composer show drupal/core
Notice: running 'composer show drupal/core' in ddev
name     : drupal/core
descrip. : Drupal is an open source content management platform powering millions of websites and applications.
keywords : 
versions : * 10.2.3
[...]
gitpod /workspace/DrupalPod (main) $ php -v
Notice: running 'php -v' in ddev
PHP 8.2.15 (cli) (built: Jan 20 2024 14:13:38) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.15, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.15, Copyright (c), by Zend Technologies
gitpod /workspace/DrupalPod (main) $ composer require drupal/upgrade_status
Notice: running 'composer require drupal/upgrade_status' in ddev
./composer.json has been updated
Running composer update drupal/upgrade_status
Loading composer repositories with package information
Updating dependencies
Lock file operations: 7 installs, 0 updates, 0 removals
  - Locking container-interop/container-interop (1.1.0)
  - Locking drupal/upgrade_status (4.x-dev)
  - Locking mathieuviossat/arraytotexttable (v1.0.7)
  - Locking zendframework/zend-hydrator (1.0.0)
  - Locking zendframework/zend-servicemanager (2.6.0)
  - Locking zendframework/zend-stdlib (2.7.4)
  - Locking zendframework/zend-text (2.5.1)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 7 installs, 0 updates, 0 removals
  - Installing container-interop/container-interop (1.1.0): Extracting archive
  - Installing zendframework/zend-stdlib (2.7.4): Extracting archive
  - Installing zendframework/zend-hydrator (1.0.0): Extracting archive
  - Installing zendframework/zend-servicemanager (2.6.0): Extracting archive
  - Installing zendframework/zend-text (2.5.1): Extracting archive
  - Installing mathieuviossat/arraytotexttable (v1.0.7): Extracting archive
  - Installing drupal/upgrade_status (4.x-dev): Source already present
8 package suggestions were added by new dependencies, use `composer suggest` to see details.
Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.
Package zendframework/zend-hydrator is abandoned, you should avoid using it. Use laminas/laminas-hydrator instead.
Package zendframework/zend-servicemanager is abandoned, you should avoid using it. Use laminas/laminas-servicemanager instead.
Package zendframework/zend-stdlib is abandoned, you should avoid using it. Use laminas/laminas-stdlib instead.
Package zendframework/zend-text is abandoned, you should avoid using it. Use laminas/laminas-text instead.
Generating autoload files
94 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
phpstan/extension-installer: Extensions installed
> repos/add-project-as-symlink.sh
Replace project with a symlink
No security vulnerability advisories found.
Using version 4.x-dev for drupal/upgrade_status

Why are you getting a different result?

mathieuviossat/arraytotexttable's 1.0.7 version was (a) PHP 8.2 and 8.3 compatible (in fact compatible with any future version of PHP) and did not use the laminas dependencies yet, so there was no conflict on that version.

🇭🇺Hungary Gábor Hojtsy Hungary

Hm I re-ran PHPUnit Functional Javascript 1/2 which was failing but it still fails.

🇭🇺Hungary Gábor Hojtsy Hungary

Re activitytracker, that is not a project, tracker is, as shown in the error message: drupal/tracker. Why do you want to remove that?

🇭🇺Hungary Gábor Hojtsy Hungary

In fact the composer failures in the MR show the exact same problem as the other two linked issues.

🇭🇺Hungary Gábor Hojtsy Hungary

This is your whole diff:

-        "mathieuviossat/arraytotexttable": "~1.0.0",
+        "mathieuviossat/arraytotexttable": "~1.0.10",

However the existing constraint already allowed for the updated version? See https://jubianchi.github.io/semver-check/#/~1.0.0/1.0.10 -- so there is no need to commit this, a composer update does the same, no?

So I don't see how does the proposed fix change anything?

Note that there is also 🐛 [PHP 8.2] Composer - Upgrade Status conflicts with core 10.1.5 Active and 📌 Composer conflict prevents search_api_solr to be installed Active which are essentially the same problem I think and point to external dependencies.

🇭🇺Hungary Gábor Hojtsy Hungary

The latest laminas-text from https://github.com/laminas/laminas-text/blob/2.11.0/composer.json did support PHP 8.3.0, so this seems to be down to laminas/laminas-servicemanager not having a PHP 8.3 compatible release.

🇭🇺Hungary Gábor Hojtsy Hungary

In [] the problem is a combination of psr/container v2 and PHP 8.3. Sounds like from the issue summary you hit the same package already on PHP 8.2. Drupal 10.0 already required psr/container v2 so its not a change in 10.1.5 specifically. It looks to be related to your PHP version (which the downstream packages don't seem to be ready for).

🇭🇺Hungary Gábor Hojtsy Hungary

Also Drupal core requires psr container 2 since Drupal 10.0. So looks like the combo of that and PHP 8.3 is causing problems? In 🐛 [PHP 8.2] Composer - Upgrade Status conflicts with core 10.1.5 Active it is also claimed that this already causes problems on PHP 8.2.

🇭🇺Hungary Gábor Hojtsy Hungary

It is unfortunate that https://github.com/laminas/laminas-servicemanager/blob/4.0.0-rc2/compose... also does not yet support PHP 8.3. Would a 4.0.0-rc3 of servicemanager help? https://github.com/laminas/laminas-servicemanager/commits/4.0.x/ seems to not have much else since rc2. An issue there to request an RC3 would probably be worth it / helpful :)

🇭🇺Hungary Gábor Hojtsy Hungary

Any day now, any day now :)

🇭🇺Hungary Gábor Hojtsy Hungary

This is where this fails, so clearly does not do the theme function checking properly:

    $report = $key_value->get('upgrade_status_test_theme_functions');
    $this->assertNotEmpty($report);
    if ($this->getDrupalCoreMajorVersion() < 10) {
      $this->assertEquals(3, $report['data']['totals']['file_errors']);

Help is welcome to figure out how to make it compatible :)

🇭🇺Hungary Gábor Hojtsy Hungary

Interestingly it only fails on Drupal 9 with

1) Drupal\Tests\upgrade_status\Functional\UpgradeStatusAnalyzeTest::testAnalyzer
Failed asserting that 1 matches expected 3.
/builds/project/upgrade_status/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:94
/builds/project/upgrade_status/tests/src/Functional/UpgradeStatusAnalyzeTest.php:197
/builds/project/upgrade_status/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
🇭🇺Hungary Gábor Hojtsy Hungary

Maybe its the book navigation block only. It adds the olivero book library (got it, library, haha?!) even if there was no content in the block.

🇭🇺Hungary Gábor Hojtsy Hungary

Only the https://git.drupalcode.org/project/upgrade_status/-/blob/4.x/src/ThemeFu... uses the PHP parser I think directly. It would need to be attempted whether there were any API changes related to those uses.

🇭🇺Hungary Gábor Hojtsy Hungary

Some out of the box ideas is if the pager can hide some items towards the end if it would be too wide? Or it can be more tight (less click/touch space) if the space is not enough due to sidebar? The region output IMHO would be its own issue, should I open that one as well?

🇭🇺Hungary Gábor Hojtsy Hungary

The changes visually look good, thanks! I have no idea if this is the best way to implement them in Olivero's CSS :)

🇭🇺Hungary Gábor Hojtsy Hungary

How does this look with a tall sidebar? I am not well versed enough in CSS flex to tell sorry :)

🇭🇺Hungary Gábor Hojtsy Hungary

📌 [11.x] Add void returns for Symfony 7 RTBC is for the 11.x codebase only, so it cannot be committed right now. Are there any other changes to be made on "the 10.3.x branch" for Symfony 7 or none left?

🇭🇺Hungary Gábor Hojtsy Hungary

The text you copied is the command that was run. The error should be more than the command. Can you paste that too? Thanks!

🇭🇺Hungary Gábor Hojtsy Hungary

Hm, there are more undecided things here, sorry about Windows support, composer and browsers.

Re composer requirements my understanding from the Symfony 7 issue is that Composer 2.2.6 and/or 2.7.0 are required to work with Symfony 7. See 📌 Symfony 7 compatibility Active .

Re browser requirements is there any reason to make it more specific than the existing rolling browser policy Drupal core has? This is the current list of supported browsers from https://www.drupal.org/docs/system-requirements/browser-requirements

  • The latest release of each of the latest two supported major versions of:
    • Desktop browsers:
      • Google Chrome
      • Firefox
      • Safari
      • Microsoft Edge
      • Opera
    • Mobile browsers:
      • Safari for iOS
  • The latest supported release of the latest major version of:
    • Desktop browsers:
      • Firefox ESR
      • Internet Explorer (Drupal 9 and below only)
    • Mobile browsers:
      • Chrome for Android
      • Chrome for iOS
      • UC Browser (Drupal 9 and below only)
      • Opera Mini (except for 'extreme data savings' mode)
      • Samsung Internet
🇭🇺Hungary Gábor Hojtsy Hungary

@quietone went through and updated drupal.org webpages with the decided requirements. I opened #3421175: Update INSTALL.txt and friends with Drupal 11 platform requirements to do when 11.x is ready for it. So I think we can consider this done.

🇭🇺Hungary Gábor Hojtsy Hungary

Indeed, this is not something we can do anything about. Thanks for confirming!

🇭🇺Hungary Gábor Hojtsy Hungary

Looks like the error is in core's code path. Not sure how we could pre-validate the schema so core does not fail this way. It is definitely a mismatch between core's understanding of how schema should be and the schema provided by your contrib module. But this does not look like the fault of config schema, rather the schema as applied when validating a config item.

If the exception is thrown all the way forward to the config inspector level, the inspector may be able to catch it. Is that the case?

🇭🇺Hungary Gábor Hojtsy Hungary

It seems like the Olivero book navigation template override attaches the olivero book library (hah, get it? book library!) even if there is no book tree to display. That may result in some whitespace left around from there? I don't have enough experience to know how whitespace is handled in templates.

🇭🇺Hungary Gábor Hojtsy Hungary

The pager is good when I disable the sidebar block. So I think there are two bugs:

(1) the pager wraps when there is a sidebar block
(2) there looks like whitespace produced from block templates that the main page template thinks is sidebar content

🇭🇺Hungary Gábor Hojtsy Hungary

@hansfn: we want to set requirements early enough (see 🌱 [11.x] [meta] Set Drupal 11 platform and browser requirements at least six months before the release Active ), however the 11.x branch is not yet open for development of 11.x. It is true that we need a dedicated issue to update the INSTALL.txt info once the branch is open for 11.x development. Can you help open an issue for that? Thanks!

Production build https://api.contrib.social 0.61.6-2-g546bc20