- Issue created by @timohuisman
- 🇳🇱Netherlands timohuisman Leiden, Netherlands
I've created a MR so we can see if the tests are still green.
- Status changed to Needs review
2 months ago 2:40pm 24 April 2025 - First commit to issue fork.
- 🇩🇪Germany jurgenhaas Gottmadingen
I've updated the MR to also allow
phpstan/phpstan-deprecation-rulesversion 2 because otherwise, we would still get PhpStan version 1.I've tested the MR locally and it now works by pulling the latest PhpStan version and also the latest mglaman/phpstan-drupal
Leaving the status at NR as I've changed the MR, so I can't move it to RTBC.
- 🇳🇱Netherlands kingdutch
Based on the code changes I'd be happy to RTBC this, but the tests are failing so I think this needs some work to figure out why that is.
- 🇩🇪Germany jurgenhaas Gottmadingen
I've rebased to the latest changes in the dev branch, let's see if the tests are passing now.
- 🇩🇪Germany jurgenhaas Gottmadingen
Back to NR, the pipelines are all green now.
- 🇳🇱Netherlands kingdutch
🎉
Looks good to me, ensures that Upgrade Status can be installed for projects that got ahead of it with PHPStan and looks to work as expected :)
- 🇧🇾Belarus f1mishutka Minsk
Nice and simple patch, thanks!
Please merge it because it is a sad show stopper for switching to Drupal 11.2
- Status changed to RTBC
about 7 hours ago 11:20pm 23 June 2025 - 🇨🇦Canada joelpittet Vancouver
This caught me trying to upgrade to D11 and then got held back from Drupal 11.2. +1 for merge
